From f5c38c923a3e3ce0020bdbdca1490749dd26eb03 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 23 Oct 2026 17:40:06 -0700 Subject: [PATCH 1/2] chore(quest): claim quest/m0/web-transport-proto-0.6.3.md Quest-Claim: 3dda7f4cbd54c92a From 060ad8fe8665441d260f5afa85c592aac4acf0ec Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 23 Oct 2026 17:45:41 -0700 Subject: [PATCH 2/2] fix: bound decoded WebTransport CONNECT headers Co-Authored-By: GPT-6 --- Cargo.lock | 4 +-- quest/m0/README.md | 1 - quest/m0/web-transport-proto-0.6.3.md | 35 --------------------------- quest/m1/release-audit/README.md | 1 - quest/m2/drop-web-transport-trait.md | 2 +- 5 files changed, 3 insertions(+), 40 deletions(-) delete mode 100644 quest/m0/web-transport-proto-0.6.3.md diff --git a/Cargo.lock b/Cargo.lock index bd8c1c25329..57f4d88904a 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -11129,9 +11129,9 @@ dependencies = [ [[package]] name = "web-transport-proto" -version = "0.6.2" +version = "0.6.3" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "1a81bcc79bf48ad0b819bfa51ec28524ee7c356056d43c316727d6b505dcc71e" +checksum = "d2baf87f7a4701d964fd23529b440db3da535b1d7539289f7a463c3481dafcff" dependencies = [ "bytes", "http", diff --git a/quest/m0/README.md b/quest/m0/README.md index ad395b62a9e..ede2fc2b22c 100644 --- a/quest/m0/README.md +++ b/quest/m0/README.md @@ -41,7 +41,6 @@ Each lands its fixes in its own PR and plans only what needs a decision. ## Required - [Broadcast epochs](/quest/m0/broadcast-epoch/README.md) - every first-party publisher that can restart mints a fresh route epoch, the newest wins a path, and only routes with the same epoch resume a subscription -- [web-transport-proto 0.6.3](/quest/m0/web-transport-proto-0.6.3.md) - `main` and `release` lock the upstream release that bounds decoded CONNECT headers, so a peer can't make a relay hold megabytes per session before auth - [qmux 0.5.3](/quest/m0/qmux-0.5.3.md) - crates.io publishes qmux 0.5.3 with the builder session config the release backport of #5609 needs - [Release shutdown backport](/quest/m0/ffi-shutdown-backport.md) - `release` publishes a non-breaking moq-ffi with an async `drain()` and qmux sessions on the QUIC stream limit - [HLS admission backport](/quest/m0/hls-admission-backport.md) - `release` refuses the hostile HLS playlists `main` does, without breaking `import::Config::client` diff --git a/quest/m0/web-transport-proto-0.6.3.md b/quest/m0/web-transport-proto-0.6.3.md deleted file mode 100644 index 08fea551ed2..00000000000 --- a/quest/m0/web-transport-proto-0.6.3.md +++ /dev/null @@ -1,35 +0,0 @@ -# [XS] Take web-transport-proto 0.6.3 - -## Goal - -The `main` and `release` lockfiles resolve web-transport-proto 0.6.3, which -bounds decoded CONNECT headers to a 16 KiB field section, counting each field -as name + value + 32 bytes. Until then, a peer can make moq-tokio, moq-uring, -or the iroh backend hold about 2.7 MB per session from one 64 KiB CONNECT, -before auth: unique short literal names amplify the frame about 42x (the -[QPACK header accordion](https://foxio.io/blog/header-accordions-qpack-amplification-attacks-against-http-3-servers) -class, without its dynamic-table variant, which the decoder refuses). - -Waiting on moq-dev/web-transport's -[Bound decoded CONNECT headers](https://github.com/moq-dev/web-transport/blob/main/quest/a0/qpack-field-section.md) -quest. Check: `cargo info web-transport-proto@0.6.3` resolves. - -## Plan - -Decided 2026-10-21 (maintainer): - -- **Fix upstream, not in-tree.** The iroh backend decodes CONNECT inside - web-transport-iroh with the same crate, so only an upstream release covers - every backend, and web-transport-proto stays upstream - ([Drop web-transport-trait](/quest/m2/drop-web-transport-trait.md) records - why). This is the one exception to taking no work in moq-dev/web-transport. -- **Lock-only bumps on both lines.** `cargo update -p web-transport-proto` in - a PR against `main` and a backport PR against `release`, whose - `web-transport-proto = "0.6"` also takes 0.6.3, so moq.dev's relay gets the - bound at its next patch release. No `Cargo.toml` change. -- **No moq-side test.** The upstream unit test covers the decoder. Confirm - both servers' SETTINGS now carry `MAX_FIELD_SECTION_SIZE`; they build them - with `Settings::enable_webtransport`, which 0.6.3 extends. -- moq-uring's 64 KiB `MESSAGE_LIMIT` stays: it also bounds SETTINGS, and - 0.6.3's sync decoder refuses an oversized HEADERS frame at its declared - length, before the payload is buffered. diff --git a/quest/m1/release-audit/README.md b/quest/m1/release-audit/README.md index c82fdc9b53d..e455c0f9244 100644 --- a/quest/m1/release-audit/README.md +++ b/quest/m1/release-audit/README.md @@ -104,7 +104,6 @@ child records whether its behavior is new on main or inherited from release. - [JS subscription ranges](/quest/m1/subscribe-ranges/js.md) - range lists and frame offsets build on the bounds fixed here - [OBS video source](/quest/m2/obs-moq-video/source.md) - reproduced inherited timing and EOF defects remain with the decoder replacement owner -- [QPACK dependency fix](/quest/m0/web-transport-proto-0.6.3.md) - decoded header expansion is already tracked - [Compressed tracks](/quest/m1/compress/README.md) - mid-group widening and application migration have existing owners - [Archive consumer](/quest/m1/archive/consumer.md) - current producer and CLI reader still need the new-format roundtrip - [Measured release performance](/quest/m1/release-perf/README.md) - existing paired benchmark regressions and their confirmation runs diff --git a/quest/m2/drop-web-transport-trait.md b/quest/m2/drop-web-transport-trait.md index 2dfdd635711..1d4eb4e020c 100644 --- a/quest/m2/drop-web-transport-trait.md +++ b/quest/m2/drop-web-transport-trait.md @@ -67,7 +67,7 @@ from that repo as accepted exceptions, and web-transport-proto may stay. Decided 2026-10-21 (maintainer): web-transport-proto stays upstream, with no migration quest. web-transport-iroh decodes CONNECT with it, so an in-tree copy would duplicate the crate whenever iroh is on. Its QPACK bound ships as -an upstream patch ([web-transport-proto 0.6.3](/quest/m0/web-transport-proto-0.6.3.md)). +the upstream web-transport-proto 0.6.3 patch. ## Related