From 14481c5d9857b25ea6d540e0e8d5703b1d825f57 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 24 Oct 2026 10:00:24 -0700 Subject: [PATCH 1/4] chore(quest): claim quest/m1/test-flakes-2/interop-timestamp-gap.md Quest-Claim: 8218259057965e08 From 47320c818e1df250b89fd643cc67d01a57688e7f Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 24 Oct 2026 10:27:21 -0700 Subject: [PATCH 2/4] test(interop): keep the Rust publisher's media as long as the audio readers wait The Rust CLI imported with --max-age 1s, which caps every reader's max delay, so the native JS audio reader's 5 s budget was really 1 s. Each 1 s fMP4 fragment lands as one burst, so the oldest group a joining reader is served went stale as soon as the next group landed and was cut mid-read, which the tone check failed as a timestamp gap. Co-Authored-By: Claude Opus 5.5 --- test/interop/clients/js-native/subscribe.ts | 3 ++- test/interop/interop.sh | 6 +++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/test/interop/clients/js-native/subscribe.ts b/test/interop/clients/js-native/subscribe.ts index 02412084061..e578b11789b 100644 --- a/test/interop/clients/js-native/subscribe.ts +++ b/test/interop/clients/js-native/subscribe.ts @@ -47,7 +47,8 @@ const MAX_DELAY = Milli(1000); // Audio is checked for gaps, which a reader skipping behind live would cause itself: the matrix // starts every subscriber at once, and a runtime starved by the others can fall a second behind. -// That is this reader's speed, not the delivery under test, so it gets a wider budget. +// That is this reader's speed, not the delivery under test, so it gets a wider budget. A track's +// max-age caps it, so interop.sh's Rust publisher keeps its media at least this long. const AUDIO_MAX_DELAY = Milli(5000); const { positionals, values } = parseArgs({ diff --git a/test/interop/interop.sh b/test/interop/interop.sh index 2eecb6bd1cb..8531c5db260 100755 --- a/test/interop/interop.sh +++ b/test/interop/interop.sh @@ -1004,8 +1004,12 @@ run_publisher() { # A finished import stays up for its max-age; `stop_publisher` allows 10 s to close. # The wire-compat FETCH lanes keep the video-only Annex-B input. if [[ "$AUDIO" -eq 1 ]]; then + # The max-age caps every reader's max delay, so it covers the longest, the native + # JS audio readers' 5 s. Each 1 s fragment lands as one burst, so with a 1 s + # max-age the oldest group a joining reader is served goes stale as soon as the + # next group lands, cutting it mid-read and failing the gap check. ffmpeg_fmp4 "$tone" "$(publisher_codecs rust)" | RUST_LOG="$CLI_LOG" "$MOQ" --connect "$url" --connect-version "$(cell_version rust)" \ - --broadcast "$broadcast" import --max-age 1s fmp4 + --broadcast "$broadcast" import --max-age 5s fmp4 else ffmpeg_h264 | RUST_LOG="$CLI_LOG" "$MOQ" --connect "$url" --connect-version "$(cell_version rust)" \ --broadcast "$broadcast" import --max-age 1s avc3 From eff6ce1e41e806e9a81704da222700251de3d5b9 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 24 Oct 2026 10:36:14 -0700 Subject: [PATCH 3/4] quest: finish the interop timestamp gap Co-Authored-By: Claude Opus 5.5 --- quest/m1/interop-js-tone.md | 4 ---- quest/m1/test-flakes-2/README.md | 1 - quest/m1/test-flakes-2/interop-timestamp-gap.md | 17 ----------------- 3 files changed, 22 deletions(-) delete mode 100644 quest/m1/test-flakes-2/interop-timestamp-gap.md diff --git a/quest/m1/interop-js-tone.md b/quest/m1/interop-js-tone.md index 691201d6450..c8f0944d0b0 100644 --- a/quest/m1/interop-js-tone.md +++ b/quest/m1/interop-js-tone.md @@ -25,7 +25,3 @@ covers a false "wrong tone" under CPU starvation. Decided 2026-10-23 (maintainer): its own quest, ranked above the load flakes. Public API: depends on the cause. Wire: depends on the cause. - -## Related - -- [Interop timestamp gap](/quest/m1/test-flakes-2/interop-timestamp-gap.md) - the load-only audio flake, a different symptom diff --git a/quest/m1/test-flakes-2/README.md b/quest/m1/test-flakes-2/README.md index 1d9391c3868..d1a4566ad24 100644 --- a/quest/m1/test-flakes-2/README.md +++ b/quest/m1/test-flakes-2/README.md @@ -43,5 +43,4 @@ Public API: none. Wire: none. - [Media resource instrumentation](/quest/m1/test-flakes-2/resource-instrumentation.md) - the media test stops seeing a playing player report nothing to release - [Tone check grace](/quest/m1/test-flakes-2/tone-grace.md) - the interop tone check charges its grace only for audible playback, so a refilling ring under CPU starvation is not a failure - [IETF22 fallback](/quest/m1/test-flakes-2/ietf22-fallback.md) - an IETF22 browser viewer follows a fallback within the media lane's bound, keeping its session and its audio -- [Interop timestamp gap](/quest/m1/test-flakes-2/interop-timestamp-gap.md) - `rust -> js-native-node` audio has no gap under load - [Go reservation grant](/quest/m1/test-flakes-2/go-reservation-grant.md) - the Go reservation test waits for its grant diff --git a/quest/m1/test-flakes-2/interop-timestamp-gap.md b/quest/m1/test-flakes-2/interop-timestamp-gap.md deleted file mode 100644 index 5bf5c6fac23..00000000000 --- a/quest/m1/test-flakes-2/interop-timestamp-gap.md +++ /dev/null @@ -1,17 +0,0 @@ -# [S] Interop audio has no timestamp gap under load - -## Goal - -`rust -> js-native-node` (and `rust-swapped`) never fail the audio check with -a timestamp gap under load. - -## Plan - -Seen in the interop runs of -[moq-dev/moq#6447](https://github.com/moq-dev/moq/pull/6447), -[moq-dev/moq#6530](https://github.com/moq-dev/moq/pull/6530), and -[moq-dev/moq#6517](https://github.com/moq-dev/moq/pull/6517): a gap up to the -next 1 s group, passing on rerun. Reproduce under CPU load, find whether the -publisher, relay, or the Node subscriber drops the audio, and fix that layer. - -Public API: none. Wire: none. From 5733f62eb7ef00f5db7b35bf2d76407911adb29e Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 24 Oct 2026 10:45:47 -0700 Subject: [PATCH 4/4] test(interop): say a finished import stays up for its linger Co-Authored-By: Claude Opus 5.5 --- test/interop/interop.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/interop/interop.sh b/test/interop/interop.sh index 8531c5db260..901b197656d 100755 --- a/test/interop/interop.sh +++ b/test/interop/interop.sh @@ -1001,8 +1001,9 @@ run_publisher() { client_flags "$lang" case "$lang" in rust) - # A finished import stays up for its max-age; `stop_publisher` allows 10 s to close. - # The wire-compat FETCH lanes keep the video-only Annex-B input. + # A finished import stays up for its linger (a released CLI: its max-age); + # `stop_publisher` allows 10 s to close. The wire-compat FETCH lanes keep the + # video-only Annex-B input. if [[ "$AUDIO" -eq 1 ]]; then # The max-age caps every reader's max delay, so it covers the longest, the native # JS audio readers' 5 s. Each 1 s fragment lands as one burst, so with a 1 s