From c39d9d5b6a94b33a124cd49dc41f3ca88e32bfac Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 24 Oct 2026 22:40:10 -0700 Subject: [PATCH 1/2] chore(quest): claim quest/m0/ci/nightly-ffi-reuse.md Quest-Claim: 8817aecaec148e2e From a3a93b9f73cda009a62895e3b50791720aded697 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 24 Oct 2026 22:47:15 -0700 Subject: [PATCH 2/2] quest(ci): narrow the shared FFI release quest to the tag check The release backport is open and the Shipping sizes Go keys are verified, so only the first shared tag remains. Co-Authored-By: Claude Opus 5.5 --- quest/m0/ci/README.md | 2 +- quest/m0/ci/nightly-ffi-reuse.md | 40 +++++++++++++------------------- 2 files changed, 17 insertions(+), 25 deletions(-) diff --git a/quest/m0/ci/README.md b/quest/m0/ci/README.md index 7ecadcdfc1e..b118774bf51 100644 --- a/quest/m0/ci/README.md +++ b/quest/m0/ci/README.md @@ -98,4 +98,4 @@ The historical samples locate candidates; they are not controlled benchmarks. - [Verify the R2 Rust cache](/quest/m0/ci/mbx-r2-verify.md) - measure the hosted Nightly jobs' hits, restore time, and expiry once the bump lands - [mbx on a full disk](/quest/m0/ci/mbx-low-disk.md) - gc never evicts a live build's trees, and the Dart check names the real cause - [Verify the Nix cache](/quest/m0/ci/nix-cache-verify.md) - confirm CI and releases use `nix.moq.dev` and retire Cachix -- [First shared FFI release](/quest/m0/ci/nightly-ffi-reuse.md) - condition: the first `moq-ffi-v*` tag that runs `Release FFI`, and a `Shipping sizes` run; verify the wrappers and size keys +- [First shared FFI release](/quest/m0/ci/nightly-ffi-reuse.md) - condition: the backport merges and the next `moq-ffi-v*` tag runs `Release FFI`; verify the wrappers diff --git a/quest/m0/ci/nightly-ffi-reuse.md b/quest/m0/ci/nightly-ffi-reuse.md index e7a61de1c49..bad5eebc292 100644 --- a/quest/m0/ci/nightly-ffi-reuse.md +++ b/quest/m0/ci/nightly-ffi-reuse.md @@ -2,29 +2,26 @@ ## Goal -Backport `.github/workflows/release-shared-ffi.yml` to `release` now as -release-line maintenance (decided 2026-10-22, maintainer), so the next -`moq-ffi-v*` tag carries it. Condition: that tag has run `Release FFI`, and a -Nightly's `Shipping sizes` job has run since -[#5549](https://github.com/moq-dev/moq/pull/5549). Check the tag with -`git ls-tree .github/workflows/` and its runs with -`gh run list --workflow release-shared-ffi.yml --event push`; check sizes with -`gh run list --workflow nightly.yml --event schedule` and the `Shipping sizes` -job. Then verify the items below, fix or quest what fails, and delete this -quest. +Verify the first `moq-ffi-v*` tag that runs `Release FFI`. Condition: the +backport [#6730](https://github.com/moq-dev/moq/pull/6730) has merged to +`release`, and a `moq-ffi-v*` tag cut after it has run `Release FFI`. Check the +tag with `git ls-tree .github/workflows/` and its runs with +`gh run list --workflow release-shared-ffi.yml --event push`. Then verify the +items below, fix or quest what fails, and delete this quest. ## Plan -`moq-ffi-v0.4.16` (2026-10-16) was cut from a `release` without #5549, so it -ran the per-language workflows and verified nothing here; `moq-ffi-v0.4.17` -was likewise cut without it. `Shipping sizes` has run (Nightly -[39779729461](https://github.com/moq-dev/moq/actions/runs/39779729461), -2026-10-22): check its Go keys below, so only the tag condition remains. +`moq-ffi-v0.4.16` through `moq-ffi-v0.4.18` were cut from a `release` without +[#5549](https://github.com/moq-dev/moq/pull/5549), so they ran the per-language +workflows. #6730 backports #5549, the attempt-scoped publisher check from +[#5573](https://github.com/moq-dev/moq/pull/5573), and the wrapper gates from +[#6084](https://github.com/moq-dev/moq/pull/6084), without the Shipping sizes +and C++ parts `release` lacks. -The first scheduled Nightly after the change (run 38897397428, 2026-10-16) -already verified the dry-run side: the nested job names match the publisher -check, each packager selected its own targets from the shared artifacts, and -the Swift wrapper dry run passed. Its measured saving is in `.github/ffi.md`. +The Nightly side is verified: run 38897397428 covered the dry-run jobs (see +`.github/ffi.md`), and the Shipping sizes jobs of Nightlies 39779729461 and +40090959108 keep the `release/go-lib-/` keys, with the second compared +against the prior history (a changed artifact set fails the report). From the first shared tag: @@ -32,8 +29,3 @@ From the first shared tag: sees its publisher through the jobs API under the `workflow_run` token and releases or skips as its own publisher did. - The Go, Kotlin and Swift packages publish from the shared artifacts. - -From the first `Shipping sizes` run: - -- The Go static libraries keep their `release/go-lib-/` history keys, - so the comparison shows no removed or added Go entries.