From aaa5c6d9692acccec37f1db13e302168757be676 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 27 Oct 2026 17:13:54 -0700 Subject: [PATCH] fix(net): refuse partial lite groups on release Co-Authored-By: GPT-6 --- js/net/src/lite/subscriber.test.ts | 31 ++++++++++++++++++++++++++++++ js/net/src/lite/subscriber.ts | 6 ++++++ 2 files changed, 37 insertions(+) diff --git a/js/net/src/lite/subscriber.test.ts b/js/net/src/lite/subscriber.test.ts index 63b38f9d68b..482150144ba 100644 --- a/js/net/src/lite/subscriber.test.ts +++ b/js/net/src/lite/subscriber.test.ts @@ -1090,3 +1090,34 @@ test("closing a broadcast while TRACK_INFO is pending leaves no unhandled reject subscriber.close(); } }); + +// A peer can start mid-group, but this release has no way to preserve those frame indices. +test("a nonzero lite frame start is refused before publishing the group", async () => { + const { quic, streams, opened } = fakeSession(); + const subscriber = new Subscriber(quic, Version.DRAFT_07, HopSchema.parse(1n)); + const broadcast = subscriber.consume(Path.from("room")); + const track = broadcast.track("video").subscribe(); + const ordered = track.ordered(); + const reader = new Reader( + new ReadableStream({ start: (controller) => controller.close() }), + undefined, + Version.DRAFT_07, + ); + try { + await opened(0); + await answerTrackInfo(streams[0], Version.DRAFT_07); + await (await opened(1)).reading; + const next = ordered.nextGroup(); + await expect( + subscriber.runGroup(new Group({ subscribe: 0n, sequence: 0, frameStart: 5 }), reader), + ).rejects.toThrow("group 0 starts at frame 5"); + ordered.close(); + expect(await next).toBeUndefined(); + } finally { + reader.stop(new Error("test complete")); + ordered.close(); + track.close(); + broadcast.close(); + subscriber.close(); + } +}); diff --git a/js/net/src/lite/subscriber.ts b/js/net/src/lite/subscriber.ts index b5096c8a36c..3893855e0da 100644 --- a/js/net/src/lite/subscriber.ts +++ b/js/net/src/lite/subscriber.ts @@ -1043,6 +1043,12 @@ export class Subscriber { return; } + // This reader cannot preserve a partial group's frame indices, so refuse it before + // publishing anything that would number its first received frame as zero. + if (group.frameStart !== 0) { + throw new ProtocolViolation(`group ${group.sequence} starts at frame ${group.frameStart}`); + } + const { track, timescale, tail } = entry; const producer = new netGroup.Producer(group.sequence); const read = tail.open(group.sequence);