diff --git a/quest/m1/README.md b/quest/m1/README.md index 5a0dc4f1ca2..591282e9235 100644 --- a/quest/m1/README.md +++ b/quest/m1/README.md @@ -126,6 +126,7 @@ removed). - [Address groups by timestamp](/quest/m1/time-addressing/README.md) - group start timestamps replace sequence numbers in the moq-net API and lite-07 wire, while old subscribers, old publishers, and published JS clients keep working - [Release audit findings](/quest/m1/release-audit/README.md) - resolve newly identified resource, parser, playback, and interoperability risks before the cut - [Pre-cut audit findings](/quest/m1/cut-audit/README.md) - fix the crashes, hostile-input costs, and correctness bugs the 2026-10-24 audit of main found +- [moq-quic has every quinn fix it needs](/quest/m1/quinn-sync.md) - quinn's fixes since the fork point are ported with their tests, once per release cycle - [Security audit findings](/quest/m1/security-audit/README.md) - fix the verified relay, importer, moq-c, browser, and CI findings of the 2026-10-27 external security audit - [Withdrawn advertisements stop](/quest/m1/ietf-withdraw-credit.md) - a withdrawn moq-transport namespace releases its state even when the peer withholds credit - [Cluster routing](/quest/m1/cluster-routing/README.md) - prove shared routing contracts, implement per-origin routes, and connect outbound local clusters diff --git a/quest/m1/cut-audit/README.md b/quest/m1/cut-audit/README.md index 15fd10e0b1f..09933ed0065 100644 --- a/quest/m1/cut-audit/README.md +++ b/quest/m1/cut-audit/README.md @@ -58,7 +58,7 @@ leaving JS-only redesigns of `js/net` to [rs2ts](/quest/m2/rs2ts/README.md). - [A reserved group survives a route returning](/quest/m1/cut-audit/reserved-route-return.md) - a route flip A to B to A no longer panics a peeked reader - [Settle received-track termination on a local session close](/quest/m1/cut-audit/js-close-cause.md) - choose the received track's local-close outcome after the prepared teardown error fixes - [A description-less AAC rendition means one thing](/quest/m1/cut-audit/aac-description-less.md) - every player and exporter agrees on the frame format -- [The export jitter buffer admits only frames due within its window](/quest/m1/cut-audit/jitter-admission.md) - a fast track is backpressured, not buffered without bound +- [The export jitter buffer admits only frames due within its window](/quest/m1/cut-audit/jitter-admission.md) - a fast or dense track is backpressured by time and bytes, not buffered without bound - [Peer-driven receive loops yield on a per-message budget](/quest/m1/cut-audit/peer-loop-budget.md) - small-message floods cannot monopolize a session driver - [Rust and JS accept the same catalogs](/quest/m1/cut-audit/catalog-parity.md) - one strictness, per rendition, with a shared fixture corpus - [Every relay runtime honors or refuses each listen setting](/quest/m1/cut-audit/uring-listen-config.md) - io_uring stops ignoring preferred addresses diff --git a/quest/m1/cut-audit/jitter-admission.md b/quest/m1/cut-audit/jitter-admission.md index f9590ab10de..fcf76a0ed97 100644 --- a/quest/m1/cut-audit/jitter-admission.md +++ b/quest/m1/cut-audit/jitter-admission.md @@ -30,6 +30,16 @@ frames pile up behind it, and `Stream::fill` keeps reading while `jitter.full(name)` is false. No frame-count cap. Alternatively charge a track whose lead keeps growing as a source fault. +Bound bytes too (decided 2026-10-27, maintainer, from a second audit of +main against release). Timestamp distance does not bound memory: frames +that share one timestamp all fall inside the window, and the container +consumer's max buffer +([moq-dev/moq#7056](https://github.com/moq-dev/moq/pull/7056)) only charges +frames the jitter buffer has not pulled yet. So a track is also full while +its queued bytes exceed a per-track byte budget. Like the time bound, it +holds the track back in its source as backpressure, never refuses a frame. +Test a track that packs many frames into one timestamp beside an honest one. + Then evaluate the larger simplification: about a dozen fixes to the export clock (f85547ffd0, 5d5974f083, 3fdf46160b, e84ffb3de3, a1465d0d00, 11bfa30461, 3cf978cdbf, 493d8eee99, 7a3890cd30, 3b77d23015, 7c4c48d08b, diff --git a/quest/m1/quinn-sync.md b/quest/m1/quinn-sync.md new file mode 100644 index 00000000000..fb9213730ad --- /dev/null +++ b/quest/m1/quinn-sync.md @@ -0,0 +1,53 @@ +# [S] moq-quic has every quinn fix it needs + +## Goal + +moq-quic, moq-sock's `udp`, and moq-tokio's `quic::driver` carry every +security and correctness fix quinn has landed since the last sync, each +ported with its regression test or recorded as not applying. The fork +ledger in `rs/moq-quic/README.md` says how far upstream was checked. + +## Plan + +Decided 2026-10-27 (maintainer), from a second audit of main against +release: the hard fork never merges upstream and cargo-deny cannot see a +quinn advisory in in-tree code, so checking upstream is recurring work. + +Each run: + +- Compare quinn-rs/quinn `main` against the last checked commit (the fork + point [`7616e6b2`](https://github.com/quinn-rs/quinn/commit/7616e6b2782722f3ce4a1b181ef08817d7f545e4) + for the first run), plus quinn's GitHub security advisories. +- Port each fix that applies to code the fork still carries, with its + regression test, and list it under the README's ported commits. Record + one that does not apply with its reason, as the README already does. + Skip dependency bumps. +- Record the newest upstream commit checked in the README, so the next run + starts there. + +First run: three fixes on quinn `main` are not in the ledger yet. Check +each against the fork's code before porting, since a missing ledger entry +does not prove the bug remains: +[`f233510c`](https://github.com/quinn-rs/quinn/commit/f233510c) (honor a +disabled idle timeout when accepting), +[`6c69f9f4`](https://github.com/quinn-rs/quinn/commit/6c69f9f4) (don't +credit a reset stream's unread data twice on stop; the fork rewrote `stop` +under the README's "Stream credit on stop", so it may already hold), and +[`623a0369`](https://github.com/quinn-rs/quinn/commit/623a0369) (don't make +specific IPv6 endpoints dual-stack). + +Recurrence: the PR that finishes a run deletes this file and creates the +next run at `/quest/m2/quinn-sync.md`, linked from `/quest/m2/README.md`'s +`Required`. It keeps this Goal and recurrence paragraph, carries forward +what this run learned, and requires [the release cut](/quest/m2/release/cut.md). +The cut removes itself from every `Required` and shifts m2 into m1, so the +next run becomes ready in the new m1, once per release cycle. Only +`/quest-delete` ends the recurrence. + +Public API: none expected; a ported fix that changes one says so. Wire: +QUIC behavior follows upstream's fixes. + +## Related + +- [moq-quic's API improves on quinn's](/quest/m1/quic-api/README.md) - renames that make each port a hand translation +- [Dependency audit](/quest/m2/audit-deps.md) - covers crates cargo-deny can see