From 0c3ca16ed858b789928a5d8777e517a24f0cde87 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 27 Oct 2026 23:36:10 -0700 Subject: [PATCH 1/2] chore(quest): claim quest/m0/ci/nightly-ffi-reuse.md Quest-Claim: 2806da0d52898582 From c16738d3d40420d8385e26d9f01baf65b2673b24 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 27 Oct 2026 23:48:09 -0700 Subject: [PATCH 2/2] fix(ci): let the Kotlin wrapper publish after Release FFI `inputs.dry-run` is null outside workflow_call, so the publish job's `cancel-in-progress` evaluated to '' and failed the job on the first shared FFI release (moq-ffi-v0.4.19). Compare against `true` explicitly. The first shared release verified the rest: every wrapper saw its publisher under the workflow_run token, and the Go and Swift wrappers published from the shared artifacts. Delete the verification quest. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/release-kt-lib.yml | 7 ++++--- quest/m0/ci/README.md | 1 - quest/m0/ci/nightly-ffi-reuse.md | 31 ---------------------------- quest/m2/cpp-ffi-reuse.md | 4 ---- 4 files changed, 4 insertions(+), 39 deletions(-) delete mode 100644 quest/m0/ci/nightly-ffi-reuse.md diff --git a/.github/workflows/release-kt-lib.yml b/.github/workflows/release-kt-lib.yml index d2d75544e60..f5c9f48dad6 100644 --- a/.github/workflows/release-kt-lib.yml +++ b/.github/workflows/release-kt-lib.yml @@ -179,10 +179,11 @@ jobs: # pending run per group and drops the older one, so a PR or a no-op push # sharing it silently cancelled a queued release. Scoped to this job so runs # that skip publishing never enter it. Dry-runs get a per-ref group instead - # and cancel their superseded builds. + # and cancel their superseded builds. `inputs.dry-run` is null outside + # workflow_call, and a null cancel-in-progress fails the job. concurrency: - group: release-kt-lib-${{ (github.event_name == 'pull_request' || inputs.dry-run) && github.ref || 'publish' }} - cancel-in-progress: ${{ github.event_name == 'pull_request' || inputs.dry-run }} + group: release-kt-lib-${{ (github.event_name == 'pull_request' || inputs.dry-run == true) && github.ref || 'publish' }} + cancel-in-progress: ${{ github.event_name == 'pull_request' || inputs.dry-run == true }} runs-on: ubuntu-latest env: # Picked up by com.vanniktech.maven.publish via Gradle project properties. diff --git a/quest/m0/ci/README.md b/quest/m0/ci/README.md index 46ae5afef89..a30962c23d3 100644 --- a/quest/m0/ci/README.md +++ b/quest/m0/ci/README.md @@ -132,6 +132,5 @@ The historical samples locate candidates; they are not controlled benchmarks. - [Verify the Nix cache](/quest/m0/ci/nix-cache-verify.md) - confirm CI and releases use `nix.moq.dev` and retire Cachix - [Unify dependency features](/quest/m0/ci/hakari.md) - a cargo-hakari workspace-hack so every job compiles each dependency alike and mbx hits across jobs - [Replay full-run failures against the selected gate](/quest/m0/ci/select-audit.md) - every dependency edge `just ci` misses is found and fixed with a test -- [First shared FFI release](/quest/m0/ci/nightly-ffi-reuse.md) - condition: the backport merges and the next `moq-ffi-v*` tag runs `Release FFI`; verify the wrappers - [Fewer BTreeMap instantiations](/quest/m0/ci/btree-keys.md) - moq-net shares BTreeMap key and value types, kept only if its CPU time drops - [Halve the slowest tests' CPU](/quest/m0/ci/slow-tests.md) - the slowest 1% of tests take under half their 289 CPU-seconds, with coverage kept diff --git a/quest/m0/ci/nightly-ffi-reuse.md b/quest/m0/ci/nightly-ffi-reuse.md deleted file mode 100644 index bad5eebc292..00000000000 --- a/quest/m0/ci/nightly-ffi-reuse.md +++ /dev/null @@ -1,31 +0,0 @@ -# [XS] First shared FFI release - -## Goal - -Verify the first `moq-ffi-v*` tag that runs `Release FFI`. Condition: the -backport [#6730](https://github.com/moq-dev/moq/pull/6730) has merged to -`release`, and a `moq-ffi-v*` tag cut after it has run `Release FFI`. Check the -tag with `git ls-tree .github/workflows/` and its runs with -`gh run list --workflow release-shared-ffi.yml --event push`. Then verify the -items below, fix or quest what fails, and delete this quest. - -## Plan - -`moq-ffi-v0.4.16` through `moq-ffi-v0.4.18` were cut from a `release` without -[#5549](https://github.com/moq-dev/moq/pull/5549), so they ran the per-language -workflows. #6730 backports #5549, the attempt-scoped publisher check from -[#5573](https://github.com/moq-dev/moq/pull/5573), and the wrapper gates from -[#6084](https://github.com/moq-dev/moq/pull/6084), without the Shipping sizes -and C++ parts `release` lacks. - -The Nightly side is verified: run 38897397428 covered the dry-run jobs (see -`.github/ffi.md`), and the Shipping sizes jobs of Nightlies 39779729461 and -40090959108 keep the `release/go-lib-/` keys, with the second compared -against the prior history (a changed artifact set fails the report). - -From the first shared tag: - -- Each wrapper (`release-go.yml`, `release-kt-lib.yml`, `release-swift-lib.yml`) - sees its publisher through the jobs API under the `workflow_run` token and - releases or skips as its own publisher did. -- The Go, Kotlin and Swift packages publish from the shared artifacts. diff --git a/quest/m2/cpp-ffi-reuse.md b/quest/m2/cpp-ffi-reuse.md index 76676a14b48..bdf5a550238 100644 --- a/quest/m2/cpp-ffi-reuse.md +++ b/quest/m2/cpp-ffi-reuse.md @@ -56,7 +56,3 @@ Keep this quest open for the published release input: Follow-up to [#5549](https://github.com/moq-dev/moq/pull/5549), which shared the default FFI build across Go, Kotlin and Swift. - -## Related - -- [First shared FFI release](/quest/m0/ci/nightly-ffi-reuse.md) - confirms the shared build in production first