From 3dc5c9d943bb138a9d01bb0f70e5d30b3482fee1 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Wed, 28 Oct 2026 00:19:20 -0700 Subject: [PATCH 1/2] chore(quest): claim quest/m0/interop-green/stale-browser-tests.md Quest-Claim: 27395e41b0f66df1 From 267d41083800c6adaec110477bf45c1a34c5f2c1 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sun, 1 Nov 2026 15:02:57 -0800 Subject: [PATCH 2/2] test: browser tests expect current element behavior The Video renderer test now asserts that an invalid `url` or `volume` attribute keeps the last valid value, reports one page error each, and suspends media until every invalid attribute is corrected. The publish-ui version-list tests use `moq-transport-18` where they mean a supported version, since moq-transport-14 was removed. Finishes quest/m0/interop-green/stale-browser-tests.md and sizes the interop-green epic now that its last child is done. Co-Authored-By: Claude Opus 5.5 --- quest/m0/interop-green/README.md | 8 ++--- quest/m0/interop-green/stale-browser-tests.md | 25 --------------- test/interop/clients/js/publish-ui.browser.ts | 10 +++--- test/video/renderer.browser.ts | 32 ++++++++++++------- 4 files changed, 28 insertions(+), 47 deletions(-) delete mode 100644 quest/m0/interop-green/stale-browser-tests.md diff --git a/quest/m0/interop-green/README.md b/quest/m0/interop-green/README.md index 08d8aaf328e..fdedf1c7ae7 100644 --- a/quest/m0/interop-green/README.md +++ b/quest/m0/interop-green/README.md @@ -1,4 +1,4 @@ -# Interop and Video pass on main +# [XS] Interop and Video pass on main ## Goal @@ -24,11 +24,7 @@ Already owned: the intermittent media-matrix timestamp-gap cells [test flakes](/quest/m0/test-flakes-2/README.md), with [moq-dev/moq#6990](https://github.com/moq-dev/moq/pull/6990) open. -This README's own work, after the children: confirm a scheduled Interop +Every child has landed. What remains: confirm a scheduled Interop and Video run each pass. Public API: none. Wire: none. - -## Required - -- [Browser tests expect current behavior](/quest/m0/interop-green/stale-browser-tests.md) - the renderer and element version tests match the shipped validation and version list diff --git a/quest/m0/interop-green/stale-browser-tests.md b/quest/m0/interop-green/stale-browser-tests.md deleted file mode 100644 index 73ed8f81c18..00000000000 --- a/quest/m0/interop-green/stale-browser-tests.md +++ /dev/null @@ -1,25 +0,0 @@ -# [XS] Browser tests expect current behavior - -## Goal - -The Video workflow's renderer test and the Interop harness's element -version tests assert the behavior the elements ship. - -## Plan - -- `test/video/renderer.browser.ts` expects an invalid `url` and `volume` - attribute to reset to their defaults with no page errors. The elements now - keep the last valid value, report the invalid attribute as a page error, - and suspend media until it is fixed (`js/watch/MIGRATE.md`). Assert that - contract: the last valid value is kept, each invalid attribute reports - once, and media stays suspended until a valid value returns. It fails - every Video run on main. -- `test/interop/clients/js/publish-ui.browser.ts` (the "version lists keep - their defaults" and "version lists refuse unsupported" tests) uses - `moq-transport-14`, which - [moq-dev/moq#6753](https://github.com/moq-dev/moq/pull/6753) removed, so - the setter throws `unsupported version`. Use a supported draft where the - test means a valid version and keep an unsupported one only where it - tests the refusal. - -Public API: none. Wire: none. diff --git a/test/interop/clients/js/publish-ui.browser.ts b/test/interop/clients/js/publish-ui.browser.ts index b3eff9092a1..c87971b6a5a 100644 --- a/test/interop/clients/js/publish-ui.browser.ts +++ b/test/interop/clients/js/publish-ui.browser.ts @@ -582,7 +582,7 @@ test("version lists keep their defaults and explicit false booleans round-trip", await customElements.whenDefined("moq-watch"); const watch = document.createElement("moq-watch"); const versions = []; - for (const value of ["moq-transport-14", " moq-lite-06 , moq-transport-22 ", "", " , ", null]) { + for (const value of ["moq-transport-18", " moq-lite-06 , moq-transport-22 ", "", " , ", null]) { if (value === null) watch.removeAttribute("versions"); else watch.setAttribute("versions", value); versions.push(watch.versions); @@ -593,7 +593,7 @@ test("version lists keep their defaults and explicit false booleans round-trip", return { versions, follow }; }); expect(result).toEqual({ - versions: [["moq-transport-14"], ["moq-lite-06", "moq-transport-22"], undefined, undefined, undefined], + versions: [["moq-transport-18"], ["moq-lite-06", "moq-transport-22"], undefined, undefined, undefined], follow: false, }); } finally { @@ -643,7 +643,7 @@ test("version lists refuse unsupported, duplicate, and empty lists and snapshot return error instanceof TypeError && element.versions === undefined; } }); - const list = ["moq-lite-06", "moq-transport-14"]; + const list = ["moq-lite-06", "moq-transport-18"]; element.versions = list; list.push("moq-lite-05"); const snapshot = element.versions; @@ -661,8 +661,8 @@ test("version lists refuse unsupported, duplicate, and empty lists and snapshot tag: result.tag, markup: [true, true], thrown: [true, true, true], - snapshot: ["moq-lite-06", "moq-transport-14"], - reflected: "moq-lite-06,moq-transport-14", + snapshot: ["moq-lite-06", "moq-transport-18"], + reflected: "moq-lite-06,moq-transport-18", }); } finally { await browser.close(); diff --git a/test/video/renderer.browser.ts b/test/video/renderer.browser.ts index 0eb9927803f..2ee12a79171 100644 --- a/test/video/renderer.browser.ts +++ b/test/video/renderer.browser.ts @@ -120,14 +120,10 @@ test(" swaps its canvas when the GPU is lost and keeps previewing t } }, 60_000); -test("invalid player and publisher attributes fall back without browser errors", async () => { +test("invalid player and publisher attributes keep the last valid value and suspend media until corrected", async () => { const page = await open(); const errors: string[] = []; - const warnings: string[] = []; page.on("pageerror", (error) => errors.push(error.message)); - page.on("console", (message) => { - if (message.type() === "warning") warnings.push(message.text()); - }); try { const report = await page.evaluate(async () => { const watch = document.createElement("moq-watch"); @@ -135,6 +131,8 @@ test("invalid player and publisher attributes fall back without browser errors", watch.setAttribute("visible", "always"); watch.setAttribute("paused", ""); document.body.append(watch, publish); + const enabled = () => [watch.connection.enabled.peek(), publish.connection.enabled.peek()]; + const before = enabled(); for (const element of [watch, publish]) { element.setAttribute("url", "https://example.invalid/"); element.setAttribute("url", "http://["); @@ -142,15 +140,27 @@ test("invalid player and publisher attributes fall back without browser errors", watch.setAttribute("volume", "0.75"); watch.setAttribute("volume", "foo"); await Promise.resolve(); - const result = { watch: watch.url, publish: publish.url, volume: watch.volume }; + const kept = { watch: watch.url?.href, publish: publish.url?.href, volume: watch.volume }; + const suspended = enabled(); + // The watch element resumes only once every invalid attribute is corrected. + for (const element of [watch, publish]) element.setAttribute("url", "https://example.invalid/"); + const partial = enabled(); + watch.setAttribute("volume", "0.25"); + const corrected = enabled(); watch.remove(); publish.remove(); - return result; + return { before, kept, suspended, partial, corrected }; + }); + expect(report).toEqual({ + before: [true, true], + kept: { watch: "https://example.invalid/", publish: "https://example.invalid/", volume: 0.75 }, + suspended: [false, false], + partial: [false, true], + corrected: [true, true], }); - expect(report).toEqual({ watch: undefined, publish: undefined, volume: 0.5 }); - expect(errors).toEqual([]); - expect(warnings.filter((message) => message.includes("invalid url="))).toHaveLength(2); - expect(warnings.filter((message) => message.includes("invalid volume="))).toHaveLength(1); + expect(errors.filter((message) => message.includes('invalid url="http://["'))).toHaveLength(2); + expect(errors.filter((message) => message.includes('invalid volume="foo"'))).toHaveLength(1); + expect(errors).toHaveLength(3); } finally { await page.close(); }