From 32f39fd3541f9b2f60628f9a22073213520675e2 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Wed, 28 Oct 2026 05:09:50 -0700 Subject: [PATCH 1/4] chore(quest): claim quest/m2/c/consumers.md Quest-Claim: 3014c570e44a08fe From d6bec78b89edcec368689559bc0e8ec838fc8413 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Wed, 28 Oct 2026 05:12:30 -0700 Subject: [PATCH 2/4] chore(quest): block C consumers on the cut and the generator switch The hand-written moq-c 0.7 ships at the cut with this interop client and doc/lib/c as its proof, and the generator switch re-cases every C type. Co-Authored-By: Claude Opus 5.5 --- quest/m2/c/consumers.md | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/quest/m2/c/consumers.md b/quest/m2/c/consumers.md index bef0ad0bcb0..8c95c9032a9 100644 --- a/quest/m2/c/consumers.md +++ b/quest/m2/c/consumers.md @@ -14,3 +14,25 @@ build. Nothing in the repository calls the hand-written ABI any more. hand-written ABI has only `moq_consume_video_enabled` (decided 2026-10-23). - Rewrite `doc/lib/c` around the generated API, including a sample that runs callbacks on the host's own loop through `moq_set_dispatcher`. + +Waits for the cut and the generator switch (found when first started, +2026-10-28). Until the cut, [moq-c parity](/quest/m1/c/README.md) ships the +hand-written 0.7 and proves it with this interop client and the current +`doc/lib/c`, and `doc/` describes only what ships, so either half landing first +drops the shipping crate's proof and documents an unpublished API. The switch +re-cases every generated C type (`moq_session` becomes `MoqSession`), so a port +before it is written twice; `c/moq/test/probe.c` takes that rename with the +switch. + +The generated API covers everything the client does, publishing included: the +C++ interop client already drives the same moq-ffi surface both ways. + +Open: `test/smoke/clients/c` checks the published `libmoq` archive with the +hand-written ABI, and can move only once the generated archive publishes, after +this quest. [Published generated C](/quest/m2/release/c-publish.md) is the +natural owner. + +## Required + +- [Breaking release cut](/quest/m2/release/cut.md) - the hand-written 0.7 ships with this client and these docs as its proof +- [Switch to rust2's UniFFI](/quest/m2/uniffi-fork.md) - the generated C type names settle before consumers are written against them From 3584062c1067c75ab3e2a8c2259626ed84653292 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 30 Oct 2026 21:30:34 -0700 Subject: [PATCH 3/4] chore(quest): record the C consumers picks Co-Authored-By: Claude Opus 5.5 --- quest/m2/c/consumers.md | 17 +++++++++++------ quest/m2/release/c-publish.md | 6 ++++++ quest/m2/release/c-retire.md | 4 ++-- 3 files changed, 19 insertions(+), 8 deletions(-) diff --git a/quest/m2/c/consumers.md b/quest/m2/c/consumers.md index 8c95c9032a9..88e4c96d55f 100644 --- a/quest/m2/c/consumers.md +++ b/quest/m2/c/consumers.md @@ -4,7 +4,9 @@ The C interop client (`test/interop/clients/c`) and the `doc/lib/c` samples use the generated `moq-c` API and pass `just test interop --all` and the doc-sample -build. Nothing in the repository calls the hand-written ABI any more. +build. Nothing in the repository calls the hand-written ABI any more except +the smoke client (`test/smoke/clients/c`), which +[Published generated C](/quest/m2/release/c-publish.md) moves. ## Plan @@ -12,11 +14,14 @@ build. Nothing in the repository calls the hand-written ABI any more. the callback and dispatcher shape end to end. It skips a disabled audio rendition through the generated record's `enabled`, as js-native does; the hand-written ABI has only `moq_consume_video_enabled` (decided 2026-10-23). + It stays subscribe-only (decided 2026-10-31): the C++ interop client already + covers moq-ffi's publish path, so a C publish lane would grow the matrix for + little new coverage. - Rewrite `doc/lib/c` around the generated API, including a sample that runs callbacks on the host's own loop through `moq_set_dispatcher`. Waits for the cut and the generator switch (found when first started, -2026-10-28). Until the cut, [moq-c parity](/quest/m1/c/README.md) ships the +2026-10-28; decided 2026-10-31). Until the cut, [moq-c parity](/quest/m1/c/README.md) ships the hand-written 0.7 and proves it with this interop client and the current `doc/lib/c`, and `doc/` describes only what ships, so either half landing first drops the shipping crate's proof and documents an unpublished API. The switch @@ -27,10 +32,10 @@ switch. The generated API covers everything the client does, publishing included: the C++ interop client already drives the same moq-ffi surface both ways. -Open: `test/smoke/clients/c` checks the published `libmoq` archive with the -hand-written ABI, and can move only once the generated archive publishes, after -this quest. [Published generated C](/quest/m2/release/c-publish.md) is the -natural owner. +`test/smoke/clients/c` checks the published archive with the hand-written ABI, +so it can move only once the generated archive publishes, after this quest; +[Published generated C](/quest/m2/release/c-publish.md) owns that move +(decided 2026-10-31). ## Required diff --git a/quest/m2/release/c-publish.md b/quest/m2/release/c-publish.md index 0e0755de89a..b97d3a589e9 100644 --- a/quest/m2/release/c-publish.md +++ b/quest/m2/release/c-publish.md @@ -4,6 +4,8 @@ The generated moq-c release archive installs, and every doc/lib/c sample and the C interop client build and run against it from a clean consumer checkout. +The smoke client (`test/smoke/clients/c`) checks the published generated +archive instead of the hand-written one. ## Plan @@ -14,6 +16,10 @@ ships at the m1 cut (decided 2026-10-25), so the generated 0.8 supersedes a published package; its source stays until [c-retire](/quest/m2/release/c-retire.md). +The smoke client moves here rather than with +[C consumers](/quest/m2/c/consumers.md) because it checks a published archive, +and the generated one publishes only after that quest (decided 2026-10-31). + ## Required - [Breaking release cut](/quest/m2/release/cut.md) - prepared code reaches release before artifact publication and installed proof diff --git a/quest/m2/release/c-retire.md b/quest/m2/release/c-retire.md index d69e75d37f2..d81dbf830bb 100644 --- a/quest/m2/release/c-retire.md +++ b/quest/m2/release/c-retire.md @@ -32,9 +32,9 @@ served it are deleted once the generated `moq-c` publishes. The generated ## Required -- [Generated C publication](/quest/m2/release/c-publish.md) - the replacement is available and verified +- [Generated C publication](/quest/m2/release/c-publish.md) - the replacement is available and verified, and the smoke client checks it -- [C consumers](/quest/m2/c/consumers.md) - nothing in the repository still calls the hand-written ABI +- [C consumers](/quest/m2/c/consumers.md) - the interop client and `doc/lib/c` samples no longer call the hand-written ABI ## Related From 474d121582b0c6040d92c67ff640a57f339ee459 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 30 Oct 2026 22:33:57 -0700 Subject: [PATCH 4/4] chore(quest): hand the C smoke client's rename to c-publish The hand-written moq-c keeps moq_origin_announced_broadcast, so the C smoke client gets request/follow only when c-publish moves it onto the generated archive. Drop C from smoke-bindings-rename and cross-link the two quests. Co-Authored-By: Claude Opus 5.5 --- quest/m2/release/c-publish.md | 4 ++++ quest/m2/release/smoke-bindings-rename.md | 9 +++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/quest/m2/release/c-publish.md b/quest/m2/release/c-publish.md index b97d3a589e9..20347715707 100644 --- a/quest/m2/release/c-publish.md +++ b/quest/m2/release/c-publish.md @@ -19,6 +19,10 @@ published package; its source stays until The smoke client moves here rather than with [C consumers](/quest/m2/c/consumers.md) because it checks a published archive, and the generated one publishes only after that quest (decided 2026-10-31). +The move also takes the client off `moq_origin_announced_broadcast` onto the +generated `request`/`follow`, so +[Smoke clients use request and follow](/quest/m2/release/smoke-bindings-rename.md) +leaves the C client to this quest. ## Required diff --git a/quest/m2/release/smoke-bindings-rename.md b/quest/m2/release/smoke-bindings-rename.md index ed19a6df13b..0c21301a6fb 100644 --- a/quest/m2/release/smoke-bindings-rename.md +++ b/quest/m2/release/smoke-bindings-rename.md @@ -4,8 +4,8 @@ Condition: a binding release ships the `request` and `follow` names from [moq-dev/moq#7193](https://github.com/moq-dev/moq/pull/7193). Check each -registry's latest moq-ffi-based package (Go, Python, Kotlin, Swift, C) for -`request`/`follow`. Then move `test/smoke/clients/{go,python,kotlin,swift,c}` +registry's latest moq-ffi-based package (Go, Python, Kotlin, Swift) for +`request`/`follow`. Then move `test/smoke/clients/{go,python,kotlin,swift}` off `request_broadcast` and `announced_broadcast`, and delete this quest. ## Plan @@ -16,4 +16,9 @@ Decided 2026-10-29 (maintainer). The smoke clients install published packages smoke client the same way. If a client must run against both old and new releases for a while, detect the method, as the JS compat client does. +The C smoke client is out of scope: it uses the hand-written `moq-c`, which +keeps `moq_origin_announced_broadcast`, and +[Published generated C](/quest/m2/release/c-publish.md) moves it onto the +generated API, which already names them `request` and `follow`. + Public API: none. Wire: none.