From e81b9047e346c7f92586ca26e7c3fe65fdf0f9c5 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Wed, 28 Oct 2026 08:12:46 -0700 Subject: [PATCH] quest: plan follow-ups from #7015 and #7016 Co-Authored-By: Claude Opus 5.5 --- quest/m0/ci/README.md | 1 + quest/m0/ci/out-of-crate-targets.md | 26 ++++++++++++++++++ quest/m1/README.md | 1 + quest/m1/ietf-withdraw-credit.md | 31 ++++++++++++++++++++++ quest/m1/interop-coverage/README.md | 1 + quest/m1/interop-coverage/js-ietf-fetch.md | 30 +++++++++++++++++++++ 6 files changed, 90 insertions(+) create mode 100644 quest/m0/ci/out-of-crate-targets.md create mode 100644 quest/m1/ietf-withdraw-credit.md create mode 100644 quest/m1/interop-coverage/js-ietf-fetch.md diff --git a/quest/m0/ci/README.md b/quest/m0/ci/README.md index 700b5b7d160..f1a1aa5c014 100644 --- a/quest/m0/ci/README.md +++ b/quest/m0/ci/README.md @@ -138,3 +138,4 @@ The historical samples locate candidates; they are not controlled benchmarks. - [Padding runs](/quest/m0/ci/quic-padding.md) - moq-quic parses a PADDING run as one frame, keeping the padding stats' meaning - [tracing-test filter](/quest/m0/ci/tracing-filter.md) - moq-tokio's tests stop forcing every crate to format at TRACE - [Stats oversize](/quest/m0/ci/stats-oversize.md) - moq-stats refuses an oversized plain snapshot before parsing it back +- [Out-of-crate targets](/quest/m0/ci/out-of-crate-targets.md) - branch checks format and lint a crate whose target file lives outside it, such as the Rust interop clients diff --git a/quest/m0/ci/out-of-crate-targets.md b/quest/m0/ci/out-of-crate-targets.md new file mode 100644 index 00000000000..7948dd9e586 --- /dev/null +++ b/quest/m0/ci/out-of-crate-targets.md @@ -0,0 +1,26 @@ +# [S] Branch checks cover out-of-crate targets + +## Goal + +When a branch changes only a file that a Cargo target points at from outside +its crate, such as the Rust interop clients under +`test/interop/clients/rust/`, `just check` and `just fix` format and lint that +crate. + +## Plan + +Found by [moq-dev/moq#7015](https://github.com/moq-dev/moq/pull/7015). +`rs/moq-cli/Cargo.toml` builds those clients as examples through `path = +"../../test/interop/clients/rust/*.rs"`, but `sh/rs/select.sh` seeds crates +only from paths under `rs/` and `demo/` (and the `rs` scope in +`sh/dispatch.sh` matches the same way), so those files reach neither rustfmt +nor clippy. Seed from each target's `src_path` in the `cargo metadata` the +selector already reads instead of adding a moq-cli special case, and cover it +in the selector's tests. + +Decided 2026-10-28 (maintainer): the draft-18 FETCH cancel spelling the same +PR noted (a reset from Rust, a FIN from JS) is not a quest, since both sides +accept either as a draft-18 cancel (`fin_cancels` in +`rs/moq-net/src/ietf/request_stream.rs`). + +Public API: none. diff --git a/quest/m1/README.md b/quest/m1/README.md index 3f93058e5c5..87dead34607 100644 --- a/quest/m1/README.md +++ b/quest/m1/README.md @@ -126,6 +126,7 @@ removed). - [Release audit findings](/quest/m1/release-audit/README.md) - resolve newly identified resource, parser, playback, and interoperability risks before the cut - [Pre-cut audit findings](/quest/m1/cut-audit/README.md) - fix the crashes, hostile-input costs, and correctness bugs the 2026-10-24 audit of main found - [Cancelled moq-transport requests stop](/quest/m1/ietf-request-cancel.md) - a cancelled request releases its state even when the peer withholds credit +- [Withdrawn advertisements stop](/quest/m1/ietf-withdraw-credit.md) - a withdrawn moq-transport namespace releases its state even when the peer withholds credit - [Cluster routing](/quest/m1/cluster-routing/README.md) - prove shared routing contracts, implement per-origin routes, and connect outbound local clusters - [Routing guide](/quest/m1/routing-guide.md) - concepts and practical outbound federation setup - [moq-c at parity](/quest/m1/c/README.md) - the hand-written `moq-c` ships at the cut with every m1 binding feature moq-ffi gains diff --git a/quest/m1/ietf-withdraw-credit.md b/quest/m1/ietf-withdraw-credit.md new file mode 100644 index 00000000000..a8f5800f7ea --- /dev/null +++ b/quest/m1/ietf-withdraw-credit.md @@ -0,0 +1,31 @@ +# [S] A withdrawn moq-transport advertisement stops writing + +## Goal + +Withdrawing a namespace a Rust publisher advertised over moq-transport +releases its state at once, even when the peer's send window holds back the +PUBLISH_NAMESPACE or a later namespace update. + +## Plan + +Found by [moq-dev/moq#7016](https://github.com/moq-dev/moq/pull/7016), +which fixed the subscriber side. In `rs/moq-net/src/ietf/publisher.rs`, +`advertise_namespace` awaits its PUBLISH_NAMESPACE, and each namespace +update, before it watches for withdrawal, so a peer that withholds +flow-control credit pins a withdrawn advertisement. + +Decided 2026-10-28 (maintainer): its own quest rather than part of +[one request lease](/quest/m2/ietf-request-lease.md), since a peer making us +hold state is a hostile-peer bound to fix now; it waits for +[Rust FETCH parity](/quest/m1/ietf-fetch-parity.md) only because that PR edits +the same file. Use #7016's pattern: buffer each message and flush it inside +the wait that already watches for withdrawal, and reset the stream rather +than FIN it when withdrawn before the message fully left. + +Test with a peer that never grants send credit, on drafts 18 and 22. + +Public API: none. Wire: none. + +## Required + +- [Rust FETCH parity](/quest/m1/ietf-fetch-parity.md) - edits `publisher.rs`, so this follows it diff --git a/quest/m1/interop-coverage/README.md b/quest/m1/interop-coverage/README.md index 9e3e2800e48..0da740476b3 100644 --- a/quest/m1/interop-coverage/README.md +++ b/quest/m1/interop-coverage/README.md @@ -47,6 +47,7 @@ coverage on `main` at `3ab6cbf81d`. - [JS namespace lifecycle](/quest/m1/interop-coverage/js-namespace-done.md) - the runner's moq-dev-js client moves to an `@moq/net` that withdraws namespaces by reset, so subscribe-namespace-lifecycle passes on Cloudflare draft-18 and aiomoqt - [JS subgroup data through imquic](/quest/m1/interop-coverage/js-imquic-objects.md) - the runner's moq-dev-js client moves to an `@moq/net` patch that writes data stream headers in one write, so data-subgroup-basic passes against imquic - [Late join and FETCH](/quest/m1/interop-coverage/late-join.md) - a late subscriber gets the current group from object 0, and a standalone FETCH returns a past group exactly +- [JS subscribers FETCH](/quest/m1/interop-coverage/js-ietf-fetch.md) - `@moq/net` fetches past groups and recovers a mid-group join over moq-transport, and joins the CLI FETCH round ## Related diff --git a/quest/m1/interop-coverage/js-ietf-fetch.md b/quest/m1/interop-coverage/js-ietf-fetch.md new file mode 100644 index 00000000000..55a70b4508b --- /dev/null +++ b/quest/m1/interop-coverage/js-ietf-fetch.md @@ -0,0 +1,30 @@ +# [M] JS subscribers FETCH over moq-transport + +## Goal + +`@moq/net`'s moq-transport subscriber fetches a past group, and recovers the +start of the current group when it joins mid-group, so a strict third-party +relay no longer cuts a JS player's join to the next group boundary. JS +subscribers join the CLI FETCH interop round beside Rust. + +## Plan + +Found by [moq-dev/moq#7015](https://github.com/moq-dev/moq/pull/7015). Today +`track.Consumer.fetchGroup()` is rejected on moq-transport, and a JS +subscriber asks for neither a joining FETCH (draft 18) nor a fill (draft 22); +see the SUBSCRIBE filter comment in `js/net/src/ietf/subscriber.ts`. The +in-tree relay replays the group, so only third-party relays show the cut. + +Decided 2026-10-28 (maintainer): one [M] quest in m1, after +[JS ranges](/quest/m1/subscribe-ranges/js.md), which turns `fetchGroup` into +a one-range subscription. Map a past range to a standalone FETCH, and a +mid-group join to a joining FETCH on draft 18 or a fill on draft 22, the way +Rust's subscriber does. Then add the native JS runtimes as subscribers to the +`run_fetch_round` cells in the tail suite, and a late-join case through a +relay that does not replay the group. + +Public API: none beyond JS ranges' surface. Wire: none. + +## Required + +- [JS ranges](/quest/m1/subscribe-ranges/js.md) - the one-range subscription this maps onto FETCH