From d86b324d0897f1158bc91d992dc814949e9858c9 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Wed, 28 Oct 2026 17:36:39 -0700 Subject: [PATCH 1/2] chore(quest): claim quest/m0/local-review.md Quest-Claim: c8e033f22a2df0f8 From 5b020555e4cb214a2763c4000dccb1cd35960456 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Wed, 28 Oct 2026 17:38:54 -0700 Subject: [PATCH 2/2] chore(quest): adopt local reviews Co-Authored-By: GPT-6.1 Sol --- .claude/skills/quest-ready/SKILL.md | 7 ------ .claude/skills/quest-review/SKILL.md | 7 ++++++ CONTRIBUTING.md | 36 +++++++++++++++++----------- flake.lock | 8 +++---- flake.nix | 2 +- quest/m0/README.md | 1 - quest/m0/local-review.md | 26 -------------------- 7 files changed, 34 insertions(+), 53 deletions(-) delete mode 100644 .claude/skills/quest-ready/SKILL.md create mode 100644 .claude/skills/quest-review/SKILL.md delete mode 100644 quest/m0/local-review.md diff --git a/.claude/skills/quest-ready/SKILL.md b/.claude/skills/quest-ready/SKILL.md deleted file mode 100644 index 371bacff0c5..00000000000 --- a/.claude/skills/quest-ready/SKILL.md +++ /dev/null @@ -1,7 +0,0 @@ ---- -name: quest-ready -description: Mark a draft PR ready for review, wait for an automated review, then decide whether to merge. ---- - -Run `quest skill ready` and follow its output. -If `quest` is not installed, follow https://github.com/kixelated/quest/blob/main/SETUP.md first. diff --git a/.claude/skills/quest-review/SKILL.md b/.claude/skills/quest-review/SKILL.md new file mode 100644 index 00000000000..3a9251f21a5 --- /dev/null +++ b/.claude/skills/quest-review/SKILL.md @@ -0,0 +1,7 @@ +--- +name: quest-review +description: Review a PR's branch locally with the other vendor's model, then mark it ready for review. +--- + +Run `quest skill review` and follow its output. +If `quest` is not installed, follow https://github.com/kixelated/quest/blob/main/SETUP.md first. diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4a88fbabe2c..1c76328efb5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -63,20 +63,28 @@ Prefer a quest for work needing durable scope or coordination. # Reviews -AI agents review pushes on their own, skipping ones they judge trivial. -Never explicitly request a review. - -For each finding: - -- If you don't agree with it, reply to the finding and move on. -- If it's a relatively easy improvement, fix it and push. Update the summary if needed. - -Wait for a review from any reviewer other than Grok. -Codex (OpenAI) reacts with a thumbs up when it has no findings; that counts as a review. -A push that gets no new review once CI finishes was judged trivial, so the earlier review still covers it. -Skipped or rate-limited reviews do not count. -For a fork with no automatic non-Grok review, ask the maintainer to arrange one. -Merge only when that review has no findings, or every finding is fixed or replied to. +Before marking a PR ready for review, and before each push to a ready PR, +run `/quest-review` on the committed branch after the local checks pass. +It uses `quest review` to have the other vendor's model review against the +PR's base branch, with `REVIEW.md` read from that base. + +The PR body's `## Review` section records the reviewer harness, model and +effort, reviewed head SHA, and each finding's disposition, or a skip and its +reason when the author judges the change too trivial to review. +A record naming the head being merged counts as the required review when +the PR's author has write access to the repository. Otherwise, or if the +record is missing or stale, the merging session checks out the head and +runs `/quest-review`, following `quest guide`'s rules for untrusted heads +and review exemptions. + +Address online reviewers' findings already posted on the head when merging; +never wait for or request an online review. +For each local or online finding: + +- Refute findings you disagree with using evidence; reply to online findings + on the PR. +- Fix findings you agree with, rerun checks, and review the new head locally + before pushing. Update the summary if needed. # Follow-ups diff --git a/flake.lock b/flake.lock index 85e94603a9f..92e47402ca3 100644 --- a/flake.lock +++ b/flake.lock @@ -59,17 +59,17 @@ ] }, "locked": { - "lastModified": 1793200283, - "narHash": "sha256-7hbnEIQg96MZZfAEOVCirp1S7MZqCo0zVal9jjSGzsU=", + "lastModified": 1793231863, + "narHash": "sha256-ZBuL9W5jXsTRDmjJoHV1+QeXgd5QMkzTtOHPNmo6vr8=", "owner": "kixelated", "repo": "quest", - "rev": "21d2159d504295c629d545a126f0cefd6da80149", + "rev": "4feaf18e9a7f4a8060a51f5f834ea424778aff95", "type": "github" }, "original": { "owner": "kixelated", "repo": "quest", - "rev": "21d2159d504295c629d545a126f0cefd6da80149", + "rev": "4feaf18e9a7f4a8060a51f5f834ea424778aff95", "type": "github" } }, diff --git a/flake.nix b/flake.nix index 87bd2fa5837..54a9a8f7e46 100644 --- a/flake.nix +++ b/flake.nix @@ -32,7 +32,7 @@ # The quest CLI, which also serves the quest guide and skills the stubs in # .claude/skills call. Bump the rev to upgrade them. quest = { - url = "github:kixelated/quest/21d2159d504295c629d545a126f0cefd6da80149"; + url = "github:kixelated/quest/4feaf18e9a7f4a8060a51f5f834ea424778aff95"; inputs.nixpkgs.follows = "nixpkgs"; inputs.flake-utils.follows = "flake-utils"; }; diff --git a/quest/m0/README.md b/quest/m0/README.md index d6b88c51a4e..85c8bc2d5c9 100644 --- a/quest/m0/README.md +++ b/quest/m0/README.md @@ -20,7 +20,6 @@ edge, which embeds moq-relay; it moved there on 2026-09-28. ## Required -- [Adopt local reviews](/quest/m0/local-review.md) - PRs are reviewed locally by the other vendor's model before they are pushed, and merging never waits on an online reviewer - [Nightly passes on main](/quest/m0/nightly/README.md) - the scheduled Nightly passes end to end, so red means a new break - [Interop and Video pass on main](/quest/m0/interop-green/README.md) - the scheduled Interop and Video workflows pass, so red means a new break - [Release shutdown backport](/quest/m0/ffi-shutdown-backport.md) - `release` publishes a non-breaking moq-ffi with an async `drain()` and qmux sessions on the QUIC stream limit diff --git a/quest/m0/local-review.md b/quest/m0/local-review.md deleted file mode 100644 index 6946ad5360c..00000000000 --- a/quest/m0/local-review.md +++ /dev/null @@ -1,26 +0,0 @@ -# [S] Adopt local reviews - -## Goal - -PRs here are reviewed locally by the other vendor's model through -`/quest-review` before they are pushed for review, and merging never waits -on an online reviewer. Start once `quest review` is on kixelated/quest's -`main`, where it is planned as `quest/m0/local-review.md`. - -## Plan - -Decided 2026-10-28 (maintainer, /quest-plan in kixelated/quest): - -- Bump the `quest` flake input to a kixelated/quest rev with `quest review`. -- Rewrite the review policy: the PR body's `## Review` record counts as the - required review when it names the head being merged, and so does a - recorded skip of a change the author judged too trivial to review. - Online reviewers' findings already posted on the head are addressed at - merge, never waited for or requested. -- In `CONTRIBUTING.md`'s Reviews section, drop waiting for "a review from - any reviewer other than Grok", the Codex 👍 rule, the "push with no new - review was judged trivial" rule, and asking the maintainer to arrange a - fork's review: the merging session checks out the head and runs - `/quest-review`. -- `REVIEW.md` is added by its own PR; check that `quest review` reads it - from the base.