diff --git a/quest/m1/README.md b/quest/m1/README.md index fdf97415a72..fc47a5146d6 100644 --- a/quest/m1/README.md +++ b/quest/m1/README.md @@ -123,7 +123,6 @@ removed). ## Required - [Address groups by timestamp](/quest/m1/time-addressing/README.md) - group start timestamps replace sequence numbers in the moq-net API and lite-07 wire, while old subscribers, old publishers, and published JS clients keep working -- [Release audit findings](/quest/m1/release-audit/README.md) - resolve newly identified resource, parser, playback, and interoperability risks before the cut - [Pre-cut audit findings](/quest/m1/cut-audit/README.md) - fix the crashes, hostile-input costs, and correctness bugs the 2026-10-24 audit of main found - [Vendored code has every upstream fix it needs](/quest/m1/vendor-sync/README.md) - quinn, libv4l-rs, nvidia-video-codec-sdk, rust-media-libs, cros-codecs, and UniFFI generator fixes are ported or planned, once per release cycle - [Security audit findings](/quest/m1/security-audit/README.md) - fix the verified relay, importer, moq-c, browser, and CI findings of the 2026-10-27 external security audit diff --git a/quest/m1/cut-audit/README.md b/quest/m1/cut-audit/README.md index c5316b207a3..2c10b81b9d0 100644 --- a/quest/m1/cut-audit/README.md +++ b/quest/m1/cut-audit/README.md @@ -62,7 +62,6 @@ leaving JS-only redesigns of `js/net` to [rs2ts](/quest/m2/rs2ts/README.md). ## Related -- [Release audit findings](/quest/m1/release-audit/README.md) - the 2026-10-22 audit this one follows - [Untrusted media parsers have fuzz targets](/quest/m2/media-fuzz.md) - would have caught the media parser findings here - [Announce interest streams share one route table](/quest/m2/announce-interest-memory.md) - the audit's inherited announce memory finding - [A parked read of a resumed group reads its budget without re-syncing](/quest/m2/recover-budget.md) - measure-first resume cost diff --git a/quest/m1/release-audit/README.md b/quest/m1/release-audit/README.md deleted file mode 100644 index dedbe4dcd53..00000000000 --- a/quest/m1/release-audit/README.md +++ /dev/null @@ -1,99 +0,0 @@ -# [S] Resolve the release audit findings - -## Goal - -Resolve the newly identified correctness, resource, and performance risks from -the 2026-10-22 release-to-main audit before the next cut. Existing quests keep -ownership of previously tracked problems. This epic's remaining work is to -recheck the resolved findings together on the release candidate and hand the -evidence to the existing cut quest. - -## Plan - -The maintainer requested an extensive audit and quests for bugs, potential -issues, and performance concerns. The comparison pins are -[main 6369eca](https://github.com/moq-dev/moq/commit/6369eca26472e120ee20c473027c13d36994edad) -and [release 36f392f](https://github.com/moq-dev/moq/commit/36f392f492f571454e5abc0e441ddc0168f16477). -Their tree diff spans 3,720 files, 575,722 insertions, and 125,659 deletions. - -Review covered protocol/model ownership, compression, auth, relay discovery, -QUIC/WebTransport/QMux, browser ingestion, media containers, FFI lifetimes, -archive migration, E2EE, release-only commits, and CI/publication paths. -This was risk-based source review with targeted reproductions, not a manual -verification of every changed line. Each child distinguishes reproduction, -source inference, and whether the problem is new or inherited. Priorities -describe impact; no unsupported exploit or performance magnitude is assumed. -No production code, public API, wire format, or package version changed in -the audit. Implementation choices remain with each fix; prefer the existing -ownership mechanisms and keep fixes scoped to their consumer. - -Validation at these pins: - -- Native protocol/auth/relay/JSON/stats: 3,830 passed, 18 skipped. -- Native task/clock/QUIC/socket: 923 passed, 2 skipped; Tokio/uring: - 656 passed, 4 skipped. A strict io_uring WebTransport echo also passed. -- Native mux/HLS/archive/E2EE: 1,992 passed, 5 skipped. -- Browser packages under Bun: 4,229 distinct tests passed across the initial - runs and targeted reruns. Initial failures were a denied socket listen and - two missing-libav tests; these passed after enabling loopback access and - building libav. Hang and watch also passed their normal per-package runs. - Combining the two polyfill tests in one custom Bun process polluted shared - WebCodecs globals; the repository isolates packages in separate processes. - This is not a claim that the full JS type/build/browser gate ran. -- Dependency audit reported the four already tracked unmaintained packages - basic-toml, zbus_names, zvariant, and zvariant_derive, not four new advisories. - -Run focused regression checks and relevant benchmark sweeps after the fixes, -then carry the candidate through the existing compatibility, package, draft, -and all-language interop checks. This audit did not run the full platform -matrix, real-browser WebCodecs/capture/GPU coverage, installed registry artifacts, -or a complete public-API diff against published packages. Those proofs retain -their existing owners. Reconcile release-only versions, changelogs, and -backports through the documented merge sequence before the cut. - -The deeper pass advanced main to -[1d43c096e0](https://github.com/moq-dev/moq/commit/1d43c096e04431bfc87d807ce47a546df8017475), -with the same release pin. It reviewed valid-input protocol differences, -subscription bounds, JSON/model expiry ownership, HLS/archive lifecycle, -FFI/C cancellation, and the handwritten Python/Swift/Kotlin/Go/Dart/C++ -wrappers. Native FFI/C checks added 371 passes and two skips. The repeated -309-test archive/HLS run passed with two skips; it is not additional distinct -coverage over the first pass. - -`TMPDIR=/tmp just test interop --all` passed at the deeper pin: seven native -interop tests and the complete configured integration harness. The harness -covered Rust/Python/Go/C++/browser publishers against Rust, Python, Go, C++, -Chromium, Node, Bun, C, and GStreamer consumers, permitted and denied AUTH, -browser session refusal, CLI FETCH close, finite tails, compression, and -partial-group drops. The initial run failed because nested temporary paths -exceeded Unix socket limits in Go tooling and Chromium; the short-path rerun -completed with no skips or failures. This is Linux workspace-artifact proof, -not installed-registry or mobile/macOS/Windows validation. - -Targeted reproductions confirmed a finite HLS startup race, retained HLS -server state after final drop, idle Dart stream cancellation, empty expiry -indexes, JS IETF timestamp changes, JS datagram range violations, and OBS -reordered-frame timestamps and missing EOF output. Each owning quest records -the reproduction's limits. JS reader and publisher datagram paths now enforce -subscription bounds, and the OBS source now stamps each decoded picture with its -own timestamp and drains at clean EOF. -Go reservation disposal was settled by -[moq-dev/moq#6424](https://github.com/moq-dev/moq/pull/6424): `Update(0)` -releases a reservation deterministically. -No platform-wide binding parity, full OBS runtime, fuzzing campaign, or -network-impairment performance result is implied by these checks. - -The 2026-10-22 binding and OBS audit at main -[1f5caa7026](https://github.com/moq-dev/moq/commit/1f5caa7026) added the -rate recovery child. Its two OBS findings went to m2 next to the other OBS -work, because obs-moq ships on its own schedule. - -## Related - -- [JS subscription ranges](/quest/m1/subscribe-ranges/js.md) - range lists and frame offsets build on the bounds fixed here -- [OBS video source](/quest/m2/obs-moq-video/source.md) - the decoder replacement keeps the timing and EOF behavior fixed here -- [Measured release performance](/quest/m1/release-perf/README.md) - existing paired benchmark regressions and their confirmation runs -- [Transport performance audit](/quest/m2/audit-perf.md) - congestion-control coverage remains outstanding -- [Binding timestamps](/quest/m1/binding-timestamps.md) - exact timestamps across language APIs -- [Dependency audit](/quest/m2/audit-deps.md) - existing advisory inventory -- [Publish and adopt](/quest/m2/release/README.md) - API/feature review, merge order, candidate checks, publication, and installed-artifact proof diff --git a/quest/m2/performance-survey/README.md b/quest/m2/performance-survey/README.md index 2624881e6f7..c25cce3d3b9 100644 --- a/quest/m2/performance-survey/README.md +++ b/quest/m2/performance-survey/README.md @@ -150,7 +150,7 @@ No duplicate quest or workflow edit belongs here. [performance audit](/quest/m2/audit-perf.md) repeats it before later cuts. - [Perf](/quest/m2/perf/README.md) owns measured channel contention, relay allocations, ingest batching, worker quiescence and runtime selection. -- The [release audit](/quest/m1/release-audit/README.md) bounded the media +- The 2026-10-22 release audit bounded the media reorder queues in [moq-dev/moq#6453](https://github.com/moq-dev/moq/pull/6453) and fixed QMux copying in [moq-dev/moq#6381](https://github.com/moq-dev/moq/pull/6381). MKV diff --git a/quest/m2/release/cut.md b/quest/m2/release/cut.md index df1b39335ff..cd93641cc2d 100644 --- a/quest/m2/release/cut.md +++ b/quest/m2/release/cut.md @@ -45,6 +45,19 @@ From the 2026-10-25 pre-cut run: `MOQ_FFI_RANGE`) to the release that ships the `implementation` field from [moq-dev/moq#6775](https://github.com/moq-dev/moq/pull/6775). +The [2026-10-22 release audit](https://github.com/moq-dev/moq/pull/7176) +closed with its fixes rechecked together. At source candidate +[main 487759f62a](https://github.com/moq-dev/moq/commit/487759f62a9ef39d916fe5b92df06dcff83478ce), +the focused native suites (7,697 passes), JS checks, draft checks, OBS sanitizer +suite, and all 176 configured all-language interop cells passed. At +[main 1ea4b1a2c3](https://github.com/moq-dev/moq/commit/1ea4b1a2c333527e25c8c29ee827290ed6e7d410), +`just test wire-compat` against moq-cli 0.14.10, moq-relay 0.17.10, and +`@moq/net` 0.4.7 passed every stable lite-01 through lite-06 session cell, +token, and catalog/container lane, with lite-07-wip skipped as its accepted +planned break. Dart's tests and both staged publish dry-runs passed with no +warnings. Neither main is the cut tree, and the full Linux gate was not run: +repeat these checks after the documented release-to-main merge. + ## Required - [Breaking release readiness](/quest/m1/README.md) - code, protocol and package proofs