diff --git a/quest/m0/ci/README.md b/quest/m0/ci/README.md index 8a16b82eb96..81a08f62f8c 100644 --- a/quest/m0/ci/README.md +++ b/quest/m0/ci/README.md @@ -139,7 +139,6 @@ The historical samples locate candidates; they are not controlled benchmarks. - [Gate send-depth](/quest/m0/ci/send-depth-gate.md) - the merge gate runs send-depth on a pinned nightly when moq-net changes, after #6890 fixes main - [Cargo aliases in nested checkouts](/quest/m0/ci/cargo-alias-strings.md) - `cargo build-ffi` and `cargo moq` work from a worktree nested inside another checkout - [Release credentials off main](/quest/m0/ci/publish-release-only.md) - `publish` admits only `release` and release tags once its `workflow_run` publishers run on their tag -- [VM checks refuse a host without KVM](/quest/m0/ci/vm-kvm.md) - `check flake` fails fast with a clear message instead of an emulated-boot timeout - [Biome checks every file it can parse](/quest/m0/ci/biome-whole-repo.md) - Biome runs over the whole repository and main is clean under it - [workspace.test.py ignores the caller's gate filter](/quest/m0/ci/workspace-test-env.md) - the dispatcher test passes under any `just gate` module filter - [PRs build the feature shapes they can break](/quest/m0/ci/pr-feature-builds.md) - a PR touching a crate's source runs that crate's isolated feature builds diff --git a/quest/m0/ci/vm-kvm.md b/quest/m0/ci/vm-kvm.md deleted file mode 100644 index 1849bc677e9..00000000000 --- a/quest/m0/ci/vm-kvm.md +++ /dev/null @@ -1,22 +0,0 @@ -# [XS] VM checks refuse a host without KVM - -## Goal - -`just ci`'s `check flake` fails at once with a message naming the missing -`/dev/kvm` when it would run the NixOS VM tests (such as -`vm-test-run-github-runner-vm`) on a host without KVM, instead of booting the -VMs under software emulation until they time out with "Shell did not start -in time". - -## Plan - -Decided by the maintainer on 2026-10-29, from the follow-ups of -[moq-dev/moq#7175](https://github.com/moq-dev/moq/pull/7175), whose local gate -spent about 19 minutes before failing this way on a host without KVM. - -- Refuse, don't skip: a skipped check would let a local gate read as passing. - The message says the check needs KVM and that CI runs it. -- The other follow-up from #7175, a nested Codex shell's `BASH_ENV` snapshot - inflating `PATH` past mbx's exec limit, did not reproduce with codex-cli - 0.162.1 (`BASH_ENV` unset, `PATH` stable across nested shells), so it is - neither planned nor reported. diff --git a/sh/dispatch.sh b/sh/dispatch.sh index a8ebcadfea9..3b74a967ddc 100755 --- a/sh/dispatch.sh +++ b/sh/dispatch.sh @@ -337,6 +337,13 @@ step() { return 77 fi fi + # Without KVM, QEMU falls back to emulation and the VM tests time + # out long after. Refuse rather than skip, so a local gate never + # reads as passing without them. + if [[ "$OSTYPE" == linux* && "$HOSTTYPE" == x86_64 && ! -e /dev/kvm ]]; then + echo "$action: flake's NixOS VM tests need KVM, but /dev/kvm is missing; run them on a KVM host, as CI does" >&2 + return 1 + fi # 77 marks the probe's skip, so the check's own 77 is a failure. # Full build logs name a failing VM subtest; Nix otherwise keeps # only the last 25 lines, which are QEMU's cleanup.