From f07a6bb30df6df42154e38807fd96eac745324de Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 31 Oct 2026 02:04:58 -0700 Subject: [PATCH 1/2] chore(quest): claim quest/m0/nightly/hang-libav-tests.md Quest-Claim: c0f92d236ef739ba From 4f2b30021df5b2abd37cabd40634e3d78f01dcc3 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 31 Oct 2026 02:07:45 -0700 Subject: [PATCH 2/2] chore(quest): retire the verified libav test dependency task The root postinstall already runs js/libav/build.ts, and the JS gate installs dependencies before package tests. A fresh supported install builds libav and both targeted tests pass on origin/main a1169021b6f250309b4428e8f28b03dcdc4236af. Avoid duplicating that build or skipping tests that already pass. Co-Authored-By: GPT-6.1 Sol --- quest/m0/nightly/README.md | 1 - quest/m0/nightly/hang-libav-tests.md | 15 --------------- 2 files changed, 16 deletions(-) delete mode 100644 quest/m0/nightly/hang-libav-tests.md diff --git a/quest/m0/nightly/README.md b/quest/m0/nightly/README.md index f74e2ae04a0..edab3d0a04c 100644 --- a/quest/m0/nightly/README.md +++ b/quest/m0/nightly/README.md @@ -42,4 +42,3 @@ Public API: none. Wire: none. - [Firefox's player closes every VideoFrame](/quest/m0/nightly/firefox-videoframe.md) - the Media job's Firefox player stops leaking an unclosed VideoFrame - [moq-tokio's isolated feature builds pass](/quest/m0/nightly/tokio-features.md) - `Incoming::refuse` stops failing `tokio-features --all` on dead_code, so the rest of `rs features` runs - [moq-uring's tests build on macOS and Windows](/quest/m0/nightly/kio-e0433.md) - the platform jobs stop failing with E0433 on `kio` in moq-uring's integration tests -- [@moq/hang's libav tests pass on main](/quest/m0/nightly/hang-libav-tests.md) - the two libav tests pass, or skip with a reason when the libav build is missing diff --git a/quest/m0/nightly/hang-libav-tests.md b/quest/m0/nightly/hang-libav-tests.md deleted file mode 100644 index 52a663e07d5..00000000000 --- a/quest/m0/nightly/hang-libav-tests.md +++ /dev/null @@ -1,15 +0,0 @@ -# [S] @moq/hang's libav tests pass on main - -## Goal - -The two tests in `js/hang/src/util/libav.test.ts` pass under `just ci` on main, or are skipped with a stated reason when the libav build they need isn't available, instead of failing. - -## Plan - -Reported by the agent on [moq-dev/moq#7061](https://github.com/moq-dev/moq/pull/7061): `just ci` passed except these two tests, which also failed on main's identical JS tree. Reproduce first; the cause isn't confirmed. - -The likely cause: both tests call `polyfill()` (`js/hang/src/util/libav.ts:16`), which imports `@moq/libav`. That package's entry point is `./dist/libav-opus-aac-af.mjs`, and `dist/` exists only after `js/libav/build.ts` runs `nix build .#moq-libav`. - -Decided 2026-10-30 (maintainer, follow-up planning after the /quest-afk run). If that is the cause, make the test depend on the build the way other generated artifacts do: build it in the gate's JS setup, or skip with a message naming the missing build outside the dev shell. Don't commit the built WebAssembly. - -Public API: none. Wire: none.