From ba3f8fb11fa215e4f880129e35a1687b3f400915 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 31 Oct 2026 16:41:09 -0700 Subject: [PATCH 1/6] quest: plan follow-ups from the 2026-10-31 /quest-complete requeue session New quests: catalog jitter floor, fMP4 open/commit, MKV leaf limits, DASH across reconfigure, relay undialable peers, moq-auth iroh drop, C origin relay mode, dispatcher selection gaps, Kotlin/JS flakes, moq-net test subscriber, format-gate follow-ups. Edits: media-fuzz, announce-takeover, net-wrap/e2ee, lint-examples, audit-lints, hls-conformance. Deletes noq-congestion. Co-Authored-By: Claude Opus 5.5 --- quest/m0/ci/README.md | 1 + quest/m0/ci/dispatch-selection-gaps.md | 36 +++++++++++++++++ quest/m0/test-flakes-2/README.md | 1 + quest/m0/test-flakes-2/kotlin-js-flakes.md | 27 +++++++++++++ quest/m1/README.md | 1 + quest/m1/announce-takeover.md | 22 ++++++++++ quest/m1/api-audit/congestion-names.md | 9 ++--- quest/m1/catalog-jitter-floor.md | 44 ++++++++++++++++++++ quest/m1/hls-conformance.md | 6 +++ quest/m1/security-audit/README.md | 2 + quest/m1/security-audit/fmp4-open-commit.md | 45 +++++++++++++++++++++ quest/m1/security-audit/mkv-leaf-limits.md | 31 ++++++++++++++ quest/m2/README.md | 9 ++++- quest/m2/audit-lints.md | 12 ++++++ quest/m2/auth-drop-iroh.md | 27 +++++++++++++ quest/m2/c-origin-relay.md | 33 +++++++++++++++ quest/m2/dash-reconfigure.md | 44 ++++++++++++++++++++ quest/m2/format-gate-followups.md | 28 +++++++++++++ quest/m2/lint-examples.md | 10 ++++- quest/m2/media-fuzz.md | 8 ++++ quest/m2/net-test-subscriber.md | 31 ++++++++++++++ quest/m2/net-wrap/e2ee.md | 9 +++++ quest/m2/noq-congestion.md | 31 -------------- quest/m2/relay-undialable-peers.md | 33 +++++++++++++++ 24 files changed, 461 insertions(+), 39 deletions(-) create mode 100644 quest/m0/ci/dispatch-selection-gaps.md create mode 100644 quest/m0/test-flakes-2/kotlin-js-flakes.md create mode 100644 quest/m1/catalog-jitter-floor.md create mode 100644 quest/m1/security-audit/fmp4-open-commit.md create mode 100644 quest/m1/security-audit/mkv-leaf-limits.md create mode 100644 quest/m2/auth-drop-iroh.md create mode 100644 quest/m2/c-origin-relay.md create mode 100644 quest/m2/dash-reconfigure.md create mode 100644 quest/m2/format-gate-followups.md create mode 100644 quest/m2/net-test-subscriber.md delete mode 100644 quest/m2/noq-congestion.md create mode 100644 quest/m2/relay-undialable-peers.md diff --git a/quest/m0/ci/README.md b/quest/m0/ci/README.md index a9de7b9f6d9..3209e67769e 100644 --- a/quest/m0/ci/README.md +++ b/quest/m0/ci/README.md @@ -140,4 +140,5 @@ The historical samples locate candidates; they are not controlled benchmarks. - [Release credentials off main](/quest/m0/ci/publish-release-only.md) - `publish` admits only `release` and release tags once its `workflow_run` publishers run on their tag - [Biome checks every file it can parse](/quest/m0/ci/biome-whole-repo.md) - Biome runs over the whole repository and main is clean under it - [workspace.test.py ignores the caller's gate filter](/quest/m0/ci/workspace-test-env.md) - the dispatcher test passes under any `just gate` module filter +- [Dispatcher tool changes run the dispatcher tests](/quest/m0/ci/dispatch-selection-gaps.md) - a tool-list change runs `sh/dispatch-query.test.py` in CI, and `sh/rs/uring.test.py` stops printing jq errors - [PRs build the feature shapes they can break](/quest/m0/ci/pr-feature-builds.md) - a PR touching a crate's source runs that crate's isolated feature builds diff --git a/quest/m0/ci/dispatch-selection-gaps.md b/quest/m0/ci/dispatch-selection-gaps.md new file mode 100644 index 00000000000..0d2d518019f --- /dev/null +++ b/quest/m0/ci/dispatch-selection-gaps.md @@ -0,0 +1,36 @@ +# [S] Dispatcher tool changes run the dispatcher tests + +## Goal + +A change to the dispatcher's tool lists (`sh/dispatch.sh` and the files it +reads them from) runs `sh/dispatch-query.test.py` in CI, so a tool added to a +module can't break that suite on `main` unnoticed. `sh/rs/uring.test.py` +runs without the repeated `jq: error ... null (null) cannot be matched` +lines. + +## Plan + +Decided 2026-10-31 (maintainer, the /quest-complete requeue session), from +[moq-dev/moq#7432](https://github.com/moq-dev/moq/pull/7432). + +- **Selection.** [6633d2f2e2](https://github.com/moq-dev/moq/commit/6633d2f2e2) + added `zizmor` to the `gh` module's tools in `sh/dispatch.sh`, and every + `CI_STRICT` case of `sh/dispatch-query.test.py` then failed with "these + tools are missing: zizmor" on `main`; #7432 fixes the stub. `run_lane` in + `sh/dispatch.sh` says gh's tests run on every `check` diff, and a change to + `sh/dispatch.sh` selects everything, so find why the commit's CI didn't run + or didn't fail on the suite (`.github/justfile` `test`, the CI lane that + runs it, the land gate) and fix that gap rather than adding a path rule. +- **jq noise.** `python3 sh/rs/uring.test.py` passes but prints + `jq: error (at :36): null (null) cannot be matched, as it is not a + string` four times. Its cargo-metadata fixture has no `workspace_root` or + `targets`, which the seed filter in `sh/rs/select.sh` (around line 66) + reads. Make the fixture complete, or make the filter tolerate their + absence, whichever matches real `cargo metadata` output. + +Public API: none. Wire: none. + +## Related + +- [workspace.test.py ignores the caller's gate filter](/quest/m0/ci/workspace-test-env.md) - #7432's quest, the same dispatcher test environment +- [moq-dev/moq#7440](https://github.com/moq-dev/moq/pull/7440) - plans `quest/m0/ci/check-selection.md`, which makes a jq error in Rust selection fail the run; that turns this jq noise into a failure, so land the fixture fix first or together. It does not cover the tool-list selection gap diff --git a/quest/m0/test-flakes-2/README.md b/quest/m0/test-flakes-2/README.md index 680bcd05bfc..9069230e906 100644 --- a/quest/m0/test-flakes-2/README.md +++ b/quest/m0/test-flakes-2/README.md @@ -55,3 +55,4 @@ Public API: none. Wire: none. - [IETF22 fallback](/quest/m0/test-flakes-2/ietf22-fallback.md) - an IETF22 browser viewer follows a fallback within the media lane's bound, keeping its session and its audio - [Tests own their temp directories](/quest/m0/test-flakes-2/temp-paths.md) - concurrent test processes stop overwriting each other's fixed temp files - [moq-rtc's session-end test survives load](/quest/m0/test-flakes-2/rtc-dtls.md) - its DTLS handshake stops timing out on a busy host +- [A Kotlin cancel test and a JS late-publisher test hold up](/quest/m0/test-flakes-2/kotlin-js-flakes.md) - the Kotlin flow-cancel test stops failing `unroutable` and the IETF blind-handle test passes under load diff --git a/quest/m0/test-flakes-2/kotlin-js-flakes.md b/quest/m0/test-flakes-2/kotlin-js-flakes.md new file mode 100644 index 00000000000..8b8107c833d --- /dev/null +++ b/quest/m0/test-flakes-2/kotlin-js-flakes.md @@ -0,0 +1,27 @@ +# [S] A Kotlin cancel test and a JS late-publisher test hold up + +## Goal + +Two intermittent failures are fixed at their cause: the Kotlin test +"cancelling a flow collection cancels its native handle" no longer fails +with `unroutable`, and the JS integration test "ietf blind handle picks up a +publisher that arrives late" passes under a heavily loaded `just check`. + +## Plan + +Decided 2026-10-31 (maintainer, the /quest-complete requeue session): +root-cause both in one quest, since each is small and they surfaced +together in that session's merge runs. + +- **Kotlin.** `kt/moq/src/jvmAndAndroidTest/kotlin/dev/moq/SmokeTest.kt:462`. + An `unroutable` answer means the request resolved before the publisher's + route reached the origin, so look for a wait on announcement that the test + skips or a race between the publish and the collection it cancels. +- **JS.** `js/net/src/integration.test.ts:1998`, the moq-transport variant + of the lite test at `:1933`. Under load the late publisher's arrival and + the blind handle's wait race some deadline; find which, and replace the + wall-time dependency with an event or a controlled clock. + +Follow the epic's rules: no raised timeout and no retry. + +Public API: none. Wire: none. diff --git a/quest/m1/README.md b/quest/m1/README.md index fdf97415a72..aea2a335ed2 100644 --- a/quest/m1/README.md +++ b/quest/m1/README.md @@ -176,6 +176,7 @@ removed). - [The browser baseline keeps its page logs](/quest/m1/baseline-page-logs.md) - a failing wasm-baseline cell is diagnosable from its artifact - [Interop coverage](/quest/m1/interop-coverage/README.md) - the riskiest moq-transport features moq-net exposes get cross-implementation tests over drafts 18 and 22 - [Calibrate the paired nightly benchmarks](/quest/m1/bench-ci.md) - A/A and deliberately slowed Nightly runs set the paired comparison's threshold, so its regression alerts can be trusted +- [A reconfigure keeps the published jitter and delay floor](/quest/m1/catalog-jitter-floor.md) - `Rendition::set` floors unsupplied jitter and delay at the catalog's values, so a same-codec reconfigure after a jitter rise no longer aborts TS import - [HLS and DASH segment conformance](/quest/m1/hls-conformance.md) - nightly ffprobe checks that advertised timing, sync flags, and bytes match the media served - [Unbounded groups](/quest/m1/unbounded-groups/README.md) - groups and frames lose their size caps; a group keeps a 32 MB tail, and readers behind it replay through paced flights or refresh - [Next Object on a cold Rust copy](/quest/m1/next-object-cold-copy.md) - a join after an upstream group report starts at the first frame received, never skipping diff --git a/quest/m1/announce-takeover.md b/quest/m1/announce-takeover.md index e7833db3104..958b231a3c7 100644 --- a/quest/m1/announce-takeover.md +++ b/quest/m1/announce-takeover.md @@ -56,6 +56,28 @@ What remains: relays, a claim ending before or after its child, and held catalog pins through a real player rather than route-table checks. +### Once identity replaces ANNOUNCE_TAKEOVER + +Decided 2026-10-31 (maintainer, the /quest-complete requeue session). Kept +separate from the rest of this Plan so it survives the identity rewrite +planned in [moq-dev/moq#7420](https://github.com/moq-dev/moq/pull/7420). +"We're replacing EPOCH with IDENTITY soon" (maintainer, 2026-10-31). + +- Reword "takeover" as an event or operation, in terms of identity + continuity, in [moq-bench pins the instances it measures](/quest/m2/bench-epoch-pin.md) + (Goal and Plan), [the HLS server follows each path once](/quest/m2/hls-follow-once.md) + (Goal and Tests), and [routes and announces](/quest/m1/cluster-routing/routes.md) + (around line 37, "the separately proven Takeover operation"). +- Rewrite the EPOCH references in `drafts/draft-lcurley-moq-cluster.md` and + `drafts/draft-lcurley-moq-epoch.md` in terms of IDENTITY. +- Add a regression test where a publisher restart's new announcement + arrives before the old one's reset, on `solicit = false` moq-transport + sessions. [moq-dev/moq#7239](https://github.com/moq-dev/moq/pull/7239) + found that the subscriber (`rs/moq-net/src/ietf/subscriber.rs`, `attach`) + folds such a PUBLISH_NAMESPACE into the same epochless route as an update + instead of End then Start; per-announcement identities resolve it, and + the test proves they do. + ## Related - [Routes and announces](/quest/m1/cluster-routing/routes.md) - the route layer whose ANNOUNCE_START layout overlaps this one's diff --git a/quest/m1/api-audit/congestion-names.md b/quest/m1/api-audit/congestion-names.md index 6584d982780..c5689574cec 100644 --- a/quest/m1/api-audit/congestion-names.md +++ b/quest/m1/api-audit/congestion-names.md @@ -16,9 +16,9 @@ Non-goals: new controller signals or a controller framework, and Decided 2026-10-27 from the release-to-main API audit (maintainer picked each option): -- The crate is still 0.1.0 and unpublished, and - [noq adopts moq-congestion](/quest/m2/noq-congestion.md) starts after the - m1 cut publishes it, so the rename costs one change now and nothing later. +- The crate is still 0.1.0 and unpublished, so the rename costs one change + now and nothing later. (The noq adoption quest it once waited on was + dropped on 2026-10-31: with iroh gone, nothing in moq runs noq.) - **Namespace** (chosen over keeping the quinn-style names that noq's adapter would read more easily): make `bbr3` and `cubic` public modules exporting `Config`. Rename `ControllerMetrics` to `Metrics` and @@ -27,8 +27,7 @@ option): - **Remove `into_any`**: its only callers are the moq-tokio tests in `rs/moq-tokio/src/quic/backend.rs` that assert which controller a factory built. Check the selection another way (such as observable behavior or - metrics) or drop an assertion that only restates the `match`. noq's adapter - keeps its own `into_any` on its side of the boundary. + metrics) or drop an assertion that only restates the `match`. - moq-quic's `transport::Config` already nests the controller factory (`congestion: Arc`, defaulting to `congestion::Bbr3Config`); rename its uses, its tests, and its bench to the diff --git a/quest/m1/catalog-jitter-floor.md b/quest/m1/catalog-jitter-floor.md new file mode 100644 index 00000000000..5ce6c1286b5 --- /dev/null +++ b/quest/m1/catalog-jitter-floor.md @@ -0,0 +1,44 @@ +# [S] A reconfigure keeps the published jitter and delay floor + +## Goal + +Re-setting an already-published rendition, such as an H.264 or H.265 +same-codec resolution change, never lowers the jitter or delay its catalog +already advertises for a field the new config leaves unset. The reconfigure +publishes with the higher of the two, as a measurement does, instead of +failing with `JitterDecreased` and aborting the TS import. + +## Plan + +Decided 2026-10-31 (maintainer, the /quest-complete requeue session), found +by the sessions of [moq-dev/moq#7436](https://github.com/moq-dev/moq/pull/7436) +and [moq-dev/moq#7387](https://github.com/moq-dev/moq/pull/7387). Planned +here in m1 as its own [S] rather than fixed inside #7436 (no test there needs +it) or dropped: it blocks the conformance test in #7387 once that fixture is +repaired. + +`Rendition::set` (`rs/moq-mux/src/catalog/tracks.rs:655`) resolves the new +config from what it supplies plus the last measurement (`Self::resolved`), +then `check_decrease` refuses anything below the catalog's current jitter or +delay. `Rendition::estimate` (`:711`) already floors its result at the +published values (`resolved.jitter.max(published.jitter)`, `:725-726`). +After a measurement raises jitter mid-run, a reconfigure that supplies no +jitter resolves to the lower detected value and fails. Floor the unsupplied +jitter and delay in `set` at the catalog's published values the same way, so +`check_decrease` still refuses only a value the caller explicitly lowers. + +`published_text_jitter_never_decreases` (`:1077`) expects a `None` re-set +after a supplied 100 ms to fail; with the floor it publishes 100 ms. Keep +the explicit-lower case failing and update the `None` case to the floor. + +Regression test: a unit test in `tracks.rs` that publishes a video config, +raises its jitter with `estimate`, then `set`s a config with new dimensions +and no jitter, and asserts it succeeds with the raised jitter still +published. + +Public API: none. Wire: none. + +## Related + +- [HLS and DASH segment conformance](/quest/m1/hls-conformance.md) - the conformance test this unblocks +- [HLS export follows a resolution change](/quest/m1/hls-reinit-same-codec.md) - the same-codec reconfigure that hits it diff --git a/quest/m1/hls-conformance.md b/quest/m1/hls-conformance.md index b0d21709e1a..77b1b954c26 100644 --- a/quest/m1/hls-conformance.md +++ b/quest/m1/hls-conformance.md @@ -33,10 +33,16 @@ Decided 2026-10-30 (maintainer): fix first. The two bugs the test found are their own quests, required below, and the test lands once it passes with both checks intact. +Added 2026-10-31 (maintainer, the /quest-complete requeue session): once +the fixture is repaired, the test's TS import hits a third bug, a +reconfigure failing `JitterDecreased` after a mid-run jitter rise, also its +own quest below. + ## Required - [HLS export follows a resolution change](/quest/m1/hls-reinit-same-codec.md) - the conformance test's same-codec switch fails until it lands - [The last AAC segment advertises its full duration](/quest/m1/hls-final-aac-segment.md) - the conformance test's audio check fails until it lands +- [A reconfigure keeps the published jitter and delay floor](/quest/m1/catalog-jitter-floor.md) - the conformance test's TS import aborts with `JitterDecreased` at its reconfigure until it lands ## Related diff --git a/quest/m1/security-audit/README.md b/quest/m1/security-audit/README.md index d610666eacd..36bfc17bdcd 100644 --- a/quest/m1/security-audit/README.md +++ b/quest/m1/security-audit/README.md @@ -56,6 +56,8 @@ Dropped, with reasons: - [fMP4 import streams mdat](/quest/m1/security-audit/fmp4-stream-mdat.md) - a box header declaring a huge size cannot pin importer memory across segments - [MKV import streams blocks](/quest/m1/security-audit/mkv-stream-blocks.md) - a declared block, metadata master, or ignored element cannot pin importer memory +- [fMP4 import streams samples through open and commit](/quest/m1/security-audit/fmp4-open-commit.md) - after the streaming PRs land, fMP4 samples share MKV's `open`/`commit`, a refused box stops dropping the rest of its call's input, and the import benchmark is re-measured +- [MKV leaf element limits](/quest/m1/security-audit/mkv-leaf-limits.md) - `CodecID`, `DocType`, and `CodecPrivate` are refused past per-element size limits instead of read whole - [Relay HTTP surface](/quest/m1/security-audit/relay-http.md) - `/fetch` cannot be sniffed as active content, and no web page can reach the ops listener - [Lite fetch backstop](/quest/m1/security-audit/fetch-backstop.md) - the pre-lite-05 fetch backstop is bounded by design or by the session's limits, not an unrelated default - [Browser input checks](/quest/m1/security-audit/js-input.md) - room metadata is schema-validated and the http:// fingerprint fetch is aborted and length-checked diff --git a/quest/m1/security-audit/fmp4-open-commit.md b/quest/m1/security-audit/fmp4-open-commit.md new file mode 100644 index 00000000000..18e2cddc0e3 --- /dev/null +++ b/quest/m1/security-audit/fmp4-open-commit.md @@ -0,0 +1,45 @@ +# [S] fMP4 import streams samples through open and commit + +## Goal + +The fMP4 importer streams its Legacy samples through the container +`Producer::open`/`commit` API instead of its own +`start_sample`/`finish_sample` pair, a box refused at its header no longer +drops the rest of the input handed to that decode call, and the 4-track +interleaved import benchmark is no slower than before the streaming change, +or the cost is measured and accepted. + +## Plan + +Decided 2026-10-31 (maintainer, the /quest-complete requeue session), from +the follow-ups of [moq-dev/moq#7232](https://github.com/moq-dev/moq/pull/7232) +(fMP4 streams mdat) and [moq-dev/moq#7234](https://github.com/moq-dev/moq/pull/7234) +(MKV streams blocks). + +Starts after both land. They are queued PRs that finish and delete the +`fmp4-stream-mdat` and `mkv-stream-blocks` quests, so they are named here +rather than linked under Required. Check with `gh pr view 7232` and +`gh pr view 7234`. + +- **open/commit.** #7234 adds `Producer::open`/`commit` for the MKV + importer's streamed blocks. Move the fMP4 importer's streamed Legacy + samples (`start_sample`/`finish_sample` in + `rs/moq-mux/src/container/fmp4/import.rs` after #7232) onto it, so both + importers stream a frame one way, and delete the fMP4-only pair. +- **A refused box.** After #7232, a box refused at its header ends the decode + call and drops whatever input followed it in that call. Either continue + past the refused box, or make a refusal terminal for the importer as the + MKV importer's is. Choose during implementation, by which keeps the + importer's state simpler and what HLS ingest (which feeds one segment per + call) needs, and record the choice in the PR. +- **Benchmark.** #7232 measured a possible ~25% slowdown in the 4-track + whole-input interleaved import benchmark, in a noisy run. Re-measure it + with the paired comparison on a quiet host, before and after this change, + and fix it or record why it is accepted. + +Public API: none expected. Wire: none. + +## Related + +- [MKV leaf element limits](/quest/m1/security-audit/mkv-leaf-limits.md) - the other leftover of the importer streaming work +- [Media fuzz](/quest/m2/media-fuzz.md) - would catch a dropped-input bug like the refused-box one diff --git a/quest/m1/security-audit/mkv-leaf-limits.md b/quest/m1/security-audit/mkv-leaf-limits.md new file mode 100644 index 00000000000..351e635d820 --- /dev/null +++ b/quest/m1/security-audit/mkv-leaf-limits.md @@ -0,0 +1,31 @@ +# [XS] MKV leaf element limits + +## Goal + +The MKV importer refuses a `CodecID`, `DocType`, or `CodecPrivate` element +whose declared size is past a limit specific to that element, so a header +declaring a huge one cannot pin importer memory. + +## Plan + +Decided 2026-10-31 (maintainer, the /quest-complete requeue session), a +follow-up of [moq-dev/moq#7234](https://github.com/moq-dev/moq/pull/7234), +which streams blocks and discards ignored elements but still reads these +three leaf elements whole. Starts after #7234 lands; it is a queued PR that +finishes and deletes the `mkv-stream-blocks` quest, so it is named here +rather than linked under Required. + +The maintainer earlier ruled out a blanket tag-size cap (it would refuse +large Segments and Clusters). These limits are per element +and bound only what the importer must hold whole: a `CodecID` and `DocType` +are short ASCII strings, and `CodecPrivate` is a decoder config (avcC, hvcC, +an Opus or Vorbis header). Pick each limit from its spec and the largest +real decoder config, check them against the MKV fixtures, and return the +importer's existing error for a refused element. Test each element declared +past its limit, fed in small chunks. + +Public API: none. Wire: none. + +## Related + +- [fMP4 import streams samples through open and commit](/quest/m1/security-audit/fmp4-open-commit.md) - the fMP4 leftover of the same streaming work diff --git a/quest/m2/README.md b/quest/m2/README.md index e8f04926b51..4852ba107e0 100644 --- a/quest/m2/README.md +++ b/quest/m2/README.md @@ -28,15 +28,16 @@ lite-07; bitrate enforcement is not part of this release. - [Every opt-in test target has a CI caller](/quest/m2/test-inventory.md) - the merge gate flags ignored tests, fuzz and bench targets, recipes, and scripts no workflow runs - [Worklet bundler matrix and React hooks run in CI](/quest/m2/browser-test-gaps.md) - the worklet matrix runs nightly on pinned bundlers, and the React signal hooks have tests - [Every handwritten language has a format gate](/quest/m2/format-gates.md) - gofmt, ktfmt, swift-format, and clang-format join `just check`, and Ruff covers all Python +- [One Ruff pin and Swift formatting on aarch64-linux](/quest/m2/format-gate-followups.md) - only the dev shell pins Ruff, and aarch64-linux checks Swift formatting once nixpkgs builds `swiftc` there - [Weekly mutation testing on critical modules](/quest/m2/mutants.md) - cargo-mutants runs weekly on moq-auth and moq-net's permission, resume, and expiry code - [Video quality](/quest/m2/video-quality/README.md) - a nightly VMAF harness grades every encoder backend and on-demand GoP pops against floors, and moq-boy's encode is fixed under it -- [noq adopts moq-congestion](/quest/m2/noq-congestion.md) - noq's BBR3 and Cubic delegate to the published crate behind noq's unchanged API - [Byte streams](/quest/m2/stream/README.md) - TCP connections ride MoQ losslessly through relays, proxied per hop rather than as IP packets - [Mesh](/quest/m2/mesh/README.md) - `moq mesh` enrolls a host or robot and reaches any node by endpoint ID or name for SSH, forwards, and agents - [P2P](/quest/m2/p2p/README.md) - application-selected peer sessions use shared priorities, routing, and same-epoch handover - [rust2 publishes its UniFFI fork](/quest/m2/rust2-uniffi.md) - waiting on moq-dev/rust2 to import UniFFI and moq's generators and publish them - [Switch to rust2's UniFFI](/quest/m2/uniffi-fork.md) - moq-ffi and every wrapper build from moq-dev/rust2's fork under one pin, and moq's generator code is deleted - [Generated C bindings](/quest/m2/c/README.md) - C generated from moq-ffi ships as `moq-c` 0.8.0 and replaces the hand-written crate +- [A C origin can discover eagerly, like a relay](/quest/m2/c-origin-relay.md) - the C API puts an origin in relay mode, so forwarding a client session's routes needs no local announce watcher - [A runtime-free QUIC driver](/quest/m2/quic-sansio-driver.md) - a caller's own loop moves UDP datagrams and polls moq sessions over moq-quic, for rust2's bindings - [MoQ on rind](/quest/m2/rind/README.md) - every MoQ crate takes its crypto from rind, a pure-Rust graviola fork, so no build compiles C crypto - [Benchmark sources](/quest/m2/bench-sources.md) - every measuring nightly benchmark feeds the regression table, and none is a smoke run @@ -44,6 +45,7 @@ lite-07; bitrate enforcement is not part of this release. - [QoS](/quest/m2/qos/README.md) - the relay's egress `lag` histogram and `dropped` counters on the stats totals and prefix tracks - [Lazy retained HLS instances](/quest/m2/hls-lazy-instances.md) - a replaced HLS instance starts its watchers only when a request reaches it - [HLS and DASH browser playback](/quest/m2/hls-player-test.md) - hls.js and dash.js play, reload, switch, and survive reconfiguration nightly +- [The DASH manifest keeps segments across a reconfigure](/quest/m2/dash-reconfigure.md) - a same-codec reconfigure keeps the old instance's segments listed in DASH, as HLS does - [moq-hls export on kio](/quest/m2/hls-export-kio.md) - export watchers and the init build are owned kio tasks instead of tokio::spawn - [Re-init retires timelines](/quest/m2/reinit-retire.md) - fMP4 and MKV re-inits retire the old timeline, so import state stays bounded - [Replaced producers retire their records](/quest/m2/producer-retire.md) - encoders and bindings retire a replaced producer's HLS records @@ -62,6 +64,7 @@ lite-07; bitrate enforcement is not part of this release. - [Native browser codecs](/quest/m2/native-compression-adopt.md) - adopt native operations when timing, frame and resource contracts hold - [Time test sweep](/quest/m2/time-test-sweep.md) - unrelated test conversion and the workspace lint ratchet +- [moq-net's library tests pass under cargo test](/quest/m2/net-test-subscriber.md) - two moq-net tests stop each installing a global tracing subscriber, so plain `cargo test -p moq-net --lib` passes - [Drop test-only cut requests](/quest/m2/video-cut-test-only.md) - moq-video's encode producer loses code only its tests use - [Pipelined requests](/quest/m2/pipeline-requests/README.md) - SUBSCRIBE and the first FETCH go out with the track-info request at every hop, so first data arrives a round trip sooner per hop @@ -211,6 +214,8 @@ lite-07; bitrate enforcement is not part of this release. - [Task supervision](/quest/m2/task-supervision.md) - the auth decider loop, stats publisher, and moq-tokio's token and WebSocket internals are supervised like #5447's tasks - [Auth serve bound address](/quest/m2/auth-serve-bound-addr.md) - `moq auth serve` logs the port it actually bound +- [The relay refuses a cluster peer it cannot dial](/quest/m2/relay-undialable-peers.md) - moq-tokio reports the schemes it can dial, and the relay refuses an undialable peer at startup instead of retrying forever +- [Drop moq-auth's iroh transport](/quest/m2/auth-drop-iroh.md) - the next breaking moq-auth release drops `Transport::Iroh` and the JS `"iroh"` value - [RTMP client reports a publish or play error](/quest/m2/rtmp-client-error.md) - a refused publish or play surfaces its reason - [H.264 parsing with maintained crates](/quest/m2/h264-reader.md) - moq-mux parses SPS VUI with h264-reader and shares one bit reader across codec config parsers - [avcC and hvcC through mp4-atom](/quest/m2/mp4-atom-config.md) - moq-mux stops hand-writing the decoder config records its mp4-atom dependency already parses @@ -245,7 +250,7 @@ lite-07; bitrate enforcement is not part of this release. - [One typed SETUP parse](/quest/m2/setup-parse-once.md) - one function replaces three SETUP parameter parses - [Archive reads against a real store](/quest/m2/archive-store-bench.md) - LIST/GET counts and latency over track count - [A malformed track says so downstream](/quest/m2/malformed-track-status.md) - subscribers and bindings see a malformed track, not INTERNAL_ERROR -- [Branch checks lint examples](/quest/m2/lint-examples.md) - `just check` runs clippy on the selected crates' examples +- [Branch checks lint examples](/quest/m2/lint-examples.md) - `just check` runs clippy on the selected crates' examples, and PR CI builds the C++, Go, and Python interop clients - [Drop kio's epoch fence](/quest/m2/crossbeam-pin-fence.md) - waiting on crossbeam#1352, then the `Read::drop` fence goes - [A cancelled miss stops waiting](/quest/m2/fill-wait-cancel-test.md) - a test proves a relay miss waiting on its own fill ends when no reader wants it - [No MOQ_* knobs outside the binaries](/quest/m2/env-knobs.md) - test, bench, and library knobs leave the `MOQ_*` prefix diff --git a/quest/m2/audit-lints.md b/quest/m2/audit-lints.md index 280543d688c..81d04835df1 100644 --- a/quest/m2/audit-lints.md +++ b/quest/m2/audit-lints.md @@ -74,6 +74,18 @@ Python wrapper. This run only reviews what those gates can't see. enable `reportUnnecessaryTypeIgnoreComment` without falsely flagging its three needed ignores. Audit it with the bindings installed. +- `set_var`/`remove_var` (decided 2026-10-31, maintainer, the + /quest-complete requeue session): replace `rs lint`'s `git grep` text + check (`rs/justfile`, the `lint` recipe) with a `disallowed-methods` entry + for `std::env::set_var` and `std::env::remove_var` in the root + `clippy.toml`, which arrives with + [moq-dev/moq#7329](https://github.com/moq-dev/moq/pull/7329) (queued). The + recipe's comment says why it is text today: the clock lint's test + allowances (`expect(clippy::disallowed_methods)`) would also silence an + environment write. Narrow those allowances, or keep each test's + expectation reason specific, so the clippy entry still catches a write in + a test. + ### Results (m1, 2026-10-24) - Rust: removed the Apple-only `msghdr_x` `non_camel_case_types` (Rust diff --git a/quest/m2/auth-drop-iroh.md b/quest/m2/auth-drop-iroh.md new file mode 100644 index 00000000000..81b14545ebe --- /dev/null +++ b/quest/m2/auth-drop-iroh.md @@ -0,0 +1,27 @@ +# [XS] Drop moq-auth's iroh transport + +## Goal + +The next breaking moq-auth release drops `Transport::Iroh` +(`rs/moq-auth/src/request.rs`) and the `"iroh"` transport value in +`js/auth/src/contract.ts`, which nothing sends once the iroh backend is gone. + +## Plan + +Decided 2026-10-31 (maintainer, the /quest-complete requeue session), a +follow-up of [moq-dev/moq#7345](https://github.com/moq-dev/moq/pull/7345). +That PR kept both because the enum is the relay-to-auth-server JSON contract +and its quest said "Wire: none"; the relay just never sends `iroh` now. + +Land it with the first moq-auth release that already breaks for another +reason, rather than cutting a breaking release for this alone. An auth +server built against the old contract is unaffected, since an unknown name +deserializes to `Unknown`. Update the auth contract docs and any test or +fixture naming `iroh`. + +Public API: breaking in moq-auth and `@moq/auth` (one enum variant). Wire: +the auth JSON contract loses the `iroh` transport value. + +## Related + +- [The relay refuses a cluster peer it cannot dial](/quest/m2/relay-undialable-peers.md) - the other iroh leftover diff --git a/quest/m2/c-origin-relay.md b/quest/m2/c-origin-relay.md new file mode 100644 index 00000000000..a7090183812 --- /dev/null +++ b/quest/m2/c-origin-relay.md @@ -0,0 +1,33 @@ +# [S] A C origin can discover eagerly, like a relay + +## Goal + +The C API (`rs/moq-c`, `moq.h`) can put an origin in relay mode, with the +eager discovery moq-net gives an origin handle on a relay link, so a C +application that forwards a client session's routes needs no local +announce watcher of its own to make discovery run. + +## Plan + +Decided 2026-10-31 (maintainer, the /quest-complete requeue session), a +follow-up of [moq-dev/moq#7246](https://github.com/moq-dev/moq/pull/7246) +(moq-c API gaps), whose follow-ups note that C has no way to make an origin +relay-mode for a client-ingest relay. + +In moq-net, a handle's link decides it: `origin::Producer::with_link` +(`rs/moq-net/src/model/origin.rs`) takes `Link::Local`, `Link::Peer`, or +`Link::Upstream`, and a non-local link's sessions discover everything they +may (`relays()`). `moq_origin_create` (`rs/moq-c/src/api.rs`) always makes a +local one. Expose the choice in C, by a create option or a setter mirroring +`with_link`, following whatever moq-ffi exposes if it has gained the same +by then, and document it in `moq.h` and `doc/lib/c`. If the +[generated C line](/quest/m2/c/README.md) has replaced the hand-written crate +before this starts, add it to moq-ffi instead so every binding gets it. +Test a C origin forwarding a client session's routes with no announce +watcher. + +Public API: additive in moq-c. Wire: none. + +## Related + +- [moq-c at parity](/quest/m1/c/README.md) - the hand-written crate's m1 parity work, which this does not block diff --git a/quest/m2/dash-reconfigure.md b/quest/m2/dash-reconfigure.md new file mode 100644 index 00000000000..757651ccdec --- /dev/null +++ b/quest/m2/dash-reconfigure.md @@ -0,0 +1,44 @@ +# [M] The DASH manifest keeps segments across a reconfigure + +## Goal + +After a same-codec reconfigure (such as a resolution change) replaces a +rendition's instance, the DASH manifest keeps listing the old instance's +segments, each under the init it was muxed for, until the window slides past +them, as the HLS media playlist does. A DASH player loses no listed segment +at the switch. + +## Plan + +Decided 2026-10-31 (maintainer, the /quest-complete requeue session), a +follow-up of [moq-dev/moq#7436](https://github.com/moq-dev/moq/pull/7436). +That PR keeps a replaced instance (`Rendition::previous`) and lists its +segments in the HLS playlist behind `EXT-X-DISCONTINUITY`, each with its own +`EXT-X-MAP`. `Rendition::segment` and `Rendition::init` already resolve a +predecessor's URLs. The DASH manifest (`rs/moq-hls/src/export/mpd.rs`, +`render_manifest`) still renders one `Period id="0"` with only the current +instance's segments, and `doc/bin/hls.md` says so. + +Represent the predecessor in DASH by either: + +- **multiple Periods**, one per instance, each with its own + `SegmentTemplate` and initialization URL; or +- **a per-segment init** in one Period. + +Choose during implementation by which dash.js and the conformance test +accept without a reload, and record the choice in the PR. Reuse the +predecessor window #7436 adds rather than tracking a second one, and update +`doc/bin/hls.md`. Test that a reconfigure keeps the old segments listed in +the manifest, and extend the DASH checks of +[HLS and DASH segment conformance](/quest/m1/hls-conformance.md) if it has +landed. + +Public API: none. Wire: none. + +## Required + +- [HLS export follows a resolution change](/quest/m1/hls-reinit-same-codec.md) - the instance hand-over (#7436) this extends to DASH + +## Related + +- [HLS and DASH browser playback](/quest/m2/hls-player-test.md) - dash.js survives reconfiguration nightly diff --git a/quest/m2/format-gate-followups.md b/quest/m2/format-gate-followups.md new file mode 100644 index 00000000000..b3aeeda45ea --- /dev/null +++ b/quest/m2/format-gate-followups.md @@ -0,0 +1,28 @@ +# [XS] One Ruff pin and Swift formatting on aarch64-linux + +## Goal + +Only the dev shell pins Ruff: `ruff` leaves the uv dev group in +`pyproject.toml` (and `uv.lock`). The Linux gate checks Swift formatting on +aarch64-linux too, once nixpkgs builds `swiftc` there. + +## Plan + +Decided 2026-10-31 (maintainer, the /quest-complete requeue session), the +follow-ups of [moq-dev/moq#7319](https://github.com/moq-dev/moq/pull/7319) +(format gates). + +- **Ruff.** #7319 makes the repo-wide `python` check module run the dev + shell's Ruff and keeps `ruff` in the uv dev group (`pyproject.toml:61`) + only for editors, so two Ruff versions are pinned. Drop it from the dev + group and `uv.lock`, and point editor setup at the dev shell's Ruff. +- **Swift on aarch64-linux.** #7319 adds `swift-format` to the dev shell + only off aarch64-linux, because nixpkgs marks its `swiftc` broken there, + so release-PR Check (`ubuntu-24.04-arm`) skips Swift formatting. When + nixpkgs builds it, add `swift-format` there and drop the skip. Until then + this half waits; check nixpkgs' `swift` package `meta.broken` for + aarch64-linux. + +Starts after #7319 lands. + +Public API: none. Wire: none. diff --git a/quest/m2/lint-examples.md b/quest/m2/lint-examples.md index e580d988493..7f8b02bb825 100644 --- a/quest/m2/lint-examples.md +++ b/quest/m2/lint-examples.md @@ -4,7 +4,7 @@ On Linux, `just check` runs clippy on the example targets of each crate it selects, so a broken or lint-failing example fails the branch rather than the -next Nightly. +next Nightly. PR CI also builds the C++, Go, and Python interop clients. ## Plan @@ -18,4 +18,12 @@ Decided 2026-10-28 (maintainer): examples only. The 68 benches stay with Nightly, since they cost more to build. Measure the added build time on a moq-cli change and record it in the PR. +Decided 2026-10-31 (maintainer, the /quest-complete requeue session): PR CI +also builds the C++, Go, and Python interop clients +(`test/interop/clients/{cpp,go,python}`) when their bindings or the client +change. They went stale unnoticed while +[moq-dev/moq#7311](https://github.com/moq-dev/moq/pull/7311) changed the +decoder API, since only the interop runs build them. A build (and Python +import or type check) is enough; running them stays with interop. + Public API: none. Wire: none. diff --git a/quest/m2/media-fuzz.md b/quest/m2/media-fuzz.md index aa8ea8fbcc9..716b3422e66 100644 --- a/quest/m2/media-fuzz.md +++ b/quest/m2/media-fuzz.md @@ -24,4 +24,12 @@ the existing fixtures. Assert a work and allocation bound proportional to input size. Wire the targets into the nightly gate next to moq-net's, and replay committed regressions in the merge gate. +Measure parse amplification too (decided 2026-10-31, maintainer, from +[moq-dev/moq#7232](https://github.com/moq-dev/moq/pull/7232)). That PR bounds +a held `moov` or `moof` at 32 MiB (`fmp4::MAX_HELD_BYTES`) and a `moof` at +2^21 samples, but a body at the bound decodes into roughly 2.5x larger +structures: a `trun` entry costs 4 to 16 input bytes and about 40 parsed. +Record the peak allocation for a maximal `moov` and `moof`, and fix it or +accept it with the number. + Public API: none. Wire: none. diff --git a/quest/m2/net-test-subscriber.md b/quest/m2/net-test-subscriber.md new file mode 100644 index 00000000000..d8bf2d2c33f --- /dev/null +++ b/quest/m2/net-test-subscriber.md @@ -0,0 +1,31 @@ +# [XS] moq-net's library tests pass under cargo test + +## Goal + +`cargo test -p moq-net --lib` passes, not only under nextest: +`setup::tests::credentials_stay_out_of_traces` and the model tests using +`model/test_tracing.rs` no longer each install a process-global tracing +subscriber, so whichever runs second in the shared process still captures +its events. + +## Plan + +Decided 2026-10-31 (maintainer, the /quest-complete requeue session). +Nextest runs each test in its own process, which hides the clash. + +`credentials_stay_out_of_traces` (`rs/moq-net/src/setup.rs:311`) uses +`#[tracing_test::traced_test]`, and `count_drop_warnings` +(`rs/moq-net/src/model/test_tracing.rs:39`) calls +`tracing::subscriber::set_global_default` and expects no other global +subscriber. Its doc explains why it is global: tracing caches callsite +interest process-wide, so a scoped dispatcher misses events another thread +cached as disabled. Keep that property. Likely one shared global test +subscriber that both use (`count_drop_warnings`' thread-local capture slot +extended to the credential check), or the credential test moved onto +`count_drop_warnings`' capture. Confirm with `cargo test -p moq-net --lib`. + +Public API: none. Wire: none. + +## Related + +- [moq-clock's tests pass under cargo test](/quest/m1/clock-test-process.md) - the same nextest-only pass in moq-clock diff --git a/quest/m2/net-wrap/e2ee.md b/quest/m2/net-wrap/e2ee.md index 50a50dbc0f1..8cd9dddd02a 100644 --- a/quest/m2/net-wrap/e2ee.md +++ b/quest/m2/net-wrap/e2ee.md @@ -58,6 +58,15 @@ the reverse (decided 2026-10-20, maintainer): without changing moq-net's `track(name)`; propose the encoding in the PR. Record it in `draft-lcurley-moq-e2ee.md`, replacing the Catalogs section's `.z` sibling rule. +- Datagram header allowance (decided 2026-10-31, maintainer, a follow-up + of [moq-dev/moq#7435](https://github.com/moq-dev/moq/pull/7435)): + `MAX_DATAGRAM_HEADER` (`rs/moq-e2ee/src/limits.rs`, + `js/e2ee/src/limits.ts`; 28 after #7435, lite-07's Type plus three 9-byte + varints) also counts the optional lite datagram fields: the relayed fields + the lite `ietf` extension adds, and the Inflated Size a compressed track's + datagram carries. Without them a maximum-size protected datagram can + encode past the 1200-byte body and be dropped. Update the e2ee draft's + plaintext bound and the `moq-e2ee-00` vectors with it. - Ranges: every moq-net range starts at a group's first frame ([moq-dev/moq#6465](https://github.com/moq-dev/moq/pull/6465)), so the wrapper reads each physical group whole and inflates from frame 0. diff --git a/quest/m2/noq-congestion.md b/quest/m2/noq-congestion.md deleted file mode 100644 index 5936dd8ae36..00000000000 --- a/quest/m2/noq-congestion.md +++ /dev/null @@ -1,31 +0,0 @@ -# [M] noq adopts moq-congestion - -## Goal - -noq's BBR3 and Cubic run `moq-congestion`, its own copies are deleted, and -noq's public congestion API is unchanged. The PR merges in -[n0-computer/noq](https://github.com/n0-computer/noq) with its maintainers' -approval. - -## Plan - -Decided with the maintainer on 2026-10-23, answering the noq maintainers' -offer: moq owns BBR3 as an external crate rather than maintaining it inside -noq. - -- Starts once the m1 cut publishes `moq-congestion` to crates.io (decided: - no backport or manual publish). Check with `cargo search moq-congestion`. -- noq keeps its `Controller` trait public and stable; its `Bbr3`/`Cubic` - configs become adapters that delegate to `moq-congestion`. noq does not - re-export `moq-congestion` types, so each crate bump is an explicit noq - change that wires any new signal. -- noq has no `SpaceId` and no `on_app_limited`; the adapter supplies what - noq can and states what BBR3 loses without it. noq keeps its pacer and - reads the controller's rate. -- Check against noq's open BBR3 reports before claiming them fixed: - [n0-computer/noq#800](https://github.com/n0-computer/noq/issues/800), - [n0-computer/noq#852](https://github.com/n0-computer/noq/issues/852), and - [n0-computer/noq#819](https://github.com/n0-computer/noq/issues/819). -- Once iroh ships it, `moq-tokio`'s iroh path (its noq `ControllerFactory`) - runs the same controllers; bumping that pin is a separate quest if it - needs code. diff --git a/quest/m2/relay-undialable-peers.md b/quest/m2/relay-undialable-peers.md new file mode 100644 index 00000000000..dfb31dc155e --- /dev/null +++ b/quest/m2/relay-undialable-peers.md @@ -0,0 +1,33 @@ +# [S] The relay refuses a cluster peer it cannot dial + +## Goal + +moq-tokio exposes which URL schemes its build can dial, and moq-relay +refuses to start when a configured cluster peer uses a scheme it can't +dial (for example `iroh://` once the iroh backend is gone, or `ftp://`), +naming the peer, instead of retrying it forever. + +## Plan + +Decided 2026-10-31 (maintainer, the /quest-complete requeue session), a +follow-up of [moq-dev/moq#7345](https://github.com/moq-dev/moq/pull/7345), +which drops moq-tokio's iroh backend. A CodeRabbit thread there +([discussion](https://github.com/moq-dev/moq/pull/7345#discussion_r4432489908)) +found the gap; the behavior predates that PR and covers every unsupported +scheme. + +`rs/moq-tokio/src/client.rs` (`connect_inner`) picks a transport by scheme +under feature gates (`tcp`, `tls`, `unix`, `ws`/`wss`, QUIC for the rest), +so which schemes dial depends on the build's features. Expose that set from +moq-tokio (a function or method beside `Client`, derived from the same +`cfg`s so it cannot drift), and check every peer in `Config::connect` +(`rs/moq-relay/src/cluster.rs`) against it at startup. A peer returned later +by an `api.url` endpoint can't fail startup; decide in the PR what it does +(recommended: log once and skip it rather than retry). Test a config naming +an unsupported scheme. + +Public API: additive in moq-tokio. Wire: none. + +## Related + +- [Drop moq-auth's iroh transport](/quest/m2/auth-drop-iroh.md) - the other iroh leftover From 909cae83a5dafd1235317cee4d5060884c3e309c Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 31 Oct 2026 16:45:03 -0700 Subject: [PATCH 2/6] quest: narrow clock expectations before dropping the env-write text check A specific expectation reason does not narrow what it silences, so the clippy entry only replaces the text check once crate-wide test expectations move onto the items that read the clock. Co-Authored-By: Claude Opus 5.5 --- quest/m2/audit-lints.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/quest/m2/audit-lints.md b/quest/m2/audit-lints.md index 81d04835df1..fcf5c5abfa4 100644 --- a/quest/m2/audit-lints.md +++ b/quest/m2/audit-lints.md @@ -82,9 +82,11 @@ Python wrapper. This run only reviews what those gates can't see. [moq-dev/moq#7329](https://github.com/moq-dev/moq/pull/7329) (queued). The recipe's comment says why it is text today: the clock lint's test allowances (`expect(clippy::disallowed_methods)`) would also silence an - environment write. Narrow those allowances, or keep each test's - expectation reason specific, so the clippy entry still catches a write in - a test. + environment write, and a specific `reason` does not narrow what an + expectation silences. Move crate- and module-wide test expectations (such + as `rs/moq-mux/src/lib.rs`'s `cfg_attr(test, expect(...))`) onto the items + that read the clock, and drop the text check only once none remain, so the + clippy entry still catches a write in a test. ### Results (m1, 2026-10-24) From de0f07c824e727fd5a296bbd8df0c2fde9a893ff Mon Sep 17 00:00:00 2001 From: quest fixer Date: Sun, 1 Nov 2026 01:13:20 -0800 Subject: [PATCH 3/6] docs(quest): restore plan section and completed quest reference --- quest/m0/ci/dispatch-selection-gaps.md | 2 +- quest/m1/announce-takeover.md | 18 +++++++++--------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/quest/m0/ci/dispatch-selection-gaps.md b/quest/m0/ci/dispatch-selection-gaps.md index 0d2d518019f..430879cc10c 100644 --- a/quest/m0/ci/dispatch-selection-gaps.md +++ b/quest/m0/ci/dispatch-selection-gaps.md @@ -32,5 +32,5 @@ Public API: none. Wire: none. ## Related -- [workspace.test.py ignores the caller's gate filter](/quest/m0/ci/workspace-test-env.md) - #7432's quest, the same dispatcher test environment +- [workspace.test.py ignores the caller's gate filter](https://github.com/moq-dev/moq/pull/7432) - #7432's quest, the same dispatcher test environment - [moq-dev/moq#7440](https://github.com/moq-dev/moq/pull/7440) - plans `quest/m0/ci/check-selection.md`, which makes a jq error in Rust selection fail the run; that turns this jq noise into a failure, so land the fixture fix first or together. It does not cover the tool-list selection gap diff --git a/quest/m1/announce-takeover.md b/quest/m1/announce-takeover.md index 9ebed9857af..8a1125f4196 100644 --- a/quest/m1/announce-takeover.md +++ b/quest/m1/announce-takeover.md @@ -115,15 +115,6 @@ Remove the cold-start warm-up reads (`claimed` in assert that the first subscription succeeds. Keep them for moq-transport. Run `just check`, `just test interop --all` and `just drafts check`. -Public API: breaking; removes `Takeover` and the predecessor fields in every -language. Wire: removes lite-07's ANNOUNCE_TAKEOVER (0x5), adding nothing -beyond [Identity and epoch](/quest/m1/api-audit/route/identity.md)'s fields. - -## Required - -- [Identity and epoch](/quest/m1/api-audit/route/identity.md) - the identity a job's exact route inherits -- [One Route handle](/quest/m1/api-audit/route/handle.md) - `request.route` creates the exact route under the claim's identity - ### Once identity replaces ANNOUNCE_TAKEOVER Decided 2026-10-31 (maintainer, the /quest-complete requeue session). Kept @@ -146,6 +137,15 @@ planned in [moq-dev/moq#7420](https://github.com/moq-dev/moq/pull/7420). instead of End then Start; per-announcement identities resolve it, and the test proves they do. +Public API: breaking; removes `Takeover` and the predecessor fields in every +language. Wire: removes lite-07's ANNOUNCE_TAKEOVER (0x5), adding nothing +beyond [Identity and epoch](/quest/m1/api-audit/route/identity.md)'s fields. + +## Required + +- [Identity and epoch](/quest/m1/api-audit/route/identity.md) - the identity a job's exact route inherits +- [One Route handle](/quest/m1/api-audit/route/handle.md) - `request.route` creates the exact route under the claim's identity + ## Related - [Listing and follow](/quest/m1/api-audit/route/events.md) - continuity shows up inside `follow`, not as an event From fb7bd248cbcd9ccfc44296041638c76020766d3f Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sun, 1 Nov 2026 11:58:16 -0800 Subject: [PATCH 4/6] quest: align follow-ups with main and address review threads Rewrite the fMP4 follow-up to its remaining refused-box and benchmark work now that #7232 streams through open/commit, repoint the deleted clock-test-process link at #7243, refresh line references, and fix the CodeRabbit findings on unroutable, into_any callers, auth compatibility, dialable schemes, e2ee seal/open limits, and trun amplification. Co-Authored-By: Claude Opus 5.5 --- quest/m0/test-flakes-2/kotlin-js-flakes.md | 14 +++--- quest/m1/announce-takeover.md | 4 +- quest/m1/api-audit/congestion-names.md | 18 +++++--- quest/m1/catalog-jitter-floor.md | 2 +- quest/m1/security-audit/README.md | 2 +- quest/m1/security-audit/fmp4-open-commit.md | 45 ------------------- .../m1/security-audit/fmp4-refusal-framing.md | 40 +++++++++++++++++ quest/m1/security-audit/mkv-leaf-limits.md | 18 +++++--- quest/m2/audit-lints.md | 4 +- quest/m2/auth-drop-iroh.md | 13 +++--- quest/m2/c-origin-relay.md | 3 +- quest/m2/format-gate-followups.md | 9 ++-- quest/m2/media-fuzz.md | 11 +++-- quest/m2/net-test-subscriber.md | 4 +- quest/m2/net-wrap/e2ee.md | 10 ++++- quest/m2/relay-undialable-peers.md | 15 +++++-- 16 files changed, 120 insertions(+), 92 deletions(-) delete mode 100644 quest/m1/security-audit/fmp4-open-commit.md create mode 100644 quest/m1/security-audit/fmp4-refusal-framing.md diff --git a/quest/m0/test-flakes-2/kotlin-js-flakes.md b/quest/m0/test-flakes-2/kotlin-js-flakes.md index 8b8107c833d..fcdaa60be21 100644 --- a/quest/m0/test-flakes-2/kotlin-js-flakes.md +++ b/quest/m0/test-flakes-2/kotlin-js-flakes.md @@ -13,12 +13,14 @@ Decided 2026-10-31 (maintainer, the /quest-complete requeue session): root-cause both in one quest, since each is small and they surfaced together in that session's merge runs. -- **Kotlin.** `kt/moq/src/jvmAndAndroidTest/kotlin/dev/moq/SmokeTest.kt:462`. - An `unroutable` answer means the request resolved before the publisher's - route reached the origin, so look for a wait on announcement that the test - skips or a race between the publish and the collection it cancels. -- **JS.** `js/net/src/integration.test.ts:1998`, the moq-transport variant - of the lite test at `:1933`. Under load the late publisher's arrival and +- **Kotlin.** `kt/moq/src/jvmAndAndroidTest/kotlin/dev/moq/SmokeTest.kt:518`. + An `unroutable` answer means no route served the path when the request + resolved. A request made before the publisher's route reached the origin + returns it, and so does one made after that route was withdrawn or the + broadcast closed. Check both a wait on announcement that the test skips + and a route withdrawal or close during the collection it cancels. +- **JS.** `js/net/src/integration.test.ts:1994`, the moq-transport variant + of the lite test at `:1929`. Under load the late publisher's arrival and the blind handle's wait race some deadline; find which, and replace the wall-time dependency with an event or a controlled clock. diff --git a/quest/m1/announce-takeover.md b/quest/m1/announce-takeover.md index 991132763e6..c6e8fcc3c62 100644 --- a/quest/m1/announce-takeover.md +++ b/quest/m1/announce-takeover.md @@ -119,8 +119,8 @@ Run `just check`, `just test interop --all` and `just drafts check`. ### Once identity replaces ANNOUNCE_TAKEOVER Decided 2026-10-31 (maintainer, the /quest-complete requeue session). Kept -separate from the rest of this Plan so it survives the identity rewrite -planned in [moq-dev/moq#7420](https://github.com/moq-dev/moq/pull/7420). +separate from the identity rewrite of this Plan, which landed with +[moq-dev/moq#7420](https://github.com/moq-dev/moq/pull/7420). "We're replacing EPOCH with IDENTITY soon" (maintainer, 2026-10-31). - Reword "takeover" as an event or operation, in terms of identity diff --git a/quest/m1/api-audit/congestion-names.md b/quest/m1/api-audit/congestion-names.md index c5689574cec..087ec0236a0 100644 --- a/quest/m1/api-audit/congestion-names.md +++ b/quest/m1/api-audit/congestion-names.md @@ -18,16 +18,24 @@ option): - The crate is still 0.1.0 and unpublished, so the rename costs one change now and nothing later. (The noq adoption quest it once waited on was - dropped on 2026-10-31: with iroh gone, nothing in moq runs noq.) + dropped on 2026-10-31, maintainer: once + [moq-dev/moq#7345](https://github.com/moq-dev/moq/pull/7345) drops the iroh + backend, nothing in moq runs noq.) - **Namespace** (chosen over keeping the quinn-style names that noq's adapter would read more easily): make `bbr3` and `cubic` public modules exporting `Config`. Rename `ControllerMetrics` to `Metrics` and `ControllerFactory` to `Factory`. Keep `Bbr3`, `Cubic`, `Unlimited`, `Controller`, `Packet`, and the event structs at the root. -- **Remove `into_any`**: its only callers are the moq-tokio tests in - `rs/moq-tokio/src/quic/backend.rs` that assert which controller a factory - built. Check the selection another way (such as observable behavior or - metrics) or drop an assertion that only restates the `match`. +- **Remove `into_any`**: its callers are tests. The ones in + `rs/moq-tokio/src/quic/backend.rs` and `rs/moq-quic/src/tests/mod.rs` + assert which controller a factory built; check the selection another way + (such as observable behavior or metrics) or drop an assertion that only + restates the `match`. `rs/moq-quic/src/tests/probe.rs` downcasts to read + BBR3's `probing_rtt` and `min_rtt`; read them from `Metrics` or a + test-only hook instead. The iroh backend's controllers in + `rs/moq-tokio/src/iroh.rs` implement noq's own + `noq_proto::congestion::Controller::into_any`, a different trait this + leaves alone (and #7345 deletes). - moq-quic's `transport::Config` already nests the controller factory (`congestion: Arc`, defaulting to `congestion::Bbr3Config`); rename its uses, its tests, and its bench to the diff --git a/quest/m1/catalog-jitter-floor.md b/quest/m1/catalog-jitter-floor.md index 5ce6c1286b5..1979c48bab2 100644 --- a/quest/m1/catalog-jitter-floor.md +++ b/quest/m1/catalog-jitter-floor.md @@ -27,7 +27,7 @@ jitter resolves to the lower detected value and fails. Floor the unsupplied jitter and delay in `set` at the catalog's published values the same way, so `check_decrease` still refuses only a value the caller explicitly lowers. -`published_text_jitter_never_decreases` (`:1077`) expects a `None` re-set +`published_text_jitter_never_decreases` (`:1078`) expects a `None` re-set after a supplied 100 ms to fail; with the floor it publishes 100 ms. Keep the explicit-lower case failing and update the `None` case to the floor. diff --git a/quest/m1/security-audit/README.md b/quest/m1/security-audit/README.md index 2c0b5d6fcb7..0381f8bb0f2 100644 --- a/quest/m1/security-audit/README.md +++ b/quest/m1/security-audit/README.md @@ -54,7 +54,7 @@ Dropped, with reasons: ## Required -- [fMP4 import streams samples through open and commit](/quest/m1/security-audit/fmp4-open-commit.md) - after the streaming PRs land, fMP4 samples share MKV's `open`/`commit`, a refused box stops dropping the rest of its call's input, and the import benchmark is re-measured +- [fMP4 refusals keep framing](/quest/m1/security-audit/fmp4-refusal-framing.md) - a box refused at its header stops dropping the rest of its call's input, and the interleaved import benchmark is re-measured - [MKV leaf element limits](/quest/m1/security-audit/mkv-leaf-limits.md) - `CodecID`, `DocType`, and `CodecPrivate` are refused past per-element size limits instead of read whole - [Browser input checks](/quest/m1/security-audit/js-input.md) - room metadata is schema-validated and the http:// fingerprint fetch is aborted and length-checked - [CI tool pins](/quest/m1/security-audit/ci-pins.md) - binding generators are pinned by commit in one place, and the remaining unpinned installs and broad token grants are fixed diff --git a/quest/m1/security-audit/fmp4-open-commit.md b/quest/m1/security-audit/fmp4-open-commit.md deleted file mode 100644 index 18e2cddc0e3..00000000000 --- a/quest/m1/security-audit/fmp4-open-commit.md +++ /dev/null @@ -1,45 +0,0 @@ -# [S] fMP4 import streams samples through open and commit - -## Goal - -The fMP4 importer streams its Legacy samples through the container -`Producer::open`/`commit` API instead of its own -`start_sample`/`finish_sample` pair, a box refused at its header no longer -drops the rest of the input handed to that decode call, and the 4-track -interleaved import benchmark is no slower than before the streaming change, -or the cost is measured and accepted. - -## Plan - -Decided 2026-10-31 (maintainer, the /quest-complete requeue session), from -the follow-ups of [moq-dev/moq#7232](https://github.com/moq-dev/moq/pull/7232) -(fMP4 streams mdat) and [moq-dev/moq#7234](https://github.com/moq-dev/moq/pull/7234) -(MKV streams blocks). - -Starts after both land. They are queued PRs that finish and delete the -`fmp4-stream-mdat` and `mkv-stream-blocks` quests, so they are named here -rather than linked under Required. Check with `gh pr view 7232` and -`gh pr view 7234`. - -- **open/commit.** #7234 adds `Producer::open`/`commit` for the MKV - importer's streamed blocks. Move the fMP4 importer's streamed Legacy - samples (`start_sample`/`finish_sample` in - `rs/moq-mux/src/container/fmp4/import.rs` after #7232) onto it, so both - importers stream a frame one way, and delete the fMP4-only pair. -- **A refused box.** After #7232, a box refused at its header ends the decode - call and drops whatever input followed it in that call. Either continue - past the refused box, or make a refusal terminal for the importer as the - MKV importer's is. Choose during implementation, by which keeps the - importer's state simpler and what HLS ingest (which feeds one segment per - call) needs, and record the choice in the PR. -- **Benchmark.** #7232 measured a possible ~25% slowdown in the 4-track - whole-input interleaved import benchmark, in a noisy run. Re-measure it - with the paired comparison on a quiet host, before and after this change, - and fix it or record why it is accepted. - -Public API: none expected. Wire: none. - -## Related - -- [MKV leaf element limits](/quest/m1/security-audit/mkv-leaf-limits.md) - the other leftover of the importer streaming work -- [Media fuzz](/quest/m2/media-fuzz.md) - would catch a dropped-input bug like the refused-box one diff --git a/quest/m1/security-audit/fmp4-refusal-framing.md b/quest/m1/security-audit/fmp4-refusal-framing.md new file mode 100644 index 00000000000..b65e5efa881 --- /dev/null +++ b/quest/m1/security-audit/fmp4-refusal-framing.md @@ -0,0 +1,40 @@ +# [S] fMP4 refusals keep framing + +## Goal + +A box the fMP4 importer refuses at its header no longer drops the rest of +the input handed to that decode call, so a caller feeding arbitrary chunks +keeps framing as a box-aligned caller does. The 4-track interleaved import +benchmark is no slower than before the streaming change, or the cost is +measured and accepted. + +## Plan + +Decided 2026-10-31 (maintainer, the /quest-complete requeue session), from +the follow-ups of [moq-dev/moq#7232](https://github.com/moq-dev/moq/pull/7232) +(fMP4 streams mdat) and [moq-dev/moq#7234](https://github.com/moq-dev/moq/pull/7234) +(MKV streams blocks). Both have landed. #7234 landed first, so #7232 already +streams the importer's samples through `Producer::open`/`commit`; the +original open/commit bullet is done, and this quest keeps the other two +([noted on moq-dev/moq#7468](https://github.com/moq-dev/moq/pull/7468#issuecomment-6554670247)). + +- **A refused box.** `Import::decode` (`rs/moq-mux/src/container/fmp4/import.rs`) + documents it: a refused box or fragment discards the rest of its body, and + the rest of the refusing call's input is not read. That suits box-aligned + callers (HLS ingest feeds one segment per call) but loses framing for + arbitrary chunking. Either continue past the refused box, or make a + refusal terminal for the importer as the MKV importer's is. Choose during + implementation, by which keeps the importer's state simpler and what HLS + ingest needs, and record the choice in the PR. +- **Benchmark.** #7232 measured a possible ~25% slowdown in the 4-track + 16-run whole-input `cmaf-interleaved-import` case, in a noisy run where the + 4-track cases swung ±40% between runs of one source. Re-measure it with the + paired comparison on a quiet host, against the commit before #7232, and + fix it or record why it is accepted. + +Public API: none expected. Wire: none. + +## Related + +- [MKV leaf element limits](/quest/m1/security-audit/mkv-leaf-limits.md) - the other leftover of the importer streaming work +- [Media fuzz](/quest/m2/media-fuzz.md) - would catch a dropped-input bug like the refused-box one diff --git a/quest/m1/security-audit/mkv-leaf-limits.md b/quest/m1/security-audit/mkv-leaf-limits.md index 351e635d820..d1ce43b031e 100644 --- a/quest/m1/security-audit/mkv-leaf-limits.md +++ b/quest/m1/security-audit/mkv-leaf-limits.md @@ -11,16 +11,20 @@ declaring a huge one cannot pin importer memory. Decided 2026-10-31 (maintainer, the /quest-complete requeue session), a follow-up of [moq-dev/moq#7234](https://github.com/moq-dev/moq/pull/7234), which streams blocks and discards ignored elements but still reads these -three leaf elements whole. Starts after #7234 lands; it is a queued PR that -finishes and deletes the `mkv-stream-blocks` quest, so it is named here -rather than linked under Required. +three leaf elements whole (`rs/moq-mux/src/container/mkv/import.rs`, where +the track entry collects `CodecID` and `CodecPrivate`). #7234 has landed. The maintainer earlier ruled out a blanket tag-size cap (it would refuse large Segments and Clusters). These limits are per element and bound only what the importer must hold whole: a `CodecID` and `DocType` -are short ASCII strings, and `CodecPrivate` is a decoder config (avcC, hvcC, -an Opus or Vorbis header). Pick each limit from its spec and the largest -real decoder config, check them against the MKV fixtures, and return the +are short ASCII strings, and `CodecPrivate` is the decoder config of a +codec the importer supports: avcC (`V_MPEG4/ISO/AVC`), hvcC +(`V_MPEGH/ISO/HEVC`), av1C (`V_AV1`), an OpusHead (`A_OPUS`), an AAC +AudioSpecificConfig (`A_AAC`), or a FLAC header (`A_FLAC`). The FLAC header +carries every metadata block, so it can hold embedded cover art; size its +limit for that or refuse such art explicitly. Pick each limit from its spec +and the largest real decoder config, check them against the MKV fixtures +for each codec, and return the importer's existing error for a refused element. Test each element declared past its limit, fed in small chunks. @@ -28,4 +32,4 @@ Public API: none. Wire: none. ## Related -- [fMP4 import streams samples through open and commit](/quest/m1/security-audit/fmp4-open-commit.md) - the fMP4 leftover of the same streaming work +- [fMP4 refusals keep framing](/quest/m1/security-audit/fmp4-refusal-framing.md) - the fMP4 leftover of the same streaming work diff --git a/quest/m2/audit-lints.md b/quest/m2/audit-lints.md index fcf5c5abfa4..881e58c306a 100644 --- a/quest/m2/audit-lints.md +++ b/quest/m2/audit-lints.md @@ -84,8 +84,8 @@ Python wrapper. This run only reviews what those gates can't see. allowances (`expect(clippy::disallowed_methods)`) would also silence an environment write, and a specific `reason` does not narrow what an expectation silences. Move crate- and module-wide test expectations (such - as `rs/moq-mux/src/lib.rs`'s `cfg_attr(test, expect(...))`) onto the items - that read the clock, and drop the text check only once none remain, so the + as the one on `rs/moq-ffi/src/lib.rs`'s test-only `mod bench`) onto the + items that read the clock, and drop the text check only once none remain, so the clippy entry still catches a write in a test. ### Results (m1, 2026-10-24) diff --git a/quest/m2/auth-drop-iroh.md b/quest/m2/auth-drop-iroh.md index 81b14545ebe..9de43fbdf5c 100644 --- a/quest/m2/auth-drop-iroh.md +++ b/quest/m2/auth-drop-iroh.md @@ -13,11 +13,14 @@ follow-up of [moq-dev/moq#7345](https://github.com/moq-dev/moq/pull/7345). That PR kept both because the enum is the relay-to-auth-server JSON contract and its quest said "Wire: none"; the relay just never sends `iroh` now. -Land it with the first moq-auth release that already breaks for another -reason, rather than cutting a breaking release for this alone. An auth -server built against the old contract is unaffected, since an unknown name -deserializes to `Unknown`. Update the auth contract docs and any test or -fixture naming `iroh`. +Starts after #7345 lands; check with `gh pr view 7345`. Land it with the +first moq-auth release that already breaks for another reason, rather than +cutting a breaking release for this alone. The relay sends the transport +name and the auth server reads it. An old auth server is unaffected, since +a new relay never sends `iroh`. A new auth server still accepts `iroh` from +an older relay: an unrecognized name deserializes to `Unknown` +(`#[serde(other)]` in Rust, `z.catch` in JS). Update the auth contract docs +and any test or fixture naming `iroh`. Public API: breaking in moq-auth and `@moq/auth` (one enum variant). Wire: the auth JSON contract loses the `iroh` transport value. diff --git a/quest/m2/c-origin-relay.md b/quest/m2/c-origin-relay.md index a7090183812..1fbf9e18586 100644 --- a/quest/m2/c-origin-relay.md +++ b/quest/m2/c-origin-relay.md @@ -26,7 +26,8 @@ before this starts, add it to moq-ffi instead so every binding gets it. Test a C origin forwarding a client session's routes with no announce watcher. -Public API: additive in moq-c. Wire: none. +Public API: additive in moq-c, or in moq-ffi if the generated C line has +replaced it. Wire: none. ## Related diff --git a/quest/m2/format-gate-followups.md b/quest/m2/format-gate-followups.md index b3aeeda45ea..41cddd6a133 100644 --- a/quest/m2/format-gate-followups.md +++ b/quest/m2/format-gate-followups.md @@ -10,19 +10,18 @@ aarch64-linux too, once nixpkgs builds `swiftc` there. Decided 2026-10-31 (maintainer, the /quest-complete requeue session), the follow-ups of [moq-dev/moq#7319](https://github.com/moq-dev/moq/pull/7319) -(format gates). +(format gates), which has landed. - **Ruff.** #7319 makes the repo-wide `python` check module run the dev shell's Ruff and keeps `ruff` in the uv dev group (`pyproject.toml:61`) only for editors, so two Ruff versions are pinned. Drop it from the dev group and `uv.lock`, and point editor setup at the dev shell's Ruff. - **Swift on aarch64-linux.** #7319 adds `swift-format` to the dev shell - only off aarch64-linux, because nixpkgs marks its `swiftc` broken there, - so release-PR Check (`ubuntu-24.04-arm`) skips Swift formatting. When + only off aarch64-linux (`flake.nix`, around line 306), because nixpkgs + marks its `swiftc` broken there, so `sh/swift/format.sh` skips and + release-PR Check (`ubuntu-24.04-arm`) checks no Swift formatting. When nixpkgs builds it, add `swift-format` there and drop the skip. Until then this half waits; check nixpkgs' `swift` package `meta.broken` for aarch64-linux. -Starts after #7319 lands. - Public API: none. Wire: none. diff --git a/quest/m2/media-fuzz.md b/quest/m2/media-fuzz.md index 716b3422e66..64248d4af3c 100644 --- a/quest/m2/media-fuzz.md +++ b/quest/m2/media-fuzz.md @@ -27,9 +27,12 @@ replay committed regressions in the merge gate. Measure parse amplification too (decided 2026-10-31, maintainer, from [moq-dev/moq#7232](https://github.com/moq-dev/moq/pull/7232)). That PR bounds a held `moov` or `moof` at 32 MiB (`fmp4::MAX_HELD_BYTES`) and a `moof` at -2^21 samples, but a body at the bound decodes into roughly 2.5x larger -structures: a `trun` entry costs 4 to 16 input bytes and about 40 parsed. -Record the peak allocation for a maximal `moov` and `moof`, and fix it or -accept it with the number. +2^21 samples (`fmp4::MAX_FRAGMENT_SAMPLES`), but a body at the bound +decodes into larger structures: an explicit `trun` entry costs 4 to 16 +input bytes and about 40 parsed, so 2.5x to 10x. A `trun` without +per-sample fields parses to no entries, but planning still resolves every +sample it declares, up to the 2^21 bound. Record the peak allocation for a +maximal `moov`, a maximal `moof` of 4-byte entries, and a field-less `moof` +at the sample bound, and fix each or accept it with the number. Public API: none. Wire: none. diff --git a/quest/m2/net-test-subscriber.md b/quest/m2/net-test-subscriber.md index d8bf2d2c33f..cb99ac19a5f 100644 --- a/quest/m2/net-test-subscriber.md +++ b/quest/m2/net-test-subscriber.md @@ -13,7 +13,7 @@ its events. Decided 2026-10-31 (maintainer, the /quest-complete requeue session). Nextest runs each test in its own process, which hides the clash. -`credentials_stay_out_of_traces` (`rs/moq-net/src/setup.rs:311`) uses +`credentials_stay_out_of_traces` (`rs/moq-net/src/setup.rs:306`) uses `#[tracing_test::traced_test]`, and `count_drop_warnings` (`rs/moq-net/src/model/test_tracing.rs:39`) calls `tracing::subscriber::set_global_default` and expects no other global @@ -28,4 +28,4 @@ Public API: none. Wire: none. ## Related -- [moq-clock's tests pass under cargo test](/quest/m1/clock-test-process.md) - the same nextest-only pass in moq-clock +- [moq-dev/moq#7243](https://github.com/moq-dev/moq/pull/7243) - fixed the same nextest-only pass in moq-clock (now `kio::clock`) by isolating its process state diff --git a/quest/m2/net-wrap/e2ee.md b/quest/m2/net-wrap/e2ee.md index 43ec9ac2792..1e9b0458dbc 100644 --- a/quest/m2/net-wrap/e2ee.md +++ b/quest/m2/net-wrap/e2ee.md @@ -65,8 +65,14 @@ the reverse (decided 2026-10-20, maintainer): varints) also counts the optional lite datagram fields: the relayed fields the lite `ietf` extension adds, and the Inflated Size a compressed track's datagram carries. Without them a maximum-size protected datagram can - encode past the 1200-byte body and be dropped. Update the e2ee draft's - plaintext bound and the `moq-e2ee-00` vectors with it. + encode past the 1200-byte body and be dropped. Sealing and opening share + `MAX_DATAGRAM_PAYLOAD` today (`rs/moq-e2ee/src/track.rs`, + `js/e2ee/src/track.ts`), so a wider allowance would also make `open` + refuse a datagram an older sender sealed under the narrower one. Split + the seal and open limits, or pick the limit by wire version, so a + receiver still opens anything that fits the body. Update the e2ee + draft's plaintext bound and the `moq-e2ee-00` vectors with it, covering + both limits. - Ranges: every moq-net range starts at a group's first frame ([moq-dev/moq#6465](https://github.com/moq-dev/moq/pull/6465)), so the wrapper reads each physical group whole and inflates from frame 0. diff --git a/quest/m2/relay-undialable-peers.md b/quest/m2/relay-undialable-peers.md index dfb31dc155e..2b89bd63295 100644 --- a/quest/m2/relay-undialable-peers.md +++ b/quest/m2/relay-undialable-peers.md @@ -17,10 +17,17 @@ found the gap; the behavior predates that PR and covers every unsupported scheme. `rs/moq-tokio/src/client.rs` (`connect_inner`) picks a transport by scheme -under feature gates (`tcp`, `tls`, `unix`, `ws`/`wss`, QUIC for the rest), -so which schemes dial depends on the build's features. Expose that set from -moq-tokio (a function or method beside `Client`, derived from the same -`cfg`s so it cannot drift), and check every peer in `Config::connect` +under feature gates (`tcp`, `tls`, `unix`, `ws`/`wss`), and every other +scheme falls through to QUIC when it is compiled (raced with WebSocket when +that is too) or to WebSocket alone. Those reject what they can't carry +only at dial time: QUIC takes `http`, `https`, `moqt` and `moql` +(`rs/moq-tokio/src/quic/backend.rs`), WebSocket `http`, `https`, `ws` and +`wss` (`rs/moq-tokio/src/websocket.rs`), so a peer like `ftp://` fails each +attempt and is retried. So which schemes dial depends on the build's +features and on that fallthrough. Expose a dialability check from moq-tokio +(a function or method beside `Client`, derived from the same dispatch and +`cfg`s so it cannot drift and never rejects a scheme that dials today), and +check every peer in `Config::connect` (`rs/moq-relay/src/cluster.rs`) against it at startup. A peer returned later by an `api.url` endpoint can't fail startup; decide in the PR what it does (recommended: log once and skip it rather than retry). Test a config naming From f5eccf5e05161a00b1de0600f23bc0c5cdbd3e8e Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sun, 1 Nov 2026 12:15:39 -0800 Subject: [PATCH 5/6] quest: settle refusal framing goal and e2ee inflated-size header fmp4-refusal-framing's Goal now admits both planned options: read past the refused box, or make the refusal terminal. e2ee separates moq-net's lite Inflated Size header field from the wrapper's authenticated inflated size. Co-Authored-By: Claude Opus 5.5 --- quest/m1/security-audit/fmp4-refusal-framing.md | 12 +++++++----- quest/m2/net-wrap/e2ee.md | 13 ++++++++++--- 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/quest/m1/security-audit/fmp4-refusal-framing.md b/quest/m1/security-audit/fmp4-refusal-framing.md index b65e5efa881..612d3b0b602 100644 --- a/quest/m1/security-audit/fmp4-refusal-framing.md +++ b/quest/m1/security-audit/fmp4-refusal-framing.md @@ -2,11 +2,13 @@ ## Goal -A box the fMP4 importer refuses at its header no longer drops the rest of -the input handed to that decode call, so a caller feeding arbitrary chunks -keeps framing as a box-aligned caller does. The 4-track interleaved import -benchmark is no slower than before the streaming change, or the cost is -measured and accepted. +A box the fMP4 importer refuses at its header no longer leaves a caller +feeding arbitrary chunks out of frame. Either the importer reads the rest of +that decode call's input past the refused box, so the caller keeps framing +as a box-aligned caller does, or the refusal is terminal and every later +call fails, so no input is silently dropped mid-stream. The 4-track +interleaved import benchmark is no slower than before the streaming change, +or the cost is measured and accepted. ## Plan diff --git a/quest/m2/net-wrap/e2ee.md b/quest/m2/net-wrap/e2ee.md index 1e9b0458dbc..5d5dd6b9510 100644 --- a/quest/m2/net-wrap/e2ee.md +++ b/quest/m2/net-wrap/e2ee.md @@ -63,9 +63,16 @@ the reverse (decided 2026-10-20, maintainer): `MAX_DATAGRAM_HEADER` (`rs/moq-e2ee/src/limits.rs`, `js/e2ee/src/limits.ts`; 28 after #7435, lite-07's Type plus three 9-byte varints) also counts the optional lite datagram fields: the relayed fields - the lite `ietf` extension adds, and the Inflated Size a compressed track's - datagram carries. Without them a maximum-size protected datagram can - encode past the 1200-byte body and be dropped. Sealing and opening share + the lite `ietf` extension adds, and moq-net's Inflated Size header field, + which a compressed physical track's datagram carries outside the AEAD + (`rs/moq-net/src/lite/datagram.rs`). Without them a maximum-size protected + datagram can encode past the 1200-byte body and be dropped. That header + field is not the wrapper's own inflated size above, which sits inside the + authenticated payload and counts against the plaintext budget instead. + Today a caller's `track::Info` reaches the physical track unchanged, so it + can be compressed. Once the wrapper creates the physical track + uncompressed, the header field never appears and the allowance needs only + the `ietf` fields. Sealing and opening share `MAX_DATAGRAM_PAYLOAD` today (`rs/moq-e2ee/src/track.rs`, `js/e2ee/src/track.ts`), so a wider allowance would also make `open` refuse a datagram an older sender sealed under the narrower one. Split From df6c9f29aea296a860d317eb78f3014e8a1e03cf Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sun, 1 Nov 2026 20:37:18 -0800 Subject: [PATCH 6/6] quest: bound e2ee relay properties, clarify fMP4 refusal wording - e2ee: the ietf properties block is variable (up to 64 KiB), so no fixed allowance covers it; choose between a forwarding cap or documenting the drop, and add a vector with non-empty relay properties. - fmp4-refusal-framing: state the framing guarantee directly and fix the refusal-choice sentence. - kotlin-js-flakes: SmokeTest.kt moved to :579 after #6946. Co-Authored-By: Claude Opus 5.5 --- quest/m0/test-flakes-2/kotlin-js-flakes.md | 2 +- quest/m1/security-audit/fmp4-refusal-framing.md | 11 ++++++----- quest/m2/net-wrap/e2ee.md | 14 ++++++++++++-- 3 files changed, 19 insertions(+), 8 deletions(-) diff --git a/quest/m0/test-flakes-2/kotlin-js-flakes.md b/quest/m0/test-flakes-2/kotlin-js-flakes.md index fcdaa60be21..67a43838498 100644 --- a/quest/m0/test-flakes-2/kotlin-js-flakes.md +++ b/quest/m0/test-flakes-2/kotlin-js-flakes.md @@ -13,7 +13,7 @@ Decided 2026-10-31 (maintainer, the /quest-complete requeue session): root-cause both in one quest, since each is small and they surfaced together in that session's merge runs. -- **Kotlin.** `kt/moq/src/jvmAndAndroidTest/kotlin/dev/moq/SmokeTest.kt:518`. +- **Kotlin.** `kt/moq/src/jvmAndAndroidTest/kotlin/dev/moq/SmokeTest.kt:579`. An `unroutable` answer means no route served the path when the request resolved. A request made before the publisher's route reached the origin returns it, and so does one made after that route was withdrawn or the diff --git a/quest/m1/security-audit/fmp4-refusal-framing.md b/quest/m1/security-audit/fmp4-refusal-framing.md index 612d3b0b602..9e1956bb1fe 100644 --- a/quest/m1/security-audit/fmp4-refusal-framing.md +++ b/quest/m1/security-audit/fmp4-refusal-framing.md @@ -4,9 +4,10 @@ A box the fMP4 importer refuses at its header no longer leaves a caller feeding arbitrary chunks out of frame. Either the importer reads the rest of -that decode call's input past the refused box, so the caller keeps framing -as a box-aligned caller does, or the refusal is terminal and every later -call fails, so no input is silently dropped mid-stream. The 4-track +that decode call's input past the refused box, so later calls stay +correctly framed whatever chunk boundaries the caller picks, or the refusal +is terminal and every later call fails, so no input is silently dropped +mid-stream. The 4-track interleaved import benchmark is no slower than before the streaming change, or the cost is measured and accepted. @@ -26,8 +27,8 @@ original open/commit bullet is done, and this quest keeps the other two callers (HLS ingest feeds one segment per call) but loses framing for arbitrary chunking. Either continue past the refused box, or make a refusal terminal for the importer as the MKV importer's is. Choose during - implementation, by which keeps the importer's state simpler and what HLS - ingest needs, and record the choice in the PR. + implementation the option that keeps the importer's state simpler while + meeting HLS ingest's needs, and record the choice in the PR. - **Benchmark.** #7232 measured a possible ~25% slowdown in the 4-track 16-run whole-input `cmaf-interleaved-import` case, in a noisy run where the 4-track cases swung ±40% between runs of one source. Re-measure it with the diff --git a/quest/m2/net-wrap/e2ee.md b/quest/m2/net-wrap/e2ee.md index 5d5dd6b9510..cbc3814c939 100644 --- a/quest/m2/net-wrap/e2ee.md +++ b/quest/m2/net-wrap/e2ee.md @@ -72,14 +72,24 @@ the reverse (decided 2026-10-20, maintainer): Today a caller's `track::Info` reaches the physical track unchanged, so it can be compressed. Once the wrapper creates the physical track uncompressed, the header field never appears and the allowance needs only - the `ietf` fields. Sealing and opening share + the `ietf` fields. Of those, the relay state, object ID, priority, and + status have a fixed worst case, but `encode_datagram` + (`rs/moq-net/src/lite/ietf.rs`) also writes the forwarded properties + block, which may run to `MAX_OBJECT_EXTENSIONS` (64 KiB, + `rs/moq-net/src/ietf/group.rs`), so no fixed allowance covers it, and the + lite publisher drops a datagram whose body exceeds 1200 bytes + (`rs/moq-net/src/lite/publisher.rs`). Choose during implementation between + capping the properties a hop forwards on a protected datagram (and + counting that cap) or documenting that relay properties are outside the + allowance, so such a datagram may be dropped, and record the choice in the + PR. Sealing and opening share `MAX_DATAGRAM_PAYLOAD` today (`rs/moq-e2ee/src/track.rs`, `js/e2ee/src/track.ts`), so a wider allowance would also make `open` refuse a datagram an older sender sealed under the narrower one. Split the seal and open limits, or pick the limit by wire version, so a receiver still opens anything that fits the body. Update the e2ee draft's plaintext bound and the `moq-e2ee-00` vectors with it, covering - both limits. + both limits and a datagram with non-empty relay properties. - Ranges: every moq-net range starts at a group's first frame ([moq-dev/moq#6465](https://github.com/moq-dev/moq/pull/6465)), so the wrapper reads each physical group whole and inflates from frame 0.