From d5e427b4484332637d23f5e9415d7b63351da3c4 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 31 Oct 2026 17:18:38 -0700 Subject: [PATCH] ci: keep the land gate's CHECK_FAIL_FAST out of dispatcher tests moq's host land gate exports CHECK_FAIL_FAST=1 since #7466. The dispatcher tests run dispatch.sh in subprocesses that inherited it, so four tests expecting every lane to finish failed under the gate, failing every batch. The harness clears it with the other gate variables. Co-Authored-By: Claude Opus 5.5 --- sh/dispatch-query.test.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sh/dispatch-query.test.py b/sh/dispatch-query.test.py index ea28b99998c..4eb456ba7c6 100644 --- a/sh/dispatch-query.test.py +++ b/sh/dispatch-query.test.py @@ -31,10 +31,11 @@ def setUp(self): self.env = dict(os.environ, LOCAL_SUPERVISED="1", PATH=str(self.bin), GIT_CONFIG_NOSYSTEM="1", GIT_CONFIG_GLOBAL=os.devnull, CI_STRICT="1") # The runner's own Actions variables would move the run's error - # annotations to stdout and append to the real job summary, and a - # gate's CHECK_MODULES split would skip the modules these tests expect. + # annotations to stdout and append to the real job summary, a gate's + # CHECK_MODULES split would skip the modules these tests expect, and the + # land gate's CHECK_FAIL_FAST would cancel the lanes they expect to finish. for key in ("IN_MOQ_DEV_SHELL", "ALLOW_HOST_TOOLCHAIN", "CHECK_JOBS", "CHECK_MODULES", - "GITHUB_BASE_REF", "GITHUB_ACTIONS", "GITHUB_STEP_SUMMARY"): + "CHECK_FAIL_FAST", "GITHUB_BASE_REF", "GITHUB_ACTIONS", "GITHUB_STEP_SUMMARY"): self.env.pop(key, None) self.git("init", "-q", "-b", "main") self.git("config", "user.name", "test")