diff --git a/quest/m2/perf/README.md b/quest/m2/perf/README.md index 5465ca33590..35f1970a844 100644 --- a/quest/m2/perf/README.md +++ b/quest/m2/perf/README.md @@ -97,7 +97,6 @@ revisions on the same host and worker count, and profiles with - [An idle export poll is cheap](/quest/m2/perf/export-idle-poll.md) - an export poll nothing woke skips the track fill and catalog work it repeats today - [Mesh session cost](/quest/m2/perf/mesh-session-cost.md) - moq-net's per-session announce, route sync, and scope work drops, swept over sessions and announces - [Cluster route memory](/quest/m2/perf/cluster-route-memory.md) - a full-mesh cluster's ~3.7 KB per route per broadcast shrinks, the in-memory hop is profiled, and `bench-profile lock` tolerates lost records -- [Adapter reads reuse their waker](/quest/m2/perf/adapter-waker-alloc.md) - a measured verdict on the per-read waker allocation moq-tokio and moq-uring reads pay since #7042, fixed if real - [Lite request allocations](/quest/m2/perf/lite-request-allocs.md) - `Path::concat` allocates once and the lite request handler keeps one track-name copy - [Coverage before START](/quest/m2/perf/covered-before-start.md) - the lite-07 publisher's coverage check costs O(1) per wake before SUBSCRIBE_START - [Lock-free single-delivery writes](/quest/m2/perf/single-delivery-write.md) - a frame with one delivery writes without a lock, recovering #6922's remaining FETCH cost diff --git a/quest/m2/perf/adapter-waker-alloc.md b/quest/m2/perf/adapter-waker-alloc.md deleted file mode 100644 index e8a3ffce37f..00000000000 --- a/quest/m2/perf/adapter-waker-alloc.md +++ /dev/null @@ -1,36 +0,0 @@ -# [S] Adapter reads reuse their waker - -## Goal - -A measured verdict on what a parking read costs in the production adapters -(moq-tokio, moq-uring) since -[moq-dev/moq#7042](https://github.com/moq-dev/moq/pull/7042), and a fix if -the cost is real: a stream read that has to wait stops allocating a fresh -shared waker each time. - -## Plan - -Decided 2026-11-01 (maintainer, `/quest-plan`): measure before fixing, since -no bench has shown the cost yet. - -Since #7042, transport polls take a `kio::Waiter` through `&self`, and every -`kio::wait` future (`rs/kio/src/waiter.rs`) holds a waiter of its own. The -moq-net coding layer (`rs/moq-net/src/coding/reader.rs`, `writer.rs`) wraps -each decode or flush in one, so a read that parks allocates the waiter's -shared `Arc` every time, where a per-stream `kio::Park` used to reuse -one. - -[moq-dev/moq#7262](https://github.com/moq-dev/moq/pull/7262) fixed the -in-memory transport's version (it registered on the session close per read). -The memory-transport benches rarely park, so they cannot see the adapters' -cost. - -Measure first: user-space instruction counts and allocations, pinned to one -core, on moq-uring's `session_lite` bench (`just rs bench-session`) and, for -moq-tokio, which has no crate-level session bench, the relay's -`rs/moq-relay/benches/session.rs` or `just bench BASE`. Measure a revision -before #7042 next to main. A measured no-win deletes this quest. - -If it is real, let a stream keep one waiter (or `kio::Park`) across reads -again, for example in `coding::Reader`, instead of one per `kio::wait` -future.