From fc4cb08fed2293a574ca19404484c17be053cec4 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sun, 1 Nov 2026 17:57:52 -0800 Subject: [PATCH 1/4] chore(quest): claim quest/m0/backport-release-hardening.md Quest-Claim: 408cc0080a420dcb From 3d3eccfc54786e33497fa08ca7865e31da353b07 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sun, 1 Nov 2026 18:13:19 -0800 Subject: [PATCH 2/4] docs(quest): checkpoint release hardening backport Co-Authored-By: GPT-6.1 Sol --- quest/m0/backport-release-hardening.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/quest/m0/backport-release-hardening.md b/quest/m0/backport-release-hardening.md index 1da9042ee4b..c11e8d28e58 100644 --- a/quest/m0/backport-release-hardening.md +++ b/quest/m0/backport-release-hardening.md @@ -6,14 +6,14 @@ The `release` branch's relay refuses connection paths with `.` or `..` segments ## Plan -Decided 2026-10-30 (maintainer, follow-up planning after the /quest-afk run). +Decided 2026-10-30 (maintainer, follow-up planning after the /quest-afk run): combine these backports into one later patch release, with versions chosen by a human. -- **Dot segments:** [moq-dev/moq#7366](https://github.com/moq-dev/moq/pull/7366) makes `Auth::admit` in `rs/moq-relay/src/auth.rs` refuse any path segment that is `.` or `..`, percent-encoded or not. Before it, a raw-QUIC SETUP path like `/tenant-a/../tenant-b?jwt=b` reached the auth server unresolved. Port it once #7366 merges. -- **Auth redirects:** on `release`, `rs/moq-auth/src/client.rs:35` builds the client without a redirect policy, so reqwest follows up to 10 redirects and re-sends the credential's JSON body on a 307/308. Main refuses since [moq-dev/moq#6384](https://github.com/moq-dev/moq/pull/6384) (`redirect::Policy::none()`, plus an error naming the redirect). Found by the agent on [moq-dev/moq#7298](https://github.com/moq-dev/moq/pull/7298), which fixes the cluster client but not this one. -- Hand-port rather than cherry-pick where `release` lacks main's structure, as [moq-dev/moq#7389](https://github.com/moq-dev/moq/pull/7389) did, with a regression test for each on `release`. -- Version bumps stay with a human: several backports combine into one patch release, so this PR bumps nothing. +- The main prerequisite [moq-dev/moq#7366](https://github.com/moq-dev/moq/pull/7366) merged on 2026-11-01. The hand-port of its dot-segment refusal and [moq-dev/moq#6384](https://github.com/moq-dev/moq/pull/6384)'s auth-client redirect refusal is [moq-dev/moq#7599](https://github.com/moq-dev/moq/pull/7599), targeting `release`. +- That backport remains draft: full local CI and the io_uring compile cannot launch Cargo because of the existing mbx `E2BIG` defect tracked in [moq-dev/moq#7594](https://github.com/moq-dev/moq/pull/7594). Resume those checks after the infrastructure fix. The selected Rust package checks, all 588 selected tests, API compatibility checks, and other-vendor security review pass; the code PR records the evidence. +- Once validated and approved, land the code PR on `release` and include it in the planned combined patch release. No versions, tags, publication, deployment, or merges were authorized for this implementation task. +- Keep this main checkpoint draft until that patch publishes, then delete the quest and its milestone link, following [moq-dev/moq#7381](https://github.com/moq-dev/moq/pull/7381). The earlier [moq-dev/moq#7389](https://github.com/moq-dev/moq/pull/7389) backport is already merged and remains a separate scope. -Public API: none. Wire: none. +Public API: none. Wire format: none; the backport changes admission and auth HTTP refusal behavior. ## Related From 426a4747f361a93d4585d5de11beaac77a085331 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Wed, 4 Nov 2026 14:49:24 -0800 Subject: [PATCH 3/4] quest: record one release PR per port for the hardening backport Co-Authored-By: Claude Opus 5.5 --- quest/m0/backport-release-hardening.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/quest/m0/backport-release-hardening.md b/quest/m0/backport-release-hardening.md index d33b9807311..cd60e26a7fe 100644 --- a/quest/m0/backport-release-hardening.md +++ b/quest/m0/backport-release-hardening.md @@ -13,6 +13,8 @@ Added 2026-10-31 (user, /quest-plan of the follow-ups from the 2026-10-31 /quest - **Relay HTTP hardening:** port [moq-dev/moq#7210](https://github.com/moq-dev/moq/pull/7210) (merged): `/fetch` serves bytes as `application/octet-stream`, `/fetch` and `/announced` send `nosniff` and `private, no-store` (refusals included), and the ops listener refuses any request with `Origin` and any `Host` or URI authority that isn't the accepted socket's destination. `release` has its own `rs/moq-relay/src/fetch.rs` and `internal.rs`; port the behavior and #7210's tests, not its layout. - **Withdraw without credit:** port [moq-dev/moq#7414](https://github.com/moq-dev/moq/pull/7414) (merged), keeping `release`'s published API: a withdrawn PUBLISH_NAMESPACE or REQUEST_UPDATE that a peer starves of send credit is reset in both directions instead of pinning the announce loop. Port its zero- and partial-credit withdrawal tests for the drafts `release` speaks. +Decided 2026-11-04 (maintainer, /quest-unblock): one quest, one `release` PR per port, as [moq-dev/moq#7599](https://github.com/moq-dev/moq/pull/7599) did, with [moq-dev/moq#7596](https://github.com/moq-dev/moq/pull/7596) kept as the main-side checkpoint; not splitting the ports into two quests. The maintainer cuts the combined patch release once both land. + Shipped: the dot-segment and auth-redirect refusals landed on `release` in [moq-dev/moq#7599](https://github.com/moq-dev/moq/pull/7599) (2026-11-02) and published in `moq-auth` 0.2.3 and `moq-relay` 0.17.11 (2026-11-03). That also settles the redirect follow-up [moq-dev/moq#7298](https://github.com/moq-dev/moq/pull/7298) and [moq-dev/moq#7278](https://github.com/moq-dev/moq/pull/7278) suggested. [moq-dev/moq#7596](https://github.com/moq-dev/moq/pull/7596) holds this quest's claim. Public API: none. Wire: none; as on main, a withdrawal resets a partially written request without waiting for peer credit. From 563b8047b99cbddc587a2f767975b97dd985f814 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Wed, 4 Nov 2026 15:34:46 -0800 Subject: [PATCH 4/4] quest: link the two release ports and the maintainer's merge and cut Co-Authored-By: Claude Opus 5.5 --- quest/m0/backport-release-hardening.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/quest/m0/backport-release-hardening.md b/quest/m0/backport-release-hardening.md index cd60e26a7fe..100e104683c 100644 --- a/quest/m0/backport-release-hardening.md +++ b/quest/m0/backport-release-hardening.md @@ -15,10 +15,16 @@ Added 2026-10-31 (user, /quest-plan of the follow-ups from the 2026-10-31 /quest Decided 2026-11-04 (maintainer, /quest-unblock): one quest, one `release` PR per port, as [moq-dev/moq#7599](https://github.com/moq-dev/moq/pull/7599) did, with [moq-dev/moq#7596](https://github.com/moq-dev/moq/pull/7596) kept as the main-side checkpoint; not splitting the ports into two quests. The maintainer cuts the combined patch release once both land. +Open ports, both ready for review with local checks and a cross-vendor review: [moq-dev/moq#7920](https://github.com/moq-dev/moq/pull/7920) (relay HTTP hardening) and [moq-dev/moq#7922](https://github.com/moq-dev/moq/pull/7922) (withdrawal without send credit). + Shipped: the dot-segment and auth-redirect refusals landed on `release` in [moq-dev/moq#7599](https://github.com/moq-dev/moq/pull/7599) (2026-11-02) and published in `moq-auth` 0.2.3 and `moq-relay` 0.17.11 (2026-11-03). That also settles the redirect follow-up [moq-dev/moq#7298](https://github.com/moq-dev/moq/pull/7298) and [moq-dev/moq#7278](https://github.com/moq-dev/moq/pull/7278) suggested. [moq-dev/moq#7596](https://github.com/moq-dev/moq/pull/7596) holds this quest's claim. Public API: none. Wire: none; as on main, a withdrawal resets a partially written request without waiting for peer credit. +## Waiting + +- Maintainer: review and merge [moq-dev/moq#7920](https://github.com/moq-dev/moq/pull/7920) and [moq-dev/moq#7922](https://github.com/moq-dev/moq/pull/7922) into `release`, then cut the combined patch release and choose its versions. Agents never merge into `release`, bump versions, tag, or publish (version bumps stay with a human by the 2026-10-30 decision). Check: the `moq-relay` and `moq-net` versions next published from `release` include both ports; then delete this quest and its milestone link. + ## Related - [Backport the SETUP-path and iroh-key fixes](/quest/m0/backport-security-fixes.md) - the earlier backport, which shipped alongside the dot-segment and redirect refusals