From 02b58159c331cd9e1865e85a8cd4045204435aa8 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sun, 1 Nov 2026 19:56:29 -0800 Subject: [PATCH 1/2] chore(quest): claim quest/m1/security-audit/README.md Quest-Claim: 2b504d08ed93da91 From 5ed7461118a71176a0757fadbf2fd9a4c2b76129 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sun, 1 Nov 2026 19:58:40 -0800 Subject: [PATCH 2/2] chore(quest): complete the recorded pre-cut security audit Verify the landed child fixes and preserve external owners and dropped findings in the historical triage record. Co-Authored-By: GPT-6.1 Sol --- quest/m0/security-audit/README.md | 6 ++-- quest/m1/README.md | 1 - quest/m1/security-audit/README.md | 54 ------------------------------- 3 files changed, 3 insertions(+), 58 deletions(-) delete mode 100644 quest/m1/security-audit/README.md diff --git a/quest/m0/security-audit/README.md b/quest/m0/security-audit/README.md index e1cfb56a07f..3bf3c7ec74e 100644 --- a/quest/m0/security-audit/README.md +++ b/quest/m0/security-audit/README.md @@ -12,9 +12,9 @@ backports to `release`. An external AI audit at [651c30fee9](https://github.com/moq-dev/moq/commit/651c30fee9) reported 8 Medium and 28 Low findings. Every claim was re-checked against source before -planning; the pre-cut remainder is the -[m1 epic](/quest/m1/security-audit/README.md), whose README records what was -dropped and why. +planning. The completed pre-cut epic's +[triage record](https://github.com/moq-dev/moq/blob/e3bd4b288e01f0c2e7fbe1e6a362d6f3d58057c8/quest/m1/security-audit/README.md) +preserves the maintainer's dropped findings and external owners. Decided 2026-10-27 (maintainer): these two land in m0 because `release` carries the same bugs. Each quest owns its own backport PR rather than a diff --git a/quest/m1/README.md b/quest/m1/README.md index 55660210155..4445f704d73 100644 --- a/quest/m1/README.md +++ b/quest/m1/README.md @@ -135,7 +135,6 @@ per-frame CPU growth since #5926. - [Address groups by timestamp](/quest/m1/time-addressing/README.md) - group start timestamps replace sequence numbers in the moq-net API and lite-07 wire, while old subscribers, old publishers, and published JS clients keep working - [Pre-cut audit findings](/quest/m1/cut-audit/README.md) - fix the crashes, hostile-input costs, and correctness bugs the 2026-10-24 audit of main found - [Vendored code has every upstream fix it needs](/quest/m1/vendor-sync/README.md) - quinn, libv4l-rs, nvidia-video-codec-sdk, rust-media-libs, cros-codecs, and UniFFI generator fixes are ported or planned, once per release cycle -- [Security audit findings](/quest/m1/security-audit/README.md) - fix the verified relay, importer, moq-c, browser, and CI findings of the 2026-10-27 external security audit - [Delete the tests that don't earn their cost](/quest/m1/prune-tests.md) - an off-cycle test cost sweep deletes tests whose cost outweighs their signal and makes the rest cheaper - [Remove the dependencies that don't earn their weight](/quest/m1/prune-deps.md) - Rust, JS, and vendored dependencies that are trivial, duplicated, or serve features not worth keeping are removed - [Remove what dominates build time](/quest/m1/prune-build-time.md) - the crates, features, and code that cost the most build time are removed or made cheaper diff --git a/quest/m1/security-audit/README.md b/quest/m1/security-audit/README.md deleted file mode 100644 index bdbc2c75a2e..00000000000 --- a/quest/m1/security-audit/README.md +++ /dev/null @@ -1,54 +0,0 @@ -# [M] 2026-10-27 security audit: pre-cut findings - -## Goal - -Fix the 2026-10-27 external security audit's verified findings that are not -urgent for `release`, before main is promoted: relay and wire boundaries, -importer memory, moq-c handle exhaustion, browser input checks, and CI -supply-chain pins. - -## Plan - -An external AI audit at -[651c30fee9](https://github.com/moq-dev/moq/commit/651c30fee9) reported 8 -Medium and 28 Low findings from source review (no fuzzing or live attack). -Every claim was re-checked against -[8d2fa6653a](https://github.com/moq-dev/moq/commit/8d2fa6653a) before -planning; several were wrong or proposed fixes this repository forbids. - -Placed elsewhere (decided 2026-10-27, maintainer): - -- Credential leaks also in `release`: - [m0 security audit](/quest/m0/security-audit/README.md). -- lite-07 range-list scan (NET-1): owned by - [fill-linear](/quest/m1/subscribe-ranges/fill-linear.md). -- qmux buffering a peer-declared size (NET-3): owned by - [qmux receive lease](/quest/m2/qmux-receive-lease.md). -- Media parser fuzzing: owned by [media fuzz](/quest/m2/media-fuzz.md). -- E2EE cloned-process rule and CryptoKey length: documented in the - E2EE draft and the `moq-e2ee` and `@moq/e2ee` docs. - -Dropped, with reasons: - -- SUP-3 (`||` in release gates): wrong; deliberate, and `just gh ffi - completed` checks each language's own publisher. -- RELAY-9 (Unix socket 0666): documented, sessions still authenticate. -- RELAY-10 (pinned peers ignored by `client_ca`): unreachable from config. -- RELAY-4 (no Origin check): no ambient credentials to ride. -- RELAY-5 (connection, handshake, and auth caps): refusal constants, which - AGENTS.md forbids; handshakes already time out. -- MUX-1 (HLS whole-resource fetch): the origin is operator-chosen, a byte cap - is a refusal constant, and whole segments are buffered on purpose. -- MUX-4 (`file:` playlists read any local file): intended; confining to the - playlist directory breaks ffmpeg layouts. -- JS-1 (demo player per announcement): the demo's purpose. -- AUTH-2 (no required expiry): an opt-in policy by design. -- AUTH-5 (tokens in URL before lite-07): inherent until lite-07 publishes; - its log exposure is fixed by [log secrets](/quest/m0/security-audit/log-secrets.md). -- SUP-5 (libav integrity), SUP-10 (CODEOWNERS, pin lint): no real gain. -- SUP-9 (one GPG key): moving `SIGNING_KEY` into a protected Environment is - a maintainer settings change, not a quest. -- The audit's own fixes for MUX-3 (would break large MKV imports) and E2EE-A - (a random epoch is copied by a fork too) were wrong; the children use - better ones. -