diff --git a/quest/m0/ci/README.md b/quest/m0/ci/README.md index 8c47322eee4..fdd08593905 100644 --- a/quest/m0/ci/README.md +++ b/quest/m0/ci/README.md @@ -165,5 +165,4 @@ The historical samples locate candidates; they are not controlled benchmarks. - [The queue host keeps the queue's disk](/quest/m0/ci/queue-host-disk.md) - agent sessions can't starve the queue runner of disk, and a crashed runner restarts - [The bench comparison builds moq-gst's catalog bench on its base](/quest/m0/ci/bench-base-build.md) - A paired bench comparison that selects `rust/gst/moq-gst/catalog` against `origin/main` builds the base side and reports a comparison, instead of marking it unavailable with "base build failed" - [The workspace-hack refuses trybuild edges and spares non-media builds](/quest/m0/ci/hakari-followups.md) - `hakari.py` refuses trybuild dev-dependency edges, and non-media Linux test builds stop needing libpipewire and libclang -- [Pullfrog reviews finish inside their time limit](/quest/m0/ci/pullfrog-timeout.md) - A Pullfrog review of a large PR finishes instead of failing on the action's run limit - [The flake lane skips hosts that can't map user namespaces](/quest/m0/ci/userns-uid-map.md) - `check flake` skips instead of failing where `/proc/self/uid_map` is unwritable diff --git a/quest/m0/ci/pullfrog-timeout.md b/quest/m0/ci/pullfrog-timeout.md deleted file mode 100644 index 19a1d0537c7..00000000000 --- a/quest/m0/ci/pullfrog-timeout.md +++ /dev/null @@ -1,53 +0,0 @@ -# [XS] Pullfrog reviews finish inside their time limit - -## Goal - -A Pullfrog review of a large PR finishes instead of failing on the -action's run limit: `.github/workflows/pullfrog.yml` sets a `timeout` -and `effort` for the `pullfrog/pullfrog` step that fit the reviews it is -dispatched for, and the choice is recorded in the PR with the run -durations that support it. - -## Plan - -Decided 2026-10-31 (user, /quest-plan of the follow-ups from the 2026-10-31 /quest-complete run). Milestone: ✅ m0 (user: "use recommended for any CI/flakes"). The fix is to raise the timeout or lower the effort. - -Facts from the last 100 runs of the workflow (58 runs, all -`workflow_dispatch` reviews; 55 passed): - -- [41178266611](https://github.com/moq-dev/moq/actions/runs/41178266611) - ("Review #7202"): `agent run timed out after 1h`. The log shows - `effort: high` and `timeout: 1h (default)`. -- [41188250827](https://github.com/moq-dev/moq/actions/runs/41188250827) - ("Review #7234", 56 min): aborted by the action's activity watchdog after - the model sent nothing for 903 s. Not the run limit, but a lower effort - likely shortens those silent turns too. -- [41197083466](https://github.com/moq-dev/moq/actions/runs/41197083466) - ("Review #7211", 23 min): failed installing dependencies - (`@moq/libav@0.1.0 is not published to npm yet, and building it needs - Nix`). Unrelated to the limit; note it in the PR as a follow-up rather - than fixing it here. - -It still recurs after this plan: runs -[41362378749](https://github.com/moq-dev/moq/actions/runs/41362378749) -("Review #7586") and -[41404718134](https://github.com/moq-dev/moq/actions/runs/41404718134) -("Review #7599") both failed with `agent run timed out after 1h` at -`effort: high`. - -The action takes `timeout` ("e.g. 10m, 1h30m. Default: 1h") and `effort` -(`low` to `max`, or a position in [0, 1]) inputs; today neither is set in -`with:` (`pullfrog.yml:34-35`, at be39188000), so the `high` comes from -the repo's Pullfrog settings. The file's header allows -edits only where indicated; `with:` is the place. Recommended: set -`effort: medium` first, since it bounds cost as well as time, and raise -`timeout` only if medium-effort reviews of the largest recent -PRs still approach an hour. Keep the job's own `timeout-minutes` (default -360) above whatever `timeout` is set. - -[moq-dev/moq#7317](https://github.com/moq-dev/moq/pull/7317) (merged, pins -the action) and [moq-dev/moq#7424](https://github.com/moq-dev/moq/pull/7424) -(merged, gates its secrets to main through the `pullfrog` environment) -already reshaped this file; edit on top of them. - -Public API: none. Wire: none.