From 9e727f453c2b46a7ca80db3708b758320336898d Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 3 Nov 2026 21:01:07 -0800 Subject: [PATCH 1/3] chore(quest): claim quest/m0/nightly/miri.md Quest-Claim: ac4f1ff84a56bbbe From e22dd62ae952db83cf28cd1fdbd2f9c0f9dbca9f Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 3 Nov 2026 21:04:26 -0800 Subject: [PATCH 2/3] fix(ci): install Rust sources for Nightly Miri Co-Authored-By: GPT-6.1 Sol --- .github/workflows/nightly.yml | 2 +- quest/m0/nightly/miri.md | 44 ++++++++++++++++++++--------------- 2 files changed, 26 insertions(+), 20 deletions(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index e9f16cc96d1..d3e47336680 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -360,7 +360,7 @@ jobs: # Miri interprets kio's and moq-net's in-memory unsafe; too slow for the merge gate. - recipe: rs miri nightly: true - components: miri + components: miri, rust-src steps: - name: Checkout uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 diff --git a/quest/m0/nightly/miri.md b/quest/m0/nightly/miri.md index c4c5cfc991c..e194544e548 100644 --- a/quest/m0/nightly/miri.md +++ b/quest/m0/nightly/miri.md @@ -19,25 +19,31 @@ since the missing `rust-src` keeps the m0 Nightly red. The scheduled run of 2026-11-03 ([run 41656613559](https://github.com/moq-dev/moq/actions/runs/41656613559/job/125988511062)) still fails the same way. -Act on the first Nightly runs' timings, not ahead of them. Locally (24 -cores) `just rs miri` took 11.5 min wall: strict pass 118 tests in 109 s, -epoch pass 94 in 307 s. - -- No Nightly timing exists yet: the first run with the job - ([run 41483654426](https://github.com/moq-dev/moq/actions/runs/41483654426), - 2026-11-02) failed in 2 minutes before any test, as cargo-miri found no - `rust-src` ("given Rust source directory ... does not exist"). Install it - with the toolchain (`components: miri` in `.github/workflows/nightly.yml` - becomes `miri, rust-src`), then read the timings from the next run. -- `a_group_has_no_frame_cap` (`rs/moq-net/src/model/group.rs:5228` as of - be39188000) took 307 s alone, writing 10,000 one-byte frames. Under `cfg(miri)` - write fewer, still more than any former per-group frame cap, so the test - keeps its meaning. -- `rs/moq-net/src/coding/reader.rs:1232` builds its payload byte by byte - (`(0..SIZE).map(|i| (i % 251) as u8)`); switch to a cheaper fill if - Miri starts running that module. +The setup fix in [moq-dev/moq#7812](https://github.com/moq-dev/moq/pull/7812) +installs `miri, rust-src` together. The scheduled failure above is before +any test, so there is still no scheduled ARM timing evidence. Keep this +quest until a scheduled run containing that fix records the job duration, +strict and epoch pass durations, slowest test, and headroom against both +budgets. Do not dispatch Nightly by hand to obtain it. + +Act on those timings before optimizing. Earlier local measurements on 24 +cores took 11.5 min wall: strict pass 118 tests in 109 s, epoch pass 94 in +307 s. These are desktop measurements, not proof of the 4-core ARM budget. + +- `a_group_has_no_frame_cap` (`rs/moq-net/src/model/group.rs`) took 307 s + alone, writing 10,000 one-byte frames. If scheduled timings warrant a + smaller Miri workload, it must still exceed the former 8192-frame cap. +- `rs/moq-net/src/coding/reader.rs` builds its payload byte by byte + (`(0..SIZE).map(|i| (i % 251) as u8)`); consider a cheaper fill only if + Miri starts running that module and measurements justify it. - If the job nears 60 minutes, split the strict and epoch passes into - separate matrix entries (`.github/workflows/nightly.yml` Tests matrix, - `timeout-minutes: 60` at line 328) rather than raising the timeout. + separate matrix entries rather than raising the timeout. Preserve + nextest's 15-minute per-test cap. Public API: none. Wire: none. + +## Waiting + +- moq-dev/moq: After the setup fix lands, the next scheduled Nightly on + `main` must run `Tests (rs miri)` on `ubuntu-24.04-arm`. Read its log and + record the timings and headroom above; local runs do not clear this wait. From 6ec0b212c20df51bee145559530d0982546a9575 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 3 Nov 2026 21:06:53 -0800 Subject: [PATCH 3/3] fix(ci): include Rust sources in local Miri setup hints Co-Authored-By: GPT-6.1 Sol --- rs/justfile | 2 +- sh/rs/miri.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/rs/justfile b/rs/justfile index a91f3240ca1..9a1f1d6ea92 100644 --- a/rs/justfile +++ b/rs/justfile @@ -337,7 +337,7 @@ play *args: doctest *args: bash sh/local.sh cargo test --locked --doc "$@" -# Needs nightly with the miri component; executes only in Nightly. See sh/rs/miri.sh +# Needs nightly with miri and rust-src; executes only in Nightly. See sh/rs/miri.sh # for what runs and why it splits in two. # Run kio's and moq-net's hand-written in-memory unsafe under Miri. diff --git a/sh/rs/miri.sh b/sh/rs/miri.sh index 32cdbf903bb..ff28157d603 100755 --- a/sh/rs/miri.sh +++ b/sh/rs/miri.sh @@ -22,14 +22,14 @@ if [[ "$(rustc --version)" == *-nightly* ]]; then elif command -v rustup >/dev/null 2>&1; then sysroot=$(rustup run nightly rustc --print sysroot) else - echo "rs: nightly Rust is missing; select it or run rustup toolchain install nightly --component miri" >&2 + echo "rs: nightly Rust is missing; select it or run rustup toolchain install nightly --component miri,rust-src" >&2 exit 1 fi # Nix puts its pinned stable compiler first; cargo and rustc must both be nightly. export PATH="$sysroot/bin:$PATH" if ! cargo miri --version >/dev/null 2>&1; then - echo "rs: Miri is missing: rustup component add --toolchain nightly miri" >&2 + echo "rs: Miri is missing: rustup component add --toolchain nightly miri rust-src" >&2 exit 1 fi rustc --version