diff --git a/quest/m0/nightly/README.md b/quest/m0/nightly/README.md index 43a745240fb..62bbcf9e76e 100644 --- a/quest/m0/nightly/README.md +++ b/quest/m0/nightly/README.md @@ -38,7 +38,6 @@ Public API: none. Wire: none. - [The receive-windows benchmark runs to the end](/quest/m0/nightly/receive-windows-evicted.md) - `benchmark_receive_windows` stops failing `frame: Evicted`, so the Rust benchmark-tests job publishes its report - [The relay's startup fits its stack under all features](/quest/m0/nightly/relay-stack.md) - `debug_relay_load_and_run_fit_windows_stack` passes under `--all-features`, fixed at the feature that grew the future - [The binding benchmark's 64 KiB case measures](/quest/m0/nightly/bindings-bench-evicted.md) - the 64 KiB case completes instead of failing `evicted` -- [The range-widening bench expects a narrowed read to end](/quest/m0/nightly/track-range-widening.md) - `track_range_widening/1r/64` stops asserting a pending read that #7545 made end - [moq-net's ingest fuzz target finds no stall](/quest/m0/nightly/ingest-fuzz.md) - the 13-byte stream that stalls ingest is fixed at its cause and kept as a regression test - [Nightly's shipping-size check passes](/quest/m0/nightly/shipping-size.md) - js/net, js/watch, and moq-relay growth over 5% is traced to its commits, then shrunk or accepted - [Nightly's Miri job stays inside its time budget](/quest/m0/nightly/miri.md) - Miri gets `rust-src`, then finishes inside its 60-minute job and 15-minute-per-test budgets diff --git a/quest/m0/nightly/track-range-widening.md b/quest/m0/nightly/track-range-widening.md deleted file mode 100644 index 40964f13173..00000000000 --- a/quest/m0/nightly/track-range-widening.md +++ /dev/null @@ -1,33 +0,0 @@ -# [S] The range-widening bench expects a narrowed read to end - -## Goal - -`rs/moq-net/benches/track.rs`'s `track_range_widening/1r/64` passes on -`main`, under `cargo test -p moq-net --all-targets` and Nightly's `cargo -bench -p moq-net --bench '*'`, with an assertion that matches bounded reads -as [moq-dev/moq#7545](https://github.com/moq-dev/moq/pull/7545) defined them. - -## Plan - -Decided 2026-11-03 (maintainer, follow-up planning after the 2026-11-03 /quest-afk and /quest-complete runs), milestone: - -- ✅ m0, as a child of [Nightly passes on main](/quest/m0/nightly/README.md) -- m1 -- m2 - -Found by [moq-dev/moq#7536](https://github.com/moq-dev/moq/pull/7536), which -bisected it to #7545 ("end bounded reads", -[64cba13](https://github.com/moq-dev/moq/commit/64cba1337136c67ce77aaf6ae337f355c97a895e)). -After widening, the bench narrows its reader back to the already-delivered -`0..1` and asserts the next `poll_recv_group` is pending -(`bench_range_widening`, around line 1730). Since #7545 the bounded read -ends instead, returning `Ready(Ok(None))`. CI's `cargo test` skips bench -targets, so it went unnoticed. - -- Either assert the end, or narrow to a range that isn't finished yet so the - read stays pending. Pick the one that keeps the bench measuring the widening - it names, and say why in the PR. -- Confirm with `cargo test -p moq-net --all-targets` and a short `cargo - bench -p moq-net --bench track -- track_range_widening`. - -Public API: none. Wire: none. diff --git a/rs/moq-net/benches/track.rs b/rs/moq-net/benches/track.rs index c9daf63bf15..4c03f6e9610 100644 --- a/rs/moq-net/benches/track.rs +++ b/rs/moq-net/benches/track.rs @@ -1628,7 +1628,8 @@ fn bench_range_widening(c: &mut Criterion) { black_box(group); } reader.update(narrow.clone()).unwrap(); - assert!(reader.poll_recv_group(&waiter).is_pending()); + // The narrow range is already delivered, so it ends until widened again. + assert!(matches!(reader.poll_recv_group(&waiter), Poll::Ready(Ok(None)))); }); drop((readers, track, broadcast)); });