From a8e54a7a316460b24e551a95cae9ae21bff32460 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 5 Nov 2026 22:27:51 -0800 Subject: [PATCH 1/3] chore(quest): claim quest/m0/test-flakes-2/ietf-wider-fill.md Quest-Claim: 910c3271f1c191fe From 41d6252e6740a23bbdf062641046626693ba731b Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 6 Nov 2026 00:20:05 -0800 Subject: [PATCH 2/3] test(net): re-enable the draft-22 wider-fill refusal test Group 9 is the latest group when the subscription starts, so it is served live. Under the default zero max age, the live group superseding it gave up its stream mid-write whenever the publisher had not yet finished it, which raced the test's read of the refused fill. The fixture's unbounded max age (from #7852) removes that budget, so the test is deterministic in both orders. Co-Authored-By: Claude Opus 5.5 --- js/net/src/ietf/publisher.test.ts | 6 ++-- quest/m0/test-flakes-2/README.md | 1 - quest/m0/test-flakes-2/ietf-wider-fill.md | 35 ----------------------- 3 files changed, 3 insertions(+), 39 deletions(-) delete mode 100644 quest/m0/test-flakes-2/ietf-wider-fill.md diff --git a/js/net/src/ietf/publisher.test.ts b/js/net/src/ietf/publisher.test.ts index 256cee7b9f4..4dfe4ad4f9b 100644 --- a/js/net/src/ietf/publisher.test.ts +++ b/js/net/src/ietf/publisher.test.ts @@ -2663,10 +2663,10 @@ test("draft-22: a backwards range within one group serves nothing and ends the s } }); -// Quarantined: the live group intermittently resets while read. -// Investigation: quest/m0/test-flakes-2/ietf-wider-fill.md. -test.skip.each(["ascending", "descending"] as const)("draft-22: a wider fill is refused in %s order", async (order) => { +test.each(["ascending", "descending"] as const)("draft-22: a wider fill is refused in %s order", async (order) => { const fx = fixture(); + // No max age: group 9 is served live, and a zero budget would give it up mid-write once the + // live group supersedes it, racing this test's read of the refused fill. const track = fx.broadcast.createTrack("video", { timescale: Timescale.MILLI, maxAge: null }); for (const sequence of [0n, 3n, 9n]) { const group = track.createGroup(sequence); diff --git a/quest/m0/test-flakes-2/README.md b/quest/m0/test-flakes-2/README.md index 0f3622170f7..ebde3f4b9e0 100644 --- a/quest/m0/test-flakes-2/README.md +++ b/quest/m0/test-flakes-2/README.md @@ -100,7 +100,6 @@ Public API: none. Wire: none. ## Required - [Fallback playback](/quest/m0/test-flakes-2/ietf22-fallback.md) - a browser viewer follows a fallback within the media lane's bound without dropping its session -- [The draft-22 wider-fill refusal test is deterministic](/quest/m0/test-flakes-2/ietf-wider-fill.md) - fix its intermittent live-group reset and re-enable both ordering cases without weakening their assertions - [moq-gst's interleaved restart test passes under load](/quest/m0/test-flakes-2/gst-reconnect-interleave.md) - `restarts_under_reconnects_interleave_on_one_pad` passes in loaded runs and the merge queue, its missed delivery and its stray `Eos` each fixed at the cause - [reload.test.ts's close-drain tests pass under load](/quest/m0/test-flakes-2/reload-close-drain.md) - the drain cases in `js/net`'s reload tests pass in loaded multi-file runs - [dispatch-query's terminate test survives load](/quest/m0/test-flakes-2/dispatch-query-terminate.md) - `test_terminating_the_run_stops_the_running_phase` passes reliably under host load, re-enabled once fixed diff --git a/quest/m0/test-flakes-2/ietf-wider-fill.md b/quest/m0/test-flakes-2/ietf-wider-fill.md deleted file mode 100644 index 29023600e18..00000000000 --- a/quest/m0/test-flakes-2/ietf-wider-fill.md +++ /dev/null @@ -1,35 +0,0 @@ -# [S] The draft-22 wider-fill refusal test is deterministic - -## Goal - -`draft-22: a wider fill is refused in %s order` in -`js/net/src/ietf/publisher.test.ts` passes reliably in both ascending and -descending order, alone and in the loaded suite. Find and fix why its live -group intermittently resets while being read, then remove its quarantine -without weakening the refusal or live-delivery assertions. - -## Plan - -Planned 2026-11-04 under the maintainer's rule to quarantine a known flaky -test immediately and plan its investigation. This is one fixture's flake, -so it is one child of this epic; m0 follows the epic's standing rule that a -flake fails an entire merge batch. - -- The unchanged-main reproduction recorded in - [moq-dev/moq#7860](https://github.com/moq-dev/moq/pull/7860) failed 30/200 - runs. [moq-dev/moq#7851](https://github.com/moq-dev/moq/pull/7851) already - quarantines the same named case. The socket work in - [moq-dev/moq#7883](https://github.com/moq-dev/moq/pull/7883) carries the - precise investigation reference; its absolute-start adapter correction - and controlled early-burst tests do not investigate this separate flake. -- Start from the recorded reproduction and trace the live group's reset in - both orders. Establish whether fixture ownership, clock advancement, - stream ordering, or production behavior causes it before choosing a fix. - Control the responsible clock or event when the fixture is at fault; - fix the production source when it is not. -- Restore the existing test in both orders with its assertions intact. - Neither retries, longer timeouts, nor disabling production behavior is a - fix. Record the original reproduction and loaded-suite results before - and after, including the commands and limits of that evidence. - -Public API: none expected. Wire: none. From 6cde9e6347d89d93b3f2c1bc28a79f21f764b5b6 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 6 Nov 2026 07:56:21 -0800 Subject: [PATCH 3/3] test(net): assert the refused wider fill ends in a stream reset Co-Authored-By: Claude Opus 5.5 --- js/net/src/ietf/publisher.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/net/src/ietf/publisher.test.ts b/js/net/src/ietf/publisher.test.ts index 4dfe4ad4f9b..e7d71572b2d 100644 --- a/js/net/src/ietf/publisher.test.ts +++ b/js/net/src/ietf/publisher.test.ts @@ -2691,7 +2691,7 @@ test.each(["ascending", "descending"] as const)("draft-22: a wider fill is refus const fill = await nextUni(fx.uni); if (!fill) throw new Error("missing fill stream"); const served = await readFill(fill, order); - expect(served.reset).toBeDefined(); + expect(served.reset).toBeInstanceOf(StreamError); expect(served.objects).toEqual([]); const live = track.appendGroup(); live.writeFrame({ payload: new TextEncoder().encode("live"), timestamp: Timestamp.now() });