From 263169df4dda6e0158bde7553c96cdad6938d198 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 6 Nov 2026 01:45:18 -0800 Subject: [PATCH] fix(bench): the gate's benchmark fixture no longer waits for the host lock bench/build.test.py runs bench/run.sh in a synthetic repo, and since the host-wide benchmark lock landed, run.sh takes /tmp/moq-bench.lock. just gh test runs the fixture in every just check and just ci, so every gate on a host waited behind any running benchmark session. The fixture measures nothing, so it stubs the lock the way bench/profile.test.py already does. Co-Authored-By: Claude Opus 5.5 --- bench/build.test.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bench/build.test.py b/bench/build.test.py index 077f2716525..fa963993129 100644 --- a/bench/build.test.py +++ b/bench/build.test.py @@ -20,6 +20,9 @@ def test_base_builds_report_errors_and_distinguish_new_targets(self): repo = Path(directory) / "repo" repo.mkdir() shutil.copytree(ROOT / "bench", repo / "bench", ignore=shutil.ignore_patterns("__pycache__")) + # The fixture measures nothing, and `just gh test` runs it in every gate, which must + # not wait behind another session's benchmark for the host lock. + (repo / "bench/lock.sh").write_text("bench_lock() { :; }\n") (repo / ".cargo").mkdir() (repo / ".cargo/config.toml").touch() (repo / ".gitignore").write_text(".tmp/\ntarget/\n")