diff --git a/quest/m2/README.md b/quest/m2/README.md index e69973c6ea3..bbcb7530f43 100644 --- a/quest/m2/README.md +++ b/quest/m2/README.md @@ -22,7 +22,7 @@ naming abandoned groups on the wire lands on lite-07-wip) and the whole unbounded-groups epic, whose additive compressed-stream child rides with it. The cut gates that break nothing (main no slower than release, vendored -fixes, the pre-cut audit re-run, and moq-c parity) live under the recurring +fixes, and moq-c parity) live under the recurring [cut gate](/quest/m2/cut-gate/README.md), decided the same day. Held by open claims: the m1 epics and quests marked below stay where they @@ -186,6 +186,6 @@ quests that require them. - [Session policy lives in moq-net](/quest/m1/session-policy/README.md) - accept and connect deadlines, admission, window widening and reconnect live once in moq-net; moq-tokio and moq-relay's io_uring path call them (held in m1 by an open claim) - [Rename moq-rtc to moq-webrtc](/quest/m2/webrtc-rename.md) - one published `moq-webrtc` crate holds the gateway, the ICE driver, and the data-channel transport - [MoQ on rind](/quest/m1/rind/README.md) - every MoQ crate takes its crypto from rind, a pure-Rust graviola fork, so no build compiles C crypto (held in m1 by an open claim) -- [Cut readiness](/quest/m2/cut-gate/README.md) - the checks the cut needs that break nothing: main no slower than release, vendored fixes ported, the pre-cut audit re-run, and moq-c at parity +- [Cut readiness](/quest/m2/cut-gate/README.md) - the checks the cut needs that break nothing: main no slower than release, vendored fixes ported, and moq-c at parity - [Probe](/quest/m2/probe/README.md) - a session probes up to the bitrate it wants to send or receive, so a stopped simulcast rendition resumes and a viewer up-switches; browser padding is parked in m3 (held in m2 by open claims; moves to m3) - [Finish the milestone re-cut](/quest/m2/recut-held.md) - claim-held epics move to the milestone their kind and priority give them once their claims merge diff --git a/quest/m2/cut-gate/README.md b/quest/m2/cut-gate/README.md index 26f9e20691e..32766d6696f 100644 --- a/quest/m2/cut-gate/README.md +++ b/quest/m2/cut-gate/README.md @@ -4,11 +4,10 @@ Before each cut of `main` into `release`, the checks the cut needs that break nothing have passed: `main` is no slower than `release`, vendored code has -the upstream fixes it needs, the pre-cut audit's findings are fixed, and the -hand-written `moq-c` is at parity with moq-ffi. This epic's own work, once -every entry under `Required` has merged: confirm the children's results still -hold on the release candidate commit and record that commit in the -[release cut](/quest/m3/release/cut.md)'s Plan. +the upstream fixes it needs, and the hand-written `moq-c` is at parity with +moq-ffi. This epic's own work, once every entry under `Required` has merged: +confirm the children's results still hold on the release candidate commit and +record that commit in the [release cut](/quest/m3/release/cut.md)'s Plan. ## Plan @@ -23,13 +22,11 @@ it shifts the milestones, after removing this path from every `Required`. The new gate keeps this Goal and this paragraph, gets a fresh "main is no slower than release" child with its Goal and no measurements yet, and takes the [vendor sync](/quest/m3/vendor-sync/README.md) questline that this -run re-created in m3. The pre-cut audit is a one-time child and does not -recur. Only `/quest-delete` ends the recurrence. +run re-created in m3. Only `/quest-delete` ends the recurrence. The completed [release performance comparison](/.github/release-perf.md) records the accepted costs and final relay pairing for this cut. ## Required -- [Pre-cut audit findings](/quest/m2/cut-gate/cut-audit/README.md) - fix the crashes, hostile-input costs, and correctness bugs the 2026-10-24 audit of main found - [moq-c at parity](/quest/m2/cut-gate/c/README.md) - the hand-written `moq-c` ships at the cut with every binding feature moq-ffi gains diff --git a/quest/m2/cut-gate/cut-audit/README.md b/quest/m2/cut-gate/cut-audit/README.md deleted file mode 100644 index 304e8fd5ad9..00000000000 --- a/quest/m2/cut-gate/cut-audit/README.md +++ /dev/null @@ -1,59 +0,0 @@ -# [S] Pre-cut audit findings - -## Goal - -Resolve the bugs and hostile-input costs found by the 2026-10-24 pre-cut -audit of main before main is promoted to release. This epic's own work, once -every child has merged: re-run the reproductions the children record against -the release candidate and hand the result to the -[release cut](/quest/m3/release/cut.md). - -## Plan - -The maintainer asked for an extensive audit of main for bugs and -improvements before the cut, with attention to high-churn areas that need a -redesign. The audit ran at -[151a529670](https://github.com/moq-dev/moq/commit/151a529670) in eight -areas: the moq-net track and resume model, origin and sessions with kio, -moq-transport, moq-lite with its codecs and fuzzing, `js/net` with -`js/qmux`, moq-mux with hang in both languages, the browser media packages, -and the runtimes and binaries (moq-tokio, moq-uring, the relay's non-auth -paths, moq-cli, moq-rtmp, moq-gst, moq-transcode, moq-audio, moq-video). It -skipped what the 2026-10-22 to 24 audits already covered (release-to-main, -relay security, clustering, linger, moq-quic, moq-hls, the external API -audit, bindings and OBS), and every finding was checked against the quest -tree and the open PRs. - -This was risk-based source review with targeted reproductions in throwaway -tests, not a line-by-line pass; TS import/export beyond spot checks was not -covered. Each child says whether its finding was reproduced or -source-inferred and whether it is new on main or inherited from release. -Children are ordered by severity: remotely reachable crashes and -amplification first, then correctness and privacy, then bounded costs and -cleanups. - -Churn context: main landed about 2,400 commits in the 30 days before the -audit, 823 of them fixes, concentrated in `rs/moq-net` (`model/track.rs` 85 -fix commits, `ietf/subscriber.rs` 69, `ietf/publisher.rs` 53, -`lite/subscriber.rs` 51, `model/resume.rs` 46) and `js/net`. The audit's -redesign proposals for the churning mechanisms are in m3 and m4, since each is -internal and can ship after the cut: -[resume as producer replacement](/quest/m4/resume-redesign.md), -[moq-transport request leases](/quest/m3/ietf-request-lease.md), -[group heads filled in place](/quest/m3/ietf-fill-refill.md), -moqsrc pad actors and publish rendition identity (both since landed). The -[one relay serve path](/quest/m1/session-policy/uring.md) proposal moved into -m1 on 2026-11-04, as part of moving session policy into moq-net before the -cut. Other redesign evidence went into the quests that already own the -mechanism: -[subscribe ranges](/quest/m2/subscribe-ranges/README.md), -[drop set](/quest/m1/drop-set.md), -[per-origin routes](/quest/m2/cluster-routing/routes/README.md), -drafts 14-17 removal (since landed), and -[buffered playback](/quest/m1/buffered-ascending.md). The audit recommends -leaving JS-only redesigns of `js/net` to [rs2ts](/quest/m5/rs2ts-js.md). - -## Related - -- [Announce interest streams share one route table](/quest/m4/announce-interest-memory.md) - the audit's inherited announce memory finding -- [A parked read of a resumed group reads its budget without re-syncing](/quest/m5/recover-budget.md) - measure-first resume cost diff --git a/quest/m3/release/cut.md b/quest/m3/release/cut.md index c7f6763ab43..45f6d150f14 100644 --- a/quest/m3/release/cut.md +++ b/quest/m3/release/cut.md @@ -85,6 +85,20 @@ planned break. Dart's tests and both staged publish dry-runs passed with no warnings. Neither main is the cut tree, and the full Linux gate was not run: repeat these checks after the documented release-to-main merge. +The [2026-10-24 pre-cut audit](https://github.com/moq-dev/moq/pull/6707) +closed with its 37 findings' regression tests re-run together in +[moq-dev/moq#8059](https://github.com/moq-dev/moq/pull/8059). At +[main 1ae5c5f808](https://github.com/moq-dev/moq/commit/1ae5c5f808f5fb695a42dcb451611edce81802d7), +each fix's test still exists or was replaced by a later deliberate change. +These passed: the moq-net, moq-net-tests, moq-mux, moq-rtmp, moq-tokio, +moq-uring, hang, and moq-audio suites (7,027 tests, with the fuzz regression +replays), every JS package's unit tests (5,745), the `just test harness` +browser checks (48), and `just test video` (11). Nightly's harness step fails +before it reaches its browser checks, which is how two of them stayed broken +after [moq-dev/moq#7942](https://github.com/moq-dev/moq/pull/7942) until the +re-run fixed them. Run those browser checks by hand on the cut tree, along +with the suites above. + ## Required - [Breaking release readiness](/quest/m2/README.md) - code, protocol and package proofs diff --git a/test/interop/clients/js/buffering/main.ts b/test/interop/clients/js/buffering/main.ts index 9f544633bdc..96c0e6a5023 100644 --- a/test/interop/clients/js/buffering/main.ts +++ b/test/interop/clients/js/buffering/main.ts @@ -21,7 +21,7 @@ const watch = { out: { stalled: new Signal(!video) }, }, video: { - source: { out: { config: new Signal(undefined), error: new Signal(undefined) } }, + source: { out: { config: new Signal({ codec: "avc1.42E01E" }), error: new Signal(undefined) } }, out: { stalled: new Signal(video) }, }, broadcast: { out: { status: new Signal("live"), error: new Signal(undefined) } }, diff --git a/test/interop/clients/js/publish-ui.browser.ts b/test/interop/clients/js/publish-ui.browser.ts index fb8c793547a..16a245b59c2 100644 --- a/test/interop/clients/js/publish-ui.browser.ts +++ b/test/interop/clients/js/publish-ui.browser.ts @@ -728,8 +728,8 @@ test("a selected camera stays announced while real capture is reopening", async return { publish }; }); - // Muting and hiding only flip each rendition to `enabled: false`: the same tracks stay live and - // unmuting reopens nothing. + // Hiding only flips video to `enabled: false` and muting keeps audio enabled while it sends + // nothing: the same tracks stay live and unmuting reopens nothing. const opened = await captured(publication); await gate.evaluate((gate) => { gate.hold = true; @@ -741,7 +741,8 @@ test("a selected camera stays announced while real capture is reopening", async }); await page.waitForFunction( ({ publish }) => - publish.audio.out.catalog.peek()?.enabled === false && + !!publish.audio.out.catalog.peek() && + publish.audio.out.catalog.peek()?.enabled === undefined && publish.video.out.catalog.peek()?.enabled === false, publication, );