From 5277b617bb591742b70c770f30e9b78aa01de3c4 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 7 Nov 2026 07:29:50 -0800 Subject: [PATCH 1/2] quest: plan the stale invalid-attribute browser check Co-Authored-By: Claude Opus 5.5 --- quest/m0/README.md | 1 + quest/m0/watch-invalid-attribute-check.md | 25 +++++++++++++++++++++++ 2 files changed, 26 insertions(+) create mode 100644 quest/m0/watch-invalid-attribute-check.md diff --git a/quest/m0/README.md b/quest/m0/README.md index 9141265dc82..d5b4339b01a 100644 --- a/quest/m0/README.md +++ b/quest/m0/README.md @@ -33,6 +33,7 @@ edge, which embeds moq-relay; it moved there on 2026-09-28. - [Publish the release line's drain() wrappers](/quest/m0/ffi-shutdown-backport.md) - Dart `moq` 0.1.1 reaches pub.dev from `release` - [Release's audio encoder rolls groups before the cap](/quest/m0/release-audio-group-cap.md) - a long `groupDuration` with short frames never throws `GroupTooLarge` on `release` - [Local checks pass on unchanged main](/quest/m0/local-checks-main.md) - `sh/go/publish-wrapper.test.sh` passes under a global `tag.gpgsign = true`, so `just check` passes on a clean `main` +- [The invalid-attribute browser check matches moq-watch's attributes](/quest/m0/watch-invalid-attribute-check.md) - `publish-ui.browser.ts`'s invalid-attribute test passes on main again, with no stale `buffer` case - [CI cost and latency](/quest/m0/ci/README.md) - cloud CI runs only in GitHub's merge queue, one tested entry at a time, expensive checks run nightly and gate `release`, caches move to R2, and runners are chosen last - [More tests under load](/quest/m0/test-flakes-2/README.md) - load-only and queue failures, one quest per flake, fixed at the cause, since each one drops a queued PR - [Tests can't wait on the real clock](/quest/m0/clock-guard/README.md) - a test whose real-clock timer fires fails every run, in JS and, if the spike holds, Rust diff --git a/quest/m0/watch-invalid-attribute-check.md b/quest/m0/watch-invalid-attribute-check.md new file mode 100644 index 00000000000..8cb9188c2f0 --- /dev/null +++ b/quest/m0/watch-invalid-attribute-check.md @@ -0,0 +1,25 @@ +# [XS] The invalid-attribute browser check matches moq-watch's attributes + +## Goal + +`test/interop/clients/js/publish-ui.browser.ts`'s "invalid attributes and +properties refuse, retain bad markup, and recover" passes on main again. Each +case tests an attribute moq-watch or moq-publish still has, and every value it +calls invalid is one the element documents as invalid. + +## Plan + +Planned 2026-11-07 (maintainer, /quest-complete) from +[moq-dev/moq#8136](https://github.com/moq-dev/moq/pull/8136)'s validation. +`bun test ./publish-ui.browser.ts -t "invalid attributes"` fails on main +(9bf34b20dd) with `invalid: "30"` giving `threw: false, recovered: false`. + +Likely cause: [moq-dev/moq#8057](https://github.com/moq-dev/moq/pull/8057) +renamed moq-watch's `buffer` to `lookahead`. In `js/watch/src/element.ts`, a +`buffer` attribute now throws only the rename error, and the element has no +`buffer` property. So the case `["moq-watch", "buffer", "30", "buffer", 0]` +neither throws on `Reflect.set` nor reads back its valid value. Confirm which +case fails. If it is this one, move it to `lookahead` with a value +`parseLookahead` refuses, and keep a check that `buffer` reports its rename. +If the `delay` case fails instead, decide from `parseDelay`'s documented +syntax whether the element or the test is wrong. From 59a8a46a08b504cfdd8ff8c6cc7174f31fa438a2 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 7 Nov 2026 07:41:34 -0800 Subject: [PATCH 2/2] quest: give the invalid-attribute check's command its directory and the rename recovery Co-Authored-By: Claude Opus 5.5 --- quest/m0/watch-invalid-attribute-check.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/quest/m0/watch-invalid-attribute-check.md b/quest/m0/watch-invalid-attribute-check.md index 8cb9188c2f0..f60ea432178 100644 --- a/quest/m0/watch-invalid-attribute-check.md +++ b/quest/m0/watch-invalid-attribute-check.md @@ -11,7 +11,7 @@ calls invalid is one the element documents as invalid. Planned 2026-11-07 (maintainer, /quest-complete) from [moq-dev/moq#8136](https://github.com/moq-dev/moq/pull/8136)'s validation. -`bun test ./publish-ui.browser.ts -t "invalid attributes"` fails on main +From the repository root, `(cd test/interop/clients/js && bun test ./publish-ui.browser.ts -t "invalid attributes")` fails on main (9bf34b20dd) with `invalid: "30"` giving `threw: false, recovered: false`. Likely cause: [moq-dev/moq#8057](https://github.com/moq-dev/moq/pull/8057) @@ -20,6 +20,7 @@ renamed moq-watch's `buffer` to `lookahead`. In `js/watch/src/element.ts`, a `buffer` property. So the case `["moq-watch", "buffer", "30", "buffer", 0]` neither throws on `Reflect.set` nor reads back its valid value. Confirm which case fails. If it is this one, move it to `lookahead` with a value -`parseLookahead` refuses, and keep a check that `buffer` reports its rename. +`parseLookahead` refuses, and keep a check that `buffer` still reports its +rename when set and recovers once the attribute is removed. If the `delay` case fails instead, decide from `parseDelay`'s documented syntax whether the element or the test is wrong.