diff --git a/quest/m0/README.md b/quest/m0/README.md index b65bbd4d90c..0231c3a98d6 100644 --- a/quest/m0/README.md +++ b/quest/m0/README.md @@ -32,7 +32,6 @@ edge, which embeds moq-relay; it moved there on 2026-09-28. - [Peer and config values never panic or wrap moq-net arithmetic](/quest/m0/peer-arithmetic.md) - a peer's retry interval, object id, drop end or sequence, and huge configured durations no longer panic a task or wrap - [Publish the release line's drain() wrappers](/quest/m0/ffi-shutdown-backport.md) - Dart `moq` 0.1.1 reaches pub.dev from `release` - [Release's audio encoder rolls groups before the cap](/quest/m0/release-audio-group-cap.md) - a long `groupDuration` with short frames never throws `GroupTooLarge` on `release` -- [The invalid-attribute browser check matches moq-watch's attributes](/quest/m0/watch-invalid-attribute-check.md) - `publish-ui.browser.ts`'s invalid-attribute test passes on main again, with no stale `buffer` case - [CI cost and latency](/quest/m0/ci/README.md) - cloud CI runs only in GitHub's merge queue, one tested entry at a time, expensive checks run nightly and gate `release`, caches move to R2, and runners are chosen last - [More tests under load](/quest/m0/test-flakes-2/README.md) - load-only and queue failures, one quest per flake, fixed at the cause, since each one drops a queued PR - [Agent build output can't fill the desktop's disk](/quest/m0/agent-disk-budget.md) - finished agent checkouts reclaim their mbx targets automatically, so parallel agent builds stop filling the root disk diff --git a/quest/m0/interop-green/README.md b/quest/m0/interop-green/README.md index c49128639f8..239aea65216 100644 --- a/quest/m0/interop-green/README.md +++ b/quest/m0/interop-green/README.md @@ -93,4 +93,13 @@ this quest's PR: `moq-lite-07-wip` planned break stale again; remeasured, with the same 16 cells failing. +Scheduled run +[42382888974](https://github.com/moq-dev/moq/actions/runs/42382888974) +(2026-11-07, at b98833c40a, after those fixes landed) failed only Harness +regressions: `publish-ui.browser.ts`'s invalid-attribute check still tested +moq-watch's `buffer`, which +[moq-dev/moq#8057](https://github.com/moq-dev/moq/pull/8057) renamed to +`lookahead`. Fixed in this quest's PR: the case tests `lookahead`, and a new +check confirms `buffer` reports its rename and recovers once removed. + Public API: none. Wire: none. diff --git a/quest/m0/watch-invalid-attribute-check.md b/quest/m0/watch-invalid-attribute-check.md deleted file mode 100644 index f60ea432178..00000000000 --- a/quest/m0/watch-invalid-attribute-check.md +++ /dev/null @@ -1,26 +0,0 @@ -# [XS] The invalid-attribute browser check matches moq-watch's attributes - -## Goal - -`test/interop/clients/js/publish-ui.browser.ts`'s "invalid attributes and -properties refuse, retain bad markup, and recover" passes on main again. Each -case tests an attribute moq-watch or moq-publish still has, and every value it -calls invalid is one the element documents as invalid. - -## Plan - -Planned 2026-11-07 (maintainer, /quest-complete) from -[moq-dev/moq#8136](https://github.com/moq-dev/moq/pull/8136)'s validation. -From the repository root, `(cd test/interop/clients/js && bun test ./publish-ui.browser.ts -t "invalid attributes")` fails on main -(9bf34b20dd) with `invalid: "30"` giving `threw: false, recovered: false`. - -Likely cause: [moq-dev/moq#8057](https://github.com/moq-dev/moq/pull/8057) -renamed moq-watch's `buffer` to `lookahead`. In `js/watch/src/element.ts`, a -`buffer` attribute now throws only the rename error, and the element has no -`buffer` property. So the case `["moq-watch", "buffer", "30", "buffer", 0]` -neither throws on `Reflect.set` nor reads back its valid value. Confirm which -case fails. If it is this one, move it to `lookahead` with a value -`parseLookahead` refuses, and keep a check that `buffer` still reports its -rename when set and recovers once the attribute is removed. -If the `delay` case fails instead, decide from `parseDelay`'s documented -syntax whether the element or the test is wrong. diff --git a/test/interop/clients/js/publish-ui.browser.ts b/test/interop/clients/js/publish-ui.browser.ts index 16a245b59c2..2a69c46ef11 100644 --- a/test/interop/clients/js/publish-ui.browser.ts +++ b/test/interop/clients/js/publish-ui.browser.ts @@ -1072,7 +1072,7 @@ test("invalid attributes and properties refuse, retain bad markup, and recover", ["moq-watch", "backend", "gpu", "backend", "auto"], ["moq-watch", "visible", "sometimes", "visible", "never"], ["moq-watch", "delay", "30", "delay", "instant"], - ["moq-watch", "buffer", "30", "buffer", 0], + ["moq-watch", "lookahead", "30", "lookahead", 0], ["moq-watch", "catalog-format", "guess", "catalogFormat", "manual"], ["moq-publish", "source", "monitor", "source", undefined], ["moq-publish", "preview", "mse", "preview", "none"], @@ -1104,6 +1104,26 @@ test("invalid attributes and properties refuse, retain bad markup, and recover", }); for (const result of results) expect(result).toEqual({ ...result, refused: true, threw: true, recovered: true }); + // `buffer` was renamed to `lookahead`: the old attribute reports the rename until removed. + const renamedBuffer = await page.evaluate(() => { + const errors: string[] = []; + const listener = (event: ErrorEvent) => { + errors.push(event.message); + event.preventDefault(); + }; + window.addEventListener("error", listener); + const watch = document.createElement("moq-watch"); + watch.setAttribute("buffer", "30s"); + document.body.append(watch); + const refused = !watch.connection.enabled.peek() && errors.some((error) => error.includes("lookahead")); + watch.removeAttribute("buffer"); + const recovered = watch.connection.enabled.peek(); + watch.remove(); + watch.signals.close(); + window.removeEventListener("error", listener); + return { refused, recovered }; + }); + expect(renamedBuffer).toEqual({ refused: true, recovered: true }); const blocked = await page.evaluate(() => { const watch = document.createElement("moq-watch"); watch.setAttribute("backend", "bad");