From 1a512ac7fdd7f16a8939287c72a348cb007f346b Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 7 Nov 2026 11:18:52 -0800 Subject: [PATCH] test(net): quarantine the lite-07 relative-start flake and plan its fix Co-Authored-By: Claude Opus 5.5 --- js/net/src/integration.test.ts | 4 ++- quest/m0/test-flakes-2/README.md | 6 +++++ .../m0/test-flakes-2/lite07-relative-start.md | 27 +++++++++++++++++++ 3 files changed, 36 insertions(+), 1 deletion(-) create mode 100644 quest/m0/test-flakes-2/lite07-relative-start.md diff --git a/js/net/src/integration.test.ts b/js/net/src/integration.test.ts index 100c65142ca..b2e42dca32b 100644 --- a/js/net/src/integration.test.ts +++ b/js/net/src/integration.test.ts @@ -505,7 +505,9 @@ test("integration: lite-07 serves sparse and relative ranges", async () => { // so counts neither in the largest it reports nor where the copy resolves the start. The copy reports // the publisher's start, where a reader waiting on each group in sequence starts. Mirrors the Rust // `a_relative_start_reports_the_publishers_start_over_a_frameless_newest_group`. -test("integration: lite-07 reports a relative start over a frameless newest group", async () => { +// Quarantined: once on main, the start resolved to 0 instead of the publisher's 5. +// Investigation: quest/m0/test-flakes-2/lite07-relative-start.md. +test.skip("integration: lite-07 reports a relative start over a frameless newest group", async () => { const pair = createMockTransportPair(Lite.ALPN_07_WIP); const origin = new OriginProducer(); const [client, server] = await Promise.all([ diff --git a/quest/m0/test-flakes-2/README.md b/quest/m0/test-flakes-2/README.md index f448acb0bc2..a86e822f814 100644 --- a/quest/m0/test-flakes-2/README.md +++ b/quest/m0/test-flakes-2/README.md @@ -148,6 +148,11 @@ skipped the timing report. A TERM landing after a lane forked but before hung. The exit trap now waits again, and cancellation reads the job table, fixed by [moq-dev/moq#8138](https://github.com/moq-dev/moq/pull/8138). +Added 2026-11-07 (maintainer, /quest-complete): `js/net`'s lite-07 +relative-start integration test, which failed once on main in +[moq-dev/moq#8165](https://github.com/moq-dev/moq/pull/8165)'s baseline run. +It is quarantined with `test.skip` until its child fixes it. + Public API: none. Wire: none. ## Required @@ -156,3 +161,4 @@ Public API: none. Wire: none. - [The datagram-end close follow-up](/quest/m0/test-flakes-2/datagram-end-close.md) - investigate whether duplicate SETUP can override an accepted lite-06 SUBSCRIBE_END during shutdown - [moq-transcode's idle-rung cancel test survives load](/quest/m0/test-flakes-2/transcode-idle-rung-cancel.md) - `cancelling_an_idle_rung_reports_cancel` stops seeing `serve` return before its abort lands - [moq-gst's sink-restart pad test survives load](/quest/m0/test-flakes-2/gst-sink-restart-pads.md) - `a_moqsink_restart_keeps_pads_when_caps_arrive_at_different_times` keeps its pads under load +- [A lite-07 relative start resolves to the publisher's start every time](/quest/m0/test-flakes-2/lite07-relative-start.md) - `js/net`'s frameless-newest-group integration test stops reading a start of 0, and its `test.skip` is removed diff --git a/quest/m0/test-flakes-2/lite07-relative-start.md b/quest/m0/test-flakes-2/lite07-relative-start.md new file mode 100644 index 00000000000..10484be39d3 --- /dev/null +++ b/quest/m0/test-flakes-2/lite07-relative-start.md @@ -0,0 +1,27 @@ +# [S] A lite-07 relative start resolves to the publisher's start every time + +## Goal + +A lite-07 subscription whose relative start counts back from a frameless +newest group always reports the publisher's start. `js/net/src/integration.test.ts`'s +"integration: lite-07 reports a relative start over a frameless newest group" +passes reliably under load, and its `test.skip` is removed. + +## Plan + +Planned 2026-11-07 (maintainer, /quest-complete) from +[moq-dev/moq#8165](https://github.com/moq-dev/moq/pull/8165)'s validation: +in a baseline run on unchanged main, `reader.start()` returned `0n` where the +test expects the publisher's `5n`. It is quarantined with `test.skip` until +this quest fixes it, per AGENTS.md. + +Reproduce it first, under load or with `bun test --rerun-each`, and find +which side reports 0: the copy resolving the start before the publisher's +answer arrives, or the publisher counting back from the frameless newest +group. Fix it at that cause, not in the test. Check the Rust mirror, +`a_relative_start_reports_the_publishers_start_over_a_frameless_newest_group` +(`rs/moq-net/tests/integration/range_anchors.rs`), for the same ordering. +Prove the fix with a test that forces the losing order, not with repeated +runs. + +Public API: none. Wire: none.