From acdb1b3d382bbd03b708a1e501693fae1773e0b1 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 7 Nov 2026 12:05:08 -0800 Subject: [PATCH 1/2] test(gst): quarantine the stale-completion sink flake and plan its fix Co-Authored-By: Claude Opus 5.5 --- quest/m0/test-flakes-2/README.md | 6 +++++ .../m0/test-flakes-2/gst-stale-completion.md | 26 +++++++++++++++++++ rs/moq-gst/src/sink/imp.rs | 1 + 3 files changed, 33 insertions(+) create mode 100644 quest/m0/test-flakes-2/gst-stale-completion.md diff --git a/quest/m0/test-flakes-2/README.md b/quest/m0/test-flakes-2/README.md index f448acb0bc2..b496450ae28 100644 --- a/quest/m0/test-flakes-2/README.md +++ b/quest/m0/test-flakes-2/README.md @@ -148,6 +148,11 @@ skipped the timing report. A TERM landing after a lane forked but before hung. The exit trap now waits again, and cancellation reads the job table, fixed by [moq-dev/moq#8138](https://github.com/moq-dev/moq/pull/8138). +Added 2026-11-07 (maintainer, /quest-complete): moq-gst's stale-completion +sink test, which failed once in 30 stress iterations in +[moq-dev/moq#8160](https://github.com/moq-dev/moq/pull/8160)'s validation. +It is quarantined with `#[ignore]` until its child fixes it. + Public API: none. Wire: none. ## Required @@ -156,3 +161,4 @@ Public API: none. Wire: none. - [The datagram-end close follow-up](/quest/m0/test-flakes-2/datagram-end-close.md) - investigate whether duplicate SETUP can override an accepted lite-06 SUBSCRIBE_END during shutdown - [moq-transcode's idle-rung cancel test survives load](/quest/m0/test-flakes-2/transcode-idle-rung-cancel.md) - `cancelling_an_idle_rung_reports_cancel` stops seeing `serve` return before its abort lands - [moq-gst's sink-restart pad test survives load](/quest/m0/test-flakes-2/gst-sink-restart-pads.md) - `a_moqsink_restart_keeps_pads_when_caps_arrive_at_different_times` keeps its pads under load +- [moq-gst's stale-completion sink test survives load](/quest/m0/test-flakes-2/gst-stale-completion.md) - `a_stale_completion_cannot_end_the_next_publication` passes under stress, and its `#[ignore]` is removed diff --git a/quest/m0/test-flakes-2/gst-stale-completion.md b/quest/m0/test-flakes-2/gst-stale-completion.md new file mode 100644 index 00000000000..b84c5c6b714 --- /dev/null +++ b/quest/m0/test-flakes-2/gst-stale-completion.md @@ -0,0 +1,26 @@ +# [S] moq-gst's stale-completion sink test survives load + +## Goal + +`rs/moq-gst/src/sink/imp.rs`'s `a_stale_completion_cannot_end_the_next_publication` +passes reliably under load, fixed at its cause, and its `#[ignore]` is +removed. + +## Plan + +Planned 2026-11-07 (maintainer, /quest-complete) from +[moq-dev/moq#8160](https://github.com/moq-dev/moq/pull/8160)'s validation: +it failed once in a 30-iteration stress run of the moq-gst suite at +[8e2db7b9f6](https://github.com/moq-dev/moq/commit/8e2db7b9f609f1c0992049def7499c268ddcf085). +It is quarantined with `#[ignore]` until this quest fixes it, per AGENTS.md. + +The test starts a session against an unreachable URL, stops it, starts a +second one, and asserts that failing the first session's completion leaves +the second's open and the pad relinked to it. Reproduce it under stress +first and record which assertion fails, then fix the cause: a state +transition that returns before the old session's task lets go of the pad, +or a second session that hasn't linked its pad by the time `Paused` +returns. Fix it in the sink, not by waiting in the test, and prove it with +a test that forces the losing order. + +Public API: none. Wire: none. diff --git a/rs/moq-gst/src/sink/imp.rs b/rs/moq-gst/src/sink/imp.rs index 5b405e54259..7521edfc020 100644 --- a/rs/moq-gst/src/sink/imp.rs +++ b/rs/moq-gst/src/sink/imp.rs @@ -2236,6 +2236,7 @@ mod tests { // A task outliving its session writes into the handle nobody reads any more. Scoping falls out of // the topology: no id comparison guards the state the pads see. #[test] + #[ignore = "flaky under stress; investigation: quest/m0/test-flakes-2/gst-stale-completion.md"] fn a_stale_completion_cannot_end_the_next_publication() { gst::init().unwrap(); let sink = sink(); From c7e125d234c54bd52f3400ff9ed539ca179063ef Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 7 Nov 2026 12:35:24 -0800 Subject: [PATCH 2/2] test(gst): allowlist the quarantined sink test; plan names the shutdown-completion case Co-Authored-By: Claude Opus 5.5 --- quest/m0/test-flakes-2/gst-stale-completion.md | 13 ++++++++----- sh/gh/test-inventory.allow | 3 +++ 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/quest/m0/test-flakes-2/gst-stale-completion.md b/quest/m0/test-flakes-2/gst-stale-completion.md index b84c5c6b714..bce4fc49c35 100644 --- a/quest/m0/test-flakes-2/gst-stale-completion.md +++ b/quest/m0/test-flakes-2/gst-stale-completion.md @@ -17,10 +17,13 @@ It is quarantined with `#[ignore]` until this quest fixes it, per AGENTS.md. The test starts a session against an unreachable URL, stops it, starts a second one, and asserts that failing the first session's completion leaves the second's open and the pad relinked to it. Reproduce it under stress -first and record which assertion fails, then fix the cause: a state -transition that returns before the old session's task lets go of the pad, -or a second session that hasn't linked its pad by the time `Paused` -returns. Fix it in the sink, not by waiting in the test, and prove it with -a test that forces the losing order. +first and record which assertion fails; that decides whether the sink or +the test is wrong. Candidates: a state transition that returns before the +old session's task lets go of the pad; a second session that hasn't linked +its pad by the time `Paused` returns; or the old session's status task +failing its own completion during shutdown before `stale.fail()` runs, which +breaks the test's assumption rather than the sink. Fix a sink defect in the +sink, never by waiting in the test, and prove it with a test that forces +the losing order. Public API: none. Wire: none. diff --git a/sh/gh/test-inventory.allow b/sh/gh/test-inventory.allow index 8564c5eb671..d887b2353bd 100644 --- a/sh/gh/test-inventory.allow +++ b/sh/gh/test-inventory.allow @@ -35,3 +35,6 @@ ignore moq-video::frame::tests::d3d11_resize_matches_cpu /quest/m5/video-hardwar ignore moq-video::render::export::dx12::tests::exports_an_nv12_texture /quest/m5/video-hardware.md ignore moq-video::render::export::dx12::tests::media_foundation_encodes_the_export_in_place /quest/m5/video-hardware.md + +# Quarantined flakes, re-enabled by the quest that fixes them. +ignore moq-gst::sink::imp::tests::a_stale_completion_cannot_end_the_next_publication /quest/m0/test-flakes-2/gst-stale-completion.md