From ed4f918c39d5d21fb66865c68de653fa6baca274 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 7 Nov 2026 12:58:33 -0800 Subject: [PATCH 1/3] quest: plan the WebRTC stack's SCTP gate, browser-only trim, and dead-API trim Co-Authored-By: Claude Opus 5.5 --- quest/m3/webrtc/README.md | 3 +++ quest/m3/webrtc/browser-only.md | 27 +++++++++++++++++++++++++++ quest/m3/webrtc/dead-api.md | 22 ++++++++++++++++++++++ quest/m3/webrtc/sctp-feature.md | 24 ++++++++++++++++++++++++ 4 files changed, 76 insertions(+) create mode 100644 quest/m3/webrtc/browser-only.md create mode 100644 quest/m3/webrtc/dead-api.md create mode 100644 quest/m3/webrtc/sctp-feature.md diff --git a/quest/m3/webrtc/README.md b/quest/m3/webrtc/README.md index 77ee17af793..5481cd68f6e 100644 --- a/quest/m3/webrtc/README.md +++ b/quest/m3/webrtc/README.md @@ -25,6 +25,9 @@ Decided 2026-10-30 with the maintainer (planning interview), after the str0m wor - [Several bandwidth lines per media section](/quest/m3/webrtc/sdp-bandwidth.md) - answers carry both `b=TIAS` and `b=AS` without splicing - [DTLS waits for ICE](/quest/m3/webrtc/dtls-after-ice.md) - DTLS flights start once ICE nominates a pair, so a late ICE path can't exhaust them - [The stack takes kio clock time](/quest/m3/webrtc/clock.md) - the vendored code takes `kio::clock::Instant`, so sim tests drive it directly +- [WHIP/WHEP builds carry no SCTP](/quest/m3/webrtc/sctp-feature.md) - SCTP compiles only with the data-channel feature +- [The vendored stack keeps only what browsers negotiate](/quest/m3/webrtc/browser-only.md) - PSK suites, `ccm`, and anything else no browser uses are gone +- [The vendored stack exposes only what moq-webrtc calls](/quest/m3/webrtc/dead-api.md) - dead upstream API is deleted once rind and clock settle the seams ## Related diff --git a/quest/m3/webrtc/browser-only.md b/quest/m3/webrtc/browser-only.md new file mode 100644 index 00000000000..25e71a1b226 --- /dev/null +++ b/quest/m3/webrtc/browser-only.md @@ -0,0 +1,27 @@ +# [S] The vendored stack keeps only what browsers negotiate + +## Goal + +The vendored str0m, dimpl, `is`, and sctp-proto drop every feature no +browser's WebRTC negotiates today, starting with dimpl's PSK cipher suites +and the `ccm` dependency they pull in, so nothing MoQ can't reach from a +browser peer stays compiled. + +## Plan + +Planned 2026-11-07 (maintainer, /quest-complete), a follow-up of +[moq-dev/moq#8163](https://github.com/moq-dev/moq/pull/8163). The maintainer +widened the suggestion from PSK alone: delete anything browsers don't use +now. Browser DTLS authenticates with certificates and fingerprints, never +PSK. Inventory what Chrome, Firefox, and Safari offer and accept (cipher +suites, extensions, SDP attributes, codecs' packetizers) against what the +vendored code still carries, cite the evidence for each removal in the PR, +and keep what a browser negotiates even if MoQ doesn't call it yet. API +that moq-webrtc never calls but a browser could need stays for +[the dead-API trim](/quest/m3/webrtc/dead-api.md). + +Public API: none. Wire: none toward browsers. + +## Required + +- [Vendor and trim the stack](/quest/m1/webrtc-vendor.md) - the vendored code this trims diff --git a/quest/m3/webrtc/dead-api.md b/quest/m3/webrtc/dead-api.md new file mode 100644 index 00000000000..3bd1a2b0f0b --- /dev/null +++ b/quest/m3/webrtc/dead-api.md @@ -0,0 +1,22 @@ +# [M] The vendored stack exposes only what moq-webrtc calls + +## Goal + +Every item in the vendored modules is reached from moq-webrtc or its +tests; dead upstream API is deleted. + +## Plan + +Planned 2026-11-07 (maintainer, /quest-complete), a follow-up of +[moq-dev/moq#8163](https://github.com/moq-dev/moq/pull/8163). It waits on +the rind and clock quests, since both reshape the seams moq-webrtc calls +through. Start from the compiler's dead-code report with the vendored +modules private, then remove what remains unreached, keeping upstream's +tests for what stays. + +Public API: none. Wire: none. + +## Required + +- [moq-webrtc on rind](/quest/m1/rind/rtc.md) - settles the crypto seams +- [The stack takes kio clock time](/quest/m3/webrtc/clock.md) - settles the time seams diff --git a/quest/m3/webrtc/sctp-feature.md b/quest/m3/webrtc/sctp-feature.md new file mode 100644 index 00000000000..edd9e5c3145 --- /dev/null +++ b/quest/m3/webrtc/sctp-feature.md @@ -0,0 +1,24 @@ +# [S] WHIP/WHEP builds carry no SCTP + +## Goal + +The vendored `sctp_proto` and str0m's SCTP glue compile only with +moq-webrtc's data-channel feature, so a WHIP/WHEP-only build has no SCTP +code in its tree. + +## Plan + +Planned 2026-11-07 (maintainer, /quest-complete), a follow-up of +[moq-dev/moq#8163](https://github.com/moq-dev/moq/pull/8163), which vendors +the stack but still compiles SCTP into every build. The epic's settled +decision ("SCTP stays ... but compiles only with the data-channel feature") +gets this owner. Gate the modules and the str0m paths that reach them, +and add a check, in the feature matrix `just rs features` runs, that a +build without the data-channel feature neither compiles nor links +`sctp_proto`. + +Public API: none. Wire: none. + +## Required + +- [Vendor and trim the stack](/quest/m1/webrtc-vendor.md) - vendors the SCTP modules this gates From 8f35b5599c3ffbbd25f86e03e82938b32e35b401 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 7 Nov 2026 14:15:24 -0800 Subject: [PATCH 2/3] quest: name p2p, keep the epic's settled removals, narrow the vendored allow first Co-Authored-By: Claude Opus 5.5 --- quest/m3/webrtc/README.md | 2 +- quest/m3/webrtc/browser-only.md | 5 ++++- quest/m3/webrtc/dead-api.md | 7 ++++--- quest/m3/webrtc/sctp-feature.md | 8 ++++---- 4 files changed, 13 insertions(+), 9 deletions(-) diff --git a/quest/m3/webrtc/README.md b/quest/m3/webrtc/README.md index 5481cd68f6e..115d3924edc 100644 --- a/quest/m3/webrtc/README.md +++ b/quest/m3/webrtc/README.md @@ -25,7 +25,7 @@ Decided 2026-10-30 with the maintainer (planning interview), after the str0m wor - [Several bandwidth lines per media section](/quest/m3/webrtc/sdp-bandwidth.md) - answers carry both `b=TIAS` and `b=AS` without splicing - [DTLS waits for ICE](/quest/m3/webrtc/dtls-after-ice.md) - DTLS flights start once ICE nominates a pair, so a late ICE path can't exhaust them - [The stack takes kio clock time](/quest/m3/webrtc/clock.md) - the vendored code takes `kio::clock::Instant`, so sim tests drive it directly -- [WHIP/WHEP builds carry no SCTP](/quest/m3/webrtc/sctp-feature.md) - SCTP compiles only with the data-channel feature +- [WHIP/WHEP builds carry no SCTP](/quest/m3/webrtc/sctp-feature.md) - SCTP compiles only with the `p2p` feature - [The vendored stack keeps only what browsers negotiate](/quest/m3/webrtc/browser-only.md) - PSK suites, `ccm`, and anything else no browser uses are gone - [The vendored stack exposes only what moq-webrtc calls](/quest/m3/webrtc/dead-api.md) - dead upstream API is deleted once rind and clock settle the seams diff --git a/quest/m3/webrtc/browser-only.md b/quest/m3/webrtc/browser-only.md index 25e71a1b226..8cde0f16601 100644 --- a/quest/m3/webrtc/browser-only.md +++ b/quest/m3/webrtc/browser-only.md @@ -16,7 +16,10 @@ now. Browser DTLS authenticates with certificates and fingerprints, never PSK. Inventory what Chrome, Firefox, and Safari offer and accept (cipher suites, extensions, SDP attributes, codecs' packetizers) against what the vendored code still carries, cite the evidence for each removal in the PR, -and keep what a browser negotiates even if MoQ doesn't call it yet. API +and keep what a browser negotiates even if MoQ doesn't call it yet. The +epic's settled removals (its "What goes" list, such as G.7xx, DTMF, and +comfort noise) and non-goals (TURN, DTLS 1.3) stay as decided: this trim +only removes more, never restores. API that moq-webrtc never calls but a browser could need stays for [the dead-API trim](/quest/m3/webrtc/dead-api.md). diff --git a/quest/m3/webrtc/dead-api.md b/quest/m3/webrtc/dead-api.md index 3bd1a2b0f0b..9d97a358e07 100644 --- a/quest/m3/webrtc/dead-api.md +++ b/quest/m3/webrtc/dead-api.md @@ -10,9 +10,10 @@ tests; dead upstream API is deleted. Planned 2026-11-07 (maintainer, /quest-complete), a follow-up of [moq-dev/moq#8163](https://github.com/moq-dev/moq/pull/8163). It waits on the rind and clock quests, since both reshape the seams moq-webrtc calls -through. Start from the compiler's dead-code report with the vendored -modules private, then remove what remains unreached, keeping upstream's -tests for what stays. +through. The vendored tree opens with `#![allow(warnings, reason = "vendored +upstream code")]` (`rs/moq-webrtc/src/vendor/mod.rs`), so first narrow that +allow to let `dead_code` fire, then delete what the report shows unreached, +keeping upstream's tests for what stays. Public API: none. Wire: none. diff --git a/quest/m3/webrtc/sctp-feature.md b/quest/m3/webrtc/sctp-feature.md index edd9e5c3145..58413977fa3 100644 --- a/quest/m3/webrtc/sctp-feature.md +++ b/quest/m3/webrtc/sctp-feature.md @@ -3,8 +3,8 @@ ## Goal The vendored `sctp_proto` and str0m's SCTP glue compile only with -moq-webrtc's data-channel feature, so a WHIP/WHEP-only build has no SCTP -code in its tree. +moq-webrtc's `p2p` feature (its data-channel transport), so a WHIP/WHEP-only +build has no SCTP code in its tree. ## Plan @@ -14,8 +14,8 @@ the stack but still compiles SCTP into every build. The epic's settled decision ("SCTP stays ... but compiles only with the data-channel feature") gets this owner. Gate the modules and the str0m paths that reach them, and add a check, in the feature matrix `just rs features` runs, that a -build without the data-channel feature neither compiles nor links -`sctp_proto`. +build without `p2p` neither compiles nor links `sctp_proto`. The feature +keeps its name. Public API: none. Wire: none. From 200e5ee64e4681eed947822d3fe392bf19712beb Mon Sep 17 00:00:00 2001 From: quest fixer Date: Sat, 7 Nov 2026 15:12:26 -0800 Subject: [PATCH 3/3] docs(quest): drop completed vendoring prerequisites --- quest/m3/webrtc/browser-only.md | 4 ---- quest/m3/webrtc/sctp-feature.md | 4 ---- 2 files changed, 8 deletions(-) diff --git a/quest/m3/webrtc/browser-only.md b/quest/m3/webrtc/browser-only.md index 8cde0f16601..ac4db052d24 100644 --- a/quest/m3/webrtc/browser-only.md +++ b/quest/m3/webrtc/browser-only.md @@ -24,7 +24,3 @@ that moq-webrtc never calls but a browser could need stays for [the dead-API trim](/quest/m3/webrtc/dead-api.md). Public API: none. Wire: none toward browsers. - -## Required - -- [Vendor and trim the stack](/quest/m1/webrtc-vendor.md) - the vendored code this trims diff --git a/quest/m3/webrtc/sctp-feature.md b/quest/m3/webrtc/sctp-feature.md index 58413977fa3..02b8c14253b 100644 --- a/quest/m3/webrtc/sctp-feature.md +++ b/quest/m3/webrtc/sctp-feature.md @@ -18,7 +18,3 @@ build without `p2p` neither compiles nor links `sctp_proto`. The feature keeps its name. Public API: none. Wire: none. - -## Required - -- [Vendor and trim the stack](/quest/m1/webrtc-vendor.md) - vendors the SCTP modules this gates