From e5b516850e9659a35cc771fcd163ef5376448f56 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 7 Nov 2026 08:15:17 -0800 Subject: [PATCH 01/12] chore(quest): claim quest/m0/interop-green/README.md Quest-Claim: ff96dd6e1d90829f From 9349f7f79c2299b8d78d18c40b3ad5a9bd95d5f3 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 7 Nov 2026 08:16:36 -0800 Subject: [PATCH 02/12] test(interop): the invalid-attribute check tests lookahead, not the renamed buffer Scheduled Interop run 42382888974 failed only on this stale case. Co-Authored-By: Claude Opus 5.5 --- quest/m0/interop-green/README.md | 9 ++++++++ test/interop/clients/js/publish-ui.browser.ts | 22 ++++++++++++++++++- 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/quest/m0/interop-green/README.md b/quest/m0/interop-green/README.md index c49128639f8..239aea65216 100644 --- a/quest/m0/interop-green/README.md +++ b/quest/m0/interop-green/README.md @@ -93,4 +93,13 @@ this quest's PR: `moq-lite-07-wip` planned break stale again; remeasured, with the same 16 cells failing. +Scheduled run +[42382888974](https://github.com/moq-dev/moq/actions/runs/42382888974) +(2026-11-07, at b98833c40a, after those fixes landed) failed only Harness +regressions: `publish-ui.browser.ts`'s invalid-attribute check still tested +moq-watch's `buffer`, which +[moq-dev/moq#8057](https://github.com/moq-dev/moq/pull/8057) renamed to +`lookahead`. Fixed in this quest's PR: the case tests `lookahead`, and a new +check confirms `buffer` reports its rename and recovers once removed. + Public API: none. Wire: none. diff --git a/test/interop/clients/js/publish-ui.browser.ts b/test/interop/clients/js/publish-ui.browser.ts index 16a245b59c2..2a69c46ef11 100644 --- a/test/interop/clients/js/publish-ui.browser.ts +++ b/test/interop/clients/js/publish-ui.browser.ts @@ -1072,7 +1072,7 @@ test("invalid attributes and properties refuse, retain bad markup, and recover", ["moq-watch", "backend", "gpu", "backend", "auto"], ["moq-watch", "visible", "sometimes", "visible", "never"], ["moq-watch", "delay", "30", "delay", "instant"], - ["moq-watch", "buffer", "30", "buffer", 0], + ["moq-watch", "lookahead", "30", "lookahead", 0], ["moq-watch", "catalog-format", "guess", "catalogFormat", "manual"], ["moq-publish", "source", "monitor", "source", undefined], ["moq-publish", "preview", "mse", "preview", "none"], @@ -1104,6 +1104,26 @@ test("invalid attributes and properties refuse, retain bad markup, and recover", }); for (const result of results) expect(result).toEqual({ ...result, refused: true, threw: true, recovered: true }); + // `buffer` was renamed to `lookahead`: the old attribute reports the rename until removed. + const renamedBuffer = await page.evaluate(() => { + const errors: string[] = []; + const listener = (event: ErrorEvent) => { + errors.push(event.message); + event.preventDefault(); + }; + window.addEventListener("error", listener); + const watch = document.createElement("moq-watch"); + watch.setAttribute("buffer", "30s"); + document.body.append(watch); + const refused = !watch.connection.enabled.peek() && errors.some((error) => error.includes("lookahead")); + watch.removeAttribute("buffer"); + const recovered = watch.connection.enabled.peek(); + watch.remove(); + watch.signals.close(); + window.removeEventListener("error", listener); + return { refused, recovered }; + }); + expect(renamedBuffer).toEqual({ refused: true, recovered: true }); const blocked = await page.evaluate(() => { const watch = document.createElement("moq-watch"); watch.setAttribute("backend", "bad"); From bbc7734e1d1020a5d9fd48b64a17db6c5005b0c2 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sun, 8 Nov 2026 23:31:00 -0800 Subject: [PATCH 03/12] chore(quest): claim quest/m0/interop-green/README.md Quest-Claim: 51c38bbe14598f4f From 8acdc47c001643f53ee351f24d67240707b8786c Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Mon, 9 Nov 2026 00:05:33 -0800 Subject: [PATCH 04/12] quest: triage the Nov 8 Interop failures to the JS route port Run 42491651687 failed two steps. Both come from the JS lite-07 route wire, which Rust moved to and JS has not ported, so neither is a flake: the datagram test fails on main's content, and the media replacement case crashes its pages. moq-dev/moq#8290 skips both, and the scheduled wait now says so. Co-Authored-By: Claude Haiku 5.5 --- quest/m0/interop-green/README.md | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/quest/m0/interop-green/README.md b/quest/m0/interop-green/README.md index 239aea65216..06c6b289ab3 100644 --- a/quest/m0/interop-green/README.md +++ b/quest/m0/interop-green/README.md @@ -12,7 +12,11 @@ so it only needs to stay green. - moq-dev/moq: a scheduled Interop run on `main` passes. Check with `gh run list --repo moq-dev/moq --workflow interop.yml --event schedule`. - Triage any red run, then delete this quest once one passes. + Triage any red run, then delete this quest once one passes. Its pass skips + the datagram and replacement cases until + [routes/js.md](/quest/m2/cluster-routing/routes/js.md) lands, as + [moq-dev/moq#8290](https://github.com/moq-dev/moq/pull/8290) set; delete on + that pass only if those skips stay accepted. ## Plan @@ -102,4 +106,28 @@ moq-watch's `buffer`, which `lookahead`. Fixed in this quest's PR: the case tests `lookahead`, and a new check confirms `buffer` reports its rename and recovers once removed. +Scheduled run +[42491651687](https://github.com/moq-dev/moq/actions/runs/42491651687) +(2026-11-08, at e2271bad9c) failed two steps, and neither is a flake. Both come +from the JS lite-07 route wire, which Rust moved to but JS has not ported, so +they are owned by [routes/js.md](/quest/m2/cluster-routing/routes/js.md), not +this quest: + +- Datagram tracks: `datagram_tracks_javascript` times out in its first case + (relay false, JS publishes false). It fails every time on main's content + (`just test datagram-tracks`), not under load. +- Media output and lifecycle: chromium's `replacement` case crashes both + moq-lite-07-wip pages with `page crashed`. It fails every time on main's + content (`just test media --media-cases replacement`), though it passed on an + older base. + +[moq-dev/moq#8290](https://github.com/moq-dev/moq/pull/8290) skipped the +datagram step and quarantined `replacement` by default, which this quest's +triage confirms. On main's content, `just test media` passes; the datagram test +still fails until the port lands. No new quest or retry is needed here. + Public API: none. Wire: none. + +## Related + +- [The JS lite-07 route port](/quest/m2/cluster-routing/routes/js.md) - ports the JS route wire, which restores the datagram step and the `replacement` case From d145c3396e04a0c3f1095b559abc1bf1b68a6901 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Mon, 9 Nov 2026 00:06:37 -0800 Subject: [PATCH 05/12] quest: close interop-green on a scheduled pass with the route-wire cases skipped The maintainer accepted the recommendation while AFK: a scheduled Interop pass with the datagram and replacement cases skipped closes this quest, since routes/js.md tracks restoring them. Co-Authored-By: Claude Haiku 5.5 --- quest/m0/interop-green/README.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/quest/m0/interop-green/README.md b/quest/m0/interop-green/README.md index 06c6b289ab3..32a92ed5686 100644 --- a/quest/m0/interop-green/README.md +++ b/quest/m0/interop-green/README.md @@ -15,8 +15,9 @@ so it only needs to stay green. Triage any red run, then delete this quest once one passes. Its pass skips the datagram and replacement cases until [routes/js.md](/quest/m2/cluster-routing/routes/js.md) lands, as - [moq-dev/moq#8290](https://github.com/moq-dev/moq/pull/8290) set; delete on - that pass only if those skips stay accepted. + [moq-dev/moq#8290](https://github.com/moq-dev/moq/pull/8290) set. Decided + 2026-11-09 (maintainer, AFK, accepting the recommendation): close this quest + on that pass, because routes/js.md tracks restoring those cases. ## Plan From 5af2eb8da07030342c6c41ca89f624c2b16d4716 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Wed, 11 Nov 2026 23:03:01 -0800 Subject: [PATCH 06/12] quest: triage the Nov 9 to 11 Interop failures and name the stale-pin owner Runs 42673842120, 42851744235, and 43052960736 failed the staging fixture (a cargo tree stub), the invalid-attribute lookahead case, and a stale planned-break pin. Each code cause is fixed on main by #8455 and #8512. The remaining recurring cause is the pin itself, which the release cut remeasures after each publish, so the wait now names that owner. Co-Authored-By: Claude Haiku 5.5 --- quest/m0/interop-green/README.md | 34 ++++++++++++++++++++++++++++---- 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/quest/m0/interop-green/README.md b/quest/m0/interop-green/README.md index 32a92ed5686..c229222bd04 100644 --- a/quest/m0/interop-green/README.md +++ b/quest/m0/interop-green/README.md @@ -12,12 +12,15 @@ so it only needs to stay green. - moq-dev/moq: a scheduled Interop run on `main` passes. Check with `gh run list --repo moq-dev/moq --workflow interop.yml --event schedule`. - Triage any red run, then delete this quest once one passes. Its pass skips - the datagram and replacement cases until - [routes/js.md](/quest/m2/cluster-routing/routes/js.md) lands, as + Then delete this quest. Its pass skips the datagram and replacement cases + until [routes/js.md](/quest/m2/cluster-routing/routes/js.md) lands, as [moq-dev/moq#8290](https://github.com/moq-dev/moq/pull/8290) set. Decided 2026-11-09 (maintainer, AFK, accepting the recommendation): close this quest - on that pass, because routes/js.md tracks restoring those cases. + on that pass, because routes/js.md tracks restoring those cases. A red run + whose only failure is a stale planned break is not triage: the release + procedure's remeasure owns it, as [the release cut](/quest/m3/release/cut.md) + says. Run `just test wire-compat --remeasure` on `main` and land the + rewritten `test/interop/compat/planned-breaks.json`. ## Plan @@ -127,6 +130,29 @@ datagram step and quarantined `replacement` by default, which this quest's triage confirms. On main's content, `just test media` passes; the datagram test still fails until the port lands. No new quest or retry is needed here. +Scheduled run +[42673842120](https://github.com/moq-dev/moq/actions/runs/42673842120) +(2026-11-09) and +[42851744235](https://github.com/moq-dev/moq/actions/runs/42851744235) +(2026-11-10) failed Harness regressions and Released wire compatibility. The +staging fixture's fake `cargo` lacked `tree`, which `test/interop/compat.sh` +calls, so its test exited 2; [moq-dev/moq#8455](https://github.com/moq-dev/moq/pull/8455) +stubs it. The planned break's pin, moq-cli 0.14.14, went stale when 0.14.15 +shipped. + +Scheduled run +[43052960736](https://github.com/moq-dev/moq/actions/runs/43052960736) +(2026-11-11, at a4bc922c6) failed the same two steps. The invalid-attribute +browser case restored `lookahead` to the number `0` after its `try` block, +which the setter refuses, so the evaluate threw. +[moq-dev/moq#8512](https://github.com/moq-dev/moq/pull/8512) passes the page's +own Duration and remeasures the pin to moq-cli 0.14.16. + +`main` at d3b6c2573 has both fixes, and every pin matches the latest release of +its package (moq-cli 0.14.16, moq-relay 0.17.16, @moq/net 0.4.7). The stale pin +is the recurring cause: each published release of a pinned package turns the +next scheduled run red until someone remeasures. + Public API: none. Wire: none. ## Related From 8a64d1530f9bb58a3eb0e53f26abe22eb086a9eb Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Wed, 11 Nov 2026 23:15:04 -0800 Subject: [PATCH 07/12] quest: the release pipeline re-measures planned breaks Maintainer decision, 2026-11-11: the release pipeline runs `just test wire-compat --remeasure` and lands the rewritten planned-breaks.json with each release, instead of a manual post-publish step. Adds the follow-up quest, has the release cut require it, and points the Interop wait's stale-pin rule at it. Co-Authored-By: Claude Haiku 5.5 --- quest/m0/interop-green/README.md | 13 ++++---- quest/m3/release/cut.md | 7 +++-- quest/m3/release/planned-break-remeasure.md | 33 +++++++++++++++++++++ 3 files changed, 45 insertions(+), 8 deletions(-) create mode 100644 quest/m3/release/planned-break-remeasure.md diff --git a/quest/m0/interop-green/README.md b/quest/m0/interop-green/README.md index c229222bd04..4326e8c156c 100644 --- a/quest/m0/interop-green/README.md +++ b/quest/m0/interop-green/README.md @@ -10,17 +10,18 @@ so it only needs to stay green. ## Waiting -- moq-dev/moq: a scheduled Interop run on `main` passes. Check with - `gh run list --repo moq-dev/moq --workflow interop.yml --event schedule`. +- moq-dev/moq: the next scheduled Interop run on `main` (the first after + [moq-dev/moq#8455](https://github.com/moq-dev/moq/pull/8455) and + [moq-dev/moq#8512](https://github.com/moq-dev/moq/pull/8512)) passes. Check + with `gh run list --repo moq-dev/moq --workflow interop.yml --event schedule`. Then delete this quest. Its pass skips the datagram and replacement cases until [routes/js.md](/quest/m2/cluster-routing/routes/js.md) lands, as [moq-dev/moq#8290](https://github.com/moq-dev/moq/pull/8290) set. Decided 2026-11-09 (maintainer, AFK, accepting the recommendation): close this quest on that pass, because routes/js.md tracks restoring those cases. A red run - whose only failure is a stale planned break is not triage: the release - procedure's remeasure owns it, as [the release cut](/quest/m3/release/cut.md) - says. Run `just test wire-compat --remeasure` on `main` and land the - rewritten `test/interop/compat/planned-breaks.json`. + whose only failure is a stale planned break is not triage: the + [planned-break remeasure](/quest/m3/release/planned-break-remeasure.md) + owns it, and the release pipeline runs that remeasure with each release. ## Plan diff --git a/quest/m3/release/cut.md b/quest/m3/release/cut.md index 4d2bb737943..6d839294657 100644 --- a/quest/m3/release/cut.md +++ b/quest/m3/release/cut.md @@ -30,8 +30,10 @@ its unpublished 0.6.0 (decided 2026-11-01). Run candidate compatibility, draft, package, and all-language interop checks, and verify publication outcomes. Separate artifact install proofs and package-specific tags follow this cut. This planning PR cuts and publishes nothing. -After publication, re-measure the planned wire-compat breaks against the -published versions, as CONTRIBUTING.md's release procedure describes. +After publication, the release pipeline re-measures the planned wire-compat +breaks against the published versions and lands the rewritten +`planned-breaks.json`, per [planned-break remeasure](/quest/m3/release/planned-break-remeasure.md) +(decided 2026-11-11). Nobody runs that step by hand. This cut carries stats epochs, so it drops [#4810](https://github.com/moq-dev/moq/pull/4810)'s release-only wall-clock @@ -141,3 +143,4 @@ with the suites above. - [Cargo feature review](/quest/m3/release/feature-flags.md) - every Cargo feature was judged against the feature rules, and approved changes landed - [Cycle phases](/quest/m3/release/cycle-phases.md) - the shift this cut performs sorts by additive, API and wire, and its recurrence is rewritten to match - [Claim new npm names](/quest/m3/release/npm-first-publish.md) - trusted publishing can publish every new `@moq/*` package +- [Planned-break remeasure](/quest/m3/release/planned-break-remeasure.md) - the release pipeline re-measures the planned wire-compat breaks and lands their file with each release, which the post-publish step relies on diff --git a/quest/m3/release/planned-break-remeasure.md b/quest/m3/release/planned-break-remeasure.md new file mode 100644 index 00000000000..79d5e051487 --- /dev/null +++ b/quest/m3/release/planned-break-remeasure.md @@ -0,0 +1,33 @@ +# [M] Re-measure planned breaks in the release pipeline + +## Goal + +Each release that publishes a package a planned break pins (moq-cli, +moq-relay, `@moq/net`) re-measures those pins against the published versions +and lands the rewritten `test/interop/compat/planned-breaks.json` on `main` +with the release. No scheduled Interop run goes red on a stale pin, and no one +runs the remeasure by hand. + +## Plan + +Decided 2026-11-11 (maintainer), after moq-cli 0.14.15 and 0.14.16 each made +the `moq-lite-07-wip` pin stale and the scheduled Interop runs on Nov 9 to 11 +went red on it: + +- ✅ the release pipeline runs `just test wire-compat --remeasure` and lands the rewritten `test/interop/compat/planned-breaks.json` with the release (rejected: keep the manual post-publish step; warn on stale pins in scheduled runs). + +The job runs after the publish jobs for the three packages the planned-breaks +file pins, in the workflows that publish from `release` (`.github/workflows/release-*.yml`). +It re-measures the pins against the versions just published and lands the +rewritten file on `main`, which CONTRIBUTING.md's release procedure does by +hand today. Check `main`'s ruleset first: where it requires a pull request, the +job opens one. Its write credentials go in an environment limited to protected +branches. + +Verify it by running the job on its own against the current pins (moq-cli +0.14.16, moq-relay 0.17.16, `@moq/net` 0.4.7). It should reproduce the file +with no diff. + +The same PR updates CONTRIBUTING.md's release bullet, which says to run the +remeasure by hand, to name the job. The nightly wire-compat check keeps +running as it does now. From 6667d4a107ae207d5c217677e6ad275d6082868a Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Wed, 11 Nov 2026 23:23:42 -0800 Subject: [PATCH 08/12] quest: the release-remeasure pipeline is a child of the Interop epic Maintainer decided 2026-11-12 that the planned-break remeasure is a child of quest/m0/interop-green/, since stale pins caused four of the last six red scheduled Interop runs. The release cut keeps its manual post-publish remeasure until that child lands, and does not require it. - Move quest/m3/release/planned-break-remeasure.md under quest/m0/interop-green/ - The Interop README becomes an epic: drop its size, wait on the child, and restore the manual remeasure as the interim fallback in its Waiting item - cut.md keeps the manual step, links the child as its replacement, and drops its Required entry Co-Authored-By: Claude Haiku 5.5 --- quest/m0/interop-green/README.md | 23 +++++++++++++------ .../interop-green}/planned-break-remeasure.md | 5 ++++ quest/m3/release/cut.md | 10 ++++---- 3 files changed, 26 insertions(+), 12 deletions(-) rename quest/{m3/release => m0/interop-green}/planned-break-remeasure.md (75%) diff --git a/quest/m0/interop-green/README.md b/quest/m0/interop-green/README.md index 4326e8c156c..a4c2048f8eb 100644 --- a/quest/m0/interop-green/README.md +++ b/quest/m0/interop-green/README.md @@ -1,4 +1,4 @@ -# [XS] Interop and Video pass on main +# Interop and Video pass on main ## Goal @@ -14,17 +14,26 @@ so it only needs to stay green. [moq-dev/moq#8455](https://github.com/moq-dev/moq/pull/8455) and [moq-dev/moq#8512](https://github.com/moq-dev/moq/pull/8512)) passes. Check with `gh run list --repo moq-dev/moq --workflow interop.yml --event schedule`. - Then delete this quest. Its pass skips the datagram and replacement cases - until [routes/js.md](/quest/m2/cluster-routing/routes/js.md) lands, as + Its pass skips the datagram and replacement cases until + [routes/js.md](/quest/m2/cluster-routing/routes/js.md) lands, as [moq-dev/moq#8290](https://github.com/moq-dev/moq/pull/8290) set. Decided 2026-11-09 (maintainer, AFK, accepting the recommendation): close this quest - on that pass, because routes/js.md tracks restoring those cases. A red run - whose only failure is a stale planned break is not triage: the - [planned-break remeasure](/quest/m3/release/planned-break-remeasure.md) - owns it, and the release pipeline runs that remeasure with each release. + on that pass, because routes/js.md tracks restoring those cases. Decided + 2026-11-12 (maintainer): this epic also waits for its + [planned-break remeasure](/quest/m0/interop-green/planned-break-remeasure.md) + child, so the pass closes the epic only once that child lands too. Until then, + a red run whose only failure is a stale planned break is fixed by hand: run + `just test wire-compat --remeasure` and land the rewritten + `test/interop/compat/planned-breaks.json`, as CONTRIBUTING.md's release + procedure describes. ## Plan +Decided 2026-11-12 (maintainer), since green scheduled Interop is this epic's goal and stale pins caused four of the last six red runs: + +- ✅ the release-remeasure pipeline is a child quest of quest/m0/interop-green/ (rejected: quest/m3/release/; drop the follow-up). See [planned-break remeasure](/quest/m0/interop-green/planned-break-remeasure.md). +- ✅ the release cut keeps its manual post-publish `just test wire-compat --remeasure` step until that child lands, and does not require it (rejected: block the cut on the new quest; accept a red Interop run per release). + Decided 2026-10-27 (maintainer), from an external release-to-main audit and a triage of Interop runs [40517499786](https://github.com/moq-dev/moq/actions/runs/40517499786), diff --git a/quest/m3/release/planned-break-remeasure.md b/quest/m0/interop-green/planned-break-remeasure.md similarity index 75% rename from quest/m3/release/planned-break-remeasure.md rename to quest/m0/interop-green/planned-break-remeasure.md index 79d5e051487..f490c11c6eb 100644 --- a/quest/m3/release/planned-break-remeasure.md +++ b/quest/m0/interop-green/planned-break-remeasure.md @@ -16,6 +16,11 @@ went red on it: - ✅ the release pipeline runs `just test wire-compat --remeasure` and lands the rewritten `test/interop/compat/planned-breaks.json` with the release (rejected: keep the manual post-publish step; warn on stale pins in scheduled runs). +Decided 2026-11-12 (maintainer), since stale pins caused four of the last six red scheduled Interop runs. This quest is a child of the [Interop epic](/quest/m0/interop-green/README.md): + +- ✅ the release-remeasure pipeline is a child quest of quest/m0/interop-green/ (rejected: quest/m3/release/; drop the follow-up). +- ✅ the release cut keeps its manual post-publish `just test wire-compat --remeasure` step until this quest lands, and does not require it (rejected: block the cut on this quest; accept a red Interop run per release). + The job runs after the publish jobs for the three packages the planned-breaks file pins, in the workflows that publish from `release` (`.github/workflows/release-*.yml`). It re-measures the pins against the versions just published and lands the diff --git a/quest/m3/release/cut.md b/quest/m3/release/cut.md index 6d839294657..d391107facf 100644 --- a/quest/m3/release/cut.md +++ b/quest/m3/release/cut.md @@ -30,10 +30,11 @@ its unpublished 0.6.0 (decided 2026-11-01). Run candidate compatibility, draft, package, and all-language interop checks, and verify publication outcomes. Separate artifact install proofs and package-specific tags follow this cut. This planning PR cuts and publishes nothing. -After publication, the release pipeline re-measures the planned wire-compat -breaks against the published versions and lands the rewritten -`planned-breaks.json`, per [planned-break remeasure](/quest/m3/release/planned-break-remeasure.md) -(decided 2026-11-11). Nobody runs that step by hand. +After publication, re-measure the planned wire-compat breaks against the +published versions, as CONTRIBUTING.md's release procedure describes. Until the +[planned-break remeasure](/quest/m0/interop-green/planned-break-remeasure.md) +moves that step into the release pipeline (decided 2026-11-11), run it by hand; +the cut does not wait on that quest (decided 2026-11-12). This cut carries stats epochs, so it drops [#4810](https://github.com/moq-dev/moq/pull/4810)'s release-only wall-clock @@ -143,4 +144,3 @@ with the suites above. - [Cargo feature review](/quest/m3/release/feature-flags.md) - every Cargo feature was judged against the feature rules, and approved changes landed - [Cycle phases](/quest/m3/release/cycle-phases.md) - the shift this cut performs sorts by additive, API and wire, and its recurrence is rewritten to match - [Claim new npm names](/quest/m3/release/npm-first-publish.md) - trusted publishing can publish every new `@moq/*` package -- [Planned-break remeasure](/quest/m3/release/planned-break-remeasure.md) - the release pipeline re-measures the planned wire-compat breaks and lands their file with each release, which the post-publish step relies on From a25a2701b1eaae9bdca947dfdfc852a0aee0ea69 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 12 Nov 2026 12:57:48 -0800 Subject: [PATCH 09/12] quest: triage the Nov 12 Interop run into a resume-sync child The run's media pause case fails since #8507 keeps resumed audio stretched back over seconds. The fix is a maintainer call, so it is a child quest. The README drops the stale routes/js.md skip, since #8443 landed that port, and RELEASE.md replaces CONTRIBUTING.md for the release procedure. Co-Authored-By: Claude Haiku 5.5 --- quest/m0/interop-green/README.md | 50 +++++++++++++------ .../interop-green/planned-break-remeasure.md | 4 +- quest/m0/interop-green/resume-sync.md | 30 +++++++++++ 3 files changed, 67 insertions(+), 17 deletions(-) create mode 100644 quest/m0/interop-green/resume-sync.md diff --git a/quest/m0/interop-green/README.md b/quest/m0/interop-green/README.md index a4c2048f8eb..7f5c1de970d 100644 --- a/quest/m0/interop-green/README.md +++ b/quest/m0/interop-green/README.md @@ -10,21 +10,22 @@ so it only needs to stay green. ## Waiting -- moq-dev/moq: the next scheduled Interop run on `main` (the first after - [moq-dev/moq#8455](https://github.com/moq-dev/moq/pull/8455) and - [moq-dev/moq#8512](https://github.com/moq-dev/moq/pull/8512)) passes. Check - with `gh run list --repo moq-dev/moq --workflow interop.yml --event schedule`. - Its pass skips the datagram and replacement cases until - [routes/js.md](/quest/m2/cluster-routing/routes/js.md) lands, as - [moq-dev/moq#8290](https://github.com/moq-dev/moq/pull/8290) set. Decided - 2026-11-09 (maintainer, AFK, accepting the recommendation): close this quest - on that pass, because routes/js.md tracks restoring those cases. Decided +- moq-dev/moq: the next scheduled Interop run on `main` passes, once + [moq-dev/moq#8572](https://github.com/moq-dev/moq/pull/8572) merges and the + [resumed-audio child](/quest/m0/interop-green/resume-sync.md) lands. Check + with `gh run list --repo moq-dev/moq --workflow interop.yml --event schedule`, + then the run's STEPS summary. The JS route port that [moq-dev/moq#8290](https://github.com/moq-dev/moq/pull/8290) + waited on landed in [moq-dev/moq#8443](https://github.com/moq-dev/moq/pull/8443), + so the pass now runs the datagram step; the `replacement` case stays + quarantined by default. Decided 2026-11-09 (maintainer, AFK, accepting the + recommendation): close this quest on a pass, which the maintainer set with + those cases skipped; the pass that closes it now runs them. Decided 2026-11-12 (maintainer): this epic also waits for its [planned-break remeasure](/quest/m0/interop-green/planned-break-remeasure.md) child, so the pass closes the epic only once that child lands too. Until then, a red run whose only failure is a stale planned break is fixed by hand: run `just test wire-compat --remeasure` and land the rewritten - `test/interop/compat/planned-breaks.json`, as CONTRIBUTING.md's release + `test/interop/compat/planned-breaks.json`, as RELEASE.md's release procedure describes. ## Plan @@ -124,8 +125,8 @@ Scheduled run [42491651687](https://github.com/moq-dev/moq/actions/runs/42491651687) (2026-11-08, at e2271bad9c) failed two steps, and neither is a flake. Both come from the JS lite-07 route wire, which Rust moved to but JS has not ported, so -they are owned by [routes/js.md](/quest/m2/cluster-routing/routes/js.md), not -this quest: +they were owned by the JS route port, which landed as +[moq-dev/moq#8443](https://github.com/moq-dev/moq/pull/8443), not this quest: - Datagram tracks: `datagram_tracks_javascript` times out in its first case (relay false, JS publishes false). It fails every time on main's content @@ -163,8 +164,27 @@ its package (moq-cli 0.14.16, moq-relay 0.17.16, @moq/net 0.4.7). The stale pin is the recurring cause: each published release of a pinned package turns the next scheduled run red until someone remeasures. -Public API: none. Wire: none. +Scheduled run +[43260674067](https://github.com/moq-dev/moq/actions/runs/43260674067) +(2026-11-12, at e9c6df852) failed three steps, each with its own cause: + +- Optional publisher retention: `max_age_relay_javascript` fails on lite-07 + track 1, which reads a max age of 0 where the test expects none. Bisected to + [moq-dev/moq#8443](https://github.com/moq-dev/moq/pull/8443), whose parent + passes; its diff has no max-age code, so the mechanism is not traced yet. + [moq-dev/moq#8572](https://github.com/moq-dev/moq/pull/8572) changes the test + to expect lite-07 to carry the max age, and is open. +- Interop (full matrix): `go -> python` fails with `audio gap after 648 samples` + at 2 s of 30 s. It passed once locally. No open PR names this cell; + [moq-dev/moq#8587](https://github.com/moq-dev/moq/pull/8587) covers `python -> go`. +- Media output and lifecycle: after the pause case resumes, the audio trails the + picture by about 1.7 s. [moq-dev/moq#8507](https://github.com/moq-dev/moq/pull/8507) + keeps audio that trails the clock up to its 2 s stretch bound and plays it + faster, and a resume keeps the ring it had. Fixed by the child + [resumed audio snaps to the clock](/quest/m0/interop-green/resume-sync.md), + which waits on a maintainer decision. + +The 11-11 run, before #8507, passed all three steps. -## Related +Public API: none. Wire: none. -- [The JS lite-07 route port](/quest/m2/cluster-routing/routes/js.md) - ports the JS route wire, which restores the datagram step and the `replacement` case diff --git a/quest/m0/interop-green/planned-break-remeasure.md b/quest/m0/interop-green/planned-break-remeasure.md index f490c11c6eb..7f38fa349c9 100644 --- a/quest/m0/interop-green/planned-break-remeasure.md +++ b/quest/m0/interop-green/planned-break-remeasure.md @@ -24,7 +24,7 @@ Decided 2026-11-12 (maintainer), since stale pins caused four of the last six re The job runs after the publish jobs for the three packages the planned-breaks file pins, in the workflows that publish from `release` (`.github/workflows/release-*.yml`). It re-measures the pins against the versions just published and lands the -rewritten file on `main`, which CONTRIBUTING.md's release procedure does by +rewritten file on `main`, which RELEASE.md's release procedure does by hand today. Check `main`'s ruleset first: where it requires a pull request, the job opens one. Its write credentials go in an environment limited to protected branches. @@ -33,6 +33,6 @@ Verify it by running the job on its own against the current pins (moq-cli 0.14.16, moq-relay 0.17.16, `@moq/net` 0.4.7). It should reproduce the file with no diff. -The same PR updates CONTRIBUTING.md's release bullet, which says to run the +The same PR updates RELEASE.md's release bullet, which says to run the remeasure by hand, to name the job. The nightly wire-compat check keeps running as it does now. diff --git a/quest/m0/interop-green/resume-sync.md b/quest/m0/interop-green/resume-sync.md new file mode 100644 index 00000000000..8f5917c6816 --- /dev/null +++ b/quest/m0/interop-green/resume-sync.md @@ -0,0 +1,30 @@ +# [S] Resumed audio snaps to the clock + +## Goal + +A viewer that pauses and resumes hears its audio in sync with the picture from the first frame, as it did before [moq-dev/moq#8507](https://github.com/moq-dev/moq/pull/8507). So `just test media`'s pause and rejoin steps pass on every run, and a resumed viewer is not seconds behind for the stretch to catch up. Audio that falls behind because of network delay still catches up by playing faster; that is #8507's stretch and stays. + +Not in scope: the JS max-age expectation ([#8572](https://github.com/moq-dev/moq/pull/8572)) and the `go -> python` media cell. + +## Plan + +Found by the triage of scheduled Interop run [43260674067](https://github.com/moq-dev/moq/actions/runs/43260674067) (2026-11-12, head e9c6df852). Its `Media output and lifecycle` step failed on the pause case: `audio tone: after resume: 70/81 samples` in CI, and locally `audio/video sync: after resume: 0/79 samples within 200ms, median skew 600ms`. The 11-11 run, before #8507, passed that step. + +Cause: #8507 keeps audio that trails the shared clock by up to the stretch's 2 s bound and plays it faster to catch up (`js/watch/src/audio/ring-buffer.ts` `read`, bound from `js/watch/src/audio/latency.ts` `bound`). Before it, the ring skipped whatever trailed the clock. A return from pause resubscribes to the same broadcast instance, so `js/watch/src/audio/decoder.ts` keeps the predecessor's ring without a join. The resumed picture lands on the live edge, and the audio that trails it by about 1.7 s is stretched back over about 5 s. + +Evidence, `just test media --media-cases pause` in `test/interop/clients/js/media.ts`: + +- `main` at 18fc33ecc: 3 of 4 runs fail the resume sync (median skew 200 ms, or 0 of 79 in sync). +- Parent of #8507 (ac73d9e0b): passes, median skew 0 ms (one run). +- Experiment, not committed: a same-instance resubscribe calls the decoder's `reset()`, so the ring joins the clock again. 4 of 4 runs pass, median skew 0 ms. One full `just test media` run also passed the pause and rejoin steps, then failed the later `live incumbent fallback` case, which was not investigated. + +Recommendation: re-join the ring when a viewer returns from absence on the same instance, so resumed audio lands on the clock the way a tune-in does, and keep the 2 s bound for stalls. Rejected: relax the resume assertion. `js/watch/AGENTS.md` says to judge a player change by its lag first, and the lip sync this stretch was built to fix (#8031) is what a stretch-back costs. + +Open for the implementer: + +- Scope the re-join to a return from absence. The handover path (`#handover` in `decoder.ts`) also inherits the ring for a rendition swap and a fallback, which should keep their seamless handover. Check the fallback case. +- Native parity: `moq play` pauses through `rs/moq-audio`. Check whether its ring inherits the same way; `just test media` does not cover it. + +## Waiting + +- Maintainer: decide whether a resumed viewer's audio snaps to the clock or plays faster to catch up over about 5 s with #8507's stretch. Recommended: snap, as in the Plan, because the stretch-back is seconds of lip-sync loss. Choosing the stretch-back means relaxing the media test's resume assertion. Check: `just test media --media-cases pause` passes four runs in a row. From 9bc0f12f61e953fe2f43ff07b091604f94d6528d Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 12 Nov 2026 13:07:25 -0800 Subject: [PATCH 10/12] quest: trace the max-age failure to #8443's test change, and bound the media evidence Co-Authored-By: Claude Opus 5.5 --- quest/m0/interop-green/README.md | 18 ++++++++++++------ quest/m0/interop-green/resume-sync.md | 2 +- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/quest/m0/interop-green/README.md b/quest/m0/interop-green/README.md index 7f5c1de970d..5d8f4b6b703 100644 --- a/quest/m0/interop-green/README.md +++ b/quest/m0/interop-green/README.md @@ -169,13 +169,19 @@ Scheduled run (2026-11-12, at e9c6df852) failed three steps, each with its own cause: - Optional publisher retention: `max_age_relay_javascript` fails on lite-07 - track 1, which reads a max age of 0 where the test expects none. Bisected to - [moq-dev/moq#8443](https://github.com/moq-dev/moq/pull/8443), whose parent - passes; its diff has no max-age code, so the mechanism is not traced yet. - [moq-dev/moq#8572](https://github.com/moq-dev/moq/pull/8572) changes the test - to expect lite-07 to carry the max age, and is open. + track 1, which reads a max age of 0 where the test expects none. + [moq-dev/moq#8443](https://github.com/moq-dev/moq/pull/8443) added + `moq-lite-07-wip` back to `max_age_relay_javascript` in `max_age.rs`, but the + JS subscriber kept its moq-transport-only expectation of no max age; lite + carries it, as the Rust side of the test expects. + [moq-dev/moq#8572](https://github.com/moq-dev/moq/pull/8572) fixes the + expectation, and is open. - Interop (full matrix): `go -> python` fails with `audio gap after 648 samples` - at 2 s of 30 s. It passed once locally. No open PR names this cell; + at 2 s of 30 s. It passed once locally, and 8 more local runs of + `--publishers go --subscribers python,rust,go` passed every cell. A lead, not + checked: [moq-dev/moq#8531](https://github.com/moq-dev/moq/pull/8531) now waits on + a missing group in moq-audio only for the playout delay, which is small at a + cold start, so a reordered group early on reads as a gap. No open PR names this cell; [moq-dev/moq#8587](https://github.com/moq-dev/moq/pull/8587) covers `python -> go`. - Media output and lifecycle: after the pause case resumes, the audio trails the picture by about 1.7 s. [moq-dev/moq#8507](https://github.com/moq-dev/moq/pull/8507) diff --git a/quest/m0/interop-green/resume-sync.md b/quest/m0/interop-green/resume-sync.md index 8f5917c6816..0b7cd51b33a 100644 --- a/quest/m0/interop-green/resume-sync.md +++ b/quest/m0/interop-green/resume-sync.md @@ -15,7 +15,7 @@ Cause: #8507 keeps audio that trails the shared clock by up to the stretch's 2 s Evidence, `just test media --media-cases pause` in `test/interop/clients/js/media.ts`: - `main` at 18fc33ecc: 3 of 4 runs fail the resume sync (median skew 200 ms, or 0 of 79 in sync). -- Parent of #8507 (ac73d9e0b): passes, median skew 0 ms (one run). +- Parent of #8507 (ac73d9e0b): passes, median skew 0 ms (one run). On a host at load 30, four full `just test media` runs there passed 1, and the other 3 failed only `audio tone` (67 to 70 of 81 samples, the CI signature), never sync; the 11-11 head a4bc922c6 passed 4 of 6, failing the same way. #8507 itself (4262a0691) failed 4 of 4 on sync, median skew 400 to 600 ms after resume. So the CI step can stay red under load after this fix, from a tone flake older than #8507. - Experiment, not committed: a same-instance resubscribe calls the decoder's `reset()`, so the ring joins the clock again. 4 of 4 runs pass, median skew 0 ms. One full `just test media` run also passed the pause and rejoin steps, then failed the later `live incumbent fallback` case, which was not investigated. Recommendation: re-join the ring when a viewer returns from absence on the same instance, so resumed audio lands on the clock the way a tune-in does, and keep the 2 s bound for stalls. Rejected: relax the resume assertion. `js/watch/AGENTS.md` says to judge a player change by its lag first, and the lip sync this stretch was built to fix (#8031) is what a stretch-back costs. From aea51865efd3b1fec5c35fcc149340e0f8391bb0 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 12 Nov 2026 14:02:15 -0800 Subject: [PATCH 11/12] quest: record the Nov 12 Interop decisions in their quests Snap a resumed viewer's audio to the live picture, as resume-sync plans, and move the go -> python media cell into test flakes as its own child, checking #8531 first. Both answers come from the maintainer, so their Waiting items go. Co-Authored-By: Claude Haiku 5.5 --- quest/m0/interop-green/README.md | 6 ++++- quest/m0/interop-green/resume-sync.md | 6 +---- quest/m0/test-flakes-2/README.md | 8 ++++++ quest/m0/test-flakes-2/interop-go-python.md | 29 +++++++++++++++++++++ 4 files changed, 43 insertions(+), 6 deletions(-) create mode 100644 quest/m0/test-flakes-2/interop-go-python.md diff --git a/quest/m0/interop-green/README.md b/quest/m0/interop-green/README.md index 5d8f4b6b703..b8a307e7b64 100644 --- a/quest/m0/interop-green/README.md +++ b/quest/m0/interop-green/README.md @@ -183,12 +183,16 @@ Scheduled run a missing group in moq-audio only for the playout delay, which is small at a cold start, so a reordered group early on reads as a gap. No open PR names this cell; [moq-dev/moq#8587](https://github.com/moq-dev/moq/pull/8587) covers `python -> go`. + Decided 2026-11-12 (maintainer): the cell moves to + [test flakes](/quest/m0/test-flakes-2/interop-go-python.md), which checks + #8531 first. - Media output and lifecycle: after the pause case resumes, the audio trails the picture by about 1.7 s. [moq-dev/moq#8507](https://github.com/moq-dev/moq/pull/8507) keeps audio that trails the clock up to its 2 s stretch bound and plays it faster, and a resume keeps the ring it had. Fixed by the child [resumed audio snaps to the clock](/quest/m0/interop-green/resume-sync.md), - which waits on a maintainer decision. + decided 2026-11-12 (maintainer) to snap to the live picture rather than + stretch the lag back. The 11-11 run, before #8507, passed all three steps. diff --git a/quest/m0/interop-green/resume-sync.md b/quest/m0/interop-green/resume-sync.md index 0b7cd51b33a..a3715a23740 100644 --- a/quest/m0/interop-green/resume-sync.md +++ b/quest/m0/interop-green/resume-sync.md @@ -18,13 +18,9 @@ Evidence, `just test media --media-cases pause` in `test/interop/clients/js/medi - Parent of #8507 (ac73d9e0b): passes, median skew 0 ms (one run). On a host at load 30, four full `just test media` runs there passed 1, and the other 3 failed only `audio tone` (67 to 70 of 81 samples, the CI signature), never sync; the 11-11 head a4bc922c6 passed 4 of 6, failing the same way. #8507 itself (4262a0691) failed 4 of 4 on sync, median skew 400 to 600 ms after resume. So the CI step can stay red under load after this fix, from a tone flake older than #8507. - Experiment, not committed: a same-instance resubscribe calls the decoder's `reset()`, so the ring joins the clock again. 4 of 4 runs pass, median skew 0 ms. One full `just test media` run also passed the pause and rejoin steps, then failed the later `live incumbent fallback` case, which was not investigated. -Recommendation: re-join the ring when a viewer returns from absence on the same instance, so resumed audio lands on the clock the way a tune-in does, and keep the 2 s bound for stalls. Rejected: relax the resume assertion. `js/watch/AGENTS.md` says to judge a player change by its lag first, and the lip sync this stretch was built to fix (#8031) is what a stretch-back costs. +Decided 2026-11-12 (maintainer): ✅ snap to the live picture. Re-join the ring when a viewer returns from absence on the same instance, so resumed audio lands on the clock the way a tune-in does, and keep the 2 s bound for stalls. Rejected: stretch catch-up with #8507's time-stretch, which plays the lag back over about 5 s and costs the lip sync that #8031 fixed; relaxing the resume assertion to match it, since `js/watch/AGENTS.md` says to judge a player change by its lag first. Check it with `just test media --media-cases pause`. Open for the implementer: - Scope the re-join to a return from absence. The handover path (`#handover` in `decoder.ts`) also inherits the ring for a rendition swap and a fallback, which should keep their seamless handover. Check the fallback case. - Native parity: `moq play` pauses through `rs/moq-audio`. Check whether its ring inherits the same way; `just test media` does not cover it. - -## Waiting - -- Maintainer: decide whether a resumed viewer's audio snaps to the clock or plays faster to catch up over about 5 s with #8507's stretch. Recommended: snap, as in the Plan, because the stretch-back is seconds of lip-sync loss. Choosing the stretch-back means relaxing the media test's resume assertion. Check: `just test media --media-cases pause` passes four runs in a row. diff --git a/quest/m0/test-flakes-2/README.md b/quest/m0/test-flakes-2/README.md index 5ae4f1d6c10..ba124f00daf 100644 --- a/quest/m0/test-flakes-2/README.md +++ b/quest/m0/test-flakes-2/README.md @@ -280,4 +280,12 @@ its third failure since 2026-10-16 and its first after [moq-dev/moq#8526](https://github.com/moq-dev/moq/pull/8526). It is quarantined with `#[ignore]` until its child fixes it. +Added 2026-11-12 (maintainer, from the Interop triage of scheduled run +[43260674067](https://github.com/moq-dev/moq/actions/runs/43260674067)): the +`go -> python` media cell, which failed `audio gap after 648 samples` once and +passed 8 local runs after it. Decided: ✅ add it here as the child +[interop's go -> python media cell](/quest/m0/test-flakes-2/interop-go-python.md), +not quarantined (rejected: a new quest after a second red run; quarantining the +cell). Check [moq-dev/moq#8531](https://github.com/moq-dev/moq/pull/8531) first. + Public API: none. Wire: none. diff --git a/quest/m0/test-flakes-2/interop-go-python.md b/quest/m0/test-flakes-2/interop-go-python.md new file mode 100644 index 00000000000..b6a0b53f1c3 --- /dev/null +++ b/quest/m0/test-flakes-2/interop-go-python.md @@ -0,0 +1,29 @@ +# [S] Interop's go -> python media cell holds up + +## Goal + +The `go -> python` media cell of `just test interop --all` passes reliably, +fixed at its cause, never by a quarantine, a longer timeout, or a retry. + +## Plan + +Found 2026-11-12 in the Interop triage of scheduled run +[43260674067](https://github.com/moq-dev/moq/actions/runs/43260674067) (head +e9c6df852, the first run after #8455 and #8512). Its full-matrix step failed +`go -> python` with `audio gap after 648 samples` at 2 s of 30 s. It passed +once locally, and 8 more local runs of `--publishers go --subscribers +python,rust,go` passed every cell. No open PR names this cell. + +Decided 2026-11-12 (maintainer): ✅ track it as this child of test flakes +(rejected: a new quest after a second red run; quarantining the cell). + +Check first: [moq-dev/moq#8531](https://github.com/moq-dev/moq/pull/8531) +(`fix(hang,moq-mux): wait on a missing group for the delay, not the max`) merged +on 2026-11-12 and is in the failing run's head. A lead, not checked: it waits on +a missing group only for the playout delay, which is small at a cold start, so a +group that arrives out of order early on reads as an audio gap. + +Reproduce with `just test interop --publishers go --subscribers python` and the +interop logs kept. Confirm or rule out #8531 first, then fix the cause. + +Public API: none expected. Wire: none expected. From 569370781a72c3501a7eb76e1b3c2ce3e85c1530 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 12 Nov 2026 23:01:36 -0800 Subject: [PATCH 12/12] quest: interop-green waits only on the resumed-audio child Co-Authored-By: Claude Opus 5.5 --- quest/m0/interop-green/README.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/quest/m0/interop-green/README.md b/quest/m0/interop-green/README.md index b8a307e7b64..e7ffe2091f0 100644 --- a/quest/m0/interop-green/README.md +++ b/quest/m0/interop-green/README.md @@ -10,9 +10,10 @@ so it only needs to stay green. ## Waiting -- moq-dev/moq: the next scheduled Interop run on `main` passes, once - [moq-dev/moq#8572](https://github.com/moq-dev/moq/pull/8572) merges and the - [resumed-audio child](/quest/m0/interop-green/resume-sync.md) lands. Check +- moq-dev/moq: the next scheduled Interop run on `main` passes, once the + [resumed-audio child](/quest/m0/interop-green/resume-sync.md) lands + ([moq-dev/moq#8572](https://github.com/moq-dev/moq/pull/8572), the max-age + fix, merged 2026-11-12). Check with `gh run list --repo moq-dev/moq --workflow interop.yml --event schedule`, then the run's STEPS summary. The JS route port that [moq-dev/moq#8290](https://github.com/moq-dev/moq/pull/8290) waited on landed in [moq-dev/moq#8443](https://github.com/moq-dev/moq/pull/8443),