From 135249b256906ae1178425e9787786d2a8fa344f Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Mon, 9 Nov 2026 01:43:58 -0800 Subject: [PATCH] test(py): quarantine the TCP close test and plan its fix Under load the reader got Unroutable after the endpoint closed, which the test's accepted shutdown errors leave out. Skip it and plan the fix under the test-flakes-2 epic. Co-Authored-By: Claude Opus 5.5 --- py/moq-rs/tests/test_socket.py | 3 ++ quest/m0/test-flakes-2/README.md | 7 +++++ .../m0/test-flakes-2/tcp-close-unroutable.md | 28 +++++++++++++++++++ 3 files changed, 38 insertions(+) create mode 100644 quest/m0/test-flakes-2/tcp-close-unroutable.md diff --git a/py/moq-rs/tests/test_socket.py b/py/moq-rs/tests/test_socket.py index 23d16d328e7..3270bf43f0f 100644 --- a/py/moq-rs/tests/test_socket.py +++ b/py/moq-rs/tests/test_socket.py @@ -98,6 +98,9 @@ async def test_cancelled_dial_releases_the_original_subscription(): b.close() +# Quarantined: under load the reader once got `Unroutable` after `a.close()`, which the +# accepted shutdown errors leave out. See quest/m0/test-flakes-2/tcp-close-unroutable.md. +@pytest.mark.skip(reason="flaky under load: quest/m0/test-flakes-2/tcp-close-unroutable.md") async def test_tcp_rst_and_endpoint_close_are_errors(): a, b = endpoints() client, server = await tcp(a, b) diff --git a/quest/m0/test-flakes-2/README.md b/quest/m0/test-flakes-2/README.md index 8e83f1a21a4..133ebe8a2d7 100644 --- a/quest/m0/test-flakes-2/README.md +++ b/quest/m0/test-flakes-2/README.md @@ -235,6 +235,12 @@ failed the merge queue for [moq-dev/moq#8276](https://github.com/moq-dev/moq/pul after [moq-dev/moq#8321](https://github.com/moq-dev/moq/pull/8321) re-enabled it. It is quarantined with `test.skip` for every version until its child fixes it. +Added 2026-11-09 (maintainer's standing rule that flakes join this epic): +moq-rs's Python socket test `test_tcp_rst_and_endpoint_close_are_errors`, whose +reader got `Unroutable` after the endpoint closed during +[moq-dev/moq#8293](https://github.com/moq-dev/moq/pull/8293)'s loaded `just check`. +It is quarantined with `pytest.mark.skip` until its child fixes it. + Public API: none. Wire: none. ## Required @@ -246,3 +252,4 @@ Public API: none. Wire: none. - [js/net's lite-07 re-dropped re-offer test holds up under load](/quest/m0/test-flakes-2/redropped-reoffer.md) - update 3 is ordered before the re-offer opens by an event, not a yield count, and its `test.skip` is removed - [moq-net's random-mesh withdrawal tests fit the gate](/quest/m0/test-flakes-2/mesh-withdraw-runtime.md) - the 200-seed mesh tests cost seconds of CPU, and their `#[ignore]` is removed - [js/net's datagram session-close-after-end test holds up under load](/quest/m0/test-flakes-2/datagram-close-end.md) - the abort is ordered after the end by an event the client observes, and its `test.skip` is removed +- [moq-rs's Python TCP close test settles on a promised error](/quest/m0/test-flakes-2/tcp-close-unroutable.md) - the reader's error after an endpoint close is one the socket contract promises, and its `pytest.mark.skip` is removed diff --git a/quest/m0/test-flakes-2/tcp-close-unroutable.md b/quest/m0/test-flakes-2/tcp-close-unroutable.md new file mode 100644 index 00000000000..808247576f7 --- /dev/null +++ b/quest/m0/test-flakes-2/tcp-close-unroutable.md @@ -0,0 +1,28 @@ +# [S] moq-rs's Python TCP close test settles on a promised error + +## Goal + +`py/moq-rs/tests/test_socket.py`'s `test_tcp_rst_and_endpoint_close_are_errors` +passes on a loaded host, and its `pytest.mark.skip` is removed. It still +proves that a stream reset reaches the reader as `Protocol` with the app code, +and that an endpoint close never ends a reader with a clean EOF. + +## Plan + +Planned 2026-11-09 (maintainer's standing rule that flakes join this epic). +It failed once in [moq-dev/moq#8293](https://github.com/moq-dev/moq/pull/8293)'s +loaded `just check`, before a main merge, then passed 30 of 30 runs alone. The +reader after `a.close()` got `Unroutable`, while the test accepts only +`Cancelled` or `Closed`. The test uses an in-process origin with no lite-07 +session, so #8293's route changes can't reach it. + +Find which path turns the endpoint's retraction into `Unroutable` for a stream +that was already open: the socket module's route lookup, or the origin +retracting the peer's broadcast before the stream's reset lands. Decide whether +`Unroutable` is a cause the socket contract should promise here (then document +it on `moq.socket` and accept it in the test) or a wrong error for an already +routed stream (then fix the cause so `Cancelled` or `Closed` wins). Prefer the +fix if the error leaks to users of a stream they already held. Never match on +error text. + +Public API: none, unless the contract's documented errors change. Wire: none.