From eb80856aebaecff35745925a7a3caf8944b75945 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 10 Nov 2026 01:12:24 -0800 Subject: [PATCH 1/8] chore(quest): claim quest/m0/macos-check.md Quest-Claim: d69d9c2ee0c061b2 From 22c8ca855913b3d6226a67efe1314dcad3a8a2d3 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 10 Nov 2026 02:22:21 -0800 Subject: [PATCH 2/8] fix: just check failures on macOS Co-Authored-By: Claude Opus 5.5 --- demo/carla/bridge/src/lib.rs | 2 ++ doc/.vitepress/api/index.ts | 5 ++++- sh/version.py | 4 ++++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/demo/carla/bridge/src/lib.rs b/demo/carla/bridge/src/lib.rs index bdf82a891d7..f374c528530 100644 --- a/demo/carla/bridge/src/lib.rs +++ b/demo/carla/bridge/src/lib.rs @@ -18,6 +18,8 @@ //! The worker protocol is [`protocol`]. //! //! Linux only; the crate is empty elsewhere. +// Elsewhere the items these docs link to do not exist. +#![cfg_attr(not(target_os = "linux"), allow(rustdoc::broken_intra_doc_links))] #![cfg(target_os = "linux")] mod ffi; diff --git a/doc/.vitepress/api/index.ts b/doc/.vitepress/api/index.ts index a8589ee6ba2..45b0c225f95 100644 --- a/doc/.vitepress/api/index.ts +++ b/doc/.vitepress/api/index.ts @@ -1,6 +1,6 @@ // Renders the JS API reference from the TSDoc in every published `@moq/*` package's source: // one TypeDoc run over all of them, written as VitePress markdown with a sidebar. -import { existsSync, readdirSync, readFileSync, statSync, writeFileSync } from "node:fs"; +import { existsSync, readdirSync, readFileSync, realpathSync, statSync, writeFileSync } from "node:fs"; import { dirname, join, relative, resolve } from "node:path"; import { fileURLToPath } from "node:url"; import { Application, type Reflection, type ReflectionGroup, ReflectionKind, type TypeDocOptions } from "typedoc"; @@ -23,6 +23,9 @@ export interface Reference { /** Render the reference, throwing on any TypeDoc warning, such as an unresolved link or an unexported type an export names. */ export async function generate({ root, packages, out, docs }: Reference) { + // TypeScript reports sources by real path, so compare against real paths, such as macOS's `/var` -> `/private/var`. + root = realpathSync(root); + packages = packages.map((dir) => realpathSync(dir)); const plugin = (name: string) => fileURLToPath(import.meta.resolve(name)); // typedoc-vitepress-theme declares `docsRoot` without typing it. const options: TypeDocOptions & PluginOptions & { docsRoot: string } = { diff --git a/sh/version.py b/sh/version.py index 0cf2adae937..2fd71579905 100644 --- a/sh/version.py +++ b/sh/version.py @@ -245,6 +245,10 @@ def bump(root, config, target): sections.append(f'[[package]]\nname = "{p.name}"\nchangelog_path = {json.dumps(str(changelog))}\n') config_path.write_text("\n".join(sections)) if rust: + # Older release-plz, such as a non-Nix one ahead on PATH, leaves versions unset without failing. + found = run(root, "release-plz", "--version").split()[-1] + if version(found) < (0, 4, 1): + raise ValueError(f"release-plz {found} is older than 0.4.1; use the Nix dev shell's") run( root, "release-plz", From 7ce8eec5f72ff495e5c0c13a9bf0fa3362c8df04 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 10 Nov 2026 02:53:37 -0800 Subject: [PATCH 3/8] quest: finish macos-check Co-Authored-By: Claude Opus 5.5 --- quest/m0/README.md | 1 - quest/m0/macos-check.md | 55 ------------------------------------- quest/m1/carla-workspace.md | 5 ++-- 3 files changed, 2 insertions(+), 59 deletions(-) delete mode 100644 quest/m0/macos-check.md diff --git a/quest/m0/README.md b/quest/m0/README.md index 4a7f0aecf61..5708adc3384 100644 --- a/quest/m0/README.md +++ b/quest/m0/README.md @@ -33,6 +33,5 @@ edge, which embeds moq-relay; it moved there on 2026-09-28. - [Publish the release line's drain() wrappers](/quest/m0/ffi-shutdown-backport.md) - Dart `moq` 0.1.1 reaches pub.dev from `release` - [CI cost and latency](/quest/m0/ci/README.md) - cloud CI runs only in GitHub's merge queue, one tested entry at a time, expensive checks run nightly and gate `release`, caches move to R2, and runners are chosen last - [More tests under load](/quest/m0/test-flakes-2/README.md) - load-only and queue failures, one quest per flake, fixed at the cause, since each one drops a queued PR -- [just check passes on macOS](/quest/m0/macos-check.md) - the version test, the doc re-export link test, and the carla bridge docs pass on a macOS host - [Agent build output can't fill the desktop's disk](/quest/m0/agent-disk-budget.md) - finished agent checkouts reclaim their mbx targets automatically, so parallel agent builds stop filling the root disk - [MoQ builds against rind 0.4 and its corrected adapters](/quest/m0/rind-adapters.md) - the calls rind 0.4 and its adapter patch releases change, adapted the day they publish diff --git a/quest/m0/macos-check.md b/quest/m0/macos-check.md deleted file mode 100644 index b2586124f4b..00000000000 --- a/quest/m0/macos-check.md +++ /dev/null @@ -1,55 +0,0 @@ -# [S] just check passes on macOS - -## Goal - -`just check` on a clean `main` checkout passes on a macOS host inside the Nix -dev shell, as it already does on Linux. Three failures block it today, all -reproduced on `origin/main` by -[moq-dev/moq#8392](https://github.com/moq-dev/moq/pull/8392) and -[moq-dev/moq#8394](https://github.com/moq-dev/moq/pull/8394): - -- `test gh`: `sh/version.test.py`'s - `test_cut_promotes_only_published_library_dependencies_and_preserves_exemptions` - (`'0.0.1' != '0.22.0'`) and `test_release_plz_keeps_manual_cut_despite_breaking_commits`, - with release-plz 0.3.149. -- `check js`: `doc/.vitepress/api/index.test.ts`, "a re-export from another - workspace package links to its owner"; the rendered link holds - `/private/var/folders/...`. -- `check rs`: `RUSTDOCFLAGS="-D warnings" cargo doc --no-deps -p moq-carla-bridge` - reports unresolved links to `Bridge`, `Source`, and `protocol`. - -Non-goal: a macOS runner on the PR gate (rejected in -[macos.md](/quest/m0/nightly/macos.md)). - -## Plan - -Planned 2026-11-09 (maintainer, /quest-complete follow-up of #8392 and #8394). -Milestone: ✅ m0 (rejected: a later milestone). - -Causes, read from source on Linux (no macOS host was available): - -- carla bridge, **confirmed**: `demo/carla/bridge/src/lib.rs` puts - `#![cfg(target_os = "linux")]` after its `//!` docs, so on macOS the crate is - empty and the intra-doc links dangle. Either gate the links too or build the - crate (and its docs) only on Linux, e.g. by keeping it out of the macOS doc - selection. -- doc re-export link, **guess**: `tmpdir()` is `/var/folders/...` on macOS, - a symlink to `/private/var/...`. `index.ts` computes package paths with - `relative(root, dir)`; if one side is resolved through the symlink (by - TypeScript or the workspace scan) and the other is not, the link becomes a - `../../private/var/...` path. Confirm by checking which side resolves, then - realpath both sides in `index.ts` (production paths can be symlinked too), - not only in the test. -- `sh/version.test.py`, **guess**: the Linux dev shell provides release-plz - 0.4.1 (`pkgs.release-plz` in `flake.nix`), while the failing host ran - 0.3.149, so it likely picked up a non-Nix `release-plz` (e.g. from - `~/.cargo/bin`) ahead of the dev shell. The flake uses one nixpkgs for both - systems, so a different darwin build is less likely. If it is PATH, the - test should fail loud on a release-plz older than it supports instead of - asserting wrong versions; if the dev shell's darwin release-plz really is - 0.3.149, align it. - -Verify each fix on a macOS host (a maintainer machine or a manual Platform -dispatch), and on Linux. - -Public API: none. Wire: none. diff --git a/quest/m1/carla-workspace.md b/quest/m1/carla-workspace.md index c1269ee2f73..b45a13b39ab 100644 --- a/quest/m1/carla-workspace.md +++ b/quest/m1/carla-workspace.md @@ -16,8 +16,7 @@ The bridge is the root `Cargo.toml`'s first `members` entry. Give it its own workspace and lock file, keep its check in the dispatch for `demo/carla/**` changes, and keep the files where they are: moq.pro reads `demo/carla/sim/trucks.json` from its pin. Check the GPU end-to-end test in -[vendor-free CARLA bridge](/quest/m5/carla-bridge.md) and -[macOS check](/quest/m0/macos-check.md), which touch the bridge, still find -it. +[vendor-free CARLA bridge](/quest/m5/carla-bridge.md), which touches the +bridge, still finds it. Public API: none. Wire: none. From 5fdd594d15ed1294a61b5c7912df584e798efce1 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 10 Nov 2026 16:58:20 -0800 Subject: [PATCH 4/8] fix: release-plz in the macOS dev shell, carla allow reason, coverage under symlinked tmp Co-Authored-By: Claude Opus 5.5 --- demo/carla/bridge/src/lib.rs | 9 +++++++-- flake.nix | 4 ++-- sh/js/coverage.py | 2 ++ 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/demo/carla/bridge/src/lib.rs b/demo/carla/bridge/src/lib.rs index f374c528530..b5e50b86067 100644 --- a/demo/carla/bridge/src/lib.rs +++ b/demo/carla/bridge/src/lib.rs @@ -18,8 +18,13 @@ //! The worker protocol is [`protocol`]. //! //! Linux only; the crate is empty elsewhere. -// Elsewhere the items these docs link to do not exist. -#![cfg_attr(not(target_os = "linux"), allow(rustdoc::broken_intra_doc_links))] +#![cfg_attr( + not(target_os = "linux"), + allow( + rustdoc::broken_intra_doc_links, + reason = "the items these docs link to are Linux-only" + ) +)] #![cfg(target_os = "linux")] mod ffi; diff --git a/flake.nix b/flake.nix index 476b8bfea12..83405c2f3f0 100644 --- a/flake.nix +++ b/flake.nix @@ -164,6 +164,8 @@ cargo-mutants cargo-nextest cargo-codspeed + # Sets versions for a release cut; `sh/version.py` needs 0.4.1 or newer. + release-plz # Source-based test coverage (`just rs coverage`). # Its LLVM test helpers must read the compiler's profile format. (cargo-llvm-cov.override { @@ -175,8 +177,6 @@ ] ++ gstreamerDeps ++ pkgs.lib.optionals (!pkgs.stdenv.hostPlatform.isDarwin) [ - # Marked broken on Darwin in nixpkgs, but builds fine on Linux. - pkgs.release-plz # cpal's `alsa-sys` (moq-audio `capture` / `playback` features) links # libasound on Linux via pkg-config; macOS uses CoreAudio, so no dep # there. See `alsaPlugins` below for reaching the default device at diff --git a/sh/js/coverage.py b/sh/js/coverage.py index 6b59fb1494f..4280ac660a3 100644 --- a/sh/js/coverage.py +++ b/sh/js/coverage.py @@ -37,6 +37,8 @@ def report(root, directories): found = lines.setdefault(source, {}) found[int(number)] = found.get(int(number), False) or int(count) > 0 summary = {} + # Sources above are real paths; a symlinked root (macOS /var) must match them. + root = root.resolve() manifest = json.loads((root / "package.json").read_text()) for directory in [root / "js/common", *(root / path for path in manifest["workspaces"] if path.startswith("js/"))]: sources = [ From 5e7417e60c0fec6fd3b5892c054c63735991af2d Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 10 Nov 2026 18:52:54 -0800 Subject: [PATCH 5/8] fix: reap cancelled descendants off Linux, refuse relay profiling at setup off Linux Co-Authored-By: Claude Opus 5.5 --- bench/profile.test.py | 16 ++++++++++++++++ bench/run.sh | 9 +++++---- sh/local.ts | 28 ++++++++++++++++++++++++++++ 3 files changed, 49 insertions(+), 4 deletions(-) diff --git a/bench/profile.test.py b/bench/profile.test.py index 24b2e986e8f..2b54ba4b127 100644 --- a/bench/profile.test.py +++ b/bench/profile.test.py @@ -4,6 +4,7 @@ import signal import struct import subprocess +import sys import tempfile import unittest from pathlib import Path @@ -171,6 +172,19 @@ def test_profile_rejects_invalid_selection_before_building(self): self.assertEqual(result.returncode, 1, result.stdout) self.assertIn(diagnostic, result.stderr) + @unittest.skipIf(sys.platform == "linux", "Linux can profile") + def test_profile_refuses_off_linux_before_evidence(self): + root = Path(__file__).resolve().parent.parent + result = subprocess.run( + ["bash", str(root / "bench/run.sh"), "--profile"], + env=dict(os.environ, BENCH_PROFILE_MODES="cpu"), + capture_output=True, + text=True, + ) + self.assertEqual(result.returncode, 1, result.stdout) + self.assertEqual(result.stderr, "relay profiling needs Linux for perf and /proc\n") + self.assertNotIn("Benchmark evidence", result.stdout) + FIXTURE = Path(__file__).with_name("profile.test.txt").read_text() IDLE, MUTEX, ALLOCATOR = "2152705", "2152709", "2152707" @@ -178,6 +192,7 @@ def test_profile_rejects_invalid_selection_before_building(self): END = 271707 * 1_000_000_000 +@unittest.skipUnless(sys.platform == "linux", "relay profiling needs Linux for perf and /proc") class Orchestration(unittest.TestCase): def harness(self, directory, sampler_binary): """A checkout whose committed revision has the old harness and, when @@ -493,6 +508,7 @@ def test_lost_samples_refused(self): class Heap(unittest.TestCase): + @unittest.skipUnless(sys.platform == "linux", "reads /proc") def test_usr1_handler_detected(self): previous = signal.signal(signal.SIGUSR1, signal.SIG_DFL) try: diff --git a/bench/run.sh b/bench/run.sh index 894493f6915..c0e29d4c1f6 100755 --- a/bench/run.sh +++ b/bench/run.sh @@ -138,6 +138,11 @@ case $MODE in exit 1 fi done + # Refuse at setup, after validating the selection but before creating evidence. + if [[ $(uname -s) != Linux ]]; then + printf 'relay profiling needs Linux for perf and /proc\n' >&2 + exit 1 + fi # Without frame pointers, perf's DWARF unwinder stops at the first relay frame, # and CPU stacks unwind by frame pointer alone. export RUSTFLAGS="${RUSTFLAGS:+$RUSTFLAGS }-C force-frame-pointers=yes" @@ -965,10 +970,6 @@ run_shard_sweep() { } run_profiles() { - if [[ $(uname -s) != Linux ]]; then - printf 'relay profiling needs Linux for perf and /proc\n' >&2 - return 1 - fi # Refuse before the build when the host would refuse a capture. local mode for mode in $PROFILE_MODES; do diff --git a/sh/local.ts b/sh/local.ts index 24543e5bd54..3ffbf023b4e 100644 --- a/sh/local.ts +++ b/sh/local.ts @@ -19,13 +19,41 @@ const child = Bun.spawn(command, { stderr: "inherit", env: { ...process.env, LOCAL_SUPERVISED: "1" }, }); +// Every process below `root`, from one process table snapshot. +function descendants(root: number): number[] { + const children = new Map(); + for (const line of Bun.spawnSync(["ps", "-A", "-o", "pid=,ppid="]).stdout.toString().split("\n")) { + const [pid, ppid] = line.trim().split(/\s+/).map(Number); + if (pid && ppid !== undefined) children.set(ppid, [...(children.get(ppid) ?? []), pid]); + } + const found: number[] = []; + for (let queue = [root]; queue.length; ) { + for (const pid of children.get(queue.pop() as number) ?? []) { + found.push(pid); + queue.push(pid); + } + } + return found; +} + // Forward cancellation and let the child clean up; once it exits, every survivor is ours. +// Without a subreaper (macOS), a descendant whose parent dies leaves the tree before +// --no-orphans sweeps it, so record the tree when cancellation arrives. let signaled: number | undefined; +const tree = new Set(); for (const name of ["SIGINT", "SIGTERM", "SIGHUP"] as const) { process.on(name, () => { signaled ??= 128 + constants.signals[name]; + if (process.platform !== "linux") for (const pid of descendants(process.pid)) tree.add(pid); child.kill(name); }); } const code = await child.exited; +for (const pid of tree) { + try { + process.kill(pid, "SIGKILL"); + } catch { + // Already gone. + } +} process.exit(signaled ?? code); From 843a47b6b0327b67ac8a687a48c98f4b22fb8513 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 10 Nov 2026 19:00:25 -0800 Subject: [PATCH 6/8] fix: moq-vaapi docs off Linux, real temp paths in drafts and gst formula tests Co-Authored-By: Claude Opus 5.5 --- rs/moq-vaapi/src/lib.rs | 7 +++++++ sh/drafts/publish.test.sh | 3 ++- sh/gh/gst-formula.test.py | 3 ++- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/rs/moq-vaapi/src/lib.rs b/rs/moq-vaapi/src/lib.rs index 4a41092bf1d..1c1d48e5c6f 100644 --- a/rs/moq-vaapi/src/lib.rs +++ b/rs/moq-vaapi/src/lib.rs @@ -17,6 +17,13 @@ )] // VA-API and DMA-BUF are Linux-only, so elsewhere the crate is an empty stub and // moq-video only depends on it there. +#![cfg_attr( + not(target_os = "linux"), + allow( + rustdoc::broken_intra_doc_links, + reason = "the items these docs link to are Linux-only" + ) +)] #![cfg(target_os = "linux")] mod bindings; diff --git a/sh/drafts/publish.test.sh b/sh/drafts/publish.test.sh index 7e99d1b3a18..9b217b9fc17 100755 --- a/sh/drafts/publish.test.sh +++ b/sh/drafts/publish.test.sh @@ -10,7 +10,8 @@ root=$(git rev-parse --show-toplevel) publish=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/publish.sh before=$(sha256sum "$root"/drafts/draft-*.md) -tmp=$(mktemp -d) +# Real path: git reports one, and macOS's temp dir sits behind a symlink. +tmp=$(cd "$(mktemp -d)" && pwd -P) trap 'rm -rf "$tmp"' EXIT repo=$tmp/repo diff --git a/sh/gh/gst-formula.test.py b/sh/gh/gst-formula.test.py index a5875e0e766..841917f1da0 100644 --- a/sh/gh/gst-formula.test.py +++ b/sh/gh/gst-formula.test.py @@ -39,7 +39,8 @@ def test_other_target_refused_before_brew(self): def test_failed_test_cleans_only_created_tap_and_install(self): with tempfile.TemporaryDirectory() as tmp: - root = Path(tmp) + # Real path, as the formula records it; macOS's temp dir sits behind a symlink. + root = Path(tmp).resolve() (root / "Formula").mkdir() def brew(command, **kwargs): From 48d6d3b7349fa3db64e125ffaba3e720ef7945b5 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 10 Nov 2026 19:03:57 -0800 Subject: [PATCH 7/8] fix(local): kill only recorded descendants that keep their start time; quest: keep macos-check for cpp and py Co-Authored-By: Claude Opus 5.5 --- quest/m0/README.md | 1 + sh/local.ts | 46 ++++++++++++++++++++++++++++++---------------- 2 files changed, 31 insertions(+), 16 deletions(-) diff --git a/quest/m0/README.md b/quest/m0/README.md index 5708adc3384..8411b70a69d 100644 --- a/quest/m0/README.md +++ b/quest/m0/README.md @@ -33,5 +33,6 @@ edge, which embeds moq-relay; it moved there on 2026-09-28. - [Publish the release line's drain() wrappers](/quest/m0/ffi-shutdown-backport.md) - Dart `moq` 0.1.1 reaches pub.dev from `release` - [CI cost and latency](/quest/m0/ci/README.md) - cloud CI runs only in GitHub's merge queue, one tested entry at a time, expensive checks run nightly and gate `release`, caches move to R2, and runners are chosen last - [More tests under load](/quest/m0/test-flakes-2/README.md) - load-only and queue failures, one quest per flake, fixed at the cause, since each one drops a queued PR +- [just check passes on macOS](/quest/m0/macos-check.md) - `check cpp` and `check py`, the last two macOS failures, pass on a macOS host - [Agent build output can't fill the desktop's disk](/quest/m0/agent-disk-budget.md) - finished agent checkouts reclaim their mbx targets automatically, so parallel agent builds stop filling the root disk - [MoQ builds against rind 0.4 and its corrected adapters](/quest/m0/rind-adapters.md) - the calls rind 0.4 and its adapter patch releases change, adapted the day they publish diff --git a/sh/local.ts b/sh/local.ts index 3ffbf023b4e..4e1bded7f33 100644 --- a/sh/local.ts +++ b/sh/local.ts @@ -19,17 +19,26 @@ const child = Bun.spawn(command, { stderr: "inherit", env: { ...process.env, LOCAL_SUPERVISED: "1" }, }); -// Every process below `root`, from one process table snapshot. -function descendants(root: number): number[] { - const children = new Map(); - for (const line of Bun.spawnSync(["ps", "-A", "-o", "pid=,ppid="]).stdout.toString().split("\n")) { - const [pid, ppid] = line.trim().split(/\s+/).map(Number); - if (pid && ppid !== undefined) children.set(ppid, [...(children.get(ppid) ?? []), pid]); +// Each process's parent and start time; the start time tells a live process from a +// later one that reused its PID. +function table(): Map { + const found = new Map(); + for (const line of Bun.spawnSync(["ps", "-A", "-o", "pid=,ppid=,lstart="]).stdout.toString().split("\n")) { + const [pid, ppid, ...start] = line.trim().split(/\s+/); + if (pid && ppid && start.length) found.set(Number(pid), { ppid: Number(ppid), start: start.join(" ") }); } - const found: number[] = []; + return found; +} + +// Every process below `root` with its start time, from one snapshot. +function descendants(root: number): Map { + const processes = table(); + const found = new Map(); for (let queue = [root]; queue.length; ) { - for (const pid of children.get(queue.pop() as number) ?? []) { - found.push(pid); + const parent = queue.pop() as number; + for (const [pid, { ppid, start }] of processes) { + if (ppid !== parent || found.has(pid)) continue; + found.set(pid, start); queue.push(pid); } } @@ -40,20 +49,25 @@ function descendants(root: number): number[] { // Without a subreaper (macOS), a descendant whose parent dies leaves the tree before // --no-orphans sweeps it, so record the tree when cancellation arrives. let signaled: number | undefined; -const tree = new Set(); +const tree = new Map(); for (const name of ["SIGINT", "SIGTERM", "SIGHUP"] as const) { process.on(name, () => { signaled ??= 128 + constants.signals[name]; - if (process.platform !== "linux") for (const pid of descendants(process.pid)) tree.add(pid); + if (process.platform !== "linux") for (const [pid, start] of descendants(process.pid)) tree.set(pid, start); child.kill(name); }); } const code = await child.exited; -for (const pid of tree) { - try { - process.kill(pid, "SIGKILL"); - } catch { - // Already gone. +if (tree.size) { + // Kill only a recorded process that keeps its start time, never a PID's new owner. + const now = table(); + for (const [pid, start] of tree) { + if (now.get(pid)?.start !== start) continue; + try { + process.kill(pid, "SIGKILL"); + } catch { + // Exited since the check. + } } } process.exit(signaled ?? code); From 601497c10798e602f5d248bf356af06ef10046fa Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 10 Nov 2026 19:04:14 -0800 Subject: [PATCH 8/8] quest: keep macos-check for check cpp and check py Co-Authored-By: Claude Opus 5.5 --- quest/m0/macos-check.md | 42 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 quest/m0/macos-check.md diff --git a/quest/m0/macos-check.md b/quest/m0/macos-check.md new file mode 100644 index 00000000000..4e54a219342 --- /dev/null +++ b/quest/m0/macos-check.md @@ -0,0 +1,42 @@ +# [S] just check passes on macOS + +## Goal + +`just check` on a clean `main` checkout passes on a macOS host inside the Nix +dev shell, as it already does on Linux. +[moq-dev/moq#8426](https://github.com/moq-dev/moq/pull/8426) fixed the +failures in scripts, tests, and Linux-only crate docs; two remain, both seen +on the maintainer's aarch64-darwin host on 2026-11-10 with +`quest gate nix develop --command just check` selecting the whole tree: + +- `check cpp`: the build stops at + `clang++: error: -Wl,-lintl: 'linker' input unused [-Werror,-Wunused-command-line-argument]`, + after the `probe` builds pass, in a CMake build under + `cpp/moq/build/test-*` whose compiler is the mbx `clang++` shim. +- `check py`: Sphinx, which treats warnings as errors, stops with + `py/moq-rs/docs/index.md:147: WARNING: autosummary: stub file not found 'moq.media.catalog'. Check your autosummary_generate setting.` + +Non-goal: a macOS runner on the PR gate (rejected in +[macos.md](/quest/m0/nightly/macos.md)). + +## Plan + +Planned 2026-11-09 (maintainer, /quest-complete follow-up of #8392 and #8394). +Milestone: ✅ m0 (rejected: a later milestone). Narrowed 2026-11-10 +(maintainer): ✅ land #8426 and keep this quest for what remains (rejected: +widen #8426 again). + +Causes are not yet diagnosed: + +- `check cpp`: `-lintl` is gettext's library, which the Nix darwin stdenv + adds to link flags; it likely reaches a compile-only clang++ step through + `NIX_LDFLAGS` or the CMake flags `cpp/` passes. Find which step gets it and + keep link flags off compile steps rather than dropping `-Werror`. +- `check py`: check whether `moq.media.catalog` exists in the built module on + macOS (a cfg-gated or feature-gated binding would explain a missing stub), + then align the docs index with what the module exports there. + +Verify on a macOS host (a maintainer machine or a manual Platform dispatch), +and on Linux. + +Public API: none. Wire: none.