From 2ad775f5f5b55c0a892eccab5d3a2e4d9e0af98e Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 10 Nov 2026 01:12:40 -0800 Subject: [PATCH 1/2] chore(quest): claim quest/m0/nightly/qmux-bench-handshake.md Quest-Claim: 18d5f623dfb89b7f From 19071ad9371ef237d21033476b4f88d7145a19e1 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 10 Nov 2026 02:14:29 -0800 Subject: [PATCH 2/2] quest: the qmux benchmark handshake was already fixed by #8351 Co-Authored-By: Claude Opus 5.5 --- quest/m0/nightly/README.md | 1 - quest/m0/nightly/qmux-bench-handshake.md | 26 ------------------------ 2 files changed, 27 deletions(-) delete mode 100644 quest/m0/nightly/qmux-bench-handshake.md diff --git a/quest/m0/nightly/README.md b/quest/m0/nightly/README.md index 3a6969c0cff..0e52ecac867 100644 --- a/quest/m0/nightly/README.md +++ b/quest/m0/nightly/README.md @@ -51,5 +51,4 @@ near the paired threshold (re-check if one repeats), a one-off ## Required - [Nightly's macOS platform job passes](/quest/m0/nightly/macos.md) - `moq-audio`'s tests compile on macOS again and the websocket version test's timeout is fixed if it recurs -- [Nightly's WebSocket fallback benchmark connects again](/quest/m0/nightly/qmux-bench-handshake.md) - `just js qmux-bench` stops timing out on its handshake, a regression since 2026-11-07, so the Audio quality job fails only on audio results - [Nightly's Windows platform job passes](/quest/m0/nightly/windows.md) - `moq-vaapi` is gated to Linux and Windows-only unused items are fixed, so `platform.yml`'s Windows job builds and tests cleanly diff --git a/quest/m0/nightly/qmux-bench-handshake.md b/quest/m0/nightly/qmux-bench-handshake.md deleted file mode 100644 index 22467f8c8a2..00000000000 --- a/quest/m0/nightly/qmux-bench-handshake.md +++ /dev/null @@ -1,26 +0,0 @@ -# [S] Nightly's WebSocket fallback benchmark connects again - -## Goal - -The scheduled Nightly's Audio quality job passes its "WebSocket fallback -startup benchmark" step (`just js qmux-bench`) on `main`, fixed at the cause -of its handshake timeout, so the job fails only on real audio results. - -## Plan - -Planned 2026-11-09 (maintainer, /quest-unblock). The step passed on the -2026-11-05 and 2026-11-06 scheduled Nightlies, then failed on 2026-11-07, -11-08 and 11-09 ([run 42659882487](https://github.com/moq-dev/moq/actions/runs/42659882487)) -with `error: evaluate: Error: handshake timeout` from the Playwright -evaluate in `qmux-bench`. That's a regression, not a flake. The window is -[fbef872b](https://github.com/moq-dev/moq/commit/fbef872bdc7f2ec619ae515626d6cd07d3926445)..[b5805859](https://github.com/moq-dev/moq/commit/b5805859aa6bf856c1a96ab3af89d45757de8e3d) -(120 commits). Likely suspects, to check first: - -- [moq-dev/moq#8054](https://github.com/moq-dev/moq/pull/8054): QMux sessions return once established. -- [moq-dev/moq#8021](https://github.com/moq-dev/moq/pull/8021): send-rate estimates sampled from one page-wide ticker. -- [moq-dev/moq#8078](https://github.com/moq-dev/moq/pull/8078): a bun test fails when its own timer fires on the host clock. - -Reproduce locally with `just js qmux-bench`, bisect the window if no suspect -explains it, and list the culprit under the fix PR's `## Caused by`. - -Public API: none expected. Wire: none expected.