From 716f749ff98c9a7a9e0a1118f13be90812df9af5 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 10 Nov 2026 01:13:04 -0800 Subject: [PATCH 1/2] chore(quest): claim quest/m0/check-c-moqinstance.md Quest-Claim: 93b940cd81e59f37 From 378b9131d58297761f37be952af1cae1d2af6fed Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 10 Nov 2026 08:53:21 -0800 Subject: [PATCH 2/2] chore(quest): delete the check c MoqInstance quest as not reproducible `check c` passes on main through the real dispatcher, so there is no refusal to fix. The generator renders MoqInstance's exported Debug, and instance.rs and flake.lock have not changed since #8366. Co-Authored-By: Claude Haiku 5.5 --- quest/m0/README.md | 1 - quest/m0/check-c-moqinstance.md | 24 ------------------------ 2 files changed, 25 deletions(-) delete mode 100644 quest/m0/check-c-moqinstance.md diff --git a/quest/m0/README.md b/quest/m0/README.md index 4a7f0aecf61..ee5232d8af7 100644 --- a/quest/m0/README.md +++ b/quest/m0/README.md @@ -26,7 +26,6 @@ edge, which embeds moq-relay; it moved there on 2026-09-28. ## Required -- [The C bindings accept MoqInstance again](/quest/m0/check-c-moqinstance.md) - `check c` passes on main once the C generator stops refusing `MoqInstance`'s exported `Debug` - [Nightly passes on main](/quest/m0/nightly/README.md) - the scheduled Nightly passes end to end, so red means a new break - [Interop and Video pass on main](/quest/m0/interop-green/README.md) - the scheduled Interop and Video workflows pass, so red means a new break - [@moq/clock's Instant has no throwing Duration arithmetic, mirroring kio](/quest/m0/peer-arithmetic.md) - JS `Instant` drops `add`/`sub` for checked and saturating forms, so each call site states what overflow means, as kio's do diff --git a/quest/m0/check-c-moqinstance.md b/quest/m0/check-c-moqinstance.md deleted file mode 100644 index 53577269f40..00000000000 --- a/quest/m0/check-c-moqinstance.md +++ /dev/null @@ -1,24 +0,0 @@ -# [XS] The C bindings accept MoqInstance again - -## Goal - -`check c` in `just check` passes on `main`. The C bindings generator stops -refusing `MoqInstance`, whose `#[uniffi::export(Debug, Display, Eq, Hash)]` -in `rs/moq-ffi/src/instance.rs` exports a `Debug` trait method the generator -can't render. Every branch's local `just check` fails on it until then. - -## Plan - -Planned 2026-11-09 (maintainer, /quest-unblock), after -[moq-dev/moq#8375](https://github.com/moq-dev/moq/pull/8375)'s iterate found -`check c` failing identically on a clean `origin/main`. It came in with -[moq-dev/moq#8366](https://github.com/moq-dev/moq/pull/8366) (minted instances -are a typed flag), merged 2026-11-10 03:04 UTC; list it under the fix's -`## Caused by`. - -Either stop exporting `Debug` (keep `Display`, `Eq`, and `Hash` if the other -bindings use them), or have the C generator handle or skip exported trait -methods the way it handles the others. Prefer the change that keeps every -binding at the same functionality, as the root `AGENTS.md` requires. - -Public API: possibly a binding's debug string for `MoqInstance`. Wire: none.