From e470e9bcf42fca25be096dcf1c49dfc1c7765dfe Mon Sep 17 00:00:00 2001 From: Luke Curley <432854+kixelated@users.noreply.github.com> Date: Tue, 10 Nov 2026 08:17:27 -0800 Subject: [PATCH] quest: plan the lite-07 session task leak Co-Authored-By: Claude Opus 5.5 --- quest/m1/README.md | 1 + quest/m1/lite07-session-tasks.md | 28 ++++++++++++++++++++++++++++ 2 files changed, 29 insertions(+) create mode 100644 quest/m1/lite07-session-tasks.md diff --git a/quest/m1/README.md b/quest/m1/README.md index f578c647594..82415751e87 100644 --- a/quest/m1/README.md +++ b/quest/m1/README.md @@ -50,6 +50,7 @@ moves what remains of them once their claims merge. - [.github/ffi.md holds rules, not evidence](/quest/m1/ffi-doc-trim.md) - the FFI release doc drops one-off measurements for links to their PRs - [Draft publishing keeps the upload and drops changelog rewriting](/quest/m1/drafts-publish-trim.md) - `sh/drafts/publish.sh` and its test shrink to the datatracker upload - [rs/AGENTS.md's time-test rule matches the tree](/quest/m1/test-time-rule.md) - the rule names `#[kio::test]`, which about 4,900 tests use, and is stated once +- [A lite-07 session leaves no task behind](/quest/m1/lite07-session-tasks.md) - every task a lite-07 session spawned ends once its handles and connection close, and the session bench asserts it for both versions ## Related diff --git a/quest/m1/lite07-session-tasks.md b/quest/m1/lite07-session-tasks.md new file mode 100644 index 00000000000..659b67088ed --- /dev/null +++ b/quest/m1/lite07-session-tasks.md @@ -0,0 +1,28 @@ +# [M] A lite-07 session leaves no task behind + +## Goal + +Once a lite-07 session's handles and connection close, every task it spawned +ends, as lite-06's do. The session bench (`rs/moq-net/benches/session`) +asserts zero leftover tasks after each room drops, for both versions, so a +relay speaking lite-07 no longer accumulates one task per session it served. + +## Plan + +Planned 2026-11-10 (maintainer, /quest-complete follow-up of +[moq-dev/moq#8397](https://github.com/moq-dev/moq/pull/8397)). Milestone: +✅ m1 (rejected: m2 routes epic, m0, dropping it), since relays run lite-07 +in production now. + +#8397's `session_announce` bench found 18 tasks still alive in the +16-viewer delivery cell after a lite-07 room dropped, against 0 on lite-06: +about one per session. The per-cell runtimes from +[moq-dev/moq#8352](https://github.com/moq-dev/moq/pull/8352) hid this. The +likely cause is a lite-07 session driver (or a route-layer task it spawns) +that outlives its handles; confirm before fixing. + +Reproduce on the bench first, then in a unit test on mock time. Fix the +owner of the leaked task at its root rather than aborting stragglers, and +keep the zero-task assertion in the bench for both versions. + +Public API: none expected. Wire: none.