From ac029346c07f2fb05fb7d9875d712032e5a76e46 Mon Sep 17 00:00:00 2001 From: Luke Curley <432854+kixelated@users.noreply.github.com> Date: Tue, 10 Nov 2026 08:46:03 -0800 Subject: [PATCH] quest: plan refusing a reused moq-transport alias at once Co-Authored-By: Claude Opus 5.5 --- quest/m1/README.md | 1 + quest/m1/ietf-alias-refuse.md | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+) create mode 100644 quest/m1/ietf-alias-refuse.md diff --git a/quest/m1/README.md b/quest/m1/README.md index f578c647594..6f7ab9dc686 100644 --- a/quest/m1/README.md +++ b/quest/m1/README.md @@ -44,6 +44,7 @@ moves what remains of them once their claims merge. - [A padded TS export sheds when its sink falls behind](/quest/m1/ts-padded-shed.md) - a `--mux-rate` export skips stale slots with a flagged PCR jump instead of back-filling them or blaming the source - [A resumed QUIC client gives up on its own idle timer](/quest/m1/quic-resume-idle.md) - a client stopped past its idle timeout closes within about one timeout of resuming, without waiting on a stateless reset - [A reused moq-transport alias delivers a group that beats its SUBSCRIBE_OK](/quest/m1/ietf-alias-reuse.md) - a new SUBSCRIBE clears its track's alias tombstone, so moqxr's alias-0 catalog refetch no longer hangs +- [A reused moq-transport alias refuses its track at once](/quest/m1/ietf-alias-refuse.md) - a SUBSCRIBE_OK on an alias already bound fails its readers and removes its entry without waiting on the peer's FIN acknowledgement - [Unused crates, scripts, and files are deleted](/quest/m1/unused-code.md) - moq-room, the moq-native tombstone, demo/throttle, sh/dart/publish.sh, demo/web's Solid deps, and unpublished packages' release notes go - [The recurring audits are fewer and carry plans, not results](/quest/m1/audit-merge.md) - m3's 13 audits become about five, each a Goal plus a short check-first list - [The CARLA bridge builds outside the root workspace](/quest/m1/carla-workspace.md) - workspace builds stop compiling the demo bridge diff --git a/quest/m1/ietf-alias-refuse.md b/quest/m1/ietf-alias-refuse.md new file mode 100644 index 00000000000..9eaabc4aaf3 --- /dev/null +++ b/quest/m1/ietf-alias-refuse.md @@ -0,0 +1,32 @@ +# [S] A reused moq-transport alias refuses its track at once + +## Goal + +When a moq-transport publisher answers a SUBSCRIBE with a track alias that +is already bound, the subscription's readers fail and its track entry is +removed immediately, as every other refusal path does. A peer that never +acknowledges the cancelling stream's FIN can no longer leave readers waiting +on a dead copy or keep a `TrackState` entry registered. + +## Plan + +Planned 2026-11-10 (maintainer, /quest-complete follow-up of +[moq-dev/moq#8402](https://github.com/moq-dev/moq/pull/8402), from a +CodeRabbit finding declined there because `main` already behaves this way). +Milestone: ✅ m1 (rejected: m2, dropping it), since a misbehaving peer can +hold state unboundedly. + +In `rs/moq-net/src/ietf/subscriber.rs`, when `register_alias` fails after +the SUBSCRIBE_OK is accepted, the subscription moves to `OnceStep::Unbound` +and only aborts the track and removes the entry after the peer acknowledges +the FIN. The property-refusal and error branches just above it already +refuse first and then return `OnceStep::Refuse`. Do the same here: reject +the pending readers, remove the subscription and entry, abort the track, +return `OnceStep::Refuse`, and delete `OnceStep::Unbound`. Cover it with a +test whose peer never acknowledges the FIN. + +Public API: none. Wire: none. + +## Related + +- [A reused moq-transport alias delivers a group that beats its SUBSCRIBE_OK](/quest/m1/ietf-alias-reuse.md) - the same alias table, for a reused alias on the same track