diff --git a/quest/m0/test-flakes-2/interop-python-go.md b/quest/m0/test-flakes-2/interop-python-go.md index c899bc45fd3..466e8af5698 100644 --- a/quest/m0/test-flakes-2/interop-python-go.md +++ b/quest/m0/test-flakes-2/interop-python-go.md @@ -41,9 +41,14 @@ code, out of scope for routing-free work. Decided 2026-11-12 by the maintainer: ✅ keep the lane quarantined and pick up the lead above once the routing work lands (rejected: unquarantine to collect a -nightly failing log; close the quest on the clean history). The routing work is -[moq-dev/moq#8457](https://github.com/moq-dev/moq/pull/8457) and -[moq-dev/moq#8443](https://github.com/moq-dev/moq/pull/8443), which change the -same path. This quest's PR lands after both, so the quest is ready once they are in. +nightly failing log; close the quest on the clean history). + +Decided 2026-11-12 by the maintainer (coordinator session): ✅ drop +[moq-dev/moq#8457](https://github.com/moq-dev/moq/pull/8457) (cache-aware +routing proof) from what this quest waits on (rejected: keep waiting on #8457; +unquarantine to collect logs). The lead lives in lite-07's route layer, which +[moq-dev/moq#8443](https://github.com/moq-dev/moq/pull/8443) already landed, +and #8457 is paused until the warm-route rule is re-picked. The quest is +ready: start from the lead above. Public API: none expected. Wire: none. diff --git a/quest/m1/audio-jitter-target/delay-cap.md b/quest/m1/audio-jitter-target/delay-cap.md deleted file mode 100644 index eeeb6c24513..00000000000 --- a/quest/m1/audio-jitter-target/delay-cap.md +++ /dev/null @@ -1,63 +0,0 @@ -# [S] A publisher's advertised delay cannot hold a browser viewer without bound - -## Goal - -A publisher that advertises a huge `jitter` or catalog `delay` cannot hold a -`` viewer's playback, or the media it buffers, past a fixed -ceiling. The browser caps the resolved `"auto"` delay at 10 s, so a -misbehaving publisher costs its viewers bounded latency and memory, as -AGENTS.md requires. - -## Plan - -Decided 2026-11-11 (maintainer, /quest-complete, from -[moq-dev/moq#8532](https://github.com/moq-dev/moq/pull/8532)): ✅ plan it -in m1 (rejected: m3 or later; not tracking it). - -#8532 capped `moq play`'s clock at `moq_audio::playback::Input::LATENCY_MAX` -(10 s), which also bounds the catalog `delay` and `--delay` there. The -browser had no cap. In `"auto"`, `js/watch` `Sync#runDelay` holds the deepest -part's target, so an hour of advertised delay delayed playback by an hour: -- Audio's target is `max(measured, jitter) + frame + delay` - (`js/watch/src/audio/latency.ts` `target`). -- Video's target is `spread + delay`, floored by the rendition's `jitter` - (`js/watch/src/video/decoder.ts`). - -The subscription's max delay (`delay + lookahead`) follows the same delay, -so the container consumer keeps that much encoded media. - -Recommendations, as implemented: - -- The resolved `"auto"` delay is capped once in `Sync#runDelay` at an internal - constant equal to `LATENCY_MAX`, rather than capping each term, so audio and - video stay on one clock. -- A fixed delay is left alone: the viewer chose it, not the publisher. -- A catalog advertising an hour of `jitter` and `delay` resolves to the cap. - -Decided 2026-11-12 (coordinator, on the maintainer's behalf while away, from -the PR's recommendations): - -- ✅ (a) cap `moq play`'s audio target sum, the held jitter target plus the - catalog delay, at `LATENCY_MAX` too, so one 10 s ceiling holds everywhere - (rejected: (b) raise the browser to 20 s; (c) keep the mismatch). -- ✅ (a) clamp catalog `warmup` at `LATENCY_MAX` where the browser reads it, - and in Rust for parity: `moq_mux::container::Playout`, `moq_video`'s - decode `Consumer`, and `moq play`'s video refresh, all through one - `moq_mux::container::WARMUP_MAX` (rejected: (b) reject the rendition; (c) - leave unbounded). - -Findings: - -- The constants are pinned together in one place only: the `play` feature's - test in `rs/moq-cli/src/play/args.rs` pins `DELAY_MAX` to - `moq_audio::playback::Input::LATENCY_MAX`. The browser's `DELAY_MAX` and - `moq-mux`'s `WARMUP_MAX` are pinned to it by comment alone, since no test - builds them together. -- The warmup cap also bounds each decoder's join trim (the browser's audio - terminal, `moq-audio`'s decoder, `moq-gst`'s Opus clip): the subscription - reaches back only the ceiling, so trimming further would hold playback - silent past it. - -Public API: `moq_mux::container::WARMUP_MAX` (10 s) is exported so every -Rust reader of catalog `warmup` shares one ceiling; the browser's `DELAY_MAX` -stays internal. Wire: none. diff --git a/quest/m1/audio-jitter-target/delay-ceiling.md b/quest/m1/audio-jitter-target/delay-ceiling.md new file mode 100644 index 00000000000..2808fdd655b --- /dev/null +++ b/quest/m1/audio-jitter-target/delay-ceiling.md @@ -0,0 +1,34 @@ +# [S] One exported 10 s playout ceiling + +## Goal + +The 10 s ceiling on playout delay, latency and catalog `warmup` is one +exported constant in Rust, mirrored by name in JS, and every other copy reuses +it. Today it is four constants under three names, kept equal by a test in one +case and by comments in the rest: + +- `@moq/watch`'s `DELAY_MAX` (`js/watch/src/sync.ts`, internal to the package). +- `moq_audio::playback::Input::LATENCY_MAX` (public, `rs/moq-audio/src/playback/sink.rs`). +- moq-cli's private `DELAY_MAX` (`rs/moq-cli/src/play/args.rs`), duplicated + because that module builds without the `play` feature and so without + moq-audio; a test pins it to `LATENCY_MAX`. +- `moq_mux::container::WARMUP_MAX` (public, added by + [moq-dev/moq#8549](https://github.com/moq-dev/moq/pull/8549)). + +## Plan + +Decided 2026-11-12 by the maintainer (coordinator session): ✅ unify the +ceiling, and keep clamping an oversized catalog `warmup` rather than rejecting +the rendition (rejected: leave the four constants as merged; reject an +oversized warmup). + +Recommendation: define it in `moq_mux::container`, which moq-cli always +depends on and moq-audio already imports for `WARMUP_MAX`, and mirror it in +`@moq/hang`'s container module (`js/hang/src/container`), which mirrors +`moq_mux::container`. Pick one name for what it bounds (playout delay), such +as `DELAY_MAX`, replacing `WARMUP_MAX` and `Input::LATENCY_MAX`, and have +`@moq/watch` import it. Removing two public Rust constants is breaking: mark +the title with `!` and give the migration in the PR's Impact section. + +Public API: one constant replaces `moq_mux::container::WARMUP_MAX` and +`moq_audio::playback::Input::LATENCY_MAX`, plus its JS export. Wire: none.