From f6323adb7dfe59c64955eb0a9c4391083db7aa9e Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 12 Nov 2026 12:21:05 -0800 Subject: [PATCH 1/2] fix(test): nightly relay links opt into host time, rung test outlasts BBR3's filter upstream_links runs relays over real TCP and a 50ms publish loop; without the quic feature no UDP socket exempts the process, so KIO_DENY_HOST_TIMERS aborts tiered_regions in the --no-default-features run. The rung test's 100 kbit/s phase was 12s, shorter than BBR3's two-cycle max-bw filter takes to forget the 500 kbit/s samples at a 500ms queue; nightly saw the grant fall 8-12s in and missed it once. Hold it for 20s. Co-Authored-By: Claude Opus 5.5 --- rs/moq-ffi/src/test/rung.rs | 5 ++++- rs/moq-relay/tests/integration/upstream_links.rs | 3 +++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/rs/moq-ffi/src/test/rung.rs b/rs/moq-ffi/src/test/rung.rs index d6f00e70250..e0f06ac9590 100644 --- a/rs/moq-ffi/src/test/rung.rs +++ b/rs/moq-ffi/src/test/rung.rs @@ -8,7 +8,10 @@ const HIGH: u64 = 1_000_000; const BOUNDARY: u64 = (HIGH + 2 * LOW) / 3; const NARROW: Duration = Duration::from_secs(8); const BELOW_LOWEST: Duration = Duration::from_secs(20); -const RECOVER: Duration = Duration::from_secs(32); +// BBR3's two-cycle max-bw filter forgets the 500 kbit/s samples only after the +// cycle the drop landed in and one more retire: up to three ProbeBW cycles of a +// 3s probe wait plus probe rounds at the 500ms queue's RTT, about 15s. +const RECOVER: Duration = Duration::from_secs(40); const END: Duration = Duration::from_secs(110); const FRAME: Duration = Duration::from_nanos(1_000_000_000 / 30); diff --git a/rs/moq-relay/tests/integration/upstream_links.rs b/rs/moq-relay/tests/integration/upstream_links.rs index 90c32596368..c54fe8db4b0 100644 --- a/rs/moq-relay/tests/integration/upstream_links.rs +++ b/rs/moq-relay/tests/integration/upstream_links.rs @@ -249,6 +249,7 @@ fn has(routes: &BTreeMap>, paths: &[&str]) -> bool { /// route layer's choice, not something this asserts. #[test] fn tiered_regions() { + kio::clock::host_time(); // relays over real TCP, publishing a group every 50ms run_cluster_test(tiered_regions_inner()); } @@ -295,6 +296,7 @@ async fn tiered_regions_inner() { /// edge dialed the core or the core dialed the edge. #[test] fn edges_never_transit_between_cores() { + kio::clock::host_time(); // relays over real TCP, publishing a group every 50ms run_cluster_test(edges_never_transit_between_cores_inner()); } @@ -329,6 +331,7 @@ async fn edges_never_transit_between_cores_inner() { /// in a line: the mesh reaches the CDN and the CDN reaches the mesh. #[test] fn uplink_transits_both_ways() { + kio::clock::host_time(); // relays over real TCP, publishing a group every 50ms run_cluster_test(uplink_transits_both_ways_inner()); } From a8b4147862e67581bf2fa851899b1cfbda7c7d64 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 12 Nov 2026 12:36:01 -0800 Subject: [PATCH 2/2] fix(test): leave the upstream_links host-time opt-in to #8510 moq-dev/moq#8510 now carries the same fix in run_cluster_test. Co-Authored-By: Claude Opus 5.5 --- rs/moq-relay/tests/integration/upstream_links.rs | 3 --- 1 file changed, 3 deletions(-) diff --git a/rs/moq-relay/tests/integration/upstream_links.rs b/rs/moq-relay/tests/integration/upstream_links.rs index c54fe8db4b0..90c32596368 100644 --- a/rs/moq-relay/tests/integration/upstream_links.rs +++ b/rs/moq-relay/tests/integration/upstream_links.rs @@ -249,7 +249,6 @@ fn has(routes: &BTreeMap>, paths: &[&str]) -> bool { /// route layer's choice, not something this asserts. #[test] fn tiered_regions() { - kio::clock::host_time(); // relays over real TCP, publishing a group every 50ms run_cluster_test(tiered_regions_inner()); } @@ -296,7 +295,6 @@ async fn tiered_regions_inner() { /// edge dialed the core or the core dialed the edge. #[test] fn edges_never_transit_between_cores() { - kio::clock::host_time(); // relays over real TCP, publishing a group every 50ms run_cluster_test(edges_never_transit_between_cores_inner()); } @@ -331,7 +329,6 @@ async fn edges_never_transit_between_cores_inner() { /// in a line: the mesh reaches the CDN and the CDN reaches the mesh. #[test] fn uplink_transits_both_ways() { - kio::clock::host_time(); // relays over real TCP, publishing a group every 50ms run_cluster_test(uplink_transits_both_ways_inner()); }