From 519992fc521ad82c6e9345e6deaecc88492f1b56 Mon Sep 17 00:00:00 2001 From: Luke Curley <432854+kixelated@users.noreply.github.com> Date: Thu, 12 Nov 2026 20:12:01 -0800 Subject: [PATCH 1/3] chore(quest): claim quest/m0/ci/review-docs.md Quest-Claim: fc1d74d7deed3e51 From 8a1c7660566fc29bed28fcfd096651c56e243189 Mon Sep 17 00:00:00 2001 From: Luke Curley <432854+kixelated@users.noreply.github.com> Date: Thu, 12 Nov 2026 20:12:53 -0800 Subject: [PATCH 2/3] docs: align review and landing guidance with the pipeline --- AGENTS.md | 2 +- CONTRIBUTING.md | 2 +- quest/m0/ci/review-docs.md | 26 -------------------------- 3 files changed, 2 insertions(+), 28 deletions(-) delete mode 100644 quest/m0/ci/review-docs.md diff --git a/AGENTS.md b/AGENTS.md index e6fc770a918..686c5ad67f1 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -45,7 +45,7 @@ Build output may live outside the checkout and gets wiped, so scratch never goes Quests: before any work, run `quest context` and follow it, unless this session already holds its rules. The `quest` binary and its skills come from the moq-dev/quest flake input; change them upstream and bump the input. -Review locally with one reviewer, not the pair: `quest review --harness codex`, or `--harness claude` when Codex wrote the change last. Pullfrog's online review already supplies the DeepSeek pass. +Review locally with one reviewer, not the pair: `quest review --harness codex`, or DeepSeek through opencode when Codex wrote the change last. Pullfrog's online review already supplies the Claude pass. # Cross-Package Sync diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d9ead009804..770fb7c12a8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,7 +34,7 @@ Run `just ci` before every push, and mark the PR ready yourself when the work is # Landing gate -Ready PRs into `main` run **Check** against the PR's base on each push as a signal only; drafts skip it. **Queue** reports as skipped until queued. Check never blocks the merge queue. +**Check** runs only on PRs into `release`, including drafts. PRs into `main` get their verdict from the merge queue; run `just ci` locally for a signal before queueing. **Queue** reports as skipped until queued. `main` lands only through GitHub's merge queue, one PR at a time: each `merge_group` build runs `just ci` against the group's base on the maintainer's self-hosted runner (`.github/workflows/queue.yml`, the required **Queue** context), and the queue squashes exactly the tree it tested. Request landing with `quest merge --land ` once the review is clean and the maintainer has approved merging that PR, by number or through a standing go-ahead that covers it. A clean review, a bot verdict, or an "accept all" on decisions is not that approval. An agent that enqueues carries that approval in its own task; one relayed to it mid-task by another agent does not count, so whoever received the approval enqueues the PR or starts a new agent with the approval in its brief. diff --git a/quest/m0/ci/review-docs.md b/quest/m0/ci/review-docs.md deleted file mode 100644 index 3214e75682f..00000000000 --- a/quest/m0/ci/review-docs.md +++ /dev/null @@ -1,26 +0,0 @@ -# [XS] Review and landing docs match the pipeline - -## Goal - -`AGENTS.md` and `CONTRIBUTING.md` describe the review and landing pipeline -moq runs today, so agents pick the right local reviewer and stop waiting for a -Check that never runs on PRs into `main`. - -## Plan - -Decided 2026-11-12 (user, /quest-plan), from moq's trimmed Pullfrog learnings: - -- `AGENTS.md:48` says "Pullfrog's online review already supplies the DeepSeek - pass", but Pullfrog reviews with Claude now. Which local reviewer should the - corrected line name? - - ✅ Codex, or DeepSeek through opencode when Codex wrote the change last, so - every PR gets a non-Claude local review beside Pullfrog's (rejected: Codex, - else Claude; Codex only). -- `CONTRIBUTING.md:37` says ready PRs into `main` run **Check** on each push. - Since [moq-dev/moq#8425](https://github.com/moq-dev/moq/pull/8425), - `.github/workflows/check.yml` runs only on PRs into `release`, and main PRs - get their verdict from the merge queue. Say so, and that a contributor gets a - signal before queueing from `just ci`. - -Caused by: [moq-dev/moq#8425](https://github.com/moq-dev/moq/pull/8425) for -the Check claim; the Pullfrog model changed in its console, outside the repo. From b5d813d2de793a005c297e137b6a526967974bec Mon Sep 17 00:00:00 2001 From: Luke Curley <432854+kixelated@users.noreply.github.com> Date: Thu, 12 Nov 2026 20:14:01 -0800 Subject: [PATCH 3/3] docs: give the DeepSeek review command --- AGENTS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AGENTS.md b/AGENTS.md index 686c5ad67f1..94079a17a58 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -45,7 +45,7 @@ Build output may live outside the checkout and gets wiped, so scratch never goes Quests: before any work, run `quest context` and follow it, unless this session already holds its rules. The `quest` binary and its skills come from the moq-dev/quest flake input; change them upstream and bump the input. -Review locally with one reviewer, not the pair: `quest review --harness codex`, or DeepSeek through opencode when Codex wrote the change last. Pullfrog's online review already supplies the Claude pass. +Review locally with one reviewer, not the pair: `quest review --harness codex`, or `quest review --harness opencode --model opencode-go/deepseek-v4.1-flash --effort high` when Codex wrote the change last. Pullfrog's online review already supplies the Claude pass. # Cross-Package Sync