diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 32fd6f35e36..edf82652598 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -772,7 +772,7 @@ jobs: sizes: name: Shipping sizes # Measures what these release jobs upload rather than rebuilding it. - needs: [release-py-ffi, release-shared-ffi, release-libmoq, release-moq-relay, release-moq-cli] + needs: [release-py-ffi, release-shared-ffi, release-libmoq, release-c, release-moq-relay, release-moq-cli] runs-on: ubuntu-24.04-arm # Hosted `main` jobs write the Rust cache; see .github/actions/rust-cache. environment: ${{ github.ref == 'refs/heads/main' && 'cache-write' || '' }} diff --git a/quest/m2/libmoq-size-history.md b/quest/m2/libmoq-size-history.md deleted file mode 100644 index f6a470581e9..00000000000 --- a/quest/m2/libmoq-size-history.md +++ /dev/null @@ -1,23 +0,0 @@ -# [XS] Restart the nightly size history after the libmoq rename - -## Goal - -Nightly's size report passes again once -[moq-dev/moq#8941](https://github.com/moq-dev/moq/pull/8941) merges. That PR -renames the hand-written C crate's four release archives from -`moq-c-` to `libmoq-` and stops matching the generated -package's `moq-c-generated-` uploads, so a retained history that names -the old keys makes `sh/size/report.py` refuse every report as "missing or -renamed" until the history restarts. - -## Plan - -After that PR merges, delete every retained `nightly-size-history` artifact -with the command in `sh/size/README.md`, as an agent with repository admin -access can, then confirm the next scheduled Nightly's `Collect and compare -sizes` step passes. The restart drops the 30-day baseline of every series, so -the first 30 days compare only against the previous night. - -## Waiting - -- moq-dev/moq: [moq-dev/moq#8941](https://github.com/moq-dev/moq/pull/8941) merges; check with `gh pr view 8941 --json state` diff --git a/sh/size/release.py b/sh/size/release.py index 179e907a711..00329d790f0 100644 --- a/sh/size/release.py +++ b/sh/size/release.py @@ -10,7 +10,16 @@ # Keep the Go static-library history keys when the coordinator supplies them. # Android and iOS libraries are already measured inside Kotlin/Swift packages. GO_TARGETS = {"x86_64-unknown-linux-gnu", "aarch64-unknown-linux-gnu", "aarch64-apple-darwin", "x86_64-pc-windows-msvc"} -ARTIFACTS = ["go-lib-*", "libmoq-*", "moq-cli-*", "moq-relay-*", "python-*", "kotlin-package", "swift-ffi-package"] +ARTIFACTS = [ + "go-lib-*", + "libmoq-*", + "moq-c-generated-*", + "moq-cli-*", + "moq-relay-*", + "python-*", + "kotlin-package", + "swift-ffi-package", +] # What a consumer downloads: archives, packages and the Go mirror's staticlibs. # Bare binaries, .deb and .rpm repeat the archives; Go's .so and .dll ship inside the packages. SHIPPING = (".tar.gz", ".zip", ".whl", ".aar", ".jar", ".a", ".lib") diff --git a/sh/size/release.test.py b/sh/size/release.test.py index 976d7160684..68fcceab127 100644 --- a/sh/size/release.test.py +++ b/sh/size/release.test.py @@ -13,6 +13,7 @@ def fixture(root, version): "go-lib-x86_64-unknown-linux-gnu/libmoq_ffi.so", "go-lib-x86_64-pc-windows-msvc/moq_ffi.lib", f"libmoq-aarch64-unknown-linux-gnu/moq-{version}-aarch64-unknown-linux-gnu.tar.gz", + f"moq-c-generated-x86_64-pc-windows-msvc/moq-c-{version}-x86_64-pc-windows-msvc.zip", f"moq-cli-x86_64-unknown-linux-gnu/moq-cli-v{version}-x86_64-unknown-linux-gnu.tar.gz", f"moq-cli-x86_64-unknown-linux-gnu/moq-cli-v{version}-x86_64-unknown-linux-gnu", f"moq-cli-x86_64-unknown-linux-gnu/moq_{version}_amd64.deb", @@ -44,6 +45,7 @@ def test_version_changes_keep_keys(self): "release/kotlin-package/moq-ffi-android.aar", "release/kotlin-package/moq-ffi-jvm.jar", "release/libmoq-aarch64-unknown-linux-gnu/moq-aarch64-unknown-linux-gnu.tar.gz", + "release/moq-c-generated-x86_64-pc-windows-msvc/moq-c-x86_64-pc-windows-msvc.zip", "release/moq-cli-x86_64-unknown-linux-gnu/moq-cli-x86_64-unknown-linux-gnu.tar.gz", "release/moq-relay-x86_64-pc-windows-msvc/moq-relay-x86_64-pc-windows-msvc.zip", "release/python-aarch64-unknown-linux-gnu/moq_ffi-py3-none-manylinux_2_28_aarch64.whl",