From 26bb0b58c886a64086016f20924f44cd35cffac0 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Wed, 18 Nov 2026 12:04:50 -0800 Subject: [PATCH 1/2] chore(quest): claim quest/m0/test-flakes-3/pcm-five-one.md Quest-Claim: f67addc8c39fd691 From 19dbed6f2154cdf80f8dea6ce7aafa63cc23507e Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Wed, 18 Nov 2026 12:14:30 -0800 Subject: [PATCH 2/2] test(moq-audio): PCM round trips read their frame on a paused clock A zero max delay ages a finished group with no successor out once its span passes on the wall clock, so a consumer that subscribed more than the 20 ms frame after the write found the track ended. Both PCM round trips now run on the paused clock their Opus siblings already use. Co-Authored-By: Claude Opus 5.5 --- quest/m0/test-flakes-3/pcm-five-one.md | 19 ------------------- rs/moq-audio/tests/integration/roundtrip.rs | 8 ++++++-- 2 files changed, 6 insertions(+), 21 deletions(-) delete mode 100644 quest/m0/test-flakes-3/pcm-five-one.md diff --git a/quest/m0/test-flakes-3/pcm-five-one.md b/quest/m0/test-flakes-3/pcm-five-one.md deleted file mode 100644 index 8b21e8b5b75..00000000000 --- a/quest/m0/test-flakes-3/pcm-five-one.md +++ /dev/null @@ -1,19 +0,0 @@ -# [S] moq-audio's 5.1 PCM round trip reads its frame under load - -## Goal - -`moq-audio`'s `roundtrip::pcm_five_one_reads_back_at_any_layout` reads one -decoded frame per output layout on every run, instead of sometimes finding -the consumer ended first. - -## Plan - -Seen 2026-11-16 in a loaded `just check` on the branch of the hang-04 -MPEG-TS passthrough change, which touches no audio code: `next_frame` returned -`None` at `rs/moq-audio/tests/integration/roundtrip.rs:239`, and three runs of -the test alone passed. The test finishes the producer right after creating the -consumers, so a consumer may see the end before its first frame. Reproduce -under load, find whether the decode consumer drops frames written before it -subscribed or the end overtakes them, and fix that cause. - -Public API: none. Wire: none. diff --git a/rs/moq-audio/tests/integration/roundtrip.rs b/rs/moq-audio/tests/integration/roundtrip.rs index 0999b604b16..6a720f197ee 100644 --- a/rs/moq-audio/tests/integration/roundtrip.rs +++ b/rs/moq-audio/tests/integration/roundtrip.rs @@ -139,7 +139,9 @@ fn power(samples: &[f32], frequency: f64, rate: u32) -> f64 { previous * previous + older * older - coefficient * previous * older } -#[tokio::test] +// Paused: the default zero max delay ages a finished group out once its span passes on the +// wall clock, so a loaded runner would subscribe after the frame went stale. +#[tokio::test(start_paused = true)] async fn pcm_round_trip_is_lossless() { let mut broadcast = moq_net::broadcast::Info::new().produce(); let catalog = moq_mux::catalog::Producer::new(&mut broadcast, moq_mux::catalog::Config::default()).unwrap(); @@ -186,7 +188,9 @@ async fn pcm_round_trip_is_lossless() { /// A 5.1 broadcast carries only its channel count in the catalog, which reads /// back as 5.1 in canonical order and remixes to whatever the subscriber asks /// for. -#[tokio::test] +// Paused: the default zero max delay ages a finished group out once its span passes on the +// wall clock, so a loaded runner would subscribe after the frame went stale. +#[tokio::test(start_paused = true)] async fn pcm_five_one_reads_back_at_any_layout() { let mut broadcast = moq_net::broadcast::Info::new().produce(); let catalog = moq_mux::catalog::Producer::new(&mut broadcast, moq_mux::catalog::Config::default()).unwrap();