From 5e70f9b4b087248d5c73eaa23160cef4ee223a81 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 19 Nov 2026 13:27:14 -0800 Subject: [PATCH] docs(rs): create_track examples handle the Option it returns #9150 made broadcast::Producer::create_track return None for a taken name, but three doc examples still applied ? to it, so their doctests no longer compile. Co-Authored-By: Claude Opus 5.5 --- rs/moq-mux/src/catalog/tracks.rs | 2 +- rs/moq-mux/src/json.rs | 2 +- rs/moq-net/src/model/origin.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/rs/moq-mux/src/catalog/tracks.rs b/rs/moq-mux/src/catalog/tracks.rs index 428aa42c6f1..4e943d29028 100644 --- a/rs/moq-mux/src/catalog/tracks.rs +++ b/rs/moq-mux/src/catalog/tracks.rs @@ -74,7 +74,7 @@ use super::hang::{Catalog, CatalogExt}; /// let info = moq_net::track::Info::default() /// .with_timescale(moq_net::Timescale::MILLI) /// .with_compression(moq_net::track::Compression::Deflate); -/// let track = broadcast.create_track("telemetry", info)?; +/// let track = broadcast.create_track("telemetry", info).ok_or(moq_net::Error::Duplicate)?; /// // The producer fixes the mode, so the one passed here is only a placeholder. /// let entry = Mavlink { config: JsonConfig::new(Mode::Stream), sysid: 1 }; /// let mut telemetry = catalog.json_stream::(track, entry)?; diff --git a/rs/moq-mux/src/json.rs b/rs/moq-mux/src/json.rs index 91c8740684f..2c6bee7cb1c 100644 --- a/rs/moq-mux/src/json.rs +++ b/rs/moq-mux/src/json.rs @@ -24,7 +24,7 @@ //! let info = moq_net::track::Info::default() //! .with_timescale(moq_net::Timescale::MILLI) //! .with_compression(moq_net::track::Compression::Deflate); -//! let track = broadcast.create_track("chat", info)?; +//! let track = broadcast.create_track("chat", info).ok_or(moq_net::Error::Duplicate)?; //! let mut chat = catalog.json_stream::(track, moq_mux::json::Config::default())?; //! chat.append(&Message { text: "hello".to_string() }, catalog.clock().now())?; //! # Ok(()) diff --git a/rs/moq-net/src/model/origin.rs b/rs/moq-net/src/model/origin.rs index c3d3a0d35ac..b6f34e239a9 100644 --- a/rs/moq-net/src/model/origin.rs +++ b/rs/moq-net/src/model/origin.rs @@ -3155,7 +3155,7 @@ struct Serving { /// /// // Fill the catalog before readers can find it. /// let route = origin.route("live/alice", RouteOptions::hidden())?; -/// let _catalog = route.broadcast().create_track("catalog.json", None)?; +/// let _catalog = route.broadcast().create_track("catalog.json", None).ok_or(moq_net::Error::Duplicate)?; /// route.announce()?; // visible now, same instance /// route.set_cost(5)?; // re-prices in place /// route.withdraw(); // hidden; announce() again continues the same stream