From e17bafde06ea0f865bb9be0f20931b233fa27418 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 19 Nov 2026 18:56:56 -0800 Subject: [PATCH 1/2] chore(quest): claim quest/m0/nightly/fuzz-ingest-bound.md Quest-Claim: 8d548765a77cf078 From d20a736a0f9bcceb9e79fba5cb506951d2f07489 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 19 Nov 2026 19:20:29 -0800 Subject: [PATCH 2/2] fix(net): the ingest fuzzer counts a refused GROUP_END as a failed stream The harness dropped the result of settling the group, so a GROUP_END before a frame it held read as a clean end over an aborted, empty group, tripping the stream-size bound. The session already fails that stream with MalformedTrack; the harness now does too. The crash input joins the regressions. Co-Authored-By: Claude Opus 5.5 --- quest/m0/nightly/fuzz-ingest-bound.md | 22 ------------------ .../ingest/lite07-group-end-before-frame | Bin 0 -> 104 bytes rs/moq-net/src/fuzz/ingest.rs | 12 +++++----- 3 files changed, 6 insertions(+), 28 deletions(-) delete mode 100644 quest/m0/nightly/fuzz-ingest-bound.md create mode 100644 rs/moq-net/fuzz/regressions/ingest/lite07-group-end-before-frame diff --git a/quest/m0/nightly/fuzz-ingest-bound.md b/quest/m0/nightly/fuzz-ingest-bound.md deleted file mode 100644 index e62ba8a9d7d..00000000000 --- a/quest/m0/nightly/fuzz-ingest-bound.md +++ /dev/null @@ -1,22 +0,0 @@ -# [S] The ingest fuzzer's stream-size bound holds - -## Goal - -`Fuzz (ingest)` passes again: the crash input it found on 2026-11-19 either -exposes a bug in lite ingest that gets fixed, or a bound in the harness that -was wrong and gets corrected, and the input joins the corpus as a regression. - -## Plan - -Found by the 2026-11-19 triage of run [44562804083](https://github.com/moq-dev/moq/actions/runs/44562804083): - -``` -0 frames of 0 bytes account for at most 27 of a 101-byte stream -``` - -The assertion is in `rs/moq-net/src/fuzz/ingest.rs:193`; the input is the -job's `crash-278598a8...` artifact. Decide first whether ingest consumed -bytes it should have rejected or the harness undercounts what a stream may -spend on non-frame data (GROUP headers, GROUP_END, padding). - -Public API: none. Wire: none expected. diff --git a/rs/moq-net/fuzz/regressions/ingest/lite07-group-end-before-frame b/rs/moq-net/fuzz/regressions/ingest/lite07-group-end-before-frame new file mode 100644 index 0000000000000000000000000000000000000000..11edb2168dcbf7df984e5a487fa4528924e41420 GIT binary patch literal 104 gcmd;aREzu0KmmyS6;a2)yqEDm19R=(|2Pc-0C?*M?f?J) literal 0 HcmV?d00001 diff --git a/rs/moq-net/src/fuzz/ingest.rs b/rs/moq-net/src/fuzz/ingest.rs index effa0490273..cd8d9fc71e3 100644 --- a/rs/moq-net/src/fuzz/ingest.rs +++ b/rs/moq-net/src/fuzz/ingest.rs @@ -267,15 +267,15 @@ fn run(session: Session, info: &track::Info, body: &[u8], chunk: usize) -> Optio }; let (group, consumer) = group; - // Settle the group as the session does, so the reader below never waits. - match &end { - Ok(_) => { - let _ = group.end(fin); - } + // Settle the group as the session does, so the reader below never waits. A GROUP_END + // the group refuses, such as one before a frame it holds, fails the stream there too. + let end = match end { + Ok(said) => group.end(fin).map(|()| said), Err(err) => { let _ = group.abort(err.clone()); + Err(err) } - } + }; Some(Ingested { frames: read(consumer, info.compressed()),