From e33e1fab93e4bfa341aebe5aed005bea64985e25 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 20 Nov 2026 11:51:15 -0800 Subject: [PATCH] fix(net): read an IETF request message's body before allocating it A peer could declare a 64 KiB request stream message, withhold the body, and make us hold a 64 KiB buffer for every 3 bytes it sent. Co-Authored-By: Claude Opus 5.5 --- js/net/src/ietf/request_stream.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/js/net/src/ietf/request_stream.ts b/js/net/src/ietf/request_stream.ts index 4fbf33f2342..0e655ad2fcf 100644 --- a/js/net/src/ietf/request_stream.ts +++ b/js/net/src/ietf/request_stream.ts @@ -330,10 +330,12 @@ export class RequestStream { if (type === undefined) return undefined; try { const size = await reader.u16(); + // Allocate only once the body has arrived, so a peer withholding it holds just what it sent. + const body = await reader.read(size); const framed = new Uint8Array(2 + size); framed[0] = size >> 8; framed[1] = size & 0xff; - framed.set(await reader.read(size), 2); + framed.set(body, 2); return { type, reader: new Reader(undefined, framed, version) }; } catch (err) { throw malformed(err, "request stream message");