From 18b47088639d5c1b2ba1acf42dbc6a1fab300e18 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sun, 25 Oct 2026 15:53:21 -0700 Subject: [PATCH 1/2] quest: queue-siblings also covers quest check failing in the queue Co-Authored-By: Claude Opus 5.5 --- quest/m0/helpers/queue-siblings.md | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/quest/m0/helpers/queue-siblings.md b/quest/m0/helpers/queue-siblings.md index 8ef9b4da..cc117274 100644 --- a/quest/m0/helpers/queue-siblings.md +++ b/quest/m0/helpers/queue-siblings.md @@ -4,7 +4,8 @@ Several PRs that each finish a child of the same epic land back to back through a server-side merge, such as a GitHub merge queue, without each -landing knocking the next one out on a conflict in the epic's link list. +landing knocking the next one out on a conflict in the epic's link list, or +on a `quest check` failure over a quest the base just finished. ## Plan @@ -15,6 +16,12 @@ GitHub's merge queue builds its merge commit without it. Each landing conflicted with the next queued sibling, which cost four extra drop, merge, and re-land cycles in one batch. +A second symptom: a quest-only PR waiting in the queue fails `quest check` +once main finishes a quest it links. moq-dev/moq#6707 was dropped 3 times +and moq-dev/moq#6790 4 times. Options: run `quest check` against current +main before queueing, or have the check treat a link to a deleted quest as +resolvable. + The fix belongs in quest, not in each repository's process. Rejected: landing one sibling at a time, which serializes batches. From a9b665a6c3a59070b64fbe6caa7dbf7682e3cfd1 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sun, 25 Oct 2026 15:54:43 -0700 Subject: [PATCH 2/2] quest: note the limits of each queue-check option Co-Authored-By: Claude Opus 5.5 --- quest/m0/helpers/queue-siblings.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/quest/m0/helpers/queue-siblings.md b/quest/m0/helpers/queue-siblings.md index cc117274..7e7b5350 100644 --- a/quest/m0/helpers/queue-siblings.md +++ b/quest/m0/helpers/queue-siblings.md @@ -20,7 +20,8 @@ A second symptom: a quest-only PR waiting in the queue fails `quest check` once main finishes a quest it links. moq-dev/moq#6707 was dropped 3 times and moq-dev/moq#6790 4 times. Options: run `quest check` against current main before queueing, or have the check treat a link to a deleted quest as -resolvable. +resolvable. A pre-queue check alone misses a base that moves after queueing, +and a tolerant check must tell a finished quest from a mistyped link. The fix belongs in quest, not in each repository's process. Rejected: landing one sibling at a time, which serializes batches.