diff --git a/quest/a0/qmux-socket-teardown.md b/quest/a0/qmux-socket-teardown.md index 2bd9d81f..8758b8a7 100644 --- a/quest/a0/qmux-socket-teardown.md +++ b/quest/a0/qmux-socket-teardown.md @@ -13,7 +13,3 @@ Approved behavior: socket-derived metrics become unavailable after teardown; oth ## Closes - [#383](https://github.com/moq-dev/web-transport/issues/383) - the implementation completes this report - -## Related - -- [QMux send-rate filter](/quest/a1/qmux-rate-filter.md) - adds state to the same `TcpStats` diff --git a/quest/a1/README.md b/quest/a1/README.md index 951db889..0f570d32 100644 --- a/quest/a1/README.md +++ b/quest/a1/README.md @@ -10,8 +10,6 @@ The Required list is ordered by priority. Independent children may proceed concu ## Required -- [QMux send-rate filter](/quest/a1/qmux-rate-filter.md) - app-limited samples no longer lower the estimate, on main and 0.5 -- [QMux send-rate filter on 0.5](/quest/a1/qmux-rate-filter-0.5.md) - backport for published moq-relay - [Dual-stack bind](/quest/a1/dual-stack-bind.md) - native clients bind by the server's address family - [Router crypto features](/quest/a1/router-crypto-features.md) - interim aws-lc-rs/ring features on `web-transport` - [Rust crates on rind](/quest/a1/rind/README.md) - no C crypto outside Quiche diff --git a/quest/a1/qmux-rate-filter-0.5.md b/quest/a1/qmux-rate-filter-0.5.md deleted file mode 100644 index 0f94d8e9..00000000 --- a/quest/a1/qmux-rate-filter-0.5.md +++ /dev/null @@ -1,17 +0,0 @@ -# [XS] Backport the QMux send-rate filter to 0.5 - -## Goal - -The `qmux-v0.5.x` line has the same app-limited send-rate filter as main, so the next 0.5.x patch fixes the moq-relay releases that depend on `qmux ^0.5.3`. - -## Plan - -Cherry-pick or port the main-branch change onto `qmux-v0.5.x` in a PR against that branch, as [#412](https://github.com/moq-dev/web-transport/pull/412)/[#413](https://github.com/moq-dev/web-transport/pull/413) do, with the same tests. Don't publish the release yourself. - -## Required - -- [QMux send-rate filter](/quest/a1/qmux-rate-filter.md) - the main-branch change this backports - -## Closes - -- [#460](https://github.com/moq-dev/web-transport/issues/460) - the reporter runs the 0.5 line through moq-relay diff --git a/quest/a1/qmux-rate-filter.md b/quest/a1/qmux-rate-filter.md deleted file mode 100644 index b16f041a..00000000 --- a/quest/a1/qmux-rate-filter.md +++ /dev/null @@ -1,29 +0,0 @@ -# [S] Keep app-limited samples from lowering QMux's send-rate estimate - -## Goal - -On Linux, `TcpStats::estimated_send_rate` reports available bandwidth rather than the sender's own rate. An app-limited `delivery_rate` sample can raise the estimate but never lower it, so a live publisher's PROBE estimate stops alternating between its bitrate and path capacity over WebSocket/TCP. The fix ships on main and on the `qmux-v0.5.x` branch that published moq-relay depends on. - -## Plan - -Decided with the maintainer on 2026-11-06 (planning interview): - -- Fix it in qmux, not in the player. The trait documents "estimated available send bandwidth", and a raw app-limited delivery rate breaks that promise. -- Port moq's in-tree `RateFilter` from [moq-dev/moq#6925](https://github.com/moq-dev/moq/pull/6925) so the two qmux copies don't drift. It is a BBR-style windowed maximum over 10 s. A sample that isn't app-limited replaces older maxima once they leave the window. An app-limited sample counts only when it is at least the current maximum. A rejected sample changes nothing, expiry included. A zero rate is no sample. The flag is the first bitfield in the `tcpi_app_limited` byte (`tcpi_delivery_rate_app_limited:1`): bit 0 on little-endian targets, bit 7 on big-endian ones. Derive the mask from `target_endian` and pin it with a layout test. moq's copy masks bit 0 everywhere; report that as a follow-up there. -- `TcpStats` gains a small lock around the filter. macOS still reports no rate. -- Test the filter with controlled time: app-limited samples never lower the estimate, a real sample replaces expired maxima, and rejected samples retire nothing. -- This quest lands on main. The `qmux-v0.5.x` backport is [its own quest](/quest/a1/qmux-rate-filter-0.5.md), which closes the issue, because published moq-relay (0.17.14) depends on `qmux ^0.5.3`. -- Other backends are audited separately in [the quiche audit](/quest/a2/quiche-delivery-rate.md). Quinn and Noq report the pacing rate or cwnd/rtt, which don't have this flaw. - -Decision prompts (✅ chosen): - -- Goal: fix in qmux / ✅ also audit other backends / won't fix here. -- App-limited handling: hold raise-only (first pick) / windowed max / None when app-limited / `tcpi_pacing_rate`. Replaced by: ✅ port moq's RateFilter / keep hold. -- Quiche audit: ✅ separate quest / same quest. -- 0.5 line: ✅ main + 0.5 backport / main only. -- Placement: ✅ top of a1. - -## Related - -- [#460](https://github.com/moq-dev/web-transport/issues/460) - closed by the 0.5 backport -- [QMux socket teardown](/quest/a0/qmux-socket-teardown.md) - edits the same `TcpStats` ownership diff --git a/quest/a2/quiche-delivery-rate.md b/quest/a2/quiche-delivery-rate.md index 86041506..922ba9d9 100644 --- a/quest/a2/quiche-delivery-rate.md +++ b/quest/a2/quiche-delivery-rate.md @@ -8,6 +8,6 @@ web-transport-quiche's `estimated_send_rate` reports available bandwidth under e `ez/connection.rs` reports quiche's `PathStats::delivery_rate * 8` as-is. In quiche 0.30 that value is BBR2's filtered bandwidth estimate under gcongestion, but the latest raw rate sample under legacy CUBIC/Reno. That is the flaw [#460](https://github.com/moq-dev/web-transport/issues/460) found in qmux. -Confirm which controllers web-transport-quiche configures by default and on request, and whether app-limited samples reach the reported value. If they do, prefer a filtered value quiche exposes publicly (such as `max_bandwidth` where it exists), or apply the same rule as [the qmux filter](/quest/a1/qmux-rate-filter.md) when quiche exposes the app-limited state. Otherwise document the limitation on the method. Use only quiche's public API, and don't fork its recovery code. +Confirm which controllers web-transport-quiche configures by default and on request, and whether app-limited samples reach the reported value. If they do, prefer a filtered value quiche exposes publicly (such as `max_bandwidth` where it exists), or apply the same rule as moq's `RateFilter` ([moq-dev/moq#6925](https://github.com/moq-dev/moq/pull/6925)) when quiche exposes the app-limited state. Otherwise document the limitation on the method. Use only quiche's public API, and don't fork its recovery code. Decided with the maintainer on 2026-11-06: a separate quest from the qmux fix, in a2.