From c130b1103984123b4e9f76a2362e9f594a03ce09 Mon Sep 17 00:00:00 2001 From: T <60372079+mpaulosky@users.noreply.github.com> Date: Wed, 11 Nov 2026 07:48:31 -0800 Subject: [PATCH 1/3] fix(baseline): Say the hook allows dependabot/* and test the Copilot request with no login (#40) R11 was fixed by #41. This documents the hook's dependabot/* allowance in PROCESS.md (R19) and tests that a review request with no reviewer login is not taken for Copilot's (R7). Co-Authored-By: Claude Sonnet 5.5 --- .../owned/.github/scripts/tests/pr-automerge.test.mjs | 4 +++- .../skills/repo-ci-baseline/template/owned/docs/PROCESS.md | 7 ++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.claude/skills/repo-ci-baseline/template/owned/.github/scripts/tests/pr-automerge.test.mjs b/.claude/skills/repo-ci-baseline/template/owned/.github/scripts/tests/pr-automerge.test.mjs index 203cd68..68eeb02 100644 --- a/.claude/skills/repo-ci-baseline/template/owned/.github/scripts/tests/pr-automerge.test.mjs +++ b/.claude/skills/repo-ci-baseline/template/owned/.github/scripts/tests/pr-automerge.test.mjs @@ -5163,7 +5163,9 @@ const copilotRequestedAt = (at, reviewer = { login: "Copilot", type: "Bot" }) => test("a request for a copilot-x user or team does not save an add that PR Auto-Merge removed (mpaulosky/Application_Factory#22)", async () => { for (const event of [ { event: "review_requested", created_at: "2026-01-02T00:30:03Z", requested_reviewer: { login: "copilot-x", type: "User" }, actor: { login: "ruleset" } }, - { event: "review_requested", created_at: "2026-01-02T00:30:03Z", requested_team: { name: "copilot-team" }, actor: { login: "ruleset" } } + { event: "review_requested", created_at: "2026-01-02T00:30:03Z", requested_team: { name: "copilot-team" }, actor: { login: "ruleset" } }, + { event: "review_requested", created_at: "2026-01-02T00:30:03Z", requested_reviewer: { type: "Bot" }, actor: { login: "ruleset" } }, + { event: "review_requested", created_at: "2026-01-02T00:30:03Z", requested_reviewer: { login: null, type: "Bot" }, actor: { login: "ruleset" } } ]) { const result = await evaluate(documentedLoop({ reviewRequests: COPILOT_PENDING }), [addedBy(OWNER), event, removedByActions("2026-01-02T00:30:05Z")]); assert.equal(result.merges.length, 1, result.logs.join("\n")); diff --git a/.claude/skills/repo-ci-baseline/template/owned/docs/PROCESS.md b/.claude/skills/repo-ci-baseline/template/owned/docs/PROCESS.md index d088058..d7ec3a1 100644 --- a/.claude/skills/repo-ci-baseline/template/owned/docs/PROCESS.md +++ b/.claude/skills/repo-ci-baseline/template/owned/docs/PROCESS.md @@ -33,9 +33,10 @@ The folder is the branch name with `/` turned into `-`. Remove the worktree once | `chore/{slug}` | Work without an issue | `{slug}` is lowercase letters and digits in words joined by `-` (`upgrade-net10`, `oauth2-login`). A `chore/` slug -starts with a letter, so `chore/7-cleanup` is refused. The pre-push hook refuses any other name, and so does the -required **Branch name** check, which also catches a push that skipped the hook (a Claude cloud session's `claude/...` -branch, GitHub's web editor). To fix one, rename the branch on GitHub, then close and reopen the PR. +starts with a letter, so `chore/7-cleanup` is refused. The pre-push hook refuses any other name, except a shell-safe `dependabot/*` name, which it +allows so a person can push a fix to a Dependabot PR. The required **Branch name** check refuses any other name too (it +accepts any `dependabot/*`), and so catches a push that skipped the hook (a Claude cloud session's `claude/...` branch, +GitHub's web editor). To fix one, rename the branch on GitHub, then close and reopen the PR. ## Commits and PR titles From 55c03d038640a36c26f5fb5dd04cc26d0b175a22 Mon Sep 17 00:00:00 2001 From: T <60372079+mpaulosky@users.noreply.github.com> Date: Wed, 11 Nov 2026 07:56:27 -0800 Subject: [PATCH 2/3] docs(baseline): Name every branch the Branch name check allows in PROCESS.md (#40) Co-Authored-By: Claude Sonnet 5.5 --- .../skills/repo-ci-baseline/template/owned/docs/PROCESS.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.claude/skills/repo-ci-baseline/template/owned/docs/PROCESS.md b/.claude/skills/repo-ci-baseline/template/owned/docs/PROCESS.md index d7ec3a1..b8d4f72 100644 --- a/.claude/skills/repo-ci-baseline/template/owned/docs/PROCESS.md +++ b/.claude/skills/repo-ci-baseline/template/owned/docs/PROCESS.md @@ -34,9 +34,10 @@ The folder is the branch name with `/` turned into `-`. Remove the worktree once `{slug}` is lowercase letters and digits in words joined by `-` (`upgrade-net10`, `oauth2-login`). A `chore/` slug starts with a letter, so `chore/7-cleanup` is refused. The pre-push hook refuses any other name, except a shell-safe `dependabot/*` name, which it -allows so a person can push a fix to a Dependabot PR. The required **Branch name** check refuses any other name too (it -accepts any `dependabot/*`), and so catches a push that skipped the hook (a Claude cloud session's `claude/...` branch, -GitHub's web editor). To fix one, rename the branch on GitHub, then close and reopen the PR. +allows so a person can push a fix to a Dependabot PR. The required **Branch name** check allows the same names, plus any +`dependabot/*` whatever its characters and the `docs/release-notes` and `docs/backfill-blog-posts` branches the release +workflows create. It refuses everything else, so it catches a push that skipped the hook (a Claude cloud session's +`claude/...` branch, GitHub's web editor). To fix one, rename the branch on GitHub, then close and reopen the PR. ## Commits and PR titles From 4dc59e23f293b19a0c992888c0405ed1384a894e Mon Sep 17 00:00:00 2001 From: T <60372079+mpaulosky@users.noreply.github.com> Date: Wed, 11 Nov 2026 07:59:54 -0800 Subject: [PATCH 3/3] docs(baseline): Say what a refused branch name is renamed to fix in PROCESS.md (#40) Co-Authored-By: Claude Sonnet 5.5 --- .claude/skills/repo-ci-baseline/template/owned/docs/PROCESS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.claude/skills/repo-ci-baseline/template/owned/docs/PROCESS.md b/.claude/skills/repo-ci-baseline/template/owned/docs/PROCESS.md index b8d4f72..cb0da15 100644 --- a/.claude/skills/repo-ci-baseline/template/owned/docs/PROCESS.md +++ b/.claude/skills/repo-ci-baseline/template/owned/docs/PROCESS.md @@ -37,7 +37,7 @@ starts with a letter, so `chore/7-cleanup` is refused. The pre-push hook refuses allows so a person can push a fix to a Dependabot PR. The required **Branch name** check allows the same names, plus any `dependabot/*` whatever its characters and the `docs/release-notes` and `docs/backfill-blog-posts` branches the release workflows create. It refuses everything else, so it catches a push that skipped the hook (a Claude cloud session's -`claude/...` branch, GitHub's web editor). To fix one, rename the branch on GitHub, then close and reopen the PR. +`claude/...` branch, GitHub's web editor). To fix a refused name, rename the branch on GitHub, then close and reopen the PR. ## Commits and PR titles