If FactorSetup, FactorDerive, FactorMetadata is a pub trait, it may be good to tell people when they would implement this themselves (i.e., if they were to create their own factor type).
If that is really doable, then we need to make sure we can allow something like a generic factor to be used throughout this process. Not high priority at all (and maybe not actually safe), but we should probably not make a trait publicly implementable unless we think:
a) Someone will do it.
b) Someone should do it.
If we need this trait to be public so that it can be used in through the API, then we may want to seal the trait so it cannot be implemented by the user.
Originally posted by @Autoparallel in #52 (comment)
If
FactorSetup, FactorDerive, FactorMetadatais apub trait, it may be good to tell people when they would implement this themselves (i.e., if they were to create their own factor type).If that is really doable, then we need to make sure we can allow something like a generic factor to be used throughout this process. Not high priority at all (and maybe not actually safe), but we should probably not make a trait publicly implementable unless we think:
a) Someone will do it.
b) Someone should do it.
If we need this trait to be public so that it can be used in through the API, then we may want to seal the trait so it cannot be implemented by the user.
Originally posted by @Autoparallel in #52 (comment)