From 3139174347950af5b87c23571a5ca03d1c87f15a Mon Sep 17 00:00:00 2001 From: Thomas Lepore Date: Wed, 7 Oct 2026 11:43:40 +0200 Subject: [PATCH 1/3] fix(vimeo-video-element): dispatch error event when the video fails to load When the Vimeo player rejects its ready promise (e.g. NotFoundError for a deleted video), dispatch an ErrorEvent carrying the Vimeo error instead of leaving two unhandled promise rejections. Fixes #263 Co-Authored-By: Claude Opus 5.5 --- packages/vimeo-video-element/test/test.js | 13 +++++++++++++ packages/vimeo-video-element/vimeo-video-element.js | 5 ++++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/packages/vimeo-video-element/test/test.js b/packages/vimeo-video-element/test/test.js index bc7614eb..5b40e08d 100644 --- a/packages/vimeo-video-element/test/test.js +++ b/packages/vimeo-video-element/test/test.js @@ -86,6 +86,19 @@ test('play promise', async function (t) { t.ok(!video.paused, 'is playing after video.play()'); }); +test('dispatches an error event when the video does not exist', async function (t) { + const video = await fixture(``); + + const event = await new Promise((resolve) => video.addEventListener('error', resolve, { once: true })); + + t.ok(event instanceof ErrorEvent, 'is an ErrorEvent'); + t.equal(event.error?.name, 'NotFoundError', 'carries the Vimeo error'); + t.ok(event.message, 'has an error message'); +}); + function delay(ms) { return new Promise((resolve) => setTimeout(resolve, ms)); } diff --git a/packages/vimeo-video-element/vimeo-video-element.js b/packages/vimeo-video-element/vimeo-video-element.js index 2c0c4e99..675ae953 100644 --- a/packages/vimeo-video-element/vimeo-video-element.js +++ b/packages/vimeo-video-element/vimeo-video-element.js @@ -279,11 +279,14 @@ class VimeoVideoElement extends MediaPlayedRangesMixin(globalThis.HTMLElement ?? #setupApiListeners() { const textTracksVideo = document.createElement('video'); this.textTracks = textTracksVideo.textTracks; + this.api.ready().catch((error) => { + this.dispatchEvent(new ErrorEvent('error', { error, message: error?.message })); + }); this.api.getTextTracks().then((vimeoTracks) => { vimeoTracks.forEach((t) => { textTracksVideo.addTextTrack(t.kind, t.label, t.language); }); - }); + }).catch(() => {}); this.textTracks.addEventListener('change', () => { const active = Array.from(this.textTracks).find((t) => t.mode === 'showing'); if (active) { From 4d5ec5699fa22d22f902c425c111c83deb02ab5b Mon Sep 17 00:00:00 2001 From: Santiago Puppo Date: Wed, 7 Oct 2026 14:59:18 -0300 Subject: [PATCH 2/3] fix(vimeo-video): expose error through api --- packages/vimeo-video-element/test/test.js | 1 + packages/vimeo-video-element/vimeo-video-element.js | 11 ++++++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/packages/vimeo-video-element/test/test.js b/packages/vimeo-video-element/test/test.js index 5b40e08d..3427cc71 100644 --- a/packages/vimeo-video-element/test/test.js +++ b/packages/vimeo-video-element/test/test.js @@ -97,6 +97,7 @@ test('dispatches an error event when the video does not exist', async function ( t.ok(event instanceof ErrorEvent, 'is an ErrorEvent'); t.equal(event.error?.name, 'NotFoundError', 'carries the Vimeo error'); t.ok(event.message, 'has an error message'); + t.equal(video.error, event.error, 'exposes the error via video.error'); }); function delay(ms) { diff --git a/packages/vimeo-video-element/vimeo-video-element.js b/packages/vimeo-video-element/vimeo-video-element.js index 675ae953..d528df7a 100644 --- a/packages/vimeo-video-element/vimeo-video-element.js +++ b/packages/vimeo-video-element/vimeo-video-element.js @@ -109,6 +109,7 @@ class VimeoVideoElement extends MediaPlayedRangesMixin(globalThis.HTMLElement ?? #videoWidth = NaN; #videoHeight = NaN; #config = null; + #error = null; /** Distinguishes a remount from SSR hydration. * See load() */ @@ -167,6 +168,7 @@ class VimeoVideoElement extends MediaPlayedRangesMixin(globalThis.HTMLElement ?? this.#readyState = 0; this.#videoWidth = NaN; this.#videoHeight = NaN; + this.#error = null; this.dispatchEvent(new Event('emptied')); let oldApi = this.api; @@ -280,13 +282,16 @@ class VimeoVideoElement extends MediaPlayedRangesMixin(globalThis.HTMLElement ?? const textTracksVideo = document.createElement('video'); this.textTracks = textTracksVideo.textTracks; this.api.ready().catch((error) => { + this.#error = error; this.dispatchEvent(new ErrorEvent('error', { error, message: error?.message })); }); this.api.getTextTracks().then((vimeoTracks) => { vimeoTracks.forEach((t) => { textTracksVideo.addTextTrack(t.kind, t.label, t.language); }); - }).catch(() => {}); + }).catch(() => { + // getTextTracks() waits on ready(), so its rejection is already surfaced above. + }); this.textTracks.addEventListener('change', () => { const active = Array.from(this.textTracks).find((t) => t.mode === 'showing'); if (active) { @@ -427,6 +432,10 @@ class VimeoVideoElement extends MediaPlayedRangesMixin(globalThis.HTMLElement ?? return this.api?.pause(); } + get error() { + return this.#error; + } + get ended() { return this.#currentTime >= this.#duration; } From 5d6e0b1f28cbdb26e15ce0c451afe485d63a5d21 Mon Sep 17 00:00:00 2001 From: Santiago Puppo Date: Wed, 7 Oct 2026 14:59:51 -0300 Subject: [PATCH 3/3] fix(examples): changed broken vimeo src --- examples/nextjs/app/vimeo-video/page.tsx | 2 +- packages/vimeo-video-element/index.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/nextjs/app/vimeo-video/page.tsx b/examples/nextjs/app/vimeo-video/page.tsx index fd1a98b4..388c30bf 100644 --- a/examples/nextjs/app/vimeo-video/page.tsx +++ b/examples/nextjs/app/vimeo-video/page.tsx @@ -12,7 +12,7 @@ export default function Page() {
<vimeo-video> }; loadbtn.onclick = () => { - video.src = 'https://vimeo.com/638371504'; + video.src = 'https://vimeo.com/76979871'; } video.addEventListener('loadstart', (e) => {