From 1cddb358705bd3e17693da42275b72107d9e0af5 Mon Sep 17 00:00:00 2001 From: Neil Dewhurst Date: Thu, 8 Oct 2026 16:34:04 +0100 Subject: [PATCH] Pass publish-env through to the PDF build, same as the HTML build docs-build-pdf never passed publish-env to reusable-docs-pdf-build.yml, so its PDF always resolved cross-manual/javadoc links against the docset's own publish.yml default (the real prod URL) regardless of which environment this PDF was actually being published to - same fix as the HTML build's own --url handling. --- .github/workflows/docs-generate-pdf.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/docs-generate-pdf.yml b/.github/workflows/docs-generate-pdf.yml index 8b167bb..5954861 100644 --- a/.github/workflows/docs-generate-pdf.yml +++ b/.github/workflows/docs-generate-pdf.yml @@ -53,10 +53,12 @@ jobs: docs-build-pdf: name: Generate PDF + needs: resolve-env uses: neo4j/docs-tools/.github/workflows/reusable-docs-pdf-build.yml@v2 with: build-ref: ${{ inputs.build-ref }} fetch-depth: 0 + publish-env: ${{ needs.resolve-env.outputs.publish-env }} # Hand off to docs-publish (a separate repo) to actually publish this run's "pdf" # artifact - same mechanism docs-generate-html.yml already uses for its "docs"